lita-web-title 1.0.3 → 1.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2f705b31124e81a12d6ffa776252eca2909733f8
-  data.tar.gz: f20cbeaf3fcbebb65d0cdbf2559d211c9ca1eba2
+  metadata.gz: 01b22e197b9e136251e32f40b706778afd97594a
+  data.tar.gz: 6d2d77eda40cd75f4325087942ff7ce2702ff9f6
 SHA512:
-  metadata.gz: 4a43eadc289198c480e6b347218f0a2ab257476fac81755092b066f26cf4998b10566fa421e499a9c7ce284d8971bf92861ed7d087cc3521c292d428e120a0ba
-  data.tar.gz: 5b773ce37ef85a80b3f6563caf0b1e948a107d9925a9db80816ed652d59be46b7ae919d3ff7442dae191ece08fc1fd19cd079c626dd47fbda32670fc4aef71ae
+  metadata.gz: adbdd916513838a6fa0b8410e6f9cfd9f9b1b1ebdf2bffd9561874977e1e6a38f6b21646152bf11cb57d59a30c4cf697c340b308893814caf866b91cd10fa964
+  data.tar.gz: 71377ad35b300bc9f7f79705698add5a64a947f75dfd37200af38e8df2cd042f5cd35321cebec220c885e477d0cc9a520f626acd45c7a6fa7a9b5d37c7bbff77

data/.rspec

@@ -0,0 +1,2 @@
+--color
+--format documentation

data/lib/lita/handlers/web_title.rb

@@ -3,22 +3,23 @@ require "nokogiri"
 module Lita
   module Handlers
     class WebTitle < Handler
-      route(URI.regexp(["http", "https"]), :parse_uri_request, help: {
+      URI_PROTOCOLS = %w( http https )
+      route(URI.regexp(URI_PROTOCOLS), :parse_uri_request, help: {
         "URL" => "Responds with the title of the web page at URL"
       })
 
       def parse_uri_request(request)
-        requestUri = URI::extract(request.message.body, ["http", "https"])
-        result = parse_uri(requestUri[0])
-        result.delete!("\n").strip!
-        request.reply(result) unless result.nil?
+        requestUri = URI::extract(request.message.body, URI_PROTOCOLS).first
+        result = parse_uri(requestUri)
+        request.reply(result.delete("\n").strip) unless result.nil?
       end
 
       def parse_uri(uriString)
         httpRequest = http.get(uriString)
         if httpRequest.status == 200 then
+          return unless httpRequest.headers['Content-Type'] =~ %r{text/x?html}
           page = Nokogiri::HTML(httpRequest.body)
-          page.css("title")[0].text
+          page.css("title").first.text
         elsif [300, 301, 302, 303].include? httpRequest.status then
           parse_uri httpRequest.headers["Location"]
         else
@@ -26,6 +27,7 @@ module Lita
         end
       rescue Exception => msg
         log.error("lita-web-title: Exception attempting to load URL: #{msg}")
+        nil
       end
     end
 

data/lita-web-title.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = "lita-web-title"
-  spec.version       = "1.0.3"
+  spec.version       = "1.0.4"
   spec.authors       = ["Chris Baker"]
   spec.email         = ["dosman711@gmail.com"]
   spec.description   = "A Lita plugin to parse URIs and post the <title> of the page"

data/spec/lita/handlers/web_title_spec.rb

@@ -1,4 +1,35 @@
-require "spec_helper"
+require 'spec_helper'
 
 describe Lita::Handlers::WebTitle, lita_handler: true do
+  let(:robot) { Lita::Robot.new(registry) }
+  subject(:handler) { described_class.new(robot) }
+
+  describe 'routing' do
+    it { is_expected.to route('I like http://github.com/').to(:parse_uri_request) }
+  end
+
+  describe 'messages' do
+    it 'returns the title for a mentioned URL' do
+      send_command('I search on http://google.com/ a lot.')
+      expect(replies.last).to match(/Google/)
+    end
+
+    it 'returns the title for only the first mentioned URL' do
+      send_command('I search on http://google.com/ and http://yahoo.com/ a lot.')
+      expect(replies.last).to match(/Google/)
+      expect(replies.last).to_not match(/yahoo/i)
+    end
+
+    it 'returns nothing for URLs that are not HTML' do
+      send_command('This is the logo https://www.google.com/images/srpr/logo11w.png')
+      expect(replies.last).to be_nil
+    end
+  end
+
+  describe '.parse_uri' do
+    it 'returns the title' do
+      expect(handler.parse_uri('https://google.com/'))
+        .to match(/Google/)
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lita-web-title
 version: !ruby/object:Gem::Version
-  version: 1.0.3
+  version: 1.0.4
 platform: ruby
 authors:
 - Chris Baker
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-30 00:00:00.000000000 Z
+date: 2015-04-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lita
@@ -116,6 +116,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".rspec"
 - ".travis.yml"
 - Gemfile
 - LICENSE