lita-ticket_notifier 0.0.12 → 0.0.14

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 349da069fc81d0f3fe0d93bb9938221995f18c53
-  data.tar.gz: 61e7c65c42263d2617cd0847d6f7cf7ab0f61925
+  metadata.gz: 1ef0097fd60259595d434f46c56fc3a82897175e
+  data.tar.gz: 24dcad7c5cf32e2a461619f40c31b6d8ceb3d109
 SHA512:
-  metadata.gz: 95af0df2b27b5eeb7ca6d324040e27d2de28623b61b91e54f34f7bd67c4d7b8e4c745cd1f4923a01b5f40af0d7f6a59972c9f075d32f3e562b35fb6df58861cc
-  data.tar.gz: 510c96b8528ee41139202b7d3a989f0f3302a2762445b6d4e5cfd421f59655f6449826f6e4321cd45a1397b651dba4ef0276ae1119e7c24640c8510aedfa534e
+  metadata.gz: 8f94660522b3ed69e3e30014cd1a1c6b413c749f20253b91332a5b9c0a208517ae42f8e54b970c594034ff8fe4ff934fcda1fa8a68a6ca852bdc98a6db75c1a1
+  data.tar.gz: 05015b761b5f134d8e577aea6cffa1c3790e8e192496b44b1595a2c8c9032baa0799a33222576dccbe18d054e9dd7b80f037074987011f4194e5b0283d79bef3

data/lib/lita/handlers/ticket_notifier.rb

@@ -1,17 +1,93 @@
 module Lita
   module Handlers
     class TicketNotifier < Handler
+      attr_accessor :ticket_json, :ticket_object
       http.post "/ticket_notification", :ticket_notification
 
+      route(/ticket notify start/i, :add_ticket_notification, command: true,
+        help: { "ticket notify start" => "Lita will notify you of Lighthouse tickets." }
+      )
+
+      route(/ticket notify stop/i, :remove_ticket_notification, command: true,
+        help: { "ticket notify stop" => "Lita will stop notifying you of Lighthouse tickets." }
+      )
+
       def ticket_notification(request, response)
-        robot.send_message(target, request.body.read)
+        self.ticket_json ||= JSON.parse(request.body.read)
+        user_names.each do |user_name|
+          send_message_to_user(user_name, ticket_message)
+        end
+      end
+
+      def add_ticket_notification(response)
+        redis.lpush("ticket_users", response.user.name)
+        response.reply_privately "You will now get notified of ticket updates."
+      end
+
+      def remove_ticket_notification(response)
+        redis.lrem("ticket_users", 0, response.user.name)
+        response.reply_privately "You will no longer receive ticket update notifications."
+      end
+
+    private
+
+      def send_message_to_user(user_name, messaage)
+        robot.send_message(source_from_name(user_name), message)
       end
 
-      def target
-        Lita::Source.new({ room: Lita.config.adapter.rooms[0] })
+      def source_from_name(name)
+        Lita::Source.new({ user: Lita::User.find_by_name(name) })
+      end
+
+      def user_names
+        redis.lrange("ticket_users", 0, -1)
+      end
+
+      def ticket
+        self.ticket_object ||= OpenStruct.new(hash_attributes)
+      end
+
+      def hash_attributes
+        # listing this all out to document the attributes
+        h = ticket_json['version']
+        hash_attributes = {
+          assigned_user_id: h['assigned_user_id'],
+          assigned_user_name: h['assigned_user_name'],
+          attachments_count: h['attachments_count'],
+          body: h['body'],
+          body_html: h['body_html'],
+          closed: h['closed'],
+          created_at: h['created_at'],
+          creator_id: h['creator_id'],
+          creator_name: h['creator_name'],
+          diffable_attributes_hash: h['diffable_attributes'],
+          importance: h['importance'],
+          importance_name: h['importance_name'],
+          milestone_id: h['milestone_id'],
+          milestone_order: h['milestone_order'],
+          number: h['number'],
+          permalink: h['permalink'],
+          priority: h['priority'],
+          project_id: h['project_id'],
+          spam: h['spam'],
+          state: h['state'],
+          tag: h['tag'],
+          title: h['title'],
+          updated_at: h['updated_at'],
+          url: h['url'],
+          user_id: h['user_id'],
+          user_name: h['user_name'],
+          version: h['version'],
+          watchers_ids: h['watchers_ids']
+        }
+      end
+
+      def ticket_message
+        "Ticket: #{ticket.title}\nState:#{ticket.state}\nImportance:#{ticket.importance_name}\nTags:#{ticket.tag}\n#{ticket.url}"
       end
     end
 
     Lita.register_handler(TicketNotifier)
   end
 end
+

data/lita-ticket_notifier.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = "lita-ticket_notifier"
-  spec.version       = "0.0.12"
+  spec.version       = "0.0.14"
   spec.authors       = ["Michael van den Beuken", "Ruben Estevez", "Jordan Babe", "Mathieu Gilbert", "Ryan Jones", "Darko Dosenovic"]
   spec.email         = ["michael.beuken@gmail.com", "ruben.a.estevez@gmail.com", "jorbabe@gmail.com", "mathieu.gilbert@ama.ab.ca", "ryan.michael.jones@gmail.com", "darko.dosenovic@ama.ab.ca"]
   spec.description   = %q{Notify users about new tickets coming in.}

data/spec/fixtures/ticket.json

@@ -0,0 +1,36 @@
+{
+    "version": {
+        "assigned_user_id": null,
+        "attachments_count": 0,
+        "body": "",
+        "body_html": "",
+        "closed": true,
+        "created_at": "2014-08-06T22:55:30Z",
+        "creator_id": 240273,
+        "creator_name": "Mathieu Gilbert",
+        "diffable_attributes": {
+            "state": "resolved"
+        },
+        "importance": 3,
+        "importance_name": "Low",
+        "milestone_id": null,
+        "milestone_order": 9999,
+        "number": 4146,
+        "permalink": "test-ticket",
+        "priority": 3,
+        "project_id": 66073,
+        "spam": false,
+        "state": "review",
+        "tag": "dev",
+        "title": "test ticket",
+        "updated_at": "2014-08-06T22:55:32Z",
+        "url": "http://waffles.lighthouseapp.com/projects/1/tickets/200",
+        "user_id": 240273,
+        "user_name": "Mathieu Gilbert",
+        "version": 3,
+        "watchers_ids": [
+            240273,
+            216682
+        ]
+    }
+}

data/spec/lita/handlers/ticket_notifier_spec.rb

@@ -1,5 +1,32 @@
 require "spec_helper"
+require "json"
 
 describe Lita::Handlers::TicketNotifier, lita_handler: true do
+  let(:payload) { File.read(File.join('spec', 'fixtures', 'ticket.json')) }
+  let(:request) { OpenStruct.new({ body: OpenStruct.new({ read: payload }) }) }
+  let(:teddy) { Lita::User.create(123, name: "Teddy Ruxbin") }
+  let(:batman) { Lita::User.create(567, name: "The Batman") }
+  let(:ticket_messsage) { "Ticket: test ticket\nState:review\nImportance:Low\nTags:dev\nhttp://waffles.lighthouseapp.com/projects/1/tickets/200" }
 
+  it { routes_command("ticket notify start").to(:add_ticket_notification) }
+  it { routes_command("ticket notify stop").to(:remove_ticket_notification) }
+  it { routes_http(:post, "/ticket_notification").to(:ticket_notification) }
+
+  it "notifies correct users about tickets" do
+    expect(subject).to receive(:send_message_to_user).with(user.name, ticket_messsage)
+    expect(subject).to receive(:send_message_to_user).with(teddy.name, ticket_messsage)
+    expect(subject).to_not receive(:send_message_to_user).with(batman.name, ticket_messsage)
+
+    send_command("ticket notify start")
+    send_command("ticket notify start", as: teddy)
+    send_command("ticket notify start", as: batman)
+    send_command("ticket notify stop", as: batman)
+
+    subject.ticket_notification(request, nil)
+  end
+
+  it "doesn't send notifications to nobody" do
+    expect(subject).to_not receive(:send_message_to_user)
+    subject.ticket_notification(request, nil)
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lita-ticket_notifier
 version: !ruby/object:Gem::Version
-  version: 0.0.12
+  version: 0.0.14
 platform: ruby
 authors:
 - Michael van den Beuken
@@ -13,7 +13,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-08-06 00:00:00.000000000 Z
+date: 2014-08-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lita
@@ -106,6 +106,7 @@ files:
 - lib/lita/handlers/ticket_notifier.rb
 - lita-ticket_notifier.gemspec
 - locales/en.yml
+- spec/fixtures/ticket.json
 - spec/lita/handlers/ticket_notifier_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/amaabca/lita-ticket_notifier
@@ -134,5 +135,6 @@ signing_key:
 specification_version: 4
 summary: Users can opt-in/out from Lighthouse new ticket notifications.
 test_files:
+- spec/fixtures/ticket.json
 - spec/lita/handlers/ticket_notifier_spec.rb
 - spec/spec_helper.rb