lita-stocks 0.0.4 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8a03cc9ae4756d10416e873a065fe60faa46479f
-  data.tar.gz: cc1c5b78c7fd3d8631f94353e02e7ad286e8a6a8
+  metadata.gz: c2edfa8a6699523b19368601afd6fdc5d3b796f5
+  data.tar.gz: 94b38e0879f0c9e266d6d5752cf9050825e6c612
 SHA512:
-  metadata.gz: 2e26a75e9725c6cf26676202f941d1b0877dd2c5c5c2ac6dd580049daa5d9da156c415d79f35c5c72a9af3e85018335e0707f68bceb7b1dff9a2596a8d0f9571
-  data.tar.gz: 870481ebfb5cbc8a4af97f6d8e0fb92e2190464d3160bde6355af5f59dbb4b93aebd07e800d323d740b9064999bea9d08354afaa526199979fb455d434fa81f3
+  metadata.gz: 132d3588c35830c04c832da7f521c24b071685117453636b3dfad141f222090ce4e4bce40e748961816895be290b67df11dbeee25089a755bd2a24c9ef116f8e
+  data.tar.gz: 165cbb80f63c91f2bd809459767d38d06ee5d9d9331b765ccc0855ad2627cae012e88315dc6501cf680d685448c7b71e7c2b69669b45c6e5a7de5071dfd670b9

data/lib/lita/handlers/stocks.rb

@@ -1,4 +1,5 @@
 require "lita"
+require "cgi"
 
 module Lita
   module Handlers
@@ -26,7 +27,13 @@ module Lita
       def get_stock_data(symbol)
         resp = http.get("https://www.google.com/finance/info?infotype=infoquoteall&q=#{symbol}")
         raise 'RequestFail' unless resp.status == 200
-        MultiJson.load(resp.body.gsub(/\/\//, ''))[0]
+        body = resp.body.gsub(/\/\//, '')
+
+        # Google sends hex encoded data, we need to fix that
+        (33..47).each do |char|
+          body.gsub!(/\\x#{char.to_s(16)}/, char.chr)
+        end
+        MultiJson.load(body)[0]
       end
 
       def format_response(data)

data/lita-stocks.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = "lita-stocks"
-  spec.version       = "0.0.4"
+  spec.version       = "0.0.5"
   spec.authors       = ["Mitch Dempsey"]
   spec.email         = ["mrdempsey@gmail.com"]
   spec.description   = %q{A Lita handler that displays stock prices}

data/spec/lita/handlers/stocks_spec.rb

@@ -23,4 +23,11 @@ describe Lita::Handlers::Stocks, lita_handler: true do
     expect(replies.last).to_not include("MktCap")
     expect(replies.last).to_not include("P/E")
   end
+
+
+  it "ensures proper encoding" do
+    send_command "stock T"
+    expect(replies.last).to include("AT&T")
+  end
+
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lita-stocks
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - Mitch Dempsey