lita-snap-ci 1.0.0 → 1.1.0

data/README.md

@@ -1,6 +1,14 @@
 # lita-snap-ci
 
-Reports from [snap-ci]('https://snap-ci.com/'). [![Build Status](https://snap-ci.com/groteck/lita-snap-ci/branch/master/build_image)](https://snap-ci.com/groteck/lita-snap-ci/branch/master)
+Lita handler, to display the snap-ci pipelines of a project.
+
+|  Services  |
+|---  |
+|  [![Build Status](https://snap-ci.com/groteck/lita-snap-ci/branch/master/build_image)](https://snap-ci.com/groteck/lita-snap-ci/branch/master)  |
+|---  |
+|  [![Code Climate](https://codeclimate.com/github/groteck/lita-snap-ci/badges/gpa.svg)](https://codeclimate.com/github/groteck/lita-snap-ci)  |
+|---  |
+|  [![Test Coverage](https://codeclimate.com/github/groteck/lita-snap-ci/badges/coverage.svg)](https://codeclimate.com/github/groteck/lita-snap-ci/coverage)  |
 
 ## Installation
 

data/lib/snap_ci/parser.rb

@@ -1,9 +1,17 @@
 require 'multi_json'
+require_relative 'translations'
 
 module SnapCi
   class Parser
+    include Translations
+
+    ERROR_PARAMETERS = {
+      'result' => t('parser.error', { locale: :en }),
+      'stages' => nil
+    }
+
     def initialize(response)
-      @pipeline = MultiJson.load(response.body)['_embedded']['pipelines'].last
+      set_pipeline(MultiJson.load(response.body))
     end
 
     def to_parameters
@@ -12,5 +20,15 @@ module SnapCi
         steps: @pipeline['stages']
       }
     end
+
+    private
+
+    def set_pipeline(body)
+      @pipeline = if !body.has_value? 'Resource not found!'
+                    body['_embedded']['pipelines'].last
+                  else
+                    ERROR_PARAMETERS
+                  end
+    end
   end
 end

data/lib/snap_ci/project.rb

@@ -44,11 +44,22 @@ module SnapCi
     end
 
     def pipeline_to_s(branch, parameters)
-      "  #{branch}: #{parameters[:status]} (#{steps_to_s(parameters[:steps])})"
+      status_to_s(branch, parameters[:status]) + steps_to_s(parameters[:steps])
+    end
+
+    def status_to_s(branch, status)
+      "  #{branch}: #{status}"
     end
 
     def steps_to_s(steps)
-      steps.map { |step| "#{step["name"]}: #{step["result"]}" }.join(", ")
+      if !steps.nil?
+        " (#{steps
+              .map { |step| "#{step["name"]}: #{step["result"]}" }
+              .join(", ")
+        })"
+      else
+        ''
+      end
     end
 
     def uris

data/lib/snap_ci/translations.rb

@@ -0,0 +1,24 @@
+require 'i18n'
+
+module SnapCi
+  module Translations
+    module ClassMethods
+      def t(key, hash = {})
+        I18n.t("lita.handlers.snap_ci.#{key}", hash)
+      end
+    end
+
+    module InstanceMethods
+      private
+
+      def t(key, hash = {})
+        self.class.t(key, hash)
+      end
+    end
+
+    def self.included(receiver)
+      receiver.extend         ClassMethods
+      receiver.send :include, InstanceMethods
+    end
+  end
+end

data/lita-snap-ci.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = "lita-snap-ci"
-  spec.version       = "1.0.0"
+  spec.version       = "1.1.0"
   spec.authors       = ["Juan Fraire"]
   spec.email         = ["groteck@gmail.com"]
   spec.description   = "Snap-ci integration with lita"
@@ -18,6 +18,7 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency "bundler", "~> 1.3"
   spec.add_development_dependency "pry-byebug"
+  spec.add_development_dependency "codeclimate-test-reporter"
   spec.add_development_dependency "rake"
   spec.add_development_dependency "rack-test"
   spec.add_development_dependency "webmock"

data/locales/en.yml

@@ -8,3 +8,5 @@ en:
         project:
           command: snap-ci status <owner>/<repo> or <repo>
           desc: display a single project report with all the branches and status
+        parser:
+          error: Untracked branch in snap-ci

data/spec/fixtures/error.json

@@ -0,0 +1,3 @@
+{
+  "message": "Resource not found!"
+}

data/spec/fixtures/error.message

@@ -0,0 +1,2 @@
+Project: wrong_org/wrong_project:
+  wrong_branch: Untracked branch in snap-ci

data/spec/lita/handlers/snap_ci_spec.rb

@@ -1,37 +1,76 @@
 require "spec_helper"
 
 describe Lita::Handlers::SnapCi, lita_handler: true do
-  before do
-    load_config
-  end
+  context 'with valid projects' do
+    before do
+      load_config
+    end
 
-  describe 'command `snap-ci report`:' do
-    it 'display a general report' do
-      send_message("snap-ci report")
+    describe 'command `snap-ci report`:' do
+      it 'display a general report' do
+        send_message("snap-ci report")
 
-      load_message_fixture('snap-ci_report').each_line do |line|
-        expect(replies.last).to include(line.delete("\n"))
+        load_message_fixture('snap-ci_report').each_line do |line|
+          expect(replies.last).to include(line.delete("\n"))
+        end
+      end
+    end
+
+    describe 'command `snap-ci project`:' do
+      context 'with only repo format' do
+        it 'displays the project status' do
+          send_message("snap-ci project api")
+
+          load_message_fixture('snap-ci_status').each_line do |line|
+            expect(replies.last).to include(line.delete("\n"))
+          end
+        end
+      end
+
+      context 'with owner/repo format' do
+        it 'displays the project status' do
+          send_message("snap-ci project oneorg/api")
+
+          load_message_fixture('snap-ci_status').each_line do |line|
+            expect(replies.last).to include(line.delete("\n"))
+          end
+        end
       end
     end
   end
+  context 'with invalid projects' do
+    before do
+      load_wrong_config
+    end
 
-  describe 'command `snap-ci project`' do
-    context 'with repo format' do
-      it 'displays the project status' do
-        send_message("snap-ci project api")
+    describe 'command `snap-ci report`:' do
+      it 'display a general report with the failure message' do
+        send_message("snap-ci report")
 
-        load_message_fixture('snap-ci_status').each_line do |line|
+        load_message_fixture('error').each_line do |line|
           expect(replies.last).to include(line.delete("\n"))
         end
       end
     end
 
-    context 'with owner/repo format' do
-      it 'displays the project status' do
-        send_message("snap-ci project oneorg/api")
+    describe 'command `snap-ci project`:' do
+      context 'with only repo format' do
+        it 'displays the project status with the failure message' do
+          send_message("snap-ci project wrong_project")
 
-        load_message_fixture('snap-ci_status').each_line do |line|
-          expect(replies.last).to include(line.delete("\n"))
+          load_message_fixture('error').each_line do |line|
+            expect(replies.last).to include(line.delete("\n"))
+          end
+        end
+      end
+
+      context 'with owner/repo format' do
+        it 'displays the project status with the failure message' do
+          send_message("snap-ci project wrong_org/wrong_project")
+
+          load_message_fixture('error').each_line do |line|
+            expect(replies.last).to include(line.delete("\n"))
+          end
         end
       end
     end

data/spec/spec_helper.rb

@@ -1,6 +1,7 @@
 require "lita-snap-ci"
 require "lita/rspec"
 require 'webmock/rspec'
+require "codeclimate-test-reporter"
 
 # Load helpers
 require_relative 'support/fixture'
@@ -10,6 +11,8 @@ require_relative 'support/config'
 # was generated with Lita 4, the compatibility mode should be left disabled.
 Lita.version_3_compatibility_mode = false
 
+CodeClimate::TestReporter.start
+
 RSpec.configure do |c|
   c.include Fixture
   c.include Config

data/spec/support/config.rb

@@ -18,4 +18,16 @@ module Config
       }
     ]
   end
+
+  def load_wrong_config
+    registry.config.handlers.snap_ci.user = "snapUser"
+    registry.config.handlers.snap_ci.token = "Snap-ci-api-key"
+    registry.config.handlers.snap_ci.projects = [
+      {
+        owner: 'wrong_org',
+        repository: 'wrong_project',
+        branches: ['wrong_branch']
+      }
+    ]
+  end
 end

data/spec/support/fixture.rb

@@ -33,5 +33,8 @@ module Fixture
       to_return(status: 200, body: load_json_fixture('websites_develop'))
     stub_request(:get, "#{URL}otherorg/websites/branch/master/pipelines").
       to_return(status: 200, body: load_json_fixture('websites_master'))
+    # wrong_project example
+    stub_request(:get, "#{URL}wrong_org/wrong_project/branch/wrong_branch/pipelines").
+      to_return(status: 404, body: load_json_fixture('error'))
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lita-snap-ci
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors:
 - Juan Fraire
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-06-11 00:00:00.000000000 Z
+date: 2016-06-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lita
@@ -52,6 +52,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: codeclimate-test-reporter
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -115,7 +129,9 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".codeclimate.yml"
 - ".gitignore"
+- ".rubocop.yml"
 - Gemfile
 - README.md
 - Rakefile
@@ -126,11 +142,14 @@ files:
 - lib/snap_ci/parser.rb
 - lib/snap_ci/project.rb
 - lib/snap_ci/project_list.rb
+- lib/snap_ci/translations.rb
 - lita-snap-ci.gemspec
 - locales/en.yml
 - spec/fixtures/api_development.json
 - spec/fixtures/api_master.json
 - spec/fixtures/api_staging.json
+- spec/fixtures/error.json
+- spec/fixtures/error.message
 - spec/fixtures/front_master.json
 - spec/fixtures/front_staging.json
 - spec/fixtures/pipelines.json
@@ -172,6 +191,8 @@ test_files:
 - spec/fixtures/api_development.json
 - spec/fixtures/api_master.json
 - spec/fixtures/api_staging.json
+- spec/fixtures/error.json
+- spec/fixtures/error.message
 - spec/fixtures/front_master.json
 - spec/fixtures/front_staging.json
 - spec/fixtures/pipelines.json