lita-slack 1.0.3 → 1.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: edbc8dcdee46b8b2abbe6d6fcbd85e6610598726
-  data.tar.gz: 6763ecbdf98d5fbdaf0d904d4252702f1c3b236f
+  metadata.gz: 94fa7740895d09a183b18621b296e01c0b9bf4ba
+  data.tar.gz: 8d092bb60ea02b23c43f53551e6ca691d5654d00
 SHA512:
-  metadata.gz: 78c015357fa487c0ff844a8438934b9a9fa729f02c66a04182734007030b449dab63cbb09e5d9fc4cd47c89ee7473258005b4d39e27b675b72b8432b35d30c0d
-  data.tar.gz: af1dd3ecb8fc8fb3a585a6ba060c8d235d4e3a662d7af77f6c0cd2ece4773237010200dc1dc6b46af61261c81ae18555da1f603ace5c69340dcd5988fd743c95
+  metadata.gz: 9478684ba8c9c77579c3224559cff79b49a7fcf2f30c361997d2e1d53ee777269e6da9bcd0b542fac591a1b7ed20ce27a708ad25db19675bd7ca51367c83cb2b
+  data.tar.gz: 1746b869ac92e8a99d3cc8bcad47ea21707625b28dbc6607d6b8684d023e118eb8ec6cc06ed89082607ebf428a18de6bc3055da3eb32c1a59d062560d9650a42

data/README.md

@@ -18,15 +18,24 @@ gem "lita-slack"
 
 **Note**: When using lita-slack, the adapter will overwrite the bot's name and mention name with the values set on the server, so `config.robot.name` and `config.robot.mention_name` will have no effect.
 
+### config.robot.admins
+
+Each Slack user has a unique ID that never changes even if their real name or username changes. To populate the `config.robot.admins` attribute, you'll need to use these IDs for each user you want to mark as an administrator. If you're using Lita version 4.1 or greater, you can get a user's ID by sending Lita the command `users find NICKNAME_OF_USER`.
+
 ### Example
 
 ``` ruby
 Lita.configure do |config|
   config.robot.adapter = :slack
+  config.robot.admins = ["U012A3BCD"]
   config.adapters.slack.token = "abcd-1234567890-hWYd21AmMH2UHAkx29vb5c1Y"
 end
 ```
 
+## Joining rooms
+
+Lita will join your default channel after initial setup. To have it join additional channels or private groups, simply invite it to them via your Slack client as you would any normal user.
+
 ## Events
 
 * `:connected` - When the robot has connected to Slack. No payload.

data/lib/lita/adapters/slack.rb

@@ -32,10 +32,10 @@ module Lita
       attr_reader :rtm_connection
 
       def channel_for(target)
-        if target.room
-          target.room
-        else
+        if target.private_message?
           rtm_connection.im_for(target.user.id)
+        else
+          target.room
         end
       end
     end

data/lita-slack.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = "lita-slack"
-  spec.version       = "1.0.3"
+  spec.version       = "1.0.4"
   spec.authors       = ["Ken J.", "Jimmy Cuadra"]
   spec.email         = ["kenjij@gmail.com", "jimmy@jimmycuadra.com"]
   spec.description   = %q{Lita adapter for Slack.}

data/spec/lita/adapters/slack_spec.rb

@@ -40,6 +40,9 @@ describe Lita::Adapters::Slack, lita: true do
     let(:room_source) { Lita::Source.new(room: 'C024BE91L') }
     let(:user) { Lita::User.new('U023BECGF') }
     let(:user_source) { Lita::Source.new(user: user) }
+    let(:private_message_source) do
+      Lita::Source.new(room: 'C024BE91L', user: user, private_message: true)
+    end
 
     it "sends messages to rooms" do
       expect(rtm_connection).to receive(:send_messages).with(room_source.room, ['foo'])
@@ -56,7 +59,17 @@ describe Lita::Adapters::Slack, lita: true do
 
       subject.run
 
-      subject.send_messages(Lita::Source.new(user: user), ['foo'])
+      subject.send_messages(user_source, ['foo'])
+    end
+
+    it "sends messages to users when the source is marked as a private message" do
+      allow(rtm_connection).to receive(:im_for).with(user.id).and_return('D024BFF1M')
+
+      expect(rtm_connection).to receive(:send_messages).with('D024BFF1M', ['foo'])
+
+      subject.run
+
+      subject.send_messages(private_message_source, ['foo'])
     end
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lita-slack
 version: !ruby/object:Gem::Version
-  version: 1.0.3
+  version: 1.0.4
 platform: ruby
 authors:
 - Ken J.
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-12-18 00:00:00.000000000 Z
+date: 2015-01-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: eventmachine
@@ -221,7 +221,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: Lita adapter for Slack.