lita-slack-standup 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4364222638a2403f76b6dd2820942e5cb45ffe29
-  data.tar.gz: 1c99770580f1bcec56460b976be433385ee543f9
+  metadata.gz: 89112ea2047b1056586a00ba012d2512df53e655
+  data.tar.gz: 73e7b3aed31e7f7a3dc1ad27ee2cbe3e574771c7
 SHA512:
-  metadata.gz: 9e7ad5ae7f30fcf8bc6c5f44980a247cf6eeef3a06caf9798fdf5c0e2b6b4fa4949024e13e28c5cad5d12793d41fe40460fef853ab501834a8f33ed1908a553a
-  data.tar.gz: 7058bd619dfb62245fb61432c43a59fc44350ad0f5baa1991e5ed6a307e3a3ec7383046b243103c47a092bdecd20278df3faa00ec3db47b3293debb48dd92d3a
+  metadata.gz: d4b60e34957088fb7216d253e3b96c07dee1a843b3f139c86b88cf060b41685c06e77380cb16cb359538f01c2e774b8446f3b3e87f2714a1bb256b2b6e1f85c8
+  data.tar.gz: 1ae64a78fb0e9c86564f5ef8594aaa3be5a23ec74ada631a9c6aae047527739b45f6afbfb0a19f515834075181d523a20c724d31d13c6e61ee74a311f8bd242b

data/README.md

@@ -28,5 +28,6 @@ end
  - !standup ignore <some user> : ignores an user for the standups
  - !standup unignore <some user> : unignores an user
  - !standup list : lists all ignored users
+ - !standup end : ends the current standup
   
 The standup stops when everyone has done his report or has been skipped.

data/lib/lita/handlers/slack_standup.rb

@@ -86,8 +86,9 @@ module Lita
       route(/^standup\s+end$/, :standup_end, command: true, help: {t("help.end_cmd") => t("help.end_description")})
 
       def standup_end(message=nil)
-        contextual_end_message
+        return unless end_check?
 
+        send_message(config.channel,t("sentence.end_standup"))
         in_standup.value = 'false'
         update_ids_to_members
         update_standup_members
@@ -106,12 +107,11 @@ module Lita
         in_standup.value == 'true'
       end
 
-      def contextual_end_message
-        if in_standup.value == 'true'
-          send_message(config.channel,t("sentence.end_standup"))
-        else
-          send_message(config.channel, t("sentence.clear_objects"))
+      def end_check?
+        if in_standup.value != 'true'
+          send_message(config.channel, t("sentence.end_forbidden"))
         end
+        in_standup.value == 'true'
       end
 
       def standup_check?

data/lita-slack-standup.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = "lita-slack-standup"
-  spec.version       = "1.0.0"
+  spec.version       = "1.0.1"
   spec.authors       = ["Sybil Deboin"]
   spec.email         = ["sybil.deboin@gmail.com"]
   spec.description   = "Standup feature for slack"

data/locales/en.yml

@@ -30,4 +30,4 @@ en:
           standup_fill: "Standup done in live."
           already_started: "The standup is already started."
           end_standup: "That's it ! It's all good for today. Thanks everyone :)"
-          clear_objects: "We're not during standup. The saved standups have been erased and the users list updated."
+          end_forbidden: "There is no ongoing standup."

data/locales/fr.yml

@@ -30,4 +30,4 @@ fr:
           standup_fill: "Standup fait en live."
           already_started: "Le standup est déjà en cours."
           end_standup: "Et voilà ! C'est bon pour aujourd'hui. Merci tout le monde :)"
-          clear_objects: "Aucun standup en cours. Les standups enregistrés ont été supprimés et la liste des utilisateurs mise à jour."
+          end_forbidden: "Aucun standup en cours."

data/spec/lita/handlers/slack_standup_spec.rb

@@ -40,8 +40,8 @@ describe Lita::Handlers::SlackStandup, lita_handler: true do
       to_return(:status => 200, :body => '{"ok": true,"channel": "C","message": "Et voilà ! C\'est bon pour aujourd\'hui. Merci tout le monde :)"}', :headers => {})
 
     stub_request(:post, "https://slack.com/api/chat.postMessage").
-      with(:body => {"as_user"=>"true", "channel"=>"#jambot-test", "text"=>"Aucun standup en cours. Les standups enregistrés ont été supprimés et la liste des utilisateurs mise à jour.", "token"=>nil},:headers => header).
-      to_return(:status => 200, :body => '{"ok": true,"channel": "C","message": "Aucun standup en cours. Les standups enregistrés ont été supprimés et la liste des utilisateurs mise à jour."}', :headers => {})
+      with(:body => {"as_user"=>"true", "channel"=>"#jambot-test", "text"=>"Aucun standup en cours.", "token"=>nil},:headers => header).
+      to_return(:status => 200, :body => '{"ok": true,"channel": "C","message": "Aucun standup en cours."}', :headers => {})
  
     stub_request(:post, "https://slack.com/api/chat.postMessage").
       with(:body => {"as_user"=>"true", "channel"=>"#jambot-test", "text"=>"La commande n'est pas disponible en dehors d'un standup.", "token"=>nil},:headers => header).
@@ -233,7 +233,7 @@ describe Lita::Handlers::SlackStandup, lita_handler: true do
     context "outside the standup" do
       it "clears the objects" do
  
-        expect_any_instance_of(Slack::Web::Client).to receive(:chat_postMessage).with({:channel=>channel, :text=>"Aucun standup en cours. Les standups enregistrés ont été supprimés et la liste des utilisateurs mise à jour.", :as_user=>true})
+        expect_any_instance_of(Slack::Web::Client).to receive(:chat_postMessage).with({:channel=>channel, :text=>"Aucun standup en cours.", :as_user=>true})
         subject
       end
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lita-slack-standup
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Sybil Deboin