lita-slack-standup 0.3.0 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 24837d008e9571abcfcefe9e4a6cd2769806d379
-  data.tar.gz: 63f45bd81663b8258eb09a2050ff94f7ea18fc6a
+  metadata.gz: 13a8bd26d0513fbb89c7d2e2da9260382fe807c3
+  data.tar.gz: 77b75f0b5ac8943e58088151a3500ee480a4b458
 SHA512:
-  metadata.gz: b48d26793feef58a92742badd7a532f01ee929cb73bc611acc6f09a0bd7925978110c7396bad59095222d9bb85ad05d82a334aa98c0fd5943dfcd344be90eb2f
-  data.tar.gz: 44955b6360bf157e6133fdf7da8ce4cbc1772fd9f46d82eb4307c66baa507c9bcf4025b9fac82f8c5982b0329f328db7c52ee12a6e3296e1e75bf60e379f64bb
+  metadata.gz: 51473e6515c67ddff2ed08b93a426b6da14fc58727375942d2a8c9642526c11c72311572e268990101373843d717c9ac3f1f35cddc4ec6c7f085b44eb9fbd27e
+  data.tar.gz: 912ead65247840a1e91dbef8db7395954fd698f08a495861edb425111e2dda37b0dae1a6ebe9863cf6dd5e43d85712d37e6a390d999250b4ac64dc25a74c573d

data/README.md

@@ -22,11 +22,6 @@ end
 
 And set the environment variable STANDUP_CHANNEL, with the name of the channel where you want to held the standup.
 
-## Test
-
-We used VCR generated by real standups on slack. We had to delete them for privacy reasons.  
-To rerun the tests and recreate some VCR, you need to bundle the gem into a lita bot.
-
 ## Usage
 
  - !standup start : launches the standup, prints the standups already filled and asks for someone else to report

data/lita-slack-standup.gemspec

@@ -1,10 +1,10 @@
 Gem::Specification.new do |spec|
   spec.name          = "lita-slack-standup"
-  spec.version       = "0.3.0"
+  spec.version       = "0.5.0"
   spec.authors       = ["Sybil Deboin"]
   spec.email         = ["sybil.deboin@gmail.com"]
   spec.description   = "Standup feature for slack"
-  spec.summary       = ""
+  spec.summary       = "A lita gem to enable standups on slack"
   spec.homepage      = "https://github.com/blackbirdco/lita-slack-standup"
   spec.license       = "GNU v3.0"
   spec.metadata      = { "lita_plugin_type" => "handler" }
@@ -20,10 +20,7 @@ Gem::Specification.new do |spec|
   spec.add_runtime_dependency "redis-objects"
 
   spec.add_development_dependency "bundler", "~> 1.3"
-  spec.add_development_dependency "pry-byebug"
   spec.add_development_dependency "rake"
-  spec.add_development_dependency "rack-test"
   spec.add_development_dependency "rspec", ">= 3.0.0"
   spec.add_development_dependency "webmock"
-  spec.add_development_dependency "vcr" 
 end

data/spec/lita/handlers/slack_standup_spec.rb

@@ -7,25 +7,17 @@ describe Lita::Handlers::SlackStandup, lita_handler: true do
   let(:sybil) { Lita::User.create(1000, name: "sybil") }
   let(:zaratan) { Lita::User.create(1001, name: "zaratan") }
 
-  before(:all) do
-    Slack.configure do |config|
-      config.token = ENV['SLACK_LITA_TOKEN']
-    end
-    Lita.configure do |config|
-      config.handlers.slack_standup.channel = '#jambot-test'
-    end
-  end
-
   let(:registry) do
     reg = Lita::Registry.new
     reg.register_handler(Lita::Handlers::SlackStandup)
+    
     reg.configure do |config|
       config.robot.name = robot_name
       config.robot.alias = "!"
       config.robot.adapter = :slack
       config.handlers.slack_standup.channel = channel
     end
-
+    
     reg
   end
 
@@ -34,17 +26,35 @@ describe Lita::Handlers::SlackStandup, lita_handler: true do
     standup.send(:standup_members).clear
     standup.send(:ids_to_members).clear
     standup.send(:ignored_members).clear 
-    ['jambot','slackbot','sybil_test'].each do |ignored_member|
-      standup.send(:ignored_members) << ignored_member
-    end
+  
+    stub_request(:post, "https://slack.com/api/users.list").
+      with(:body => {"token"=>nil}, :headers => {'Accept'=>'application/json; charset=utf-8', 'Accept-Encoding'=>'gzip;q=1.0,deflate;q=0.6,identity;q=0.3', 'Content-Type'=>'application/x-www-form-urlencoded', 'User-Agent'=>'Slack Ruby Client/0.6.0'}).
+      to_return(:status => 200, :body => '{"ok": true,"members":[
+              {"id":"A","team_id":"AT","name":"sybil"}, {"id":"B","team_id":"BT","name":"zaratan"}]}', :headers => {})
+
+    stub_request(:post, "https://slack.com/api/channels.list").
+      with(:body => {"token"=>nil},:headers => {'Accept'=>'application/json; charset=utf-8', 'Accept-Encoding'=>'gzip;q=1.0,deflate;q=0.6,identity;q=0.3', 'Content-Type'=>'application/x-www-form-urlencoded', 'User-Agent'=>'Slack Ruby Client/0.6.0'}).
+      to_return(:status => 200, :body => '{"ok":true,"channels":[{"id":"C","name":"jambot-test","is_channel":true,"members":["B","A"],"num_members":2}]}', :headers => {})
+    
+    stub_request(:post, "https://slack.com/api/chat.postMessage").
+      with(:body => {"as_user"=>"true", "channel"=>"#jambot-test", "text"=>"Hello <!channel> ! Le standup va commencer : )", "token"=>nil},:headers => {'Accept'=>'application/json; charset=utf-8', 'Accept-Encoding'=>'gzip;q=1.0,deflate;q=0.6,identity;q=0.3', 'Content-Type'=>'application/x-www-form-urlencoded', 'User-Agent'=>'Slack Ruby Client/0.6.0'}).
+      to_return(:status => 200, :body => '{"ok": true,"channel": "C","message": "Hello <!channel> ! Le standup va commencer : )"}', :headers => {})
+  
+    stub_request(:post, "https://slack.com/api/chat.postMessage").
+      with(:body => {"as_user"=>"true", "channel"=>"#jambot-test", "text"=>"Bonjour <@zaratan> ! C'est à ton tour de parler.", "token"=>nil},:headers => {'Accept'=>'application/json; charset=utf-8', 'Accept-Encoding'=>'gzip;q=1.0,deflate;q=0.6,identity;q=0.3', 'Content-Type'=>'application/x-www-form-urlencoded', 'User-Agent'=>'Slack Ruby Client/0.6.0'}).
+      to_return(:status => 200, :body => '{"ok": true,"channel": "C","message": "Bonjour <@zaratan> ! C\'est à ton tour de parler."}', :headers => {})
   end
-
+  
+  
   describe "when standup starts" do
     subject do 
       send_message("!standup start", as: sybil, from: channel)
     end
 
-    it "starts standup", vcr: {cassette_name: 'standup_start'} do
+    it { is_expected.to route("!standup start") }  
+    
+    it "starts standup" do
+
       [ "Hello <!channel> ! Le standup va commencer : )",
         "Bonjour <@zaratan> ! C'est à ton tour de parler."
       ].each do |text|
@@ -59,29 +69,29 @@ describe Lita::Handlers::SlackStandup, lita_handler: true do
         send_message("!standup report My standup report for testing purposes", as: sybil, from: channel)
       end
 
-      it "displays known reports", vcr: {cassette_name: 'standup_one_report_prefilled'} do
-	[ "Hello <!channel> ! Le standup va commencer : )",
-	  "sybil a déjà renseigné son standup : \n My standup report for testing purposes",
-	  "Bonjour <@zaratan> ! C'est à ton tour de parler."
-	].each do |text|
-	  expect_any_instance_of(Slack::Web::Client).to receive(:chat_postMessage).with({:channel=>channel, :text=>text, :as_user=>true})
-	end
+      it "displays known reports" do
+        [ "Hello <!channel> ! Le standup va commencer : )",
+          "sybil a déjà renseigné son standup : \n My standup report for testing purposes",
+          "Bonjour <@zaratan> ! C'est à ton tour de parler."
+        ].each do |text|
+          expect_any_instance_of(Slack::Web::Client).to receive(:chat_postMessage).with({:channel=>channel, :text=>text, :as_user=>true})
+        end
         subject
       end
     
-      context "with all reports pre-filled", vcr: {cassette_name: 'standup_all_reports_prefilled'} do
+      context "with all reports pre-filled" do
         before do
           send_message("!standup report My standup report for testing purposes", as: sybil, from: channel)   
           send_message("!standup report My standup report for testing purposes", as: zaratan, from: channel)   
         end
 
         it "displays the standups and ends the meeting" do
- 	  [ "Hello <!channel> ! Le standup va commencer : )",
-	    "zaratan a déjà renseigné son standup : \n My standup report for testing purposes",
-	    "sybil a déjà renseigné son standup : \n My standup report for testing purposes",
-	    "Et voilà ! C'est bon pour aujourd'hui. Merci tout le monde :parrot:"
-	  ].each do |text|
-	    expect_any_instance_of(Slack::Web::Client).to receive(:chat_postMessage).with({:channel=>channel, :text=>text, :as_user=>true})       
+          [ "Hello <!channel> ! Le standup va commencer : )",
+            "zaratan a déjà renseigné son standup : \n My standup report for testing purposes",
+            "sybil a déjà renseigné son standup : \n My standup report for testing purposes",
+            "Et voilà ! C'est bon pour aujourd'hui. Merci tout le monde :parrot:"
+          ].each do |text|
+            expect_any_instance_of(Slack::Web::Client).to receive(:chat_postMessage).with({:channel=>channel, :text=>text, :as_user=>true})       
           end
           subject
         end
@@ -89,7 +99,7 @@ describe Lita::Handlers::SlackStandup, lita_handler: true do
     end
   end
 
-  describe "!standup report command", vcr: {cassette_name: 'standup_report'} do
+  describe "!standup report command" do
     subject do 
       send_message("!standup report My standup report for testing purposes", as: sybil, from: channel)
     end
@@ -105,14 +115,14 @@ describe Lita::Handlers::SlackStandup, lita_handler: true do
       send_message("!standup next", as: sybil, from: channel)
     end
 
-    context "when its called oustide of standups", vcr: {cassette_name: 'standup_next_refused'} do
+    context "when its called oustide of standups" do
       it "is not available" do
         expect_any_instance_of(Slack::Web::Client).to receive(:chat_postMessage).with({:channel=>channel, :text=>"La commande n'est pas disponible en dehors d'un standup.", :as_user=>true})
         subject  
       end
     end
 
-    context "when it's called during standup", vcr: {cassette_name: 'standup_next'} do
+    context "when it's called during standup" do
       before do 
         send_message("!standup start", as: sybil, from: channel)
       end
@@ -124,7 +134,7 @@ describe Lita::Handlers::SlackStandup, lita_handler: true do
     end
   end
 
-  describe "!standup ignore user command", vcr: {cassette_name: 'standup_ignore'} do
+  describe "!standup ignore user command" do
 
     before do
       send_message("!standup start", as: sybil, from: channel)
@@ -142,7 +152,7 @@ describe Lita::Handlers::SlackStandup, lita_handler: true do
     end
   end
 
-  describe "!standup unignore user command", vcr: {cassette_name: 'standup_unignore'} do
+  describe "!standup unignore user command" do
 
     before do
       send_message("!standup start", as: sybil, from: channel)

data/spec/spec_helper.rb

@@ -6,29 +6,17 @@ require "webmock/rspec"
 # was generated with Lita 4, the compatibility mode should be left disabled.
 Lita.version_3_compatibility_mode = false
 
-
 lib = File.expand_path('../lib/')
 $:.unshift lib unless $:.include?(lib)
 
-require "vcr"
 require "slack-ruby-client"
 require "slack_client"
 require "redis-objects"
 
-
 # A compatibility mode is provided for older plugins upgrading from Lita 3. Since this plugin
 # was generated with Lita 4, the compatibility mode should be left disabled.
 Lita.version_3_compatibility_mode = false
 
-
-
-VCR.configure do |config|
-  config.cassette_library_dir = "spec/fixtures/vcr"
-  config.configure_rspec_metadata!
-  config.hook_into :webmock
-  config.filter_sensitive_data("<SLACK_LITA_TOKEN>") { ENV['SLACK_LITA_TOKEN'] }
-end
-
 RSpec.configure do |c|
   c.after do
     Redis.new.flushdb

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lita-slack-standup
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.5.0
 platform: ruby
 authors:
 - Sybil Deboin
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-02-27 00:00:00.000000000 Z
+date: 2016-02-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lita
@@ -80,20 +80,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
-- !ruby/object:Gem::Dependency
-  name: pry-byebug
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -108,20 +94,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: rack-test
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -150,20 +122,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: vcr
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 description: Standup feature for slack
 email:
 - sybil.deboin@gmail.com
@@ -208,7 +166,7 @@ rubyforge_project:
 rubygems_version: 2.4.6
 signing_key: 
 specification_version: 4
-summary: ''
+summary: A lita gem to enable standups on slack
 test_files:
 - spec/lita/handlers/slack_standup_spec.rb
 - spec/spec_helper.rb