lita-reviewme 0.1.1 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: fa2d1d7d4d1f1202e1f69d3337d0c2ad5db03847
-  data.tar.gz: a97b026f8c99771b4c1bf2c8a935c5a75372e8c3
+  metadata.gz: 296d9fe4b696d9c8be819c918e3a12956e0011c1
+  data.tar.gz: 8fc85b368d684949d10d965fb201c37a5cc2442c
 SHA512:
-  metadata.gz: 11d1a2e9924542f61b590f48f172fc42196aa5f54f65208cc9f4e0db3f12988883db8fdf92d306960ae8bf7c433534618d72c2777c1d017488fdaa20684478c4
-  data.tar.gz: ec9ae4f1e848b4c6611be04b5a2ed1785f42001d1cc734c11dd372baeaf18aa3ba96527ec2d62798cbade5cf751315d22adae6bc0d58d45dbb5e2940ba796bc9
+  metadata.gz: 26d277331b7d6e75a962888f799298a5ff4d94aa5dcab135c014bed979a8fafd0f1c67aa166cae576f21a9e0e60899694b8f8d971e78afd26b1cb62e872a36ab
+  data.tar.gz: a23072dac424063faa19fbc2f7a796718515fef97b4528199fa4afa1cdd26376bb2d0f6aaa86126848a7f84ca45bbacc6d1738fc6f87d7ac367f34328a035e97

data/CHANGELOG.md

@@ -4,6 +4,11 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 
 ## [Unreleased]
 
+## [0.2.0] - 2016-01-29
+
+### Added
+- Prevent assignment to review your own PR (#36)
+
 ### Changed
 - Respond publicly w.r.t. private reply to `reviewers`.
 - Include room name in private reply to `reviewers`.
@@ -19,6 +24,7 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 ### Added
 - Start versioning gem.
 
-[Unreleased]: https://github.com/iamvery/lita-reviewme/compare/v0.1.0...HEAD
+[Unreleased]: https://github.com/iamvery/lita-reviewme/compare/v0.2.0...HEAD
+[0.2.0]: https://github.com/iamvery/lita-reviewme/compare/v0.1.0...v0.2.0
 [0.1.0]: https://github.com/iamvery/lita-reviewme/compare/v0.0.1...v0.1.0
 [0.0.1]: https://github.com/iamvery/lita-reviewme/compare/a02548...v0.0.1

data/lib/lita/handlers/reviewme.rb

@@ -85,7 +85,15 @@ module Lita
       def comment_on_github(response, room: get_room(response))
         repo = response.match_data[:repo]
         id = response.match_data[:id]
+
         reviewer = next_reviewer(room)
+        begin
+          pull_request = github_client.pull_request(repo, id)
+          owner = pull_request.user.login
+          reviewer = next_reviewer(room) if owner == reviewer
+        rescue Octokit::Error
+          response.reply("Unable to check who issued the pull request. Sorry if you end up being assigned your own PR!")
+        end
         comment = github_comment(reviewer)
 
         begin

data/lita-reviewme.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = "lita-reviewme"
-  spec.version       = "0.1.1"
+  spec.version       = "0.2.0"
   spec.authors       = ["Jay Hayes"]
   spec.email         = ["ur@iamvery.com"]
   spec.description   = %q{A lita handler that helps with code review}

data/spec/lita/handlers/reviewme_spec.rb

@@ -1,4 +1,5 @@
 require "spec_helper"
+require "ostruct"
 
 describe Lita::Handlers::Reviewme, lita_handler: true do
   it { is_expected.to route_command("add iamvery to reviews").to :add_reviewer }
@@ -52,17 +53,41 @@ describe Lita::Handlers::Reviewme, lita_handler: true do
   end
 
   describe "#comment_on_github" do
-    it "posts comment on github" do
-      repo = "gh_user/repo"
-      id = "123"
+    let(:repo) { "gh_user/repo" }
+    let(:id) { "123" }
+    let(:pr) do
+      OpenStruct.new({ user: OpenStruct.new({ login: "pr-owner" }) })
+    end
+
+    before do
+      # Prevent hitting the network for PR info.
+      allow_any_instance_of(Octokit::Client).to receive(:pull_request)
+        .and_return(pr)
+    end
 
+    it "posts comment on github" do
       expect_any_instance_of(Octokit::Client).to receive(:add_comment)
         .with(repo, id, ":eyes: @iamvery")
 
       send_command("add iamvery to reviews")
       send_command("review https://github.com/#{repo}/pull/#{id}")
 
-      expect(replies.last).to eq("iamvery should be on it...")
+      expect(reply).to eq("iamvery should be on it...")
+    end
+
+    it "skips assigning to the GitHub PR owner" do
+      expect_any_instance_of(Octokit::Client).to receive(:pull_request)
+        .with(repo, id).and_return(pr)
+
+      expected_reviewer = 'NOT THE PR OWNER'
+      expect_any_instance_of(Octokit::Client).to receive(:add_comment)
+        .with(repo, id, ":eyes: @#{expected_reviewer}")
+
+      send_command("add #{pr.user.login} to reviews")
+      send_command("add #{expected_reviewer} to reviews")
+      send_command("review https://github.com/#{repo}/pull/#{id}")
+
+      expect(reply).to eq("#{expected_reviewer} should be on it...")
     end
 
     it "handles errors gracefully" do
@@ -74,7 +99,7 @@ describe Lita::Handlers::Reviewme, lita_handler: true do
       send_command("add iamvery to reviews")
       send_command("review #{url}")
 
-      expect(replies.last).to eq("I couldn't post a comment. (Are the permissions right?) iamvery: :eyes: #{url}")
+      expect(reply).to eq("I couldn't post a comment. (Are the permissions right?) iamvery: :eyes: #{url}")
     end
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lita-reviewme
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.2.0
 platform: ruby
 authors:
 - Jay Hayes
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-01-15 00:00:00.000000000 Z
+date: 2016-01-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lita