lita-reviewme 0.1.0 → 0.1.1

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA1:
3
- metadata.gz: 9135c04a3978fc523361417f8b9ffc389640298a
4
- data.tar.gz: 858c2098a3521a22f18183fea353d24ff9575484
3
+ metadata.gz: fa2d1d7d4d1f1202e1f69d3337d0c2ad5db03847
4
+ data.tar.gz: a97b026f8c99771b4c1bf2c8a935c5a75372e8c3
5
5
  SHA512:
6
- metadata.gz: 6a625cda726942a7ab04b066fe97b5eec82897e51d22aa1a972ff25290b0983dea517fa219e39692221ca2a10143b9b883bbeb68424666e9d1c87adcdc61a472
7
- data.tar.gz: 091843b352d1568399e7a6c1a3566d7b3e96b7ce8ca4fcf3e5d78451b0ec704190720c0f43bac36e3d8062aec1c45a899f1346f9c342b23ad86bc2913ae78570
6
+ metadata.gz: 11d1a2e9924542f61b590f48f172fc42196aa5f54f65208cc9f4e0db3f12988883db8fdf92d306960ae8bf7c433534618d72c2777c1d017488fdaa20684478c4
7
+ data.tar.gz: ec9ae4f1e848b4c6611be04b5a2ed1785f42001d1cc734c11dd372baeaf18aa3ba96527ec2d62798cbade5cf751315d22adae6bc0d58d45dbb5e2940ba796bc9
data/CHANGELOG.md CHANGED
@@ -4,6 +4,10 @@ This project adheres to [Semantic Versioning](http://semver.org/).
4
4
 
5
5
  ## [Unreleased]
6
6
 
7
+ ### Changed
8
+ - Respond publicly w.r.t. private reply to `reviewers`.
9
+ - Include room name in private reply to `reviewers`.
10
+
7
11
  ## [0.1.0] - 2016-01-12
8
12
 
9
13
  ### Added
data/README.md CHANGED
@@ -29,7 +29,9 @@ ENV["GITHUB_WOLFBRAIN_ACCESS_TOKEN"]
29
29
 
30
30
  > **Jay H.** Nerdbot: reviewers
31
31
  >
32
- > **Nerdbot** iamvery, zacstewart, ...
32
+ > **Nerdbot** Responding via private message...
33
+ >
34
+ > **Nerdbot (privately)** channel-name: iamvery, zacstewart, ...
33
35
 
34
36
  ### Add a name to the review rotation
35
37
 
@@ -61,19 +61,20 @@ module Lita
61
61
 
62
62
  def add_reviewer(response, room: get_room(response))
63
63
  reviewer = response.matches.flatten.first
64
- ns_redis(room).lpush(REDIS_LIST, reviewer)
64
+ ns_redis(room.id).lpush(REDIS_LIST, reviewer)
65
65
  response.reply("added #{reviewer} to reviews")
66
66
  end
67
67
 
68
68
  def remove_reviewer(response, room: get_room(response))
69
69
  reviewer = response.matches.flatten.first
70
- ns_redis(room).lrem(REDIS_LIST, 0, reviewer)
70
+ ns_redis(room.id).lrem(REDIS_LIST, 0, reviewer)
71
71
  response.reply("removed #{reviewer} from reviews")
72
72
  end
73
73
 
74
74
  def display_reviewers(response, room: get_room(response))
75
- reviewers = ns_redis(room).lrange(REDIS_LIST, 0, -1)
76
- response.reply_privately(reviewers.join(', '))
75
+ reviewers = ns_redis(room.id).lrange(REDIS_LIST, 0, -1)
76
+ response.reply("Responding via private message...")
77
+ response.reply_privately("#{room.name}: #{reviewers.join(', ')}")
77
78
  end
78
79
 
79
80
  def generate_assignment(response, room: get_room(response))
@@ -105,7 +106,7 @@ module Lita
105
106
  private
106
107
 
107
108
  def next_reviewer(room)
108
- ns_redis(room).rpoplpush(REDIS_LIST, REDIS_LIST)
109
+ ns_redis(room.id).rpoplpush(REDIS_LIST, REDIS_LIST)
109
110
  end
110
111
 
111
112
  def github_comment(reviewer)
@@ -125,7 +126,8 @@ module Lita
125
126
  end
126
127
 
127
128
  def get_room(response)
128
- response.message.source.room
129
+ room_id = response.message.source.room
130
+ Lita::Room.find_by_id(room_id) || Lita::Room.new(room_id)
129
131
  end
130
132
 
131
133
  def ns_redis(namespace)
@@ -1,6 +1,6 @@
1
1
  Gem::Specification.new do |spec|
2
2
  spec.name = "lita-reviewme"
3
- spec.version = "0.1.0"
3
+ spec.version = "0.1.1"
4
4
  spec.authors = ["Jay Hayes"]
5
5
  spec.email = ["ur@iamvery.com"]
6
6
  spec.description = %q{A lita handler that helps with code review}
@@ -84,7 +84,7 @@ describe Lita::Handlers::Reviewme, lita_handler: true do
84
84
  send_command("add zacstewart to reviews")
85
85
  send_command("reviewers")
86
86
 
87
- expect(reply).to eq("zacstewart, iamvery")
87
+ expect(reply).to include("zacstewart, iamvery")
88
88
  end
89
89
  end
90
90
 
metadata CHANGED
@@ -1,14 +1,14 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: lita-reviewme
3
3
  version: !ruby/object:Gem::Version
4
- version: 0.1.0
4
+ version: 0.1.1
5
5
  platform: ruby
6
6
  authors:
7
7
  - Jay Hayes
8
8
  autorequire:
9
9
  bindir: bin
10
10
  cert_chain: []
11
- date: 2016-01-12 00:00:00.000000000 Z
11
+ date: 2016-01-15 00:00:00.000000000 Z
12
12
  dependencies:
13
13
  - !ruby/object:Gem::Dependency
14
14
  name: lita