lita-reviewme 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9135c04a3978fc523361417f8b9ffc389640298a
-  data.tar.gz: 858c2098a3521a22f18183fea353d24ff9575484
+  metadata.gz: fa2d1d7d4d1f1202e1f69d3337d0c2ad5db03847
+  data.tar.gz: a97b026f8c99771b4c1bf2c8a935c5a75372e8c3
 SHA512:
-  metadata.gz: 6a625cda726942a7ab04b066fe97b5eec82897e51d22aa1a972ff25290b0983dea517fa219e39692221ca2a10143b9b883bbeb68424666e9d1c87adcdc61a472
-  data.tar.gz: 091843b352d1568399e7a6c1a3566d7b3e96b7ce8ca4fcf3e5d78451b0ec704190720c0f43bac36e3d8062aec1c45a899f1346f9c342b23ad86bc2913ae78570
+  metadata.gz: 11d1a2e9924542f61b590f48f172fc42196aa5f54f65208cc9f4e0db3f12988883db8fdf92d306960ae8bf7c433534618d72c2777c1d017488fdaa20684478c4
+  data.tar.gz: ec9ae4f1e848b4c6611be04b5a2ed1785f42001d1cc734c11dd372baeaf18aa3ba96527ec2d62798cbade5cf751315d22adae6bc0d58d45dbb5e2940ba796bc9

data/CHANGELOG.md

@@ -4,6 +4,10 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 
 ## [Unreleased]
 
+### Changed
+- Respond publicly w.r.t. private reply to `reviewers`.
+- Include room name in private reply to `reviewers`.
+
 ## [0.1.0] - 2016-01-12
 
 ### Added

data/README.md

@@ -29,7 +29,9 @@ ENV["GITHUB_WOLFBRAIN_ACCESS_TOKEN"]
 
 > **Jay H.** Nerdbot: reviewers
 >
-> **Nerdbot** iamvery, zacstewart, ...
+> **Nerdbot** Responding via private message...
+>
+> **Nerdbot (privately)** channel-name: iamvery, zacstewart, ...
 
 ### Add a name to the review rotation
 

data/lib/lita/handlers/reviewme.rb

@@ -61,19 +61,20 @@ module Lita
 
       def add_reviewer(response, room: get_room(response))
         reviewer = response.matches.flatten.first
-        ns_redis(room).lpush(REDIS_LIST, reviewer)
+        ns_redis(room.id).lpush(REDIS_LIST, reviewer)
         response.reply("added #{reviewer} to reviews")
       end
 
       def remove_reviewer(response, room: get_room(response))
         reviewer = response.matches.flatten.first
-        ns_redis(room).lrem(REDIS_LIST, 0, reviewer)
+        ns_redis(room.id).lrem(REDIS_LIST, 0, reviewer)
         response.reply("removed #{reviewer} from reviews")
       end
 
       def display_reviewers(response, room: get_room(response))
-        reviewers = ns_redis(room).lrange(REDIS_LIST, 0, -1)
-        response.reply_privately(reviewers.join(', '))
+        reviewers = ns_redis(room.id).lrange(REDIS_LIST, 0, -1)
+        response.reply("Responding via private message...")
+        response.reply_privately("#{room.name}: #{reviewers.join(', ')}")
       end
 
       def generate_assignment(response, room: get_room(response))
@@ -105,7 +106,7 @@ module Lita
       private
 
       def next_reviewer(room)
-        ns_redis(room).rpoplpush(REDIS_LIST, REDIS_LIST)
+        ns_redis(room.id).rpoplpush(REDIS_LIST, REDIS_LIST)
       end
 
       def github_comment(reviewer)
@@ -125,7 +126,8 @@ module Lita
       end
 
       def get_room(response)
-        response.message.source.room
+        room_id = response.message.source.room
+        Lita::Room.find_by_id(room_id) || Lita::Room.new(room_id)
       end
 
       def ns_redis(namespace)

data/lita-reviewme.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = "lita-reviewme"
-  spec.version       = "0.1.0"
+  spec.version       = "0.1.1"
   spec.authors       = ["Jay Hayes"]
   spec.email         = ["ur@iamvery.com"]
   spec.description   = %q{A lita handler that helps with code review}

data/spec/lita/handlers/reviewme_spec.rb

@@ -84,7 +84,7 @@ describe Lita::Handlers::Reviewme, lita_handler: true do
       send_command("add zacstewart to reviews")
       send_command("reviewers")
 
-      expect(reply).to eq("zacstewart, iamvery")
+      expect(reply).to include("zacstewart, iamvery")
     end
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lita-reviewme
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Jay Hayes
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-01-12 00:00:00.000000000 Z
+date: 2016-01-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lita