lita-retro 0.0.1 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5d0cc52a998a8a5c2e66c4ae2438803d5eeadc2b
-  data.tar.gz: 6d3431bf84f8edbefd250f93b2b703fe02bf57c9
+  metadata.gz: 3a1756b9cb9ba8418c3cf29042da3e3799fcdc25
+  data.tar.gz: d4da548e18094a314cd3fd3f1be1a6b5cdab0f31
 SHA512:
-  metadata.gz: 868dbd9d744be861ace2710a963c5041db5736a16f000bf111590a81e8cdcbd50cfbded5ed58da669aac062306a62e2c3e940b961e28ef7dc4689a8c439cd92a
-  data.tar.gz: 921ad61f7f7efdaefb06af4aedaea49dcd033c083c9ff2e3332afd7bcb9b9a47a6a36ec5396b65201fd30652efd8c1d9025dfc523903513c68265256d0cd04e8
+  metadata.gz: efb01dcce5e2d220cd3414a34cce09d900c34b65254ddfbdd1375e8ffb4d4b8499c69696a89c14d1bf9e9080bd5f1266126a3b20190c93ff55aa511120da927c
+  data.tar.gz: 5e902765d396f5962ce262bccec0df45ed12180ffa4b534975ed6101a4a555e92f6922ba197d20391db202b579930d0ee2c1cd9ca0b7dbce8090329625ee61e7

data/README.md

@@ -27,6 +27,8 @@ Sophie: Lita retro :| What are we supposed to do during downtime?
 Lita: Neutral topic added!
 ```
 
+Alternatively you could use `+`, `-`, and `=` instead of smiles.
+
 When it's time for the retro, ask Lita to list all the topics for you.
 
 ```

data/lib/lita/handlers/retro.rb

@@ -1,15 +1,15 @@
 module Lita
   module Handlers
     class Retro < Handler
-      route /retro\s+:\)\s+(.+)/i, :add_good, command: true, help: {
+      route /retro\s+(?::\)|\+)\s+(.+)/i, :add_good, command: true, help: {
         t("help.add_good_key") => t("help.add_good_value")
       }
 
-      route /retro\s+:\(\s+(.+)/i, :add_bad, command: true, help: {
+      route /retro\s+(?::\(|\-)\s+(.+)/i, :add_bad, command: true, help: {
         t("help.add_bad_key") => t("help.add_bad_value")
       }
 
-      route /retro\s+:\|\s+(.+)/i, :add_neutral, command: true, help: {
+      route /retro\s+(?::\||\=)\s+(.+)/i, :add_neutral, command: true, help: {
         t("help.add_neutral_key") => t("help.add_neutral_value")
       }
 

data/lita-retro.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = "lita-retro"
-  spec.version       = "0.0.1"
+  spec.version       = "1.0.0"
   spec.authors       = ["Jimmy Cuadra"]
   spec.email         = ["jimmy@jimmycuadra.com"]
   spec.description   = %q{A Lita handler to help manage topics for regular team retrospective meetings.}
@@ -14,7 +14,7 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_runtime_dependency "lita", ">= 3.0"
+  spec.add_runtime_dependency "lita", ">= 4.0"
 
   spec.add_development_dependency "bundler", "~> 1.3"
   spec.add_development_dependency "rake"

data/locales/en.yml

@@ -3,11 +3,11 @@ en:
     handlers:
       retro:
         help:
-          add_good_key: "retro :) TOPIC"
+          add_good_key: "retro :) TOPIC or retro + TOPIC"
           add_good_value: Add a positive topic for the next retrospective.
-          add_bad_key: "retro :( TOPIC"
+          add_bad_key: "retro :( TOPIC or retro - TOPIC"
           add_bad_value: Add a negative topic for the next retrospective.
-          add_neutral_key: "retro :| TOPIC"
+          add_neutral_key: "retro :| TOPIC or retro = TOPIC"
           add_neutral_value: Add a neutral topic for the next retrospective.
           list_value: List all topics for the next retrospective.
           clear_value: Clear the retrospective topics.

data/spec/lita/handlers/retro_spec.rb

@@ -3,12 +3,17 @@ require "spec_helper"
 describe Lita::Handlers::Retro, lita_handler: true do
   let(:bad_user) { Lita::User.create(2, name: "Bad User") }
   let(:neutral_user) { Lita::User.create(3, name: "Neutral User") }
+  let(:retro_admin) do
+    user = Lita::User.create(3, name: "Retro Admin")
+    Lita::Authorization.new(registry.config).add_user_to_group!(user, :retro_admins)
+    user
+  end
 
-  it { routes_command("retro :) topic").to(:add_good) }
-  it { routes_command("retro :( topic").to(:add_bad) }
-  it { routes_command("retro :| topic").to(:add_neutral) }
-  it { routes_command("retro list").to(:list) }
-  it { routes_command("retro clear").to(:clear) }
+  it { is_expected.to route_command("retro :) topic").to(:add_good) }
+  it { is_expected.to route_command("retro :( topic").to(:add_bad) }
+  it { is_expected.to route_command("retro :| topic").to(:add_neutral) }
+  it { is_expected.to route_command("retro list").to(:list) }
+  it { is_expected.to route_command("retro clear").with_authorization_for(:retro_admins).to(:clear) }
 
   it "adds good topics" do
     send_command("retro :) foo bar")
@@ -39,14 +44,21 @@ describe Lita::Handlers::Retro, lita_handler: true do
   end
 
   it "clears all topics" do
-    allow(Lita::Authorization).to receive(:user_in_group?).with(user, :retro_admins).and_return(
-      true
-    )
     send_command("retro :) something good!")
     send_command("retro :( something bad!", as: bad_user)
     send_command("retro :| something neutral!", as: neutral_user)
-    send_command("retro clear")
+    send_command("retro clear", as: retro_admin)
     send_command("retro list")
     expect(replies.last).to eq("There are no retrospective topics yet.")
   end
+
+  it "supports +/-/= syntax" do
+    send_command("retro + something good!")
+    send_command("retro - something bad!", as: bad_user)
+    send_command("retro = something neutral!", as: neutral_user)
+    send_command("retro list")
+    expect(replies.last).to include("Good topic from Test User: something good!")
+    expect(replies.last).to include("Bad topic from Bad User: something bad!")
+    expect(replies.last).to include("Neutral topic from Neutral User: something neutral!")
+  end
 end

data/spec/spec_helper.rb

@@ -8,3 +8,5 @@ SimpleCov.start { add_filter "/spec/" }
 
 require "lita-retro"
 require "lita/rspec"
+
+Lita.version_3_compatibility_mode = false

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lita-retro
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 1.0.0
 platform: ruby
 authors:
 - Jimmy Cuadra
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-03-01 00:00:00.000000000 Z
+date: 2014-12-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lita
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '4.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '4.0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -141,3 +141,4 @@ summary: A Lita handler to help manage topics for regular team retrospective mee
 test_files:
 - spec/lita/handlers/retro_spec.rb
 - spec/spec_helper.rb
+has_rdoc: