lita-puppet 1.0.0 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b26dfb5958492199cb906c0d0ebf51fffd4a8452
-  data.tar.gz: e2525831750cb309506e4779c642b442d998eda9
+  metadata.gz: 21c2bf71dcadd164239ace4a8810aa2a7ef3ac78
+  data.tar.gz: 769464679133edea58a9d1e7791af3b5a39efea9
 SHA512:
-  metadata.gz: eacfa48fc760752e931beac72b437994c43d68cdcb15343a60e351308e192ab9e0c79ea3372a5da931dd700baefbda4d7f5ddb9730260382bdd8130b69f06158
-  data.tar.gz: 85c717691d9f470d5488acb64acf3a3b5f6abaa826531fa0a9fa8548812063480511cdfbd8f4707d4f6b80c3d274a0e85ea30604df2df8be73fc9498e1b45356
+  metadata.gz: 5b5d3cc7423f4b833e0658cb23a3aa3c473def0f9576ff1f7c803d3b486af75bf4be55a8211eb2dc64fbaeb92e5a5a9120cf2bba5dd024bc7b573c23c3561fc6
+  data.tar.gz: fd0bbf3801dc0e55b8b6ea8ab93cf5fd19795b6303f75e3f99db94413f55d10009656864f560039950fcf9f5d0c8b9dbac3b17bd5d38cb7e04658de2b9157998

data/.rubocop.yml

@@ -17,3 +17,11 @@ Metrics/MethodLength:
 
 Metrics/ClassLength:
   Max: 150
+
+Metrics/BlockLength:
+  Max: 30
+  Exclude:
+    - '*.gemspec'
+    - Rakefile
+    - 'spec/**/*_spec.rb'
+    - 'spec/spec_helper.rb'

data/README.md

@@ -2,7 +2,7 @@
 
 [![Build Status](https://img.shields.io/travis/knuedge/lita-puppet/master.svg)](https://travis-ci.org/knuedge/lita-puppet)
 [![MIT License](https://img.shields.io/badge/license-MIT-brightgreen.svg)](https://tldrlegal.com/license/mit-license)
-[![RubyGems :: RMuh Gem Version](http://img.shields.io/gem/v/lita-puppet.svg)](https://rubygems.org/gems/lita-puppet)
+[![Gem Version](https://badge.fury.io/rb/lita-puppet.svg)](https://badge.fury.io/rb/lita-puppet)
 [![Code Climate](https://img.shields.io/codeclimate/github/knuedge/lita-puppet.svg)](https://codeclimate.com/github/knuedge/lita-puppet)
 
 A [Lita](https://www.lita.io/) handler plugin for some basic [Puppet](https://puppet.com/) operations.
@@ -19,6 +19,7 @@ gem "lita-puppet"
 
 * Some of the commands require a [PuppetDB](https://docs.puppet.com/puppetdb/) server, and it must be specified in the configuration.
 * Other commands require that Lita has SSH access to machines using an SSH key, and that Lita has Passwordless `sudo` capabilities. This sounds scary, but it can be done in a very restrictive way (and if you're using puppet, you can automate it).
+* Lita authorization groups are used to restrict certain commands
 
 ## Configuration
 
@@ -37,6 +38,7 @@ If you are using this with version 4 of the PuppetDB api you append `/pdq/query`
 
 #### Deploying an environment via r10k
     puppet r10k [environment [module]]
+This requires the user is a member of the `puppet_admins` authorization group.
 
 This is also available as:
 
@@ -44,8 +46,10 @@ This is also available as:
     pp deploy [environment [module]]
     pp r10k [environment [module]]
 
+
 #### Trigger a manual run of the Puppet agent on a host
     puppet agent run on <host>
+This requires the user is a member of the `puppet_admins` authorization group.
 
 This is also available as:
 
@@ -59,6 +63,7 @@ Though we don't recomend that last one...
 
 #### Remove an SSL cert from the Puppet Master
     puppet cert clean <host>
+This requires the user is a member of the `puppet_admins` authorization group.
 
 This is also available as:
 

data/lib/lita/handlers/puppet.rb

@@ -14,6 +14,7 @@ module Lita
         /(puppet|pp)(\s+agent)?\s+(run)(\s+on)?\s+(\S+)/i,
         :puppet_agent_run,
         command: true,
+        restrict_to: :puppet_admins,
         help: { t('help.puppet_agent_run.syntax') => t('help.puppet_agent_run.desc') }
       )
 
@@ -21,6 +22,7 @@ module Lita
         /(puppet|pp)\s+(cert)\s+(clean)\s+(\S+)/i,
         :cert_clean,
         command: true,
+        restrict_to: :puppet_admins,
         help: { t('help.cert_clean.syntax') => t('help.cert_clean.desc') }
       )
 
@@ -42,6 +44,7 @@ module Lita
         /(puppet|pp)\s+(r10k|deploy)(\s+(\S+)(\s+(\S+))?)?/i,
         :r10k_deploy,
         command: true,
+        restrict_to: :puppet_admins,
         help: { t('help.r10k_deploy.syntax') => t('help.r10k_deploy.desc') }
       )
 

data/lita-puppet.gemspec

@@ -1,7 +1,6 @@
-# rubocop:disable Metrics/BlockLength
 Gem::Specification.new do |spec|
   spec.name          = 'lita-puppet'
-  spec.version       = '1.0.0'
+  spec.version       = '2.0.0'
   spec.authors       = ['Daniel Schaaff', 'Jonathan Gnagy'].sort
   spec.email         = ['jgnagy@knuedge.com']
   spec.description   = 'Some basic Puppet interactions for Lita'

data/spec/lita/handlers/puppet_spec.rb

@@ -40,14 +40,20 @@ describe Lita::Handlers::Puppet, lita_handler: true do
   let(:rye_output_base) { double(exit_status: 0, stdout: ['foo'], stderr: ['bar']) }
 
   it 'should have the required routes' do
-    is_expected.to route_command('puppet agent run on foo').to(:puppet_agent_run)
-    is_expected.to route_command('puppet cert clean foo').to(:cert_clean)
+    is_expected.to route_command('puppet agent run on foo')
+      .with_authorization_for(:puppet_admins).to(:puppet_agent_run)
+    is_expected.to route_command('puppet cert clean foo')
+      .with_authorization_for(:puppet_admins).to(:cert_clean)
     is_expected.to route_command('puppet profiles foo').to(:node_profiles)
     is_expected.to route_command('puppet class nodes foo').to(:nodes_with_class)
-    is_expected.to route_command('puppet r10k').to(:r10k_deploy)
+    is_expected.to route_command('puppet r10k')
+      .with_authorization_for(:puppet_admins).to(:r10k_deploy)
   end
 
   describe('#cert_clean') do
+    before do
+      robot.auth.add_user_to_group!(lita_user, :puppet_admins)
+    end
     it 'should clean a cert' do
       allow(Rye::Box).to receive(:new).and_return(rye_box)
       send_command('puppet cert clean server.name', as: lita_user)
@@ -56,6 +62,9 @@ describe Lita::Handlers::Puppet, lita_handler: true do
   end
 
   describe('#puppet_agent_run') do
+    before do
+      robot.auth.add_user_to_group!(lita_user, :puppet_admins)
+    end
     it 'should run a puppet agent' do
       allow(Rye::Box).to receive(:new).and_return(rye_box)
       send_command('puppet agent run on server.name', as: lita_user)
@@ -87,6 +96,9 @@ describe Lita::Handlers::Puppet, lita_handler: true do
   end
 
   describe('#r10k_deploy') do
+    before do
+      robot.auth.add_user_to_group!(lita_user, :puppet_admins)
+    end
     context 'without a module or environment' do
       it 'should trigger r10k on the puppet master' do
         allow(Rye::Box).to receive(:new).and_return(rye_box)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lita-puppet
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 2.0.0
 platform: ruby
 authors:
 - Daniel Schaaff
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-01-11 00:00:00.000000000 Z
+date: 2017-03-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lita