lita-onewheel-wolfram-alpha 0.1.6 → 0.1.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d710c2e31337fe20000c5b4217478d237a91d3a5
-  data.tar.gz: 71c621a5354931955d31469641ba194a5c80f08e
+  metadata.gz: 32d63934952e4504db6d17f6dd505b5c65a1a76c
+  data.tar.gz: 50dbb62982c46ee9fff0e6c30eef451af75f34d0
 SHA512:
-  metadata.gz: 2cf27290e2bf0626a26e2e8e5e5284d3c34cdbea56b98b7aa063137d9a20d27dd98e7126afaeb43e62a6ba19d9508752e6506bbf180e8e5e272c9c468b9c54a8
-  data.tar.gz: c5898bb0e13fa55e180dc32f4ccc15959d774ad71f9cd9ef2db0bfcb66377fe11e3b0b4351dee91b6363e6c6759d6963d7acdb3aeaf60621b65ac0080e10400a
+  metadata.gz: 0fe0c32402834e5978545d17a84af6639cc4bc56d84e29617bab46eef648bf8b340013ba35f9f9c95f6ad2403924935b519e97842fc36e5a278ca4f15ea92ae9
+  data.tar.gz: 281b516a85370dcf72156b6cf5ee32e5946ea4f162f6095f9910507787ad8ed70d9a070b5df0789e8b857d8cdee1d01c11844392a87e0c2d45067f4bdd632ee6

data/lib/lita/handlers/onewheel_wolfram_alpha.rb

@@ -24,12 +24,17 @@ module Lita
       def parse_response(noko_doc, query)
         success_node = noko_doc.xpath('queryresult').attribute('success')
         Lita.logger.debug "lita-onewheel-wolfram-alpha: Success attr: #{success_node.to_s}"
+
+        # No sense parsing if we didn't have success.
         if success_node.to_s == 'true'
+
           pods = noko_doc.xpath('//pod')
           Lita.logger.debug "lita-onewheel-wolfram-alpha: Pod title: #{pods[1].attribute('title').to_s}"
-          if pods[1].attribute('title').to_s == 'Plot'
+
+          title = pods[1].attribute('title').to_s
+          if title == 'Plot'  # Plot is a graph, grab the image.
             pods[1].xpath('//img')[1].attribute('src').to_s
-          else
+          else  # Plaintext seems to work well for, say, Definition.
             rid_thee_of_extras pods[1].xpath('//plaintext')[1].child.to_s
           end
 

data/lita-onewheel-wolfram-alpha.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = 'lita-onewheel-wolfram-alpha'
-  spec.version       = '0.1.6'
+  spec.version       = '0.1.7'
   spec.authors       = ['Andrew Kreps']
   spec.email         = ['andrew.kreps@gmail.com']
   spec.description   = %q{Lita interface to Wolfram Alpha.}
@@ -14,7 +14,7 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ['lib']
 
-  spec.add_runtime_dependency 'lita', '~> 4.7'
+  spec.add_runtime_dependency 'lita', '~> 4'
   spec.add_runtime_dependency 'rest-client', '~> 1.8'
   spec.add_runtime_dependency 'nokogiri', '~> 1.6'
 

data/spec/lita/handlers/onewheel_wolfram_alpha_spec.rb

@@ -28,7 +28,11 @@ describe Lita::Handlers::OnewheelWolframAlpha, :lita_handler => true do
   it 'will fail gracefully' do
     mock_fixture('boopadoop')
     send_command 'alpha boopadoop'
-    expect(replies.last).to include('Wolfram couldn\'t parse boopadoop.')
+    expect(replies.last).to satisfy { |v|
+      ['Nope, no boopadoop to see here.',
+       'What\'s that, now?',
+       'boopadoop?'].include? v
+    }
   end
 
   it 'will print plot for mathy things' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lita-onewheel-wolfram-alpha
 version: !ruby/object:Gem::Version
-  version: 0.1.6
+  version: 0.1.7
 platform: ruby
 authors:
 - Andrew Kreps
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-02-04 00:00:00.000000000 Z
+date: 2016-08-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lita
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.7'
+        version: '4'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.7'
+        version: '4'
 - !ruby/object:Gem::Dependency
   name: rest-client
   requirement: !ruby/object:Gem::Requirement
@@ -181,7 +181,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5.1
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Summarize THIS!