lita-onewheel-finance 0.4.0 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 316a69ee9c4dd4c0e88009906080be2d326bb4cac5723526956e29c569466607
-  data.tar.gz: e9bee0f2b4e414dcc58391707f61db410d39062ecda51ee94f185e5f613160c6
+  metadata.gz: 86924c83a1b54b7034f09552a2ff66c46723de2baa4c3b061efbdfc9bcb39d70
+  data.tar.gz: 4b2908349083d6dc6c740fd5c2ddc4b18e7cd90d6180fc672644c09be07530cc
 SHA512:
-  metadata.gz: c45a1b428948933a9680df0b80cdd1686939484e4819f0cc9a2c22046029c4a61d1337eea10586918a0721cc06d5151c6f6a3788310dfd7fe4cc33a318bbd726
-  data.tar.gz: 1051b4205d68f27c59875ef6ee986b78aecd9cbeb58acda85c8d420cc257562c8a3955f9d76671c104074b64e1766bc8751690f7e4f3e6869aa5cd9a2ef00df6
+  metadata.gz: 750a2b4e836adfaf7bea9913051037a6277c8f26787861fe14ae38389c5479c5e97e8412a9a1cd3251d4c6ad451914cf42776c400d1e97babf88adcdcdbfb4d9
+  data.tar.gz: d67f291c283fc66939cb3a3c59b2954247f7d807c4ba208c8beda96bc4ac6c5c504823dae63f31d944f1f43a6a3cbb51ba40f718a31f39eeb15bc725dd5aed6f

data/lib/lita/handlers/onewheel_finance.rb

@@ -68,7 +68,7 @@ class AlphaVantageQuote
 end
 
 class WorldTradeDataQuote
-  attr_reader :open, :high, :low, :price, :volume, :trading_day, :prev_close, :change, :change_percent, :exchange, :error, :name
+  attr_reader :open, :high, :low, :price, :volume, :trading_day, :prev_close, :change, :change_percent, :exchange, :error, :name, :message
   attr_accessor :symbol
 
   def initialize(symbol, api_key)
@@ -76,6 +76,10 @@ class WorldTradeDataQuote
     @symbol = symbol
     @api_key = api_key
 
+    if @symbol[':']
+      (@exchange, @symbol) = @symbol.split /:/
+    end
+
     self.call_api
 
     hash = JSON.parse(@response)
@@ -84,13 +88,25 @@ class WorldTradeDataQuote
     if hash['Message'].to_s.include? 'Error'
       @error = true
       self.run_search
-      self.call_api
-      hash = JSON.parse(@response)
-      @error = false
+
+      if @message
+        @error = true
+        return
+      else
+        self.call_api
+        hash = JSON.parse(@response)
+        @error = false
+      end
     else
       @error = false
     end
 
+    unless hash['data']
+      @message = "Error getting data for #{@symbol}"
+      @error = true
+      return
+    end
+
     quote = hash['data'][0]
 
     quote.keys.each do |key|
@@ -128,6 +144,10 @@ class WorldTradeDataQuote
     url = "#{@base_uri}/stock"
     params = {symbol: @symbol, api_token: @api_key}
 
+    if @exchange
+      params[:stock_exchange] = @exchange
+    end
+
     Lita.logger.debug "call_api: #{url} #{params.inspect}"
 
     @response = RestClient.get url, {params: params}
@@ -149,62 +169,15 @@ class WorldTradeDataQuote
 
     response = RestClient.get url, {params: params}
 
-    Lita.logger.debug "response: #{@response}"
+    Lita.logger.debug "response: #{response}"
     result = JSON.parse(response)
 
     if result['total_returned'] == 1
       @symbol = result['data'][0]['symbol']
-    end
-  end
-
-  def fix_number(price_str)
-    price_str.to_f.round(2)
-  end
-end
-
-class WorldTradeDataSearch
-  attr_reader :open, :high, :low, :price, :volume, :trading_day, :prev_close, :change, :change_percent, :exchange, :error, :name
-
-  def initialize(json_blob)
-    Lita.logger.debug "parsing: #{json_blob}"
-    hash = JSON.parse(json_blob)
-
-    if hash['Message'].to_s.include? 'Error'
-      @error = true
-      return
-    else
-      @error = false
-    end
-
-    quote = hash['data'][0]
-
-    quote.keys.each do |key|
-      case key
-      when "symbol"
-        @symbol = quote[key]
-      when "price_open"
-        @open = self.fix_number quote[key]
-      when "day_high"
-        @high = self.fix_number quote[key]
-      when "day_low"
-        @low = self.fix_number quote[key]
-      when "price"
-        @price = self.fix_number quote[key]
-      when "volume"
-        @volume = quote[key].to_i
-      when "last_trade_time"
-        @trading_day = quote[key]
-      when "08. previous close"
-        @prev_close = self.fix_number quote[key]
-      when "day_change"
-        @change = self.fix_number quote[key]
-      when "change_pct"
-        @change_percent = self.fix_number quote[key]
-      when 'stock_exchange_short'
-        @exchange = quote[key].sub /NYSEARCA/, 'NYSE'
-      when 'name'
-        @name = quote[key]
-      end
+    elsif result['total_returned'].to_i > 1
+      Lita.logger.debug "many search results: #{result.inspect}"
+      x = result['data'].map { |k| k.values[0] }
+      @message = "`#{symbol}` not found, did you mean one of #{x.join(', ')}?"
     end
   end
 
@@ -217,13 +190,17 @@ module Lita
   module Handlers
     class OnewheelFinance < Handler
       config :apikey, required: true
-      route /quote\s+(.+)/i, :handle_quote, command: true
+      route /qu*o*t*e*\s+(.+)/i, :handle_quote, command: true
 
       def handle_quote(response)
         stock = handle_world_trade_data response.matches[0][0]
 
         if stock.error
-          str = "`#{stock.symbol}` not found on any stock exchange."
+          if stock.message
+            str = stock.message
+          else
+            str = "`#{stock.symbol}` not found on any stock exchange."
+          end
         else
           str = "#{IrcColors::grey}#{stock.exchange} - #{IrcColors::reset}#{stock.symbol}: #{IrcColors::blue}$#{stock.price}#{IrcColors::reset} "
           if stock.change >= 0
@@ -248,13 +225,13 @@ module Lita
       end
 
       # deprecated for now
-      def handle_alphavantage
-        url = "https://www.alphavantage.co/query"
-        params = {function: 'GLOBAL_QUOTE', symbol: response.matches[0][0], apikey: config.apikey}
-        Lita.logger.debug "#{url} #{params.inspect}"
-        resp = RestClient.get url, {params: params}
-        stock = GlobalQuote.new resp
-      end
+      #def handle_alphavantage
+      #  url = "https://www.alphavantage.co/query"
+      #  params = {function: 'GLOBAL_QUOTE', symbol: response.matches[0][0], apikey: config.apikey}
+      #  Lita.logger.debug "#{url} #{params.inspect}"
+      #  resp = RestClient.get url, {params: params}
+      #  stock = GlobalQuote.new resp
+      #end
 
       Lita.register_handler(self)
     end

data/lita-onewheel-finance.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = "lita-onewheel-finance"
-  spec.version       = "0.4.0"
+  spec.version       = "0.5.0"
   spec.authors       = ["Andrew Kreps"]
   spec.email         = ["andrew.kreps@gmail.com"]
   spec.description   = "Wee li'l stock quote bot"

data/spec/lita/handlers/onewheel_finance_spec.rb

@@ -25,12 +25,24 @@ describe Lita::Handlers::OnewheelFinance, lita_handler: true do
     expect(replies.last).to include('(Consumer Staples Select Sector SPDR Fund)')
   end
 
-  it 'errors' do
-    mock_up 'worldtradedata-error'
-    send_command 'quote in'
-    expect(replies.last).to eq('`in` not found on any stock exchange.')
+  it 'nasdaq:lulu' do
+    mock_up 'worldtradedata-quote-up'
+    send_command 'q nasdaq:lulu'
+    expect(replies.last).to include("\u000314NASDAQ - \u0003LULU: \u000302$233.01\u0003")
   end
 
+  #it 'errors' do
+  #  mock_up 'worldtradedata-error'
+  #  send_command 'quote in'
+  #  expect(replies.last).to eq('`in` not found on any stock exchange.')
+  #end
+
+
+  # This doesn't exist
+  #it 'TADAWUL:2222' do
+  #  mock_up 'worldtradedata-TADAWUL-2222.json'
+  #
+  #end
   #it 'searches with 1 result' do
   #  mock_up 'worldtradedata-search-1'
   #  send_command 'quote nike'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lita-onewheel-finance
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.5.0
 platform: ruby
 authors:
 - Andrew Kreps
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-01-02 00:00:00.000000000 Z
+date: 2020-01-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lita