lita-onewheel-finance 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5edbbe2ef63969dd624af3c1657c738648ff8b5faf965379860c87e8283f95f2
-  data.tar.gz: 978e055da01a370ce7f6c835ecffedb4cf8bee00edc29cda2586d4a9cbee57db
+  metadata.gz: f3747c2d546ac8e758258319b48a71e103a903a51483a57cbaee270ba6aa0538
+  data.tar.gz: 938ffb54fe90b72caa32a50f59e28b59eed27cb8bdbbe9c07cd416d358b14a11
 SHA512:
-  metadata.gz: ddb1e70d29cccdc9862a6de746db606b3818ca6bc64d45d4b7836f103c4f53766b91f891ce029277507534be70b8942cbf6ce0e5617741c149c812196bf99e0d
-  data.tar.gz: 44b36a8c69c951f93355db2286fe0113458d6d2323fd97e486fb46166eb82e6546e497a5cd18ff7978272b427d66b7e7d63f9b890ea40f6bf81a9c6c32ffbf8e
+  metadata.gz: c4239764c78f96cefaf2d319caa1d30d55d77fc6ae100e1410c4a7fa801807bd58b51a683d1f828dfea7b473586fc88b94201d1f48e3bef447e852e4b987eaab
+  data.tar.gz: fa467590bdd56dda70008a42e4c90ac42847437e57f5a3f3a53dba78b95e9c453dbf1cf837c79ae9d2bdc55c51b12242badd3626faa6ddf1cf982aeab4667ebb

data/lib/lita/handlers/onewheel_finance.rb

@@ -68,11 +68,20 @@ class AlphaVantageQuote
 end
 
 class WorldTradeDataQuote
-  attr_reader :symbol, :open, :high, :low, :price, :volume, :trading_day, :prev_close, :change, :change_percent, :exchange
+  attr_reader :open, :high, :low, :price, :volume, :trading_day, :prev_close, :change, :change_percent, :exchange, :error
+  attr_accessor :symbol
 
   def initialize(json_blob)
     Lita.logger.debug "parsing: #{json_blob}"
     hash = JSON.parse(json_blob)
+
+    if hash['Message'].to_s.include? 'Error'
+      @error = true
+      return
+    else
+      @error = false
+    end
+
     quote = hash['data'][0]
 
     quote.keys.each do |key|
@@ -117,12 +126,16 @@ module Lita
       def handle_quote(response)
         stock = handle_world_trade_data response.matches[0][0]
 
-        str = "#{stock.exchange} - #{stock.symbol}: $#{stock.price} "
-        if stock.change >= 0
-          # if irc
-          str += "#{IrcColors::green} ⬆$#{stock.change}#{IrcColors::reset}, #{IrcColors::green}#{stock.change_percent}%#{IrcColors::reset} "
+        if stock.error
+          str = "`#{stock.symbol}` not found on any stock exchange."
         else
-          str += "#{IrcColors::red} ↯$#{stock.change}#{IrcColors::reset}, #{IrcColors::red}#{stock.change_percent}%#{IrcColors::reset} "
+          str = "#{IrcColors::grey}#{stock.exchange} - #{IrcColors::reset}#{stock.symbol}: #{IrcColors::blue}$#{stock.price}#{IrcColors::reset} "
+          if stock.change >= 0
+            # if irc
+            str += "#{IrcColors::green} ⬆$#{stock.change}#{IrcColors::reset}, #{IrcColors::green}#{stock.change_percent}%#{IrcColors::reset} "
+          else
+            str += "#{IrcColors::red} ↯$#{stock.change}#{IrcColors::reset}, #{IrcColors::red}#{stock.change_percent}%#{IrcColors::reset} "
+          end
         end
 
         response.reply str
@@ -135,7 +148,13 @@ module Lita
         Lita.logger.debug "#{url} #{params.inspect}"
 
         resp = RestClient.get url, {params: params}
+        Lita.logger.debug "response: #{resp}"
+
         stock = WorldTradeDataQuote.new resp
+        if stock.error
+          stock.symbol = symbol
+        end
+        stock
       end
 
       # deprecated for now

data/lita-onewheel-finance.gemspec

@@ -1,10 +1,10 @@
 Gem::Specification.new do |spec|
   spec.name          = "lita-onewheel-finance"
-  spec.version       = "0.1.0"
+  spec.version       = "0.2.0"
   spec.authors       = ["Andrew Kreps"]
   spec.email         = ["andrew.kreps@gmail.com"]
   spec.description   = "Wee li'l stock quote bot"
-  spec.summary       = spec.description
+  spec.summary       = "Designed to query stock indicies and return relevant data."
   spec.homepage      = "https://github.com/onewheelskyward/lita-onewheel-finance"
   spec.license       = "MIT"
   spec.metadata      = { "lita_plugin_type" => "handler" }

data/spec/fixtures/worldtradedata-error.json

@@ -0,0 +1,3 @@
+{
+  "Message": "Error! The requested stock(s) could not be found."
+}

data/spec/lita/handlers/onewheel_finance_spec.rb

@@ -13,15 +13,19 @@ describe Lita::Handlers::OnewheelFinance, lita_handler: true do
   it 'quotes up' do
     mock_up 'worldtradedata-quote-up'
     send_command 'quote lulu'
-    puts replies.last
-    expect(replies.last).to include('NASDAQ - LULU: $233.01')
+    expect(replies.last).to include("\u000314NASDAQ - \u0003LULU: \u000302$233.01\u0003")
   end
 
   it 'quotes down' do
     mock_up 'worldtradedata-quote-down'
     send_command 'quote xlp'
-    puts replies.last
-    expect(replies.last).to include('NYSE - XLP: $62.51')
+    expect(replies.last).to include("\u000314NYSE - \u0003XLP: \u000302$62.51\u0003")
     expect(replies.last).to include('↯$-0.47')
   end
+
+  it 'errors' do
+    mock_up 'worldtradedata-error'
+    send_command 'quote in'
+    expect(replies.last).to eq('`in` not found on any stock exchange.')
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lita-onewheel-finance
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Andrew Kreps
@@ -141,6 +141,7 @@ files:
 - spec/fixtures/alphavantage-global-quote.json
 - spec/fixtures/alphavantage-quote-down.json
 - spec/fixtures/effr.html
+- spec/fixtures/worldtradedata-error.json
 - spec/fixtures/worldtradedata-quote-down.json
 - spec/fixtures/worldtradedata-quote-up.json
 - spec/lita/handlers/onewheel_finance_spec.rb
@@ -168,11 +169,12 @@ requirements: []
 rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
-summary: Wee li'l stock quote bot
+summary: Designed to query stock indicies and return relevant data.
 test_files:
 - spec/fixtures/alphavantage-global-quote.json
 - spec/fixtures/alphavantage-quote-down.json
 - spec/fixtures/effr.html
+- spec/fixtures/worldtradedata-error.json
 - spec/fixtures/worldtradedata-quote-down.json
 - spec/fixtures/worldtradedata-quote-up.json
 - spec/lita/handlers/onewheel_finance_spec.rb