lita-nexus 0.1.6 → 0.1.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: dbc794f471930b728dd358f570eed7a89597af0b
-  data.tar.gz: 1e70eb6098a4976efd221b6979ba4483b55b68b9
+  metadata.gz: c4346dc2067ad2f052178e5715c9616e9ac99051
+  data.tar.gz: 38a29eaf66f5b3dbab1bf04cba7d33f8bf41a15f
 SHA512:
-  metadata.gz: e599ffc8b730fd4f609f682c72ae9282ffaf88bfb52b36ab88180c0c7d878631d9e231e149fc78058bc8da5de392ece0fca8bdc2f5140e9ac0d1679434afb5a6
-  data.tar.gz: c62d35d0703b6624fa0f0e0b08dd7c7d9906cc747ea6c51de6b3665541208b8da12793daba8526fd6defbba5e5a4b0879d868ea819ca4be636f7283e48472477
+  metadata.gz: a76441fbec949793a4dc521b7c2c9af15c79313257f6f5c3be812650a1fd53e78b31689af2d7838fb8a00e516b15d933992d2fe9aa71091cbd7e8f7b6469f7df
+  data.tar.gz: aa27d8873f8f7a4bc363e5f2e95d2022a1c0598564bd69f8350fcfdbe97531fd2423da3ae1297de33052c2b9979c49cd67e5b56f78375f93d0b37149a6a24ef5

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Change Log
 
+## 0.1.7
+* externalize messages
+* allow reuse docker container reuse during development testing, through environment variables.
+
 ## 0.1.6
 * Show artifact versions
 * Search artifact now by default only show 5 latest version, configuration limit. Show text other than xml result.

data/lib/lita/handlers/nexus.rb

@@ -163,7 +163,8 @@ module Lita
         coordinate = response.matches[0][0]
         begin
           delete_artifact(coordinate)
-          response.reply "Artifact deleted successfully."
+          #response.reply "Artifact deleted successfully."
+          response.reply t('msg.info_artifact_deleted')
         rescue Exception => e
           response.reply e.message
         end
@@ -174,13 +175,14 @@ module Lita
         if repo && repo.strip.length >0
           config.current_repository = repo
         end
-        response.reply "Success: current repository is changed to #{repo}."
+        #response.reply "Success: current repository is changed to #{repo}."
+        response.reply t('msg.info_repos_set_success', repo: repo)
       end
 
       def cmd_show_current_repository(response)
         current_repo = get_current_repo
-        response.reply "Current repository is #{current_repo}"
-
+        #response.reply "Current repository is #{current_repo}"
+        response.reply t('msg.info_current_repo_is', repo: current_repo)
       end
 
       def cmd_push_artifact(coordinate, file_path)

data/lib/nexushelper/remote.rb

@@ -33,7 +33,7 @@ module LitaNexusHelper
       begin
         info = remote.get_artifact_info(coordinate)
       rescue NexusCli::ArtifactNotFoundException => e
-        info = "Artifact not found"
+        info = t('msg.info_artifact_not_found')
       end
       #puts "info: #{info}"
       info
@@ -55,7 +55,8 @@ module LitaNexusHelper
       if remote.respond_to? 'get_license_info'
         remote.get_license_info
       else
-        'Only supported on professional version.'
+        #'Only supported on professional version.'
+        t('msg.info_only_supported_on_pro_version')
       end
     end
 
@@ -65,9 +66,8 @@ module LitaNexusHelper
       begin
         info = remote.get_repository_info(coordinate)
       rescue NexusCli::RepositoryNotFoundException => e
-        info = "Repository not found"
+        info = t('msg.info_repository_not_found')
       end
-      #puts "info: #{info}"
       info
     end
 

data/lita-nexus.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = "lita-nexus"
-  spec.version       = "0.1.6"
+  spec.version       = "0.1.7"
   spec.authors       = ["Wang, Dawei"]
   spec.email         = ["dwang@entertainment.com"]
   spec.description   = "Lita Nexus Operations"

data/locales/en.yml

@@ -19,3 +19,10 @@ en:
           cmd_set_repo_value: 'Set current repository to specified REPO'
           cmd_get_artifact_versions_key: 'nexus get artifact versions G:A'
           cmd_get_artifact_versions_value: 'Get all versions of artifact with groupId and artifacId'
+        msg:
+          info_repository_not_found: 'Specified repository not found.'
+          info_only_supported_on_pro_version: 'Feature only supported on professional version.'
+          info_artifact_deleted: 'Artifact is deleted successfully.'
+          info_current_repo_is: 'Current repository is %{repo}.'
+          info_repos_set_success: 'Success: current repository is changed to %{repo}.'
+          info_artifact_not_found: 'Artifact cannot be found.'

data/spec/lita/handlers/nexus_spec.rb

@@ -1,68 +1,78 @@
 require "spec_helper"
 require 'docker'
+require 'i18n'
 
 describe Lita::Handlers::Nexus, lita_handler: true do
   before :all do
-    @image = Docker::Image.create('fromImage' => 'sonatype/nexus:oss')
-    #
-    @container_data =  Docker::Container.create( 'Image' => 'sonatype/nexus:oss',
-      'Cmd' => "true"
-    )
-    @container_data.rename('lita_nexus_data')
-    @container_data.start
-
-    sleep 5
-
-      #check docker image documentation
-    default_settings =[
-      'MAX_HEAP=768m'
-    ]
-    @container_nexus = Docker::Container.create( 'Image' => 'sonatype/nexus:oss',
-      'Env'=> default_settings,
-      'ExposedPorts' => {
-        '8081/tcp' => {}
-      },
-      'HostConfig' => {
-        'PortBindings' => { '8081/tcp' => [{ 'HostPort' => '8081' }] }
-      },
-      'VolumesFrom' => ['lita_nexus_data']
-    )
-    @container_nexus.rename('lita_nexus')
-    @container_nexus.start
-
-    # waiting container to startup
-    wait_time = ENV['LITA_NEXUS_WAIT_TIME'] || 20
-    sleep wait_time
-
-
-
-    #now upload test artifact to server
-    test_jar = File.expand_path("../../../fixtures/file/maven-reporting-api-2.0.9.jar", __FILE__)
-    #puts robot.handlers.to_a[0].class
-    overrides = {
-      :url => 'http://localhost:8081',
-      :repository => 'releases',
-      :username => 'admin',
-      :password => 'admin123'
-    }
-    nexus_remote ||= NexusCli::RemoteFactory.create(overrides, false)
-
-    puts "Upload testing artifact: #{test_jar}"
-    success =  nexus_remote.push_artifact('org.apache.maven.reporting:maven-reporting:jar:2.0.9', test_jar)
-
-    unless success
-      raise "Failed to upload test artifact"
-    end
+    if ENV['LITA_provision'] != 'no'
+      @image = Docker::Image.create('fromImage' => 'sonatype/nexus:oss')
+      #
+      @container_data =  Docker::Container.create( 'Image' => 'sonatype/nexus:oss',
+        'Cmd' => "true"
+      )
+      @container_data.rename('lita_nexus_data')
+      @container_data.start
+
+      sleep 5
+
+        #check docker image documentation
+      default_settings =[
+        'MAX_HEAP=768m'
+      ]
+      @container_nexus = Docker::Container.create( 'Image' => 'sonatype/nexus:oss',
+        'Env'=> default_settings,
+        'ExposedPorts' => {
+          '8081/tcp' => {}
+        },
+        'HostConfig' => {
+          'PortBindings' => { '8081/tcp' => [{ 'HostPort' => '8081' }] }
+        },
+        'VolumesFrom' => ['lita_nexus_data']
+      )
+      @container_nexus.rename('lita_nexus')
+      @container_nexus.start
+
+      # waiting container to startup
+      wait_time = ENV['LITA_NEXUS_WAIT_TIME'] || 20
+      sleep wait_time
+
+
+
+      #now upload test artifact to server
+      test_jar1 = File.expand_path("../../../fixtures/file/maven-reporting-api-2.0.9.jar", __FILE__)
+      test_jar2 = File.expand_path("../../../fixtures/file/maven-reporting-api-2.0.6.jar", __FILE__)
+      #puts robot.handlers.to_a[0].class
+      overrides = {
+        :url => 'http://localhost:8081',
+        :repository => 'releases',
+        :username => 'admin',
+        :password => 'admin123'
+      }
+      nexus_remote ||= NexusCli::RemoteFactory.create(overrides, false)
+
+      puts "Upload testing artifact: #{test_jar1}"
+      success =  nexus_remote.push_artifact('org.apache.maven.reporting:maven-reporting:jar:2.0.9', test_jar1)
+      unless success
+        raise "Failed to upload test artifact"
+      end
+      puts "Upload testing artifact: #{test_jar2}"
+      success =  nexus_remote.push_artifact('org.apache.maven.reporting:maven-reporting:jar:2.0.6', test_jar2)
+      unless success
+        raise "Failed to upload test artifact"
+      end
+    end #if
 
   end
 
 
  after :all do
-   puts "Shutting down containers"
-   @container_nexus.stop
-   @container_nexus.delete(:force => true)
-   sleep 1
-   @container_data.delete(:force => true)
+   if ENV['LITA_destroy'] != 'no'
+     puts "Shutting down containers"
+     @container_nexus.stop
+     @container_nexus.delete(:force => true)
+     sleep 1
+     @container_data.delete(:force => true)
+   end
  end
 
   before do
@@ -93,67 +103,74 @@ describe Lita::Handlers::Nexus, lita_handler: true do
 
   describe '#get artifact info' do
     #let(:robot) { Lita::Robot.new(registry) }
-    it 'fecth artifact info' do
+    it 'fecth artifact info should return info' do
       send_command('nexus artifact info org.apache.maven.reporting:maven-reporting:jar:2.0.9')
       expect(replies.last).to match(/repositoryPath/)
     end
+
+    it 'return not found for non-existing' do
+      send_command('nexus artifact info webapps:maven-reporting:jar:2.0.9')
+      expect(replies.last).to eq(I18n.t('lita.handlers.nexus.msg.info_artifact_not_found'))
+    end
   end
 
   describe '#search artifact info' do
-    it 'search artifact' do
+    it 'search artifact should return artifact' do
       send_command('nexus search artifact org.apache.maven.reporting:maven-reporting limit 5')
-      expect(replies.first).to match(/Artifact found: 1/)
-      expect(replies.last).to match(/org.apache.maven.reporting:maven-reporting:2.0.9:jar/)
+      expect(replies.first).to match(/Artifact found: [0-9]+/)
+      expect(replies.last).to match(/org.apache.maven.reporting:maven-reporting/)
     end
-    it 'search artifact with default limit' do
+    it 'search artifact with default limit should return artifact' do
       send_command('nexus search artifact org.apache.maven.reporting:maven-reporting')
-      expect(replies.first).to match(/Artifact found: 1/)
-      expect(replies.last).to match(/org.apache.maven.reporting:maven-reporting:2.0.9:jar/)
+      expect(replies.first).to match(/Artifact found: [0-9]+/)
+      expect(replies.last).to match(/org.apache.maven.reporting:maven-reporting/)
     end
   end
 
   describe '#get license info' do
-    it 'fecth server license info' do
+    it 'fecth server license info should show feature only available in pro version' do
       send_command('nexus license info')
-      expect(replies.last).to match(/professional version/)
+      expect(replies.last).to eq(I18n.t('lita.handlers.nexus.msg.info_only_supported_on_pro_version'))
     end
   end
 
   describe '#get repo info' do
-    it 'fecth repository info' do
+    it 'fecth repository info should show snapshots' do
       send_command('nexus repo info snapshots')
       expect(replies.last).to match(/<id>snapshots/)
-
     end
     it 'show repository not found' do
       send_command('nexus repo info notexist')
-      expect(replies.last).to match(/not found/)
+      expect(replies.last).to eq(I18n.t('lita.handlers.nexus.msg.info_repository_not_found'))
     end
   end
 
   describe '#show and set current repo' do
-    it 'get current repo' do
+    it 'get current repo should show as releases' do
       send_command('nexus show current repo')
       #puts replies
-      expect(replies.last).to match(/releases/)
+      #expect(replies.last).to match(/releases/)
+      expect(replies.last).to eq(I18n.t('lita.handlers.nexus.msg.info_current_repo_is', repo: 'releases'))
     end
-    it 'set current repo ' do
+    it 'set current repo with success ' do
       send_command('nexus set current repo snapshots')
-      expect(replies.last).to match(/Success/)
+      #expect(replies.last).to match(/Success/)
+      expect(replies.last).to eq(I18n.t('lita.handlers.nexus.msg.info_repos_set_success', repo: 'snapshots'))
     end
-    it 'get current repo' do
+    it 'get current repo shoud show as snapshots' do
       send_command('nexus show current repo')
-      puts "Getting current repo, changed"
       #puts replies
-      expect(replies.last).to match(/snapshots/)
+      expect(replies.last).to eq(I18n.t('lita.handlers.nexus.msg.info_current_repo_is', repo: 'snapshots'))
     end
   end
 
   describe '#get artifact versions' do
-    it 'get artifact versions' do
+    it 'get artifact versions should show both versions' do
       send_command('nexus get artifact versions org.apache.maven.reporting:maven-reporting')
-      #puts replies
-      expect(replies.last).to match(/[0-9.]+/)
+      expect(replies.last).to include('2.0.6')
+      expect(replies.last).to include('2.0.9')
+
+      puts I18n.t('lita.handlers.nexus.msg.info_repository_not_found')
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lita-nexus
 version: !ruby/object:Gem::Version
-  version: 0.1.6
+  version: 0.1.7
 platform: ruby
 authors:
 - Wang, Dawei
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-07-13 00:00:00.000000000 Z
+date: 2016-07-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lita
@@ -156,6 +156,7 @@ files:
 - lib/nexushelper/remote.rb
 - lita-nexus.gemspec
 - locales/en.yml
+- spec/fixtures/file/maven-reporting-api-2.0.6.jar
 - spec/fixtures/file/maven-reporting-api-2.0.9.jar
 - spec/lita/handlers/nexus_spec.rb
 - spec/spec_helper.rb
@@ -186,6 +187,7 @@ signing_key:
 specification_version: 4
 summary: Nexus server related operations
 test_files:
+- spec/fixtures/file/maven-reporting-api-2.0.6.jar
 - spec/fixtures/file/maven-reporting-api-2.0.9.jar
 - spec/lita/handlers/nexus_spec.rb
 - spec/spec_helper.rb