lita-markov-blabber 0.2.0 → 0.3.0

data/lib/lita-markov-blabber.rb

@@ -1,12 +1,12 @@
-require "lita"
+require 'lita'
 
 Lita.load_locales Dir[File.expand_path(
-  File.join("..", "..", "locales", "*.yml"), __FILE__
+  File.join('..', '..', 'locales', '*.yml'), __FILE__
 )]
 
-require "lita/handlers/markov_blabber"
+require 'lita/handlers/markov_blabber'
 
 Lita::Handlers::MarkovBlabber.template_root File.expand_path(
-  File.join("..", "..", "templates"),
- __FILE__
+  File.join('..', '..', 'templates'),
+  __FILE__
 )

data/lib/lita/handlers/markov_blabber.rb

@@ -1,30 +1,28 @@
 require 'lita/markov_brain'
+require 'pry'
 
 module Lita
   module Handlers
     class MarkovBlabber < Handler
+      DEFAULT_INPUTS_PATH = File.join __dir__, '..', '..', '..', 'dict'
 
-      on :loaded, :on_loaded
-      on :unhandled_message, :blabber
+      config :markov_inputs_path, default: DEFAULT_INPUTS_PATH
 
-      def on_loaded(payload)
-        brain.load_dictionaries
-      end
+      on :unhandled_message, :blabber
 
-      def brain
-        self.class.brain
+      def blabber(payload)
+        payload.fetch(:message).reply gibberish
       end
 
-      def blabber(payload)
+      def gibberish
         n = rand(5..20)
         gibberish = brain.generate_n_words n
-
-        payload.fetch(:message).reply gibberish
       end
 
-      # Save a class-wide
-      def self.brain
-        @brain ||= Lita::MarkovBrain.new
+      private
+
+      def brain
+        @@brain ||= Lita::MarkovBrain.new(inputs_path: config.markov_inputs_path)
       end
 
       Lita.register_handler(self)

data/lib/lita/markov_brain.rb

@@ -1,31 +1,40 @@
 require 'marky_markov'
 
 class Lita::MarkovBrain
-  def initialize
-    @dictionary ||= ::MarkyMarkov::TemporaryDictionary.new
-  end
+  NoBrainInputsFound = Class.new(StandardError)
 
-  attr_reader :dictionary
+  def initialize(inputs_path:)
+    @inputs_path = File.absolute_path(inputs_path)
+    @dictionary = ::MarkyMarkov::TemporaryDictionary.new
+    load_brain!
+  end
 
-  def inputs_path
-    File.join __dir__, '..', '..', 'dict', '*.txt'
+  def generate_n_words(n)
+    dictionary.generate_n_words(n)
   end
 
-  def load_dictionaries
-    Dir[inputs_path].each do |file|
+  private
+
+  attr_reader :dictionary, :inputs_path
+
+  def load_brain!
+    return unless dictionary.dictionary.empty?
+    text_files_path = inputs_path + '/*.txt'
+
+    files = Dir[text_files_path]
+    raise NoBrainInputsFound, "No markov input files found at [#{text_files_path}]" if files.none?
+
+    Dir[text_files_path].each do |file|
       load_dictionary(file)
     end
   end
 
+
   def load_dictionary(path)
     logger.debug "Loading Markov input text at: [#{path}]"
     dictionary.parse_file path
   end
 
-  def generate_n_words(n)
-    dictionary.generate_n_words(n)
-  end
-
   def logger
     Lita.logger
   end

data/lita-markov-blabber.gemspec

@@ -1,25 +1,25 @@
 Gem::Specification.new do |spec|
-  spec.name          = "lita-markov-blabber"
-  spec.version       = "0.2.0"
-  spec.authors       = ["Daniel J. Pritchett"]
-  spec.email         = ["dpritchett@gmail.com"]
-  spec.description   = "Nonsensical nearly-human fallback responses for your lita bot"
-  spec.summary       = "Nonsensical nearly-human fallback responses for your lita bot"
-  spec.homepage      = "https://github.com/dpritchett/lita-markov-blabber"
-  spec.license       = "MIT"
-  spec.metadata      = { "lita_plugin_type" => "handler" }
+  spec.name          = 'lita-markov-blabber'
+  spec.version       = '0.3.0'
+  spec.authors       = ['Daniel J. Pritchett']
+  spec.email         = ['dpritchett@gmail.com']
+  spec.description   = 'Nonsensical nearly-human fallback responses for your lita bot'
+  spec.summary       = 'Nonsensical nearly-human fallback responses for your lita bot'
+  spec.homepage      = 'https://github.com/dpritchett/lita-markov-blabber'
+  spec.license       = 'MIT'
+  spec.metadata      = { 'lita_plugin_type' => 'handler' }
 
-  spec.files         = `git ls-files`.split($/)
+  spec.files         = `git ls-files`.split($INPUT_RECORD_SEPARATOR)
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
-  spec.require_paths = ["lib"]
+  spec.require_paths = ['lib']
 
-  spec.add_runtime_dependency "lita", ">= 4.7"
-  spec.add_runtime_dependency "marky_markov", "~> 0.3.5"
+  spec.add_runtime_dependency 'lita', '>= 4.7'
+  spec.add_runtime_dependency 'marky_markov', '~> 0.3.5'
 
-  spec.add_development_dependency "bundler", "~> 1.3"
-  spec.add_development_dependency "pry-byebug"
-  spec.add_development_dependency "rake"
-  spec.add_development_dependency "rack-test"
-  spec.add_development_dependency "rspec", ">= 3.0.0"
+  spec.add_development_dependency 'bundler', '~> 1.3'
+  spec.add_development_dependency 'pry-byebug'
+  spec.add_development_dependency 'rack-test'
+  spec.add_development_dependency 'rake'
+  spec.add_development_dependency 'rspec', '>= 3.0.0'
 end

data/spec/dict/moby_dick_sample.txt

@@ -0,0 +1,100 @@
+reveries—stand that man on his legs, set his feet a-going, and he will
+infallibly lead you to water, if water there be in all that region.
+Should you ever be athirst in the great American desert, try this
+experiment, if your caravan happen to be supplied with a metaphysical
+professor. Yes, as every one knows, meditation and water are wedded for
+ever.
+
+But here is an artist. He desires to paint you the dreamiest, shadiest,
+quietest, most enchanting bit of romantic landscape in all the valley
+of the Saco. What is the chief element he employs? There stand his
+trees, each with a hollow trunk, as if a hermit and a crucifix were
+within; and here sleeps his meadow, and there sleep his cattle; and up
+from yonder cottage goes a sleepy smoke. Deep into distant woodlands
+winds a mazy way, reaching to overlapping spurs of mountains bathed in
+their hill-side blue. But though the picture lies thus tranced, and
+though this pine-tree shakes down its sighs like leaves upon this
+shepherd’s head, yet all were vain, unless the shepherd’s eye were
+fixed upon the magic stream before him. Go visit the Prairies in June,
+when for scores on scores of miles you wade knee-deep among
+Tiger-lilies—what is the one charm wanting?—Water—there is not a drop
+of water there! Were Niagara but a cataract of sand, would you travel
+your thousand miles to see it? Why did the poor poet of Tennessee, upon
+suddenly receiving two handfuls of silver, deliberate whether to buy
+him a coat, which he sadly needed, or invest his money in a pedestrian
+trip to Rockaway Beach? Why is almost every robust healthy boy with a
+robust healthy soul in him, at some time or other crazy to go to sea?
+Why upon your first voyage as a passenger, did you yourself feel such a
+mystical vibration, when first told that you and your ship were now out
+of sight of land? Why did the old Persians hold the sea holy? Why did
+the Greeks give it a separate deity, and own brother of Jove? Surely
+all this is not without meaning. And still deeper the meaning of that
+story of Narcissus, who because he could not grasp the tormenting, mild
+image he saw in the fountain, plunged into it and was drowned. But that
+same image, we ourselves see in all rivers and oceans. It is the image
+of the ungraspable phantom of life; and this is the key to it all.
+
+Now, when I say that I am in the habit of going to sea whenever I begin
+to grow hazy about the eyes, and begin to be over conscious of my
+lungs, I do not mean to have it inferred that I ever go to sea as a
+passenger. For to go as a passenger you must needs have a purse, and a
+purse is but a rag unless you have something in it. Besides, passengers
+get sea-sick—grow quarrelsome—don’t sleep of nights—do not enjoy
+themselves much, as a general thing;—no, I never go as a passenger;
+nor, though I am something of a salt, do I ever go to sea as a
+Commodore, or a Captain, or a Cook. I abandon the glory and distinction
+of such offices to those who like them. For my part, I abominate all
+honorable respectable toils, trials, and tribulations of every kind
+whatsoever. It is quite as much as I can do to take care of myself,
+without taking care of ships, barques, brigs, schooners, and what not.
+And as for going as cook,—though I confess there is considerable glory
+in that, a cook being a sort of officer on ship-board—yet, somehow, I
+never fancied broiling fowls;—though once broiled, judiciously
+buttered, and judgmatically salted and peppered, there is no one who
+will speak more respectfully, not to say reverentially, of a broiled
+fowl than I will. It is out of the idolatrous dotings of the old
+Egyptians upon broiled ibis and roasted river horse, that you see the
+mummies of those creatures in their huge bake-houses the pyramids.
+
+No, when I go to sea, I go as a simple sailor, right before the mast,
+plumb down into the forecastle, aloft there to the royal mast-head.
+True, they rather order me about some, and make me jump from spar to
+spar, like a grasshopper in a May meadow. And at first, this sort of
+thing is unpleasant enough. It touches one’s sense of honor,
+particularly if you come of an old established family in the land, the
+Van Rensselaers, or Randolphs, or Hardicanutes. And more than all, if
+just previous to putting your hand into the tar-pot, you have been
+lording it as a country schoolmaster, making the tallest boys stand in
+awe of you. The transition is a keen one, I assure you, from a
+schoolmaster to a sailor, and requires a strong decoction of Seneca and
+the Stoics to enable you to grin and bear it. But even this wears off
+in time.
+
+What of it, if some old hunks of a sea-captain orders me to get a broom
+and sweep down the decks? What does that indignity amount to, weighed,
+I mean, in the scales of the New Testament? Do you think the archangel
+Gabriel thinks anything the less of me, because I promptly and
+respectfully obey that old hunks in that particular instance? Who ain’t
+a slave? Tell me that. Well, then, however the old sea-captains may
+order me about—however they may thump and punch me about, I have the
+satisfaction of knowing that it is all right; that everybody else is
+one way or other served in much the same way—either in a physical or
+metaphysical point of view, that is; and so the universal thump is
+passed round, and all hands should rub each other’s shoulder-blades,
+and be content.
+
+Again, I always go to sea as a sailor, because they make a point of
+paying me for my trouble, whereas they never pay passengers a single
+penny that I ever heard of. On the contrary, passengers themselves must
+pay. And there is all the difference in the world between paying and
+being paid. The act of paying is perhaps the most uncomfortable
+infliction that the two orchard thieves entailed upon us. But _being
+paid_,—what will compare with it? The urbane activity with which a man
+receives money is really marvellous, considering that we so earnestly
+believe money to be the root of all earthly ills, and that on no
+account can a monied man enter heaven. Ah! how cheerfully we consign
+ourselves to perdition!
+
+Finally, I always go to sea as a sailor, because of the wholesome
+exercise and pure air of the fore-castle deck. For as in this world,
+head winds are far more prevalent than winds from astern (that is, if

data/spec/lita/handlers/markov_blabber_spec.rb

@@ -1,19 +1,31 @@
-require "spec_helper"
+require 'spec_helper'
 
 describe Lita::Handlers::MarkovBlabber, lita_handler: true do
+  let(:test_inputs_path) { File.join(__dir__, '..', '..', 'dict') }
+
   let(:robot) { Lita::Robot.new(registry) }
 
+  before do
+    robot.config.handlers.markov_blabber.markov_inputs_path = test_inputs_path
+  end
+
   subject { described_class.new(robot) }
 
-  describe ':blabber' do
-    it 'responds with a caption and an image URL' do
-      send_message "this isn't matched"
-      response = replies.last
-      word_count = response.split.count
+  describe ':gibberish' do
+    it 'generates lots of words' do
+      result = subject.gibberish
+      word_count = result.split.count
       expect(word_count > 4).to be_truthy
       expect(word_count < 30).to be_truthy
     end
+  end
+
+  describe 'preload_brain' do
+    it "fills the brain's dictionary with words" do
+    end
+  end
 
+  describe 'blabber' do
     it 'answers arbitrary inputs' do
       lyrics = ['welcome to the jungle',
                 'take me down to the paradise city',

data/spec/lita/markov_brain_spec.rb

@@ -0,0 +1,18 @@
+require 'spec_helper'
+
+describe Lita::MarkovBrain do
+  let(:test_inputs_path) { File.join(__dir__, '..', '..', 'dict') }
+
+  describe 'given a short file full of words' do
+    subject { Lita::MarkovBrain.new(inputs_path: test_inputs_path) } 
+
+    it "can generate n words on demand" do
+      n = rand(1..100)
+      result = subject.generate_n_words(n)
+
+      expect(result.split.count).to eq(n)
+    end
+
+  end
+
+end

data/spec/spec_helper.rb

@@ -1,5 +1,5 @@
-require "lita-markov-blabber"
-require "lita/rspec"
+require 'lita-markov-blabber'
+require 'lita/rspec'
 
 # A compatibility mode is provided for older plugins upgrading from Lita 3. Since this plugin
 # was generated with Lita 4, the compatibility mode should be left disabled.

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lita-markov-blabber
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Daniel J. Pritchett
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-02-20 00:00:00.000000000 Z
+date: 2018-02-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lita
@@ -67,7 +67,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: rack-test
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -81,7 +81,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rack-test
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -120,12 +120,15 @@ files:
 - README.md
 - Rakefile
 - dict/2701-0.txt
+- dict/gutenberg-moby-dick.txt
 - lib/lita-markov-blabber.rb
 - lib/lita/handlers/markov_blabber.rb
 - lib/lita/markov_brain.rb
 - lita-markov-blabber.gemspec
 - locales/en.yml
+- spec/dict/moby_dick_sample.txt
 - spec/lita/handlers/markov_blabber_spec.rb
+- spec/lita/markov_brain_spec.rb
 - spec/spec_helper.rb
 - templates/.gitkeep
 homepage: https://github.com/dpritchett/lita-markov-blabber
@@ -154,5 +157,7 @@ signing_key:
 specification_version: 4
 summary: Nonsensical nearly-human fallback responses for your lita bot
 test_files:
+- spec/dict/moby_dick_sample.txt
 - spec/lita/handlers/markov_blabber_spec.rb
+- spec/lita/markov_brain_spec.rb
 - spec/spec_helper.rb