lita-line 0.6.1 → 1.0.0.nightly.40

data/.travis.yml

@@ -1,9 +1,20 @@
 language: ruby
 cache: bundler
 rvm:
-  - 2.3.1
+- 2.3.1
 script: bundle exec rake
 before_install:
-  - gem update --system
+- gem update --system
 services:
-  - redis-server
+- redis-server
+deploy:
+  provider: rubygems
+  api_key:
+    secure: b3WMkStlgn09VthZit4RpetLVW/mIRL+mC+zVE37kf3jcvSmfRn0wbmdyZ1+71OB0nsYTwKUe4vZOScRfeu1/ME3QeFNLsjfY3JbwpBhihLSSTBmEfcwob4D/qS18GGcUqbjxHcxYydCA3yDxie6pTDsxwhxMzxrFUecyxCYxs94eiyytssm+TlAy/gsN55zudzU44HMpOOxiEuZUFDj1irkGli16/bJCNXMFvOD6R099FYKJ63rZJ2+H0b0YTHvr7p72wwktge5z51lgLNlFcWDjYuUfCRogO8LkmRd3kGyFrj+7RkHU3OWvqg/bESgDqzOsnH0baUQZrdsh9IxlaPdbhvdC9mB79V78E15NhLJ4aAYCiaZpJSOFQCN0pgEmX97YZ0zJVDnOarh1h1HiJM5Cs2vJ2QOD4qf1DlEIRlyxJyOUstZdQv+j7tYpkZOBlHbosbZ+7zTRBiIeCGqeAKTBrKwgJ2qCCwARe6G4WkvRNJSVZ83uvHQ25XJnQlO3io8PZhQhODtOnz0WfHtjY95eL66IYywnWxoUED5tjJlYuEmvRvw2ZeNcUnajaVL1dVVTdd/+nOy7JV4k7kdRRDvI+h0KapjA980BTByueUKV93yHN7c4q7u+ah67CaCGLSwSRU9BE9gdWstgdj97loiEvAJT7clsfijNVqOEYY=
+  gem: lita-line
+  on:
+    repo: aar0nTw/lita-line
+addons:
+  code_climate:
+    repo_token:
+      secure: xsmLBjL5tg2SkdbBAEmQ01zd3sASOAOHoiGBdBYYRZF4NNaMrVDNz1Tvi+4Pv0KpCCbg5TALh1ougaZrlg33fEw8DYbQoVLTmzTbZTErXxb5k6kvB/Wjs2rDJ8zWz0CAT3w64xyLm/XmledB7oZa+dzZznW8P6H83Ibw8Qa+nlyPePyB/UoDv6oAKO4b76WjeNz8wSVGawqf0yQas+BbD966B7NnNtogV3AhHiGec/X9HDqJuV2Z6bBCRX/1Hs/YDOaieyoOIn6XU7nLghymTezNEPyk6DttZpRpdBR0n6KgLuhPfcTd6TtyGDnPhnlk/rLg3/tRjKGwHj3PNjJ0ser4VFO0dpmumt60htMAKUQC3tInmuGlI4Uumpo8Ra4IsaU20/jtJKdI75PYRolqyETnR5c+Z++tZOw/l7VskLBdVKow+9ZGrePGFuumEdXG/JsFbVAilgYUubU3opCXvQ20QtlE7iSL/rwZEZEDrx/8yvjmSsqnGF5PdBrrNs4ZUxEizp5KqzyAnLLXQVEI+IDDH3uLKdSrKfiUbK2SNkULJq+eUivwgpnmDybhmjGgTsnZzWwB1NROB0JQgH5Yd+Wb9pIkmmrSu+BTNjQ+Ywo4SQkA+XYS2aP1HrZJGHMqROsZXY3EybqlTFTZ1K0apj/b4Bw7CaNH9FdKhFQBv0w=

data/README.md

@@ -1,10 +1,12 @@
 # lita-line
 [![Gem](https://img.shields.io/gem/v/lita-line.svg)](https://rubygems.org/gems/lita-line)
 [![Gem](https://img.shields.io/gem/dt/lita-line.svg)](https://rubygems.org/gems/lita-line)
+[![Gemnasium](https://img.shields.io/gemnasium/aar0nTw/lita-line.svg)](https://gemnasium.com/github.com/aar0nTw/lita-line)
 [![Build Status](https://img.shields.io/travis/aar0nTw/lita-line.svg)](https://travis-ci.org/aar0nTw/lita-line)
+[![Code Climate](https://codeclimate.com/github/aar0nTw/lita-line/badges/gpa.svg)](https://codeclimate.com/github/aar0nTw/lita-line)
 [![Coverage Status](https://img.shields.io/coveralls/aar0nTw/lita-line.svg)](https://coveralls.io/github/aar0nTw/lita-line?branch=master)
 
-Line Messanging webhook adapter for [Lita](https://github.com/litaio/lita)
+LINE messaging webhook adapter for [Lita](https://github.com/litaio/lita)
 
 ## Installation
 
@@ -40,6 +42,10 @@ Create a line bot at https://business.line.me/ and get it's secret and token in
 
 The API documentation, useful for plugin authors, can be found for the latest gem release on [RubyDoc.info](http://www.rubydoc.info/gems/lita-line)
 
+## Example
+
+- [Lita-line-bot](https://github.com/aar0nTw/lita-line-bot) | A simple LINE messaging bot use Lita
+
 ## License
 
 [MIT](http://opensource.org/licenses/MIT)

data/lib/lita/adapters/line.rb

@@ -11,7 +11,7 @@ module Lita
 
       def run
         return if client
-        @client = Client.new(robot, config)
+        @client = Client.new(config)
         client.run
       end
 

data/lib/lita/adapters/line/client.rb

@@ -6,7 +6,7 @@ module Lita
     class Line < Adapter
       class Client
         attr_reader :client
-        def initialize(robot, config)
+        def initialize(config)
           @client = ::Line::Bot::Client.new { |c|
             c.channel_secret = config.channel_secret
             c.channel_token = config.channel_token

data/lib/lita/handlers/webhook.rb

@@ -27,11 +27,8 @@ module Lita
             when ::Line::Bot::Event::Message
               case event.type
               when ::Line::Bot::Event::MessageType::Text
-                log.info "Webhook: #{DateTime.strptime(event['timestamp'].to_s, '%Q').to_s}[#{event.message['id']}##{event.message['type']}]: #{event.message['text']} "
-                # TODO Parse user from event
-                user = Lita::User.create('guest', {
-                  name: 'Guest'
-                })
+                log.info "Webhook: #{DateTime.strptime(event['timestamp'].to_s, '%Q')}[#{event.message['id']}##{event.message['type']}]: #{event.message['text']} "
+                user = create_user event['source']
                 source = Lita::Source.new(user: user, room: event['replyToken'])
                 message = Lita::Message.new(robot, event.message['text'], source)
                 robot.receive(message)
@@ -42,6 +39,13 @@ module Lita
         response.finish
       end
 
+      def create_user(event_source)
+        source_type = event_source['type']
+        user = Lita::User.create(event_source["#{source_type}Id"], { type: source_type })
+        log.info "Create User: #{user.id} - #{user.metadata}"
+        user
+      end
+
       http.post "/callback", :callback
 
       Lita.register_handler(self)

data/lita-line.gemspec

@@ -1,6 +1,7 @@
 Gem::Specification.new do |spec|
   spec.name          = "lita-line"
-  spec.version       = "0.6.1"
+  spec.version       = "1.0.0"
+  spec.version       = "#{spec.version}.nightly.#{ENV['TRAVIS_BUILD_NUMBER']}" if ENV['TRAVIS']
   spec.authors       = ["Aaron Huang"]
   spec.email         = ["aaroms9733@gmail.com"]
   spec.description   = "A line adapter for lita bot"
@@ -24,5 +25,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rack-test"
   spec.add_development_dependency "rspec", ">= 3.0.0"
   spec.add_development_dependency "simplecov"
+  spec.add_development_dependency "codeclimate-test-reporter", "~> 1.0.0"
   spec.add_development_dependency "coveralls"
 end

data/spec/lita/adapters/line/client_spec.rb

@@ -2,7 +2,7 @@ require 'spec_helper'
 require 'line/bot'
 
 describe Lita::Adapters::Line::Client, lita: true do
-  subject { described_class.new(robot, config) }
+  subject { described_class.new(config) }
   let(:robot) { Lita::Robot.new(registry) }
   let(:line_client) {instance_double("Line::Bot::Client")}
   let(:reply_token) { "reply_token" }
@@ -22,7 +22,7 @@ describe Lita::Adapters::Line::Client, lita: true do
   it 'LineBotClien init' do
     expect(config).to receive(:channel_secret)
     expect(config).to receive(:channel_token)
-    described_class.new(nil, config)
+    described_class.new(config)
   end
 
   it 'run should use EventMachine' do

data/spec/lita/adapters/line_spec.rb

@@ -5,6 +5,7 @@ describe Lita::Adapters::Line, lita: true do
 
   let(:robot) { Lita::Robot.new(registry) }
   let(:secret) { 'channel-secret' }
+  let(:client_type) { described_class::Client }
   let(:client) { instance_double("#{described_class}::Client") }
   let(:token) { 'channel-token' }
 
@@ -14,9 +15,6 @@ describe Lita::Adapters::Line, lita: true do
     registry.config.adapters.line.channel_token = token
     robot.config.robot.adapter = :line
 
-    allow(
-      described_class::Client
-    ).to receive(:new).with(robot, subject.config).and_return(client)
     allow(client).to receive(:run)
   end
 
@@ -25,47 +23,49 @@ describe Lita::Adapters::Line, lita: true do
   end
 
   it 'running' do
+    described_class::Client.any_instance.stub(:run)
     subject.run
-    expect(subject.client).to be client
+    expect(subject.client).to be_a client_type
   end
 
-  it 'client will run when adapter run' do
-    expect(client).to receive(:run)
-    subject.run
-  end
-
-  it 'Only run once' do
-    expect(client).to receive(:run).once
-    subject.run
-    subject.run
-  end
-
-  it 'Chat service' do
-    subject.run
-    expect(subject.chat_service).to eq(client)
-  end
+  describe "Client#run" do
+    before do
+      allow(
+        described_class::Client
+      ).to receive(:new).with(subject.config).and_return(client)
+    end
+    it 'client will run when adapter run' do
+      expect(client).to receive(:run)
+      subject.run
+    end
 
-  it 'Shut down will call client.stop' do
-    expect(client).to receive(:stop)
-    subject.run
-    subject.shut_down
-  end
+    it 'Only run once' do
+      expect(client).to receive(:run).once
+      subject.run
+      subject.run
+    end
 
-  describe 'send messages' do
-    let(:room_source) {Lita::Source.new(room: "reply_token")}
-    let(:messages) {["Hello world"]}
-    let(:client) {instance_double('Lita::Adapters::Line::Client')}
-    before do
-      allow(described_class::Client).to receive(:new).with(robot, subject.config).and_return(client)
-      allow(client).to receive(:send_messages).with(room_source.room, messages)
+    it 'Chat service' do
+      subject.run
+      expect(subject.chat_service).to eq(client)
     end
 
-    it "Send messages by client" do
-      expect(client).to receive(:send_messages).with(room_source.room, messages)
+    it 'Shut down will call client.stop' do
+      expect(client).to receive(:stop)
       subject.run
-      subject.send_messages(room_source, messages)
+      subject.shut_down
     end
-  end
 
+    describe 'Client#send_messages' do
+      let(:room_source) {Lita::Source.new(room: "reply_token")}
+      let(:messages) {["Hello world"]}
+
+      it "Send messages by client" do
+        expect(client).to receive(:send_messages).with(room_source.room, messages)
+        subject.run
+        subject.send_messages(room_source, messages)
+      end
+    end
+  end
 end
 

data/spec/lita/handlers/webhook_spec.rb

@@ -1,4 +1,5 @@
 require "spec_helper"
+require "json"
 
 describe Lita::Handlers::Webhook, lita_handler: true do
 
@@ -28,24 +29,24 @@ describe Lita::Handlers::Webhook, lita_handler: true do
     let(:response) { double }
     let(:config) { double }
     let(:body) { <<EOS
-{
-  "events": [
       {
-        "replyToken": "reply_token",
-        "type": "message",
-        "timestamp": 1462629479859,
-        "source": {
-             "type": "user",
-             "userId": "U206d25c2ea6bd87c17655609a1c37cb8"
-         },
-         "message": {
-             "id": "325708",
-             "type": "text",
-             "text": "Hello, world"
+        "events": [
+          {
+            "replyToken": "reply_token",
+            "type": "message",
+            "timestamp": 1462629479859,
+            "source": {
+              "type": "user",
+              "userId": "U206d25c2ea6bd87c17655609a1c37cb8"
+            },
+            "message": {
+              "id": "325708",
+              "type": "text",
+              "text": "Hello, world"
+            }
           }
+        ]
       }
-  ]
-    }
 EOS
     }
     let(:signature) { double }
@@ -59,7 +60,7 @@ EOS
       request.stub(:env).and_return env
       config.stub(:channel_secret).and_return 'secret'
       config.stub(:channel_token).and_return 'token'
-      robot.stub_chain(:chat_service, :client).and_return(Lita::Adapters::Line::Client.new(robot, config).client)
+      robot.stub_chain(:chat_service, :client).and_return(Lita::Adapters::Line::Client.new(config).client)
     end
 
     it 'HTTP 401 when Line signature unvalidated' do
@@ -74,6 +75,41 @@ EOS
       expect(response).to receive(:status=).with(200)
       subject.callback(request, response)
     end
+
+    it "Callback Should call @create_user function" do
+      Line::Bot::Client.any_instance.stub(:validate_signature => true)
+      allow(response).to receive(:status=).with(200)
+      expect(subject).to receive :create_user
+      subject.callback(request, response)
+    end
+  end
+
+  describe 'Create User' do
+    let(:id) {'U206d25c2ea6bd87c17655609a1c37cb8'}
+    let(:event_source_json) { <<EOS
+      {
+        "type": "user",
+        "userId": "#{id}"
+      }
+EOS
+    }
+    let(:event_source) { JSON.parse event_source_json }
+
+    it 'create_user should return a source instance' do
+      expect(subject.create_user event_source).to be_a Lita::User
+    end
+
+    it 'create_user should return right metadata' do
+      event_source['type'] = 'group'
+      user = subject.create_user event_source
+      expect(user.metadata['type']).to eq 'group'
+    end
+
+    it 'user object should have correct id' do
+      user = subject.create_user event_source
+      expect(user.id).to eq id
+    end
+
   end
 end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lita-line
 version: !ruby/object:Gem::Version
-  version: 0.6.1
+  version: 1.0.0.nightly.40
 platform: ruby
 authors:
 - Aaron Huang
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-11-22 00:00:00.000000000 Z
+date: 2016-11-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: eventmachine
@@ -136,6 +136,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: codeclimate-test-reporter
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.0.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.0.0
 - !ruby/object:Gem::Dependency
   name: coveralls
   requirement: !ruby/object:Gem::Requirement
@@ -157,8 +171,10 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".codeclimate.yml"
 - ".gitignore"
 - ".rspec"
+- ".rubocop.yml"
 - ".travis.yml"
 - Gemfile
 - LICENSE
@@ -190,12 +206,12 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.8
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: ''