lita-jira 0.7.2 → 0.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 60daa5d9457d96452b4a5173475ea8d0100e3599
-  data.tar.gz: dbe9dd305a9fb2d16131f3aadbd45de6371d60cf
+  metadata.gz: 48c00700fdf50c30b6ad579589c2fd0524c40910
+  data.tar.gz: 601010e495e0f28b68a3a7f854eb0af1c51bcb63
 SHA512:
-  metadata.gz: 26a7c84e39b53e8efd70fa120b1917f6662df89162b947d2e8cb5b9c2f1048550c8e85a70deebb79d5f8583daff6d42465b6c71cf9d9a059b11afcace65f12ba
-  data.tar.gz: 75e000b407485a88e511940c8aeacae0264914196de243fc6f1ba3643756d3414e996d632a3d639500b1571c3b4f3f4d25bf28a047993aa58b98cb33ecbc0266
+  metadata.gz: 9b64f58dc863e610feb45e334859b7b21af89a0ff2dfcde1ee49b82a19702781eeb8bcddba9ea0ac7aa486deeb9a789c2260a814b96a7d1c0877b447bf4ff470
+  data.tar.gz: 873c4fb13c1f868e55f1edc193aa675178b50cd0dc93b51808ce02b5dfe484b7ad2153f6544328249eaf99dd7b2b1100f6b1b9c29b3bf0a910ae051ff5dfd424

data/README.md

@@ -33,6 +33,7 @@ config.handlers.jira.site     = 'https://your.jira.instance.example.com/'
 * `ambient` (boolean) - When set to `true`, Lita will show JIRA issue details when a JIRA issue key is mentioned in chat, outside the context of a command. Default: `false`
 * `ignore` (array) - Prevent ambient JIRA issue detection in certain users' messages. Accepts user names, mention names, and IDs. Default: `[]`
 * `rooms` (array) - Limit ambient JIRA issue detection to a certain list of rooms. If unspecified, the bot will respond to detected issues in all rooms.
+* `use_ssl` (boolean) - When set to `true`, an SSL connection will be used to JIRA. Set to `false` if you run JIRA over plain http.
 
 ``` ruby
 config.handlers.jira.context = '/myjira'
@@ -40,6 +41,7 @@ config.handlers.jira.format = 'one-line'
 config.handlers.jira.ambient = true
 config.handlers.jira.ignore = ['Jira', 'Github', 'U1234']
 config.handlers.jira.rooms = ['devtools', 'engineering']
+config.handlers.jira.use_ssl = false
 ```
 
 ## Usage

data/lib/jirahelper/issue.rb

@@ -2,15 +2,12 @@
 module JiraHelper
   # Issues
   module Issue
-    # NOTE: Prefer this syntax here as it's cleaner
-    # rubocop:disable Style/RescueEnsureAlignment
     def fetch_issue(key, expected = true)
       client.Issue.find(key)
-      rescue
-        log.error('JIRA HTTPError') if expected
-        nil
+    rescue
+      log.error('JIRA HTTPError') if expected
+      nil
     end
-    # rubocop:enable Style/RescueEnsureAlignment
 
     # Leverage the jira-ruby Issue.jql search feature
     #
@@ -20,15 +17,12 @@ module JiraHelper
       client.Issue.jql(jql)
     end
 
-    # NOTE: Prefer this syntax here as it's cleaner
-    # rubocop:disable Style/RescueEnsureAlignment
     def fetch_project(key)
       client.Project.find(key)
-      rescue
-        log.error('JIRA HTTPError')
-        nil
+    rescue
+      log.error('JIRA HTTPError')
+      nil
     end
-    # rubocop:enable Style/RescueEnsureAlignment
 
     # NOTE: Not breaking this function out just yet.
     # rubocop:disable Metrics/AbcSize

data/lib/jirahelper/misc.rb

@@ -8,7 +8,8 @@ module JiraHelper
         password: config.password,
         site: config.site,
         context_path: config.context,
-        auth_type: :basic
+        auth_type: :basic,
+        use_ssl: config.use_ssl
       )
     end
   end

data/lib/jirahelper/regex.rb

@@ -8,6 +8,6 @@ module JiraHelper
     PROJECT_PATTERN = /(?<project>[a-zA-Z0-9]{1,10})/
     ISSUE_PATTERN   = /(?<issue>#{PROJECT_PATTERN}-[0-9]{1,5}+)/
     EMAIL_PATTERN   = /(?<email>[\w+\-.]+@[a-z\d\-]+(\.[a-z]+)*\.[a-z]+)/i
-    AMBIENT_PATTERN = /\s#{ISSUE_PATTERN}/
+    AMBIENT_PATTERN = /(\s|^)#{ISSUE_PATTERN}/
   end
 end

data/lib/lita/handlers/jira.rb

@@ -15,6 +15,7 @@ module Lita
       config :ambient, required: false, types: [TrueClass, FalseClass], default: false
       config :ignore, required: false, type: Array, default: []
       config :rooms, required: false, type: Array
+      config :use_ssl, required: false, types: [TrueClass, FalseClass], default: true
 
       include ::JiraHelper::Issue
       include ::JiraHelper::Misc
@@ -109,7 +110,7 @@ module Lita
           return
         end
 
-        return response.reply(t('myissues.empty')) unless issues.size > 0
+        return response.reply(t('myissues.empty')) if issues.empty?
 
         response.reply(format_issues(issues))
       end

data/lita-jira.gemspec

@@ -1,8 +1,8 @@
 Gem::Specification.new do |spec|
   spec.name          = 'lita-jira'
-  spec.version       = '0.7.2'
-  spec.authors       = ['Eric Sigler', 'Matt Critchlow']
-  spec.email         = ['me@esigler.com', 'matt.critchlow@gmail.com']
+  spec.version       = '0.8.0'
+  spec.authors       = ['Eric Sigler', 'Matt Critchlow', 'Tristan Chong', 'Lee Briggs']
+  spec.email         = ['me@esigler.com', 'matt.critchlow@gmail.com', 'ong@tristaneuan.ch', 'lee@brig.gs']
   spec.description   = 'A JIRA plugin for Lita.'
   spec.summary       = spec.description
   spec.homepage      = 'https://github.com/esigler/lita-jira'

data/spec/lita/handlers/jira_spec.rb

@@ -189,9 +189,10 @@ describe Lita::Handlers::Jira, lita_handler: true do
       end
 
       it 'shows details for a detected issue in a message' do
+        send_message('XYZ-987')
         send_message('foo XYZ-987 bar')
         send_message('foo XYZ-987?')
-        expect(replies.size).to eq(2)
+        expect(replies.size).to eq(3)
       end
 
       it 'does not show details for a detected issue in a command' do
@@ -200,8 +201,10 @@ describe Lita::Handlers::Jira, lita_handler: true do
       end
 
       it 'does not show details for a issue in a URL-ish context' do
+        send_message('http://www.example.com/XYZ-987')
         send_message('http://www.example.com/XYZ-987.html')
         send_message('http://www.example.com/someother-XYZ-987.html')
+        send_message('TIL http://ruby-doc.org/core-2.3.0/Enumerable.html#method-i-each_slice')
         expect(replies.size).to eq(0)
       end
 
@@ -281,10 +284,10 @@ describe Lita::Handlers::Jira, lita_handler: true do
         grab_request(valid_client)
         send_command('jira myissues')
         expect(replies[-3..-1]).to eq([
-          'Here are issues currently assigned to you:',
-          "[XYZ-987] Some summary text\nStatus: In Progress, assigned to: A Person, fixVersion: Sprint 2, priority: P0\nhttp://jira.local/browse/XYZ-987",
-          "[XYZ-988] Some summary text 2\nStatus: In Progress 2, assigned to: A Person 2, fixVersion: none, priority: P1\nhttp://jira.local/browse/XYZ-988"
-        ])
+                                        'Here are issues currently assigned to you:',
+                                        "[XYZ-987] Some summary text\nStatus: In Progress, assigned to: A Person, fixVersion: Sprint 2, priority: P0\nhttp://jira.local/browse/XYZ-987",
+                                        "[XYZ-988] Some summary text 2\nStatus: In Progress 2, assigned to: A Person 2, fixVersion: none, priority: P1\nhttp://jira.local/browse/XYZ-988"
+                                      ])
       end
 
       it 'shows an error when the search fails' do

metadata

@@ -1,15 +1,17 @@
 --- !ruby/object:Gem::Specification
 name: lita-jira
 version: !ruby/object:Gem::Version
-  version: 0.7.2
+  version: 0.8.0
 platform: ruby
 authors:
 - Eric Sigler
 - Matt Critchlow
+- Tristan Chong
+- Lee Briggs
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-12-01 00:00:00.000000000 Z
+date: 2016-02-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lita
@@ -127,6 +129,8 @@ description: A JIRA plugin for Lita.
 email:
 - me@esigler.com
 - matt.critchlow@gmail.com
+- ong@tristaneuan.ch
+- lee@brig.gs
 executables: []
 extensions: []
 extra_rdoc_files: []