lita-jira 0.4.0 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 90dd09ba21f516a5e3ba14b4e508a701e3ba49e6
-  data.tar.gz: 5425fa36b10399c2d7be59ae6a853e7058a4aac2
+  metadata.gz: aef4c53ef081757f69c5313e99612eb6c9b5503a
+  data.tar.gz: 3c5ec6ad54539e97affbf462e71e3376aa9cdefd
 SHA512:
-  metadata.gz: bbff8e22a6e47173002f04d361f55ab1a1bf7cd783a56bc00d4564db07dccb1bc500237ed016e8087fe3a96ea153cda28cb02b78a165fc6a7fe07c91884b611e
-  data.tar.gz: dca962c74e1fce373a8c127f330e0fa42ad99cf03a7053693aa1d5d52163dcf39fb8fe56e7a19a5df2eca8b350df0c0ff0f1ad3e4d72a99af607e6fcf986d7a9
+  metadata.gz: bea64e3f8e3114be601474962ce76f006415fd2c797f76033242f8eaca6f5cb70a86980fb3b1c9f8cb77ec4974b73d5494642879700b1615f6acf6cea0339b69
+  data.tar.gz: ff5eb8303c4dbc703d07759b64724cc30898ea3eb1cef9da71a9cb0cb24a0a2e31333edf97b5a748e18b4b503751aa1ffadeaf0c52b97a35bd3c220b1e941757

data/README.md

@@ -34,25 +34,20 @@ config.handlers.jira.context  = '' # If your instance is in a /subdirectory, put
 
 ```
 todo <project> "<subject>" ["<summary>"] - Creates an issue in <project> with <subject> and optionally <summary>
-jira <issue>                             - Shows a short summary <issue>
-jira details <issue>                     - Shows all details about <issue>
-jira assign <user> to <issue>            - Assigns <user> to <issue>, <user> can be a 'Full Name' or a '@mentionname'
-jira comment on <issue> <comment text>   - Adds <comment text> to <issue>
 ```
 
-### Search
-
 ```
-jira search "<text>"              - Search for <text> across all of JIRA
-jira search <project ID> "<text>" - Search for <text> within the scope of <project ID>
+jira <issue>                             - Shows a short summary <issue>
+jira details <issue>                     - Shows all details about <issue>
+jira comment on <issue> <comment text>   - Adds <comment text> to <issue>
 ```
 
 ### Misc
 
 ```
-jira identify <email address>     - Associate your chat user with your email address
-jira forget                       - Remove your chat user / email association
-jira whoami                       - Show your chat user / email association
+jira identify <email address> - Associate your chat user with your email address
+jira forget                   - Remove your chat user / email association
+jira whoami                   - Show your chat user / email association
 ```
 
 ## License

data/lib/jirahelper/issue.rb

@@ -9,6 +9,13 @@ module JiraHelper
         nil
     end
 
+    def fetch_project(key)
+      client.Project.find(key)
+      rescue
+        log.error('JIRA HTTPError')
+        nil
+    end
+
     def format_issue(issue)
       t('issue.details',
         key: issue.key,
@@ -17,5 +24,16 @@ module JiraHelper
         priority: issue.priority.name,
         status: issue.status.name)
     end
+
+    def create_issue(project, subject, summary)
+      project = fetch_project(project)
+      return nil unless project
+      issue = client.Issue.build
+      issue.save(fields: { subject: subject,
+                           summary: summary,
+                           project: { id: project.id } })
+      issue.fetch
+      issue
+    end
   end
 end

data/lib/jirahelper/regex.rb

@@ -2,6 +2,9 @@
 module JiraHelper
   # Regular expressions
   module Regex
+    COMMENT_PATTERN = /\"(?<comment>.+)\"/
+    SUBJECT_PATTERN = /\"(?<subject>.+)\"/
+    SUMMARY_PATTERN = /\"(?<summary>.+)\"/
     PROJECT_PATTERN = /(?<project>[a-zA-Z0-9]{1,10})/
     ISSUE_PATTERN   = /(?<issue>#{PROJECT_PATTERN}-[0-9]{1,5}+)/
     EMAIL_PATTERN   = /(?<email>[\w+\-.]+@[a-z\d\-]+(\.[a-z]+)*\.[a-z]+)/i

data/lib/lita/handlers/jira.rb

@@ -34,7 +34,7 @@ module Lita
       )
 
       route(
-        /^jira\scomment\son\s#{ISSUE_PATTERN}\s"(?<comment>.+)"$/,
+        /^jira\scomment\son\s#{ISSUE_PATTERN}\s#{COMMENT_PATTERN}$/,
         :comment,
         command: true,
         help: {
@@ -42,10 +42,19 @@ module Lita
         }
       )
 
+      route(
+        /^todo\s#{PROJECT_PATTERN}\s#{SUBJECT_PATTERN}(\s#{SUMMARY_PATTERN})?$/,
+        :todo,
+        command: true,
+        help: {
+          t('help.todo.syntax') => t('help.todo.desc')
+        }
+      )
+
       def summary(response)
         issue = fetch_issue(response.match_data['issue'])
         return response.reply(t('error.request')) unless issue
-        response.reply("#{issue.key}: #{issue.summary}")
+        response.reply(t('issue.summary', key: issue.key, summary: issue.summary))
       end
 
       def details(response)
@@ -61,6 +70,14 @@ module Lita
         comment.save!(body: response.match_data['comment'])
         response.reply(t('comment.added', issue: issue.key))
       end
+
+      def todo(response)
+        issue = create_issue(response.match_data['project'],
+                             response.match_data['subject'],
+                             response.match_data['summary'])
+        return response.reply(t('error.request')) unless issue
+        response.reply(t('issue.created', key: issue.key))
+      end
     end
 
     Lita.register_handler(Jira)

data/lita-jira.gemspec

@@ -1,10 +1,10 @@
 Gem::Specification.new do |spec|
   spec.name          = 'lita-jira'
-  spec.version       = '0.4.0'
+  spec.version       = '0.5.0'
   spec.authors       = ['Eric Sigler']
   spec.email         = ['me@esigler.com']
-  spec.description   = 'A Lita handler for interacting with a JIRA ticket tracker.'
-  spec.summary       = 'A Lita handler for interacting with a JIRA ticket tracker.'
+  spec.description   = 'A JIRA plugin for Lita.'
+  spec.summary       = 'A JIRA plugin for Lita.'
   spec.homepage      = 'https://github.com/esigler/lita-jira'
   spec.license       = 'MIT'
   spec.metadata      = { 'lita_plugin_type' => 'handler' }

data/locales/en.yml

@@ -17,19 +17,24 @@ en:
             syntax: jira whoami
             desc: Show your chat user / email association
           comment:
-            syntax:
-            desc:
+            syntax: jira comment on <issue> <comment text>
+            desc: Adds <comment text> to <issue>
           details:
             syntax: jira details <issue>
             desc: Shows detailed information for <issue>
           summary:
             syntax: jira <issue>
             desc: Shows summary for <issue>
+          todo:
+            syntax: todo <project> "<subject>" ["<summary>"]
+            desc: Creates an issue in <project> with <subject> and optionally <summary>
         identify:
           stored: "You have been identified as %{email} to JIRA"
           deleted: You have been de-identified from JIRA
           email: "You are identified with JIRA as %{email}"
         issue:
+          created: "Issue %{key} created"
           details: "%{key}: %{summary}, assigned to: %{assigned}, priority: %{priority}, status: %{status}"
+          summary: "%{key}: %{summary}"
         comment:
           added: "Comment added to %{issue}"

data/spec/lita/handlers/jira_spec.rb

@@ -1,48 +1,60 @@
 require 'spec_helper'
 
 describe Lita::Handlers::Jira, lita_handler: true do
-  let(:basic_issue) do
-    double(summary: 'Some summary text',
-           assignee: double(displayName: 'A Person'),
-           priority: double(name: 'P0'),
-           status: double(name: 'In Progress'),
-           key: 'XYZ-987')
+  let(:saved_issue) do
+    result = double(summary: 'Some summary text',
+                    assignee: double(displayName: 'A Person'),
+                    priority: double(name: 'P0'),
+                    status: double(name: 'In Progress'),
+                    key: 'XYZ-987')
+    allow(result).to receive('save') { true }
+    allow(result).to receive('fetch') { true }
+    result
   end
 
-  let(:open_issue) do
-    r = double
-    expect(r).to receive_message_chain('Issue.find') { basic_issue }
-    r
+  let(:saved_project) do
+    double(key: 'XYZ',
+           id: 1)
   end
 
-  let(:failed_find) do
+  let(:valid_client) do
+    issue = double
+    allow(issue).to receive_message_chain('Issue.find') { saved_issue }
+    allow(issue).to receive_message_chain('Issue.find.comments.build.save!') { saved_issue }
+    allow(issue).to receive_message_chain('Issue.build') { saved_issue }
+    allow(issue).to receive_message_chain('Project.find') { saved_project }
+    issue
+  end
+
+  let(:failed_find_issue) do
     r = double
     expect(r).to receive_message_chain('Issue.find').and_throw(JIRA::HTTPError)
     r
   end
 
-  let(:comment_issue) do
+  let(:failed_find_project) do
     r = double
-    expect(r).to receive_message_chain('Issue.find') { basic_issue }
-    expect(r).to receive_message_chain('Issue.find.comments.build.save!') { basic_issue }
+    expect(r).to receive_message_chain('Project.find').and_throw(JIRA::HTTPError)
     r
   end
 
   it do
-    is_expected.to route_command('jira ABC-123')
-    is_expected.to route_command('jira details ABC-123')
-    is_expected.to route_command('jira comment on ABC-123 "You just need a cat"')
+    is_expected.to route_command('jira ABC-123').to(:summary)
+    is_expected.to route_command('jira details ABC-123').to(:details)
+    is_expected.to route_command('jira comment on ABC-123 "You just need a cat"').to(:comment)
+    is_expected.to route_command('todo ABC "summary text"').to(:todo)
+    is_expected.to route_command('todo ABC "summary text" "subject text"').to(:todo)
   end
 
   describe '#summary' do
     it 'shows summary with a valid issue' do
-      grab_request(open_issue)
+      grab_request(valid_client)
       send_command('jira XYZ-987')
       expect(replies.last).to eq('XYZ-987: Some summary text')
     end
 
     it 'warns the user when the issue is not valid' do
-      grab_request(failed_find)
+      grab_request(failed_find_issue)
       send_command('jira XYZ-987')
       expect(replies.last).to eq('Error fetching JIRA issue')
     end
@@ -50,14 +62,14 @@ describe Lita::Handlers::Jira, lita_handler: true do
 
   describe '#details' do
     it 'shows details with a valid issue' do
-      grab_request(open_issue)
+      grab_request(valid_client)
       send_command('jira details XYZ-987')
       expect(replies.last).to eq('XYZ-987: Some summary text, assigned to: ' \
                                  'A Person, priority: P0, status: In Progress')
     end
 
     it 'warns the user when the issue is not valid' do
-      grab_request(failed_find)
+      grab_request(failed_find_issue)
       send_command('jira details XYZ-987')
       expect(replies.last).to eq('Error fetching JIRA issue')
     end
@@ -65,15 +77,29 @@ describe Lita::Handlers::Jira, lita_handler: true do
 
   describe '#comment' do
     it 'updates the comment with a valid issue and comment text' do
-      grab_request(comment_issue)
+      grab_request(valid_client)
       send_command('jira comment on XYZ-987 "Testing"')
       expect(replies.last).to eq('Comment added to XYZ-987')
     end
 
     it 'warns the user when the issue is not valid' do
-      grab_request(failed_find)
+      grab_request(failed_find_issue)
       send_command('jira comment on XYZ-987 "Testing"')
       expect(replies.last).to eq('Error fetching JIRA issue')
     end
   end
+
+  describe '#todo' do
+    it 'creates a new issue if the project is valid and there is a summary' do
+      grab_request(valid_client)
+      send_command('todo XYZ "Some summary text"')
+      expect(replies.last).to eq('Issue XYZ-987 created')
+    end
+
+    it 'warns the user when the project is not valid' do
+      grab_request(failed_find_project)
+      send_command('todo ABC "Some summary text"')
+      expect(replies.last).to eq('Error fetching JIRA issue')
+    end
+  end
 end

data/spec/spec_helper.rb

@@ -19,5 +19,5 @@ RSpec.configure do |config|
 end
 
 def grab_request(result)
-  expect(JIRA::Client).to receive(:new) { result }
+  allow(JIRA::Client).to receive(:new) { result }
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lita-jira
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.5.0
 platform: ruby
 authors:
 - Eric Sigler
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-12-31 00:00:00.000000000 Z
+date: 2015-01-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lita
@@ -122,7 +122,7 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: A Lita handler for interacting with a JIRA ticket tracker.
+description: A JIRA plugin for Lita.
 email:
 - me@esigler.com
 executables: []
@@ -173,7 +173,7 @@ rubyforge_project:
 rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
-summary: A Lita handler for interacting with a JIRA ticket tracker.
+summary: A JIRA plugin for Lita.
 test_files:
 - spec/lita/handlers/jira_spec.rb
 - spec/lita/handlers/jira_utility_spec.rb