lita-jira-issues 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6a8031619193c513be736c5ab30c7a042f8e7904
-  data.tar.gz: f5cafa72ed70367ffe54ff72bb4aecc1f194e8e3
+  metadata.gz: e95a4831033d91c23789d7acd01976b7ad7772a8
+  data.tar.gz: 824e1d5b8dad51e051a317d79ef02f1057a28c57
 SHA512:
-  metadata.gz: af14129f93d13f70895fb58193572b748e068db7c18d4330819442f80867be97705234510b1d0e4fb19158a621ae86aabf0e91b29f2fd02c2d56a0a895be9f83
-  data.tar.gz: e886bd47ca666e7c2024f231eccbe1b1e0396a246b19143f0500571d4427c4848e74d46b7235c8ad12a763d33fd2b8226c36617c3c74b9f8d880a4133c127a5e
+  metadata.gz: 0a74037ccfcce383aba01ab2ed0536492e3e436a4a54ed19a8adf0e2f24ea219f9d14994b4f2e8e675714b9ed0cbcedc2680cc3783fa71a60b44b5c362d5d5c8
+  data.tar.gz: af2817980dafb19f46eaabb0c3162c88635a81d19b5d5fd90a927e8831592031e1909f9a473e2be31202735a611d7e324eb398eea75a271b38ff4810417e190e

data/README.md

@@ -1,5 +1,6 @@
 # lita-jira-issues
 
+[![Gem Version](http://img.shields.io/gem/v/lita-jira-issues.svg)](https://rubygems.org/gems/lita-jira-issues)
 [![Build Status](http://img.shields.io/travis/amaltson/lita-jira-issues.svg)](https://travis-ci.org/amaltson/lita-jira-issues)
 [![Code Climate](http://img.shields.io/codeclimate/github/amaltson/lita-jira-issues.svg)](https://codeclimate.com/github/amaltson/lita-jira-issues)
 [![Coverage Status](http://img.shields.io/coveralls/amaltson/lita-jira-issues.svg)](https://coveralls.io/r/amaltson/lita-jira-issues)
@@ -8,6 +9,9 @@ Lita handler for showing JIRA issue details when a JIRA issue key is mentioned i
 chat. Inspired by the [Hubot jira-issue
 plugin](https://github.com/github/hubot-scripts/blob/master/src/scripts/jira-issues.coffee)
 
+**Note**: Version 0.2+ of this hander require Lita 4. If you'd like to use this
+handler with Lita 3.x, please use version 0.1
+
 ## Installation
 
 Add lita-jira-issues to your Lita instance's Gemfile:

data/lib/lita/handlers/jira_issues.rb

@@ -4,33 +4,21 @@ module Lita
   module Handlers
     class JiraIssues < Handler
 
-      def initialize(*args)
-        super(args)
-        @jira = JiraGateway.new(http, config)
-      end
-
-      def self.default_config(config)
-        config.enabled = true
-      end
+      config :url, required: true, type: String
+      config :username, required: true, type: String
+      config :password, required: true, type: String
 
       route /[a-zA-Z]+-\d+/, :jira_message, help: {
         "KEY-123" => "Replies with information about the given JIRA key"
       }
 
       def jira_message(response)
-        unless configured?
-          raise 'Need to configure url, username, password for jira_issues ' \
-            'to work'
-        end
+        @jira ||= JiraGateway.new(http, config)
         response.matches.each do | key |
           handle_key(response, key)
         end
       end
 
-      def configured?
-        config.url && config.username && config.password
-      end
-
       def handle_key(response, key)
         data = @jira.data_for_issue(key)
         return if data.empty?

data/lita-jira-issues.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = "lita-jira-issues"
-  spec.version       = "0.1.0"
+  spec.version       = "0.2.0"
   spec.authors       = ["Arthur Maltson"]
   spec.email         = ["arthur@maltson.com"]
   spec.description   = "Lita handler to show JIRA issue details"
@@ -15,7 +15,7 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_runtime_dependency "lita", "~> 3.3"
+  spec.add_runtime_dependency "lita", "~> 4.0"
 
   spec.add_development_dependency "bundler", "~> 1.3"
   spec.add_development_dependency "rake", "~> 10.3"

data/spec/lita/handlers/jira_issues_spec.rb

@@ -2,12 +2,8 @@ require "spec_helper"
 
 describe Lita::Handlers::JiraIssues, lita_handler: true do
 
-  it 'should fail to start without configuration' do
-    send_message('Trying to use JIRA_123 not configured')
-  end
-
-  it { routes('JIRA-123').to(:jira_message) }
-  it { routes('user talking about something JIRA-123 had key').to(:jira_message) }
+  it { is_expected.to route('JIRA-123').to(:jira_message) }
+  it { is_expected.to route('user talking about something JIRA-123 had key').to(:jira_message) }
 
   describe 'Looking up keys' do
 

data/spec/spec_helper.rb

@@ -8,3 +8,5 @@ SimpleCov.start { add_filter "/spec/" }
 
 require "lita-jira-issues"
 require "lita/rspec"
+
+Lita.version_3_compatibility_mode = false

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lita-jira-issues
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Arthur Maltson
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.3'
+        version: '4.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.3'
+        version: '4.0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement