lita-howlongtobeat 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: fb31af125c192ec7dcd13232b24d6164cd33a20a
-  data.tar.gz: c91f5b605c190ca566e6c4cf2a311d63f1bfc775
+  metadata.gz: 91b6e19dc629d36b665cccd5803e18c774d03ad1
+  data.tar.gz: 43348a2c88c171e3b41a0f707235465cfc538020
 SHA512:
-  metadata.gz: c2aea2755662ae358f3b8d4e6e2d288fa5f56c3d23f7acdd261df6fc75c0e0d23794af8b79e80ea888d2737a5b0cb37d16c16b58e9a4541efabd05017a895959
-  data.tar.gz: 21c861b430922e7fa3d0804b0b7aa667c733956bb61b17e19f27f22061c798a98dafa9c533e11879fa57d3a93ae64fa3b76f1615850a51cee4a44eae5452d7e4
+  metadata.gz: bb6d0666bfadc04662055f9371775400fdb849257ad344c5c5b5ae1e767c1dbb8a17f22674a16d6ba6414ac23d116aa194c50e70250ea2c7881cc037baf6cc43
+  data.tar.gz: c9cc7264a66dc65561aa47a7444cd577d55fed7e3878f68a651e48add33b8c824962cd62d576eed235f1379091efd0048607a12aa03ed4671a0e72dc42247a94

data/README.md

@@ -1,5 +1,7 @@
 # lita-howlongtobeat
 
+[![Circle CI](https://circleci.com/gh/mskog/lita-howlongtobeat.svg?style=svg)](https://circleci.com/gh/mskog/lita-howlongtobeat)
+
 **lita-howlongtobeat** is a [Lita](https://github.com/litaio/lita) handler that returns the average length of the main story for a video game.
 
 ## Installation

data/lib/lita/handlers/howlongtobeat.rb

@@ -1,20 +1,52 @@
 module Lita
   module Handlers
     class Howlongtobeat < Handler
-        SITE_URL = "http://howlongtobeat.com"
-        SEARCH_URL = "http://howlongtobeat.com/search_main.php?page=1"
 
         route(/^(?:hltp|howlongtobeat)\s+(.*)/i, :howlongtobeat, command: true, help: { t("help.howlongtobeat_key") => t("help.howlongtobeat_value")})
 
         def howlongtobeat(response)
-          term = response.matches[0][0]
-          search = http.post(SEARCH_URL, queryString: term, t: 'games', sorthead: 'popular', sortd: 'Normal Order', detail: '0')
-          document = Nokogiri::HTML(search.body)
-          title = document.css('a')[0]
-          response.reply("No results found for #{term}") && return unless title
-          story = document.css(".search_list_tidbit.center")[0].text
-          response.reply("It will take about #{story}to beat the main story of #{title.attr('title')}")
-          response.reply("Source: #{SITE_URL}/#{title.attr('href')}")
+          HowlongtobeatSearch.new(response.matches[0][0], http).print_result(response)
+        end
+
+        class HowlongtobeatSearch
+          SEARCH_URL = "http://howlongtobeat.com/search_main.php?page=1"
+          SITE_URL = "http://howlongtobeat.com"
+
+          def initialize(term, client = Faraday)
+            @term = term
+            @client = client
+          end
+
+          def print_result(response)
+            response.reply("No results found for #{@term}") && return unless title
+            response.reply("No data found for how long it will take to complete the main story of '#{title_content}'") && return unless story
+            response.reply("It will take about #{story}to beat the main story of '#{title_content}'")
+            response.reply("Source: #{SITE_URL}/#{title_href}")
+          end
+
+          def story
+            text = doc.css(".search_list_tidbit.center")[0].text
+            text == '--' ? nil : text
+          end
+
+          def title
+            doc.css('a')[0]
+          end
+
+          def title_href
+            title ? title.attr('href') : nil
+          end
+
+          def title_content
+            title ? title.attr('title') : nil
+          end
+
+          def doc
+            @data ||= begin
+              search = @client.post(SEARCH_URL, queryString: @term, t: 'games', sorthead: 'popular', sortd: 'Normal Order', detail: '0')
+              Nokogiri::HTML(search.body)
+            end
+          end
         end
 
         Lita.register_handler(self)

data/lita-howlongtobeat.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = "lita-howlongtobeat"
-  spec.version       = "0.1.0"
+  spec.version       = "0.2.0"
   spec.authors       = ["Magnus Skog"]
   spec.email         = ["magnus.m.skog@gmail.com"]
   spec.description   = "A Lita handler that returns the average number of hours required to beat a game from http://howlongtobeat.com"

data/spec/fixtures/no_main.txt

@@ -0,0 +1,37 @@
+HTTP/1.1 200 OK
+Date: Tue, 17 Nov 2015 17:13:46 GMT
+Content-Type: text/html; charset=windows-1252
+Transfer-Encoding: chunked
+Connection: keep-alive
+Expires: Thu, 19 Nov 1981 08:52:00 GMT
+Cache-Control: no-store, no-cache, must-revalidate, post-check=0, pre-check=0
+Pragma: no-cache
+Set-Cookie: hl2b_save=deleted; expires=Thu, 01-Jan-1970 00:00:01 GMT; path=/; domain=howlongtobeat.com; httponly
+Vary: Accept-Encoding
+Set-Cookie: _asomcnc=1; Max-Age=900; Path=/
+X-NoCache: 1
+Server: cloudflare-nginx
+CF-RAY: 246d116e7df23ce3-CPH
+Content-Encoding: gzip
+
+<h3 class='head_padding shadow_box back_blue'>We Found 1 Games for "legacy of the void"</h3> <li class="back_white shadow_box"> <div class="search_list_image">
+<a title="StarCraft II: Legacy of the Void" href="game.php?id=9154">
+<img src="gameimages/StarCraft_II_Legacy_of_the_Void_logo.png"/>
+</a>
+</div> <div class="search_list_details"> <h3><a class="text_blue" title="StarCraft II: Legacy of the Void" href="game.php?id=9154">StarCraft II: Legacy of the Void</a></h3> <div class="search_list_details_block"> <div>
+<div class="search_list_tidbit">Main Story</div>
+<div class="search_list_tidbit center time_00">--</div>
+</div>
+<div>
+<div class="search_list_tidbit">Main + Extra</div>
+<div class="search_list_tidbit center time_40">15&#189; Hours </div>
+</div>
+<div>
+<div class="search_list_tidbit">Completionist</div>
+<div class="search_list_tidbit center time_00">--</div>
+</div>
+<div>
+<div class="search_list_tidbit">Combined</div>
+<div class="search_list_tidbit center time_40">15&#189; Hours </div>
+</div> </div>
+</div> <div class="clear"></div> </li> 

data/spec/lita/handlers/howlongtobeat_spec.rb

@@ -6,19 +6,31 @@ describe Lita::Handlers::Howlongtobeat, lita_handler: true do
 
   describe "#howlongtobeat" do
     before :each do
-      stub_request(:post, described_class::SEARCH_URL).with(body: {"detail"=>"0", "queryString"=>"sdfdfsfdfds", "sortd"=>"Normal Order", "sorthead"=>"popular", "t"=>"games"}).to_return(File.read('spec/fixtures/nothing_found.txt'))
+      stub_request(:post, described_class::HowlongtobeatSearch::SEARCH_URL).with(body: {"detail"=>"0", "queryString"=>"sdfdfsfdfds", "sortd"=>"Normal Order", "sorthead"=>"popular", "t"=>"games"}).to_return(File.read('spec/fixtures/nothing_found.txt'))
     end
 
     context "with a term with results" do
       before :each do
-        stub_request(:post, described_class::SEARCH_URL).with(body: {"detail"=>"0", "queryString"=>"witcher 3", "sortd"=>"Normal Order", "sorthead"=>"popular", "t"=>"games"}).to_return(File.read('spec/fixtures/witcher_3.txt'))
+        stub_request(:post, described_class::HowlongtobeatSearch::SEARCH_URL).with(body: {"detail"=>"0", "queryString"=>"witcher 3", "sortd"=>"Normal Order", "sorthead"=>"popular", "t"=>"games"}).to_return(File.read('spec/fixtures/witcher_3.txt'))
       end
 
       it "returns the title and the main story length" do
         send_command "howlongtobeat witcher 3"
         expect(replies.count).to eq 2
-        expect(replies[0]).to match 'It will take about 43½ Hours to beat the main story of The Witcher 3: Wild Hunt'
-        expect(replies[1]).to match "Source: #{described_class::SITE_URL}/game.php?id=10270"
+        expect(replies[0]).to match "It will take about 43½ Hours to beat the main story of 'The Witcher 3: Wild Hunt'"
+        expect(replies[1]).to match "Source: #{described_class::HowlongtobeatSearch::SITE_URL}/game.php?id=10270"
+      end
+    end
+
+    context "with a term with no main story results" do
+      before :each do
+        stub_request(:post, described_class::HowlongtobeatSearch::SEARCH_URL).with(body: {"detail"=>"0", "queryString"=>"legacy of the void", "sortd"=>"Normal Order", "sorthead"=>"popular", "t"=>"games"}).to_return(File.read('spec/fixtures/no_main.txt'))
+      end
+
+      it "returns a helpful note" do
+        send_command "howlongtobeat legacy of the void"
+        expect(replies.count).to eq 1
+        expect(replies[0]).to match "No data found for how long it will take to complete the main story of 'StarCraft II: Legacy of the Void'"
       end
     end
 
@@ -26,7 +38,7 @@ describe Lita::Handlers::Howlongtobeat, lita_handler: true do
       let(:command){'sdfdfsfdfds'}
 
       before :each do
-        stub_request(:post, described_class::SEARCH_URL).with(body: {"detail"=>"0", "queryString"=> command, "sortd"=>"Normal Order", "sorthead"=>"popular", "t"=>"games"}).to_return(File.read('spec/fixtures/nothing_found.txt'))
+        stub_request(:post, described_class::HowlongtobeatSearch::SEARCH_URL).with(body: {"detail"=>"0", "queryString"=> command, "sortd"=>"Normal Order", "sorthead"=>"popular", "t"=>"games"}).to_return(File.read('spec/fixtures/nothing_found.txt'))
       end
 
       it "returns an error" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lita-howlongtobeat
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Magnus Skog
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-11-16 00:00:00.000000000 Z
+date: 2015-11-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lita
@@ -141,6 +141,7 @@ files:
 - lib/lita/handlers/howlongtobeat.rb
 - lita-howlongtobeat.gemspec
 - locales/en.yml
+- spec/fixtures/no_main.txt
 - spec/fixtures/nothing_found.txt
 - spec/fixtures/witcher_3.txt
 - spec/lita/handlers/howlongtobeat_spec.rb
@@ -173,6 +174,7 @@ specification_version: 4
 summary: A Lita handler that returns the average number of hours required to beat
   a game from http://howlongtobeat.com
 test_files:
+- spec/fixtures/no_main.txt
 - spec/fixtures/nothing_found.txt
 - spec/fixtures/witcher_3.txt
 - spec/lita/handlers/howlongtobeat_spec.rb