lita-hcadmin 0.4.2 → 0.4.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4e35066ec0936361e47aba8dced07c20c011741d
-  data.tar.gz: bf0d87dbc41f183bf67a3fb14c07aebfedd2009c
+  metadata.gz: a305e9389b1108f8c4a4eaa5194562339a73c7de
+  data.tar.gz: f5bb648d9b55d44c9efde3787229d63cac9b65b4
 SHA512:
-  metadata.gz: 09e7acd16ce9e3de0176420d127f75cd5c52450cd1ffc17ca4e1782c9c232e589de6e0a270bc711004047fed7bb4b453fb4e71318419162a8037652ab1f3a204
-  data.tar.gz: d00d1bc5047e1af4bfa5483c807e3a62c2e9dab975604fa4023941747dbac87ab626d1d8100927aa700e21f11cea7720617d690b9e95ac6d665c22728db937d7
+  metadata.gz: ee4b47126ad575be01d78c78c262e3c561fefc4e3b75dc4abe14bc8b3fb097dc8d1bc04f069ad584e8bf55729e25f205ea222a0aa3f11d71e60cb74ba3a03070
+  data.tar.gz: 227e4c67e7e9185b2f6ad0c028136b17f424f4a17907a4a02409fbc30779d3cb2ba600a4077cf218f5308bc8e3f6e170d02622b87d0385ff69db439fa18cc45e

data/.rubocop.yml

@@ -11,7 +11,7 @@ Documentation:
   Enabled: false
 
 ClassLength:
-  Max: 400
+  Max: 430
 
 AbcSize:
   Max: 60

data/CHANGELOG.md

@@ -1,5 +1,21 @@
 # lita-hcadmin
 
+[0.4.4]
+---------
+- [desktophero] - User invite as a discrete route
+
+[0.4.3]
+---------
+- [desktophero] - Not released: User activate now sends an invite through the HipChat V2 API
+
+[0.4.2]
+---------
+- [desktophero] - User activation checks for array of approved domains from bot maintainers
+
+[0.4.1]
+---------
+- [desktophero] - Not released as approved domains for emails were not checked for
+
 [0.4.0]
 ---------
 - [desktophero] - Activate user

data/README.md

@@ -174,6 +174,22 @@ user activate <in_user_email@company.com>
 bot: That email is already in use.
 ```
 
+### user invite
+```
+user invite <email_name@company.com>
+bot: Invite sent to user with status code 200
+```
+
+A couple of checks:
+```
+user invite <bad_email@companyom>
+bot: First value needs to be a valid email address
+```
+```
+user invite <in_user_email@company.com>
+bot: That email is already in use.
+```
+
 ## TO-DOs
 The Issues for this repo will be used to accept, collaborate, and complete `TO-DOs`
 

data/lib/lita/handlers/hcadmin.rb

@@ -65,7 +65,11 @@ module Lita
 
       route(/(?:(?:user activate))\s+(.+)/i,
         :user_activate,
-        help: { 'user activate email@company' => 'When run as a user admin, generates an invite to the email account' })
+        help: { 'user activate email@company' => 'When run as a user admin, creates an account' })
+
+      route(/(?:(?:user invite))\s+(.+)/i,
+        :user_invite,
+        help: { 'user invite email@company' => 'When run as a user admin, generates an invite to the email account' })
 
       def hipchat_sponsor(response)
         response.args.each do |r|
@@ -262,6 +266,23 @@ module Lita
         response.reply "Added user with status code #{user_response.status}"
       end
 
+      def user_invite(response)
+        return response.reply 'You are not represented in the USER admin group' unless user_in_group(response.user.mention_name, user_change_admins) == true
+        user_data = user_account_parse(response.matches)
+        user_email = user_data[0]
+        user_name = username_from_email(user_email)
+        return response.reply 'First value needs to be a valid email address' unless valid_email?(user_email) == 0
+        unless email_domain_name.include? domain_from_email(user_email)
+          return response.reply "That email address is not in the approved list to activate. Approved email accounts: #{email_domain_name}"
+        end
+        user_data_check = user_exists?(user_email)
+        return response.reply 'That email is already in use but in a different HipChat account.' if user_data_check[:status] == 409
+        return response.reply 'That email is already an active user in this HipChat account' if user_data_check[:status] == 200
+        return response.reply "I did not understand the status code from HipChat: #{user_data_check[:status]}" unless user_data_check[:status] == 404
+        invite_response = http_post("https://api.hipchat.com/v2/invite/user?auth_token=#{v2_admin_token}&format=json", name: user_name, email: user_email)
+        response.reply "Invite to user sent with status code #{invite_response.status}"
+      end
+
       private
 
       def domain_from_email(email)

data/lita-hcadmin.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = "lita-hcadmin"
-  spec.version       = "0.4.2"
+  spec.version       = "0.4.4"
   spec.authors       = ["Jason Walker"]
   spec.email         = ["jason.walker@target.com"]
   spec.description   = "HipChat admin plugin for Lita"

data/spec/lita/handlers/hcadmin_spec.rb

@@ -195,6 +195,34 @@ describe Lita::Handlers::Hcadmin, lita_handler: true do
         headers: {}
       )
 
+    stub_request(:post, 'https://api.hipchat.com/v2/invite/user?auth_token=abc&format=json')
+      .with(
+        body: "{\"name\":\"email.name\",\"email\":\"email.name@company.com\"}", # rubocop:disable Style/StringLiterals
+        headers: {
+          'Accept' => 'application/json',
+          'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3',
+          'Content-Type' => 'application/json',
+          'User-Agent' => 'Faraday v0.9.2' })
+      .to_return(
+        status: 200,
+        body: '',
+        headers: {}
+      )
+
+    stub_request(:post, 'https://api.hipchat.com/v2/invite/user?auth_token=abc&format=json')
+      .with(
+        body: "{\"name\":\"new.person\",\"email\":\"new.person@company.com\"}", # rubocop:disable Style/StringLiterals
+        headers: {
+          'Accept' => 'application/json',
+          'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3',
+          'Content-Type' => 'application/json',
+          'User-Agent' => 'Faraday v0.9.2' })
+      .to_return(
+        status: 200,
+        body: '',
+        headers: {}
+      )
+
     stub_request(:get, 'https://api.hipchat.com/v2/room/real%20room?auth_token=abc&format=json')
       .with(
         headers: {
@@ -298,6 +326,10 @@ describe Lita::Handlers::Hcadmin, lita_handler: true do
     is_expected.to route_command('user activate email_address name').to(:user_activate)
   end
 
+  it 'routes user invite requests' do
+    is_expected.to route_command('user invite email_address name').to(:user_invite)
+  end
+
   describe '#hipchat_sponsor' do
     context 'validates the new account request is for a company.com email address' do
       it 'rejects non-company.com email addresses' do
@@ -619,6 +651,30 @@ describe Lita::Handlers::Hcadmin, lita_handler: true do
       end
     end
 
+    describe '#user_invite' do
+      context 'invites a person' do
+        it 'blocks an activation if requestor is not a user admin' do
+          send_command('user invite email.name@companycom', as: regular_member)
+          expect(replies.last).to include('You are not represented in the USER admin group')
+        end
+
+        it 'catches if the user does not use a real email address' do
+          send_command('user invite email.name@companycom', as: user_change_admin_member)
+          expect(replies.last).to include('First value needs to be a valid email address')
+        end
+
+        it 'rejects non-company.com email addresses' do
+          send_command('user invite dummy@gmail.com', as: user_change_admin_member)
+          expect(replies.last).to eq('That email address is not in the approved list to activate. Approved email accounts: ["@company.com", "@network.net"]')
+        end
+
+        it 'adds a user if the inputs are sane' do
+          send_command('user invite email.name@company.com Test Account', as: user_change_admin_member)
+          expect(replies.last).to include('Invite to user sent with status code 200')
+        end
+      end
+    end
+
     context 'the user account already exists' do
       let(:user_v2_already_exists) { File.read(File.join('spec', 'fixtures', 'user_v2_already_exists.json')) }
       before do

metadata

@@ -1,111 +1,111 @@
 --- !ruby/object:Gem::Specification
 name: lita-hcadmin
 version: !ruby/object:Gem::Version
-  version: 0.4.2
+  version: 0.4.4
 platform: ruby
 authors:
 - Jason Walker
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-04-03 00:00:00.000000000 Z
+date: 2016-04-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lita
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '4.3'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '4.3'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.3'
 - !ruby/object:Gem::Dependency
   name: pry-byebug
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rack-test
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: 3.0.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: 3.0.0
 - !ruby/object:Gem::Dependency
   name: rest-client
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 description: HipChat admin plugin for Lita
@@ -115,10 +115,10 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".gitignore"
-- ".rspec"
-- ".rubocop.yml"
-- ".travis.yml"
+- .gitignore
+- .rspec
+- .rubocop.yml
+- .travis.yml
 - CHANGELOG.md
 - Gemfile
 - LICENSE.md
@@ -155,17 +155,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.0.14.1
 signing_key: 
 specification_version: 4
 summary: Allow your HipChat admins to interact with the HipChat APIs
@@ -185,4 +185,3 @@ test_files:
 - spec/fixtures/v2_user_not_found.json
 - spec/lita/handlers/hcadmin_spec.rb
 - spec/spec_helper.rb
-has_rdoc: