lita-hcadmin 0.3.3

data/spec/fixtures/users_data.json

@@ -0,0 +1,49 @@
+{
+  "users": [
+    {
+      "user_id": 11,
+      "email": "user11@company.com",
+      "is_deleted": 0,
+      "is_group_admin": 0,
+      "name": "User 11",
+      "mention_name": "User11",
+      "photo_url": "https://secure.gravatar.com/avatar/0fcefe0e34ef508390c2cd8ecd3db787?s=125&d=https%3A%2F%2Fwww.hipchat.com%2Fimg%2Fsilhouette_125.png&r=g",
+      "last_active": 88,
+      "created": 55,
+      "status": "offline",
+      "status_message": "",
+      "timezone": "America/Chicago",
+      "title": "Analyst 11"
+    },
+    {
+      "user_id": 12,
+      "email": "user11@company.com",
+      "is_deleted": 0,
+      "is_group_admin": 0,
+      "name": "User 11",
+      "mention_name": "User11",
+      "photo_url": "https://secure.gravatar.com/avatar/0fcefe0e34ef508390c2cd8ecd3db787?s=125&d=https%3A%2F%2Fwww.hipchat.com%2Fimg%2Fsilhouette_125.png&r=g",
+      "last_active": 88,
+      "created": 55,
+      "status": "offline",
+      "status_message": "",
+      "timezone": "America/Chicago",
+      "title": "Analyst 11"
+    },
+    {
+      "user_id": 13,
+      "email": "user11@company.com",
+      "is_deleted": 0,
+      "is_group_admin": 0,
+      "name": "User 11",
+      "mention_name": "User11",
+      "photo_url": "https://secure.gravatar.com/avatar/0fcefe0e34ef508390c2cd8ecd3db787?s=125&d=https%3A%2F%2Fwww.hipchat.com%2Fimg%2Fsilhouette_125.png&r=g",
+      "last_active": 88,
+      "created": 55,
+      "status": "offline",
+      "status_message": "",
+      "timezone": "America/Chicago",
+      "title": "Analyst 11"
+    }
+  ]
+}

data/spec/fixtures/v2_room_not_found.json

@@ -0,0 +1,7 @@
+{
+  "error": {
+    "code": 404,
+    "message": "Room 'foobar' not found",
+    "type": "Not Found"
+  }
+}

data/spec/fixtures/v2_user_data.json

@@ -0,0 +1,41 @@
+
+{
+  "created": "2014-09-19T23:26:09+00:00",
+  "email": "dummy.account@target.com",
+  "group":
+  {
+    "id": 9876,
+    "links":
+    {
+      "self": "https://api.hipchat.com/v2/group/1234"
+    },
+    "name": "Tgtbullseye"
+  },
+  "id": 11,
+  "is_deleted": false,
+  "is_group_admin": true,
+  "is_guest": false,
+  "last_active": "2016-02-19T16:04:04+0000",
+  "links":
+  {
+    "self": "https://api.hipchat.com/v2/user/11"
+  },
+  "mention_name": "DummyAccount",
+  "name": "Dummy Account",
+  "photo_url": "https://s3.amazonaws.com/uploads.hipchat.com/photos/11/nope.jpg",
+  "presence":
+  {
+    "client":
+    {
+      "type": "http://hipchat.com/client/mac/macweb",
+      "version": "519"
+    },
+    "is_online": true,
+    "show": "chat"
+  },
+  "roles": ["owner", "admin", "user"],
+  "timezone": "America/Chicago",
+  "title": "Chairman of Dummy",
+  "version": "NMJP5APO",
+  "xmpp_jid": "1234_11@chat.hipchat.com"
+}

data/spec/fixtures/v2_user_not_found.json

@@ -0,0 +1,7 @@
+{
+  "error": {
+    "code": 404,
+    "message": "Target user testmember is not a valid user",
+    "type": "Not Found"
+  }
+}

data/spec/lita/handlers/hcadmin_spec.rb

@@ -0,0 +1,561 @@
+require 'spec_helper'
+require 'json'
+require 'net/smtp'
+
+describe Lita::Handlers::Hcadmin, lita_handler: true do
+  subject { described_class.new(robot) }
+  let(:room_json) { File.read(File.join('spec', 'fixtures', 'room_data.json')) }
+  let(:room_v2_json) { File.read(File.join('spec', 'fixtures', 'room_v2_data.json')) }
+  let(:user_json) { File.read(File.join('spec', 'fixtures', 'user_data.json')) }
+  let(:all_user_json) { File.read(File.join('spec', 'fixtures', 'users_data.json')) }
+  let(:user_v2_json) { File.read(File.join('spec', 'fixtures', 'v2_user_data.json')) }
+  let(:user_v2_noaccount) { File.read(File.join('spec', 'fixtures', 'user_v2_notreal_email.json')) }
+  let(:user_v2_not_found) { File.read(File.join('spec', 'fixtures', 'v2_user_not_found.json')) }
+  let(:room_v2_not_found) { File.read(File.join('spec', 'fixtures', 'v2_room_not_found.json')) }
+  let(:group_stats) { File.read(File.join('spec', 'fixtures', 'stats.json')) }
+  let(:status_json) { File.read(File.join('spec', 'fixtures', 'status.json')) }
+  let(:bad_gateway) { File.read(File.join('spec', 'fixtures', 'bad_gateway.txt')) }
+  let(:http_proxy) { 'http://proxy-proxy.company.com:3128' }
+  let(:url) { 'https://api.hipchat.com/v1/rooms/list?auth_token=testtoken&format=json' }
+  let(:mock_smtp) { mock('smtp') }
+
+  let(:room_change_admin_member) { Lita::User.create(55, name: 'TestAdmin') }
+  let(:regular_member) { Lita::User.create(66, name: 'RegularMember') }
+
+  let(:fetch_api_data) { Hcadmin.fetch_data('v1', 'foo', 'bar') }
+
+  before do
+    Lita.configure do |config|
+      config.handlers.hcadmin.v1_admin_token = '123'
+      config.handlers.hcadmin.v1_notify_token = '321'
+      config.handlers.hcadmin.v2_admin_token = 'abc'
+      config.handlers.hcadmin.http_proxy = 'http://proxy-proxy.company.com:3128'
+      config.handlers.hcadmin.email_dist_list = 'blahblah@company.com'
+      config.handlers.hcadmin.smtp_server = 'smtp.mailserverstuffandthings.com'
+      config.handlers.hcadmin.room_change_admins = ['TestAdmin', 'AnotherAdmin'] # rubocop:disable Style/WordArray
+      config.handlers.hcadmin.account_name = 'TestHipChatAccount'
+      config.handlers.hcadmin.email_domain_name = ['@company.com', '@network.net']
+      config.handlers.hcadmin.http_logging = false
+    end
+
+    stub_request(:get, 'https://api.hipchat.com/v1/rooms/list?auth_token=123&format=json')
+      .with(
+        headers: {
+          'Accept' => 'application/json',
+          'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3',
+          'Content-Type' => 'application/json',
+          'User-Agent' => 'Faraday v0.9.2' })
+      .to_return(
+        status: 200,
+        body: room_json,
+        headers: {}
+      )
+
+    stub_request(:get, 'https://api.hipchat.com/v1/users/show?auth_token=123&format=json&user_id=2341755')
+      .with(
+        headers: {
+          'Accept' => 'application/json',
+          'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3',
+          'Content-Type' => 'application/json',
+          'User-Agent' => 'Faraday v0.9.2' })
+      .to_return(
+        status: 200,
+        body: user_json,
+        headers: {}
+      )
+
+    stub_request(:get, 'https://api.hipchat.com/v2/health-check')
+      .with(
+        headers: {
+          'Accept' => 'application/json',
+          'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3',
+          'Content-Type' => 'application/json',
+          'User-Agent' => 'Faraday v0.9.2' })
+      .to_return(
+        status: 200,
+        body: status_json,
+        headers: {}
+      )
+    stub_request(:get, 'https://api.hipchat.com/v2/user/1234?auth_token=abc&format=json')
+      .with(
+        headers: {
+          'Accept' => 'application/json',
+          'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3',
+          'Content-Type' => 'application/json',
+          'User-Agent' => 'Faraday v0.9.2' })
+      .to_return(
+        status: 200,
+        body: user_v2_json,
+        headers: {}
+      )
+    stub_request(:get, 'https://api.hipchat.com/v2/user/@testmember?auth_token=abc&format=json')
+      .with(
+        headers: {
+          'Accept' => 'application/json',
+          'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3',
+          'Content-Type' => 'application/json',
+          'User-Agent' => 'Faraday v0.9.2' })
+      .to_return(
+        status: 200,
+        body: user_v2_not_found,
+        headers: {}
+      )
+    stub_request(:get, 'https://api.hipchat.com/v2/user/@realmember?auth_token=abc&format=json')
+      .with(
+        headers: {
+          'Accept' => 'application/json',
+          'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3',
+          'Content-Type' => 'application/json',
+          'User-Agent' => 'Faraday v0.9.2' })
+      .to_return(
+        status: 200,
+        body: user_v2_json,
+        headers: {}
+      )
+
+    stub_request(:get, 'https://api.hipchat.com/v2/room/foobar?auth_token=abc&format=json')
+      .with(
+        headers: {
+          'Accept' => 'application/json',
+          'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3',
+          'Content-Type' => 'application/json',
+          'User-Agent' => 'Faraday v0.9.2' })
+      .to_return(
+        status: 200,
+        body: room_v2_not_found,
+        headers: {}
+      )
+
+    stub_request(:get, 'https://api.hipchat.com/v2/room/realroom?auth_token=abc&format=json')
+      .with(
+        headers: {
+          'Accept' => 'application/json',
+          'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3',
+          'Content-Type' => 'application/json',
+          'User-Agent' => 'Faraday v0.9.2' })
+      .to_return(
+        status: 200,
+        body: room_v2_json,
+        headers: {}
+      )
+    stub_request(:put, 'https://api.hipchat.com/v2/room/1460619?auth_token=abc&format=json')
+      .with(
+        body: "{\"name\":\"Test Room @ Company.com\",\"privacy\":\"public\",\"is_archived\":false,\"is_guest_accessible\":false,\"topic\":\"Room for testing things\",\"owner\":{\"id\":\"11\"}}", # rubocop:disable Style/StringLiterals
+        headers: {
+          'Accept' => 'application/json',
+          'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3',
+          'Content-Type' => 'application/json',
+          'User-Agent' => 'Faraday v0.9.2' })
+      .to_return(
+        status: 204,
+        body: '',
+        headers: {}
+      )
+
+    stub_request(:put, 'https://api.hipchat.com/v2/room/1460619?auth_token=abc&format=json')
+      .with(
+        body: "{\"name\":\"Test Room @ Company.com\",\"privacy\":\"public\",\"is_archived\":false,\"is_guest_accessible\":false,\"topic\":\"Room for testing things\",\"owner\":{\"id\":\"66\"}}", # rubocop:disable Style/StringLiterals
+        headers: {
+          'Accept' => 'application/json',
+          'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3',
+          'Content-Type' => 'application/json',
+          'User-Agent' => 'Faraday v0.9.2' })
+      .to_return(
+        status: 204,
+        body: '',
+        headers: {}
+      )
+    stub_request(:get, 'https://api.hipchat.com/v2/room/real%20room?auth_token=abc&format=json')
+      .with(
+        headers: {
+          'Accept' => 'application/json',
+          'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3',
+          'Content-Type' => 'application/json',
+          'User-Agent' => 'Faraday v0.9.2' })
+      .to_return(
+        status: 200,
+        body: room_v2_json,
+        headers: {}
+      )
+  end
+
+  it 'routes the identify room owner command room name has spaces' do
+    is_expected.to route_command('identify room owner thisis a test').to(:identify_room_owner)
+  end
+
+  it 'routes the identify room owner command room name in quotes' do
+    is_expected.to route_command('identify room owner "thisis a test"').to(:identify_room_owner)
+  end
+
+  it 'routes the identify room owner command room name has a @' do
+    is_expected.to route_command('identify room owner "thisis @ test"').to(:identify_room_owner)
+  end
+
+  it 'routes the identify admins command' do
+    is_expected.to route_command('identify hipchat admins').to(:identify_hipchat_admins)
+  end
+
+  it 'routes the identify room count' do
+    is_expected.to route_command('identify room count').to(:identify_room_count)
+  end
+
+  it 'routes the identify user count' do
+    is_expected.to route_command('identify user count').to(:identify_user_count)
+  end
+
+  it 'routes the identify status check' do
+    is_expected.to route_command('identify status').to(:identify_status)
+  end
+
+  it 'routes a sponsor a person request correctly' do
+    is_expected.to route_command('hipchat sponsor first.last@company.com').to(:hipchat_sponsor)
+  end
+
+  it 'routes room change admin requests' do
+    is_expected.to route_command('identify room change admins').to(:identify_room_change_admins)
+  end
+
+  it 'routes room owner change requests' do
+    is_expected.to route_command('room owner change mention_name room_name').to(:room_owner_change)
+  end
+
+  it 'routes room unarchive requests' do
+    is_expected.to route_command('room unarchive room_name').to(:room_unarchive)
+  end
+
+  describe '#hipchat_sponsor' do
+    context 'validates the new account request is for a Target.com email address' do
+      it 'rejects non-Target.com email addresses' do
+        send_command('hipchat sponsor dummy@gmail.com')
+        expect(replies.last).to eq('The email address has to be one of: ["@company.com", "@network.net"]')
+      end
+    end
+    context 'hipchat account exists' do
+      before(:each) do
+        stub_request(:get, 'https://api.hipchat.com/v2/user/dummy.account@company.com?auth_token=abc&format=json')
+          .with(headers: { 'Accept' => 'application/json', 'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3', 'Content-Type' => 'application/json', 'User-Agent' => 'Faraday v0.9.2' })
+          .to_return(status: 200, body: user_v2_json, headers: {})
+      end
+
+      it 'responds that the user exists if an ID is found' do
+        send_command('hipchat sponsor dummy.account@company.com')
+        expect(replies.last).to eq('The email address of dummy.account@company.com already has an account on TestHipChatAccount of 11')
+      end
+    end
+
+    context 'hipchat account does not exist' do
+      before(:each) do
+        stub_request(:get, 'https://api.hipchat.com/v2/user/dummy.account@company.com?auth_token=abc&format=json')
+          .with(headers: { 'Accept' => 'application/json', 'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3', 'Content-Type' => 'application/json', 'User-Agent' => 'Faraday v0.9.2' })
+          .to_return(status: 200, body: user_v2_noaccount, headers: {})
+        allow(described_class).to receive(:send_mail).with('dummy.account@company.com', 'blahblah@company.com', 'dummyHipChatUser', 'smtp.mailserverstuffandthings.com').and_return('221')
+        allow(Net::SMTP).to receive(:start).with('smtp.mailserverstuffandthings.com').and_return('221')
+      end
+      it 'responds that the request is being sent to the defined admin room' do
+        send_command('hipchat sponsor dummy.account@company.com')
+        expect(replies.last).to eq('Message to admins sent')
+      end
+    end
+    it 'replies correctly when not using an approved email domain' do
+      send_command('hipchat sponsor dummy.account@something.com')
+      expect(replies.last).to eq('The email address has to be one of: ["@company.com", "@network.net"]')
+    end
+  end # end hipchat_sponsor
+
+  describe '#identify_hipchat_admins' do
+    describe 'successful HTTP request against the API' do
+      before(:each) do
+        stub_request(:get, 'https://api.hipchat.com/v1/users/list?auth_token=123&format=json')
+          .with(
+            headers: {
+              'Accept' => 'application/json',
+              'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3',
+              'Content-Type' => 'application/json',
+              'User-Agent' => 'Faraday v0.9.2' })
+          .to_return(
+            status: 200,
+            body: all_user_json,
+            headers: {}
+          )
+      end
+      it 'receives a list of admins from a JSON payload' do
+        send_command('identify hipchat admins')
+        expect(replies.last).to eq('Admin list: complete ( 0 s. to respond )')
+      end
+    end
+
+    describe 'handles Bad Gateway errors' do
+      before(:each) do
+        stub_request(:get, 'https://api.hipchat.com/v1/users/list?auth_token=123&format=json')
+          .with(headers: { 'Accept' => 'application/json', 'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3', 'Content-Type' => 'application/json', 'User-Agent' => 'Faraday v0.9.2' })
+          .to_return(status: 502, body: bad_gateway, headers: {})
+      end
+      it 'sends a request for admins that fails with a 502 and responds with exception details' do
+        send_command('identify hipchat admins')
+        expect(replies.last).to eq('Admin list: I ran into an HTTP error ( HTTP code: 502 ) ( 0 s. to respond )')
+      end
+    end
+
+    describe 'handles non-200 series' do
+      before(:each) do
+        stub_request(:get, 'https://api.hipchat.com/v1/users/list?auth_token=123&format=json')
+          .with(headers: { 'Accept' => 'application/json', 'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3', 'Content-Type' => 'application/json', 'User-Agent' => 'Faraday v0.9.2' })
+          .to_return(status: 501, body: bad_gateway, headers: {})
+      end
+      it 'sends a request for admins that fails with a 501 and responds with exception details' do
+        send_command('identify hipchat admins')
+        expect(replies.last).to eq('Admin list: I ran into an HTTP error ( HTTP code: 501 ) ( 0 s. to respond )')
+      end
+    end
+  end # end identify_hipchat_admins
+
+  describe '#identify_status' do
+    context 'parses the status message' do
+      it 'sends status message and parses results' do
+        send_command('identify status')
+        expect(replies.last).to include('Status of hipchat: Code:')
+      end
+    end
+  end # end identify_status
+
+  describe '#email_domain_name' do
+    context 'valid email domains are validated' do
+      before(:each) do
+        allow(described_class).to receive(:email_domain_name).and_return(Lita.config.handlers.hcadmin.email_domain_name)
+      end
+      it 'returns the approved email domains' do
+        expect(described_class.email_domain_name).to include('@company.com') # individual strings
+        expect(described_class.email_domain_name).to include('@network.net')
+        expect(described_class.email_domain_name).to include('@company.com', '@network.net') # multiple strings
+      end
+
+      it 'does not include email domains outside of the config' do
+        expect(described_class.email_domain_name).to_not include('@dummycorp.com')
+      end
+    end
+  end # end email_domain_name
+
+  describe '#identify_room_owner' do
+    context 'getting the list of rooms' do
+      it 'replies with the room_id for a real room name' do
+        send_command('identify room owner floppy drive')
+        expect(replies.last).to eq('The owner of floppy drive is AwesomeSauce')
+      end
+
+      it 'handles room names with numbers' do
+        send_command('identify room owner f00_bar')
+        expect(replies.last).to eq 'Room f00_bar apparently does not have an owner or I could not find a room with that name ( 0 s. to respond )'
+      end
+
+      it 'handles UCASE NAMES' do
+        send_command('identify room owner FOO_BAR')
+        expect(replies.last).to_not eq 'Sorry, no room found with that name FOO_BAR'
+      end
+
+      it 'handles NAMES-WITH-HYPHENS' do
+        send_command('identify room owner NAMES-WITH-HYPHENS')
+        expect(replies.last).to_not eq 'Sorry, no room found with that name NAMES-WITH-HYPHENS'
+      end
+    end
+  end # end identify_room_owner
+
+  describe '#fetch' do
+    context 'fetches JSON payload of rooms from the HipChat API' do
+      before(:each) do
+        allow(described_class).to receive(:fetch_rooms).and_return(room_json)
+      end
+
+      it 'returns JSON payload on fetch commands' do
+        expect(described_class.fetch_rooms).to eq room_json
+      end
+    end
+
+    context 'fetches JSON payload of users from the HipChat API' do
+      before(:each) do
+        allow(described_class).to receive(:fetch_user).with(2_341_755).and_return(user_json)
+      end
+
+      it 'returns JSON payload on fetch user commands' do
+        expect(described_class.fetch_user(2_341_755)).to eq user_json
+      end
+    end
+
+    context 'fetches JSON payload of a user through the V2 api' do
+      before(:each) do
+        allow(described_class).to receive(:fetch_user_v2).with('valid_user@company.com').and_return(user_v2_json)
+      end
+      it 'returns JSON of the requested user' do
+        expect(described_class.fetch_user_v2('valid_user@company.com')).to eq user_v2_json
+      end
+    end
+  end # end fetch
+
+  describe '#parse' do
+    before(:each) do
+      allow(described_class).to receive(:parse).with(room_json, 'rooms').and_return(JSON.parse(room_json))
+    end
+    let(:test_room_data) { described_class.parse(room_json, 'rooms') }
+    let(:test_room_details) { test_room_data['rooms'] }
+
+    context 'JSON data from parse should return a JSON object' do
+      it 'gets a JSON object during parse' do
+        expect(test_room_details.first['room_id']).to eq(31)
+      end
+    end
+  end
+
+  describe '#owner_name_from_id' do
+    before(:each) do
+      allow(described_class).to receive(:owner_name_from_id).with(31, user_json).and_return('AwesomeSauce')
+    end
+    context 'an owner id can be translated to an owner name' do
+      it 'gets the name of the room when presented a room ID' do
+        expect(described_class.owner_name_from_id(31, user_json)).to eq 'AwesomeSauce'
+      end
+    end
+  end
+
+  describe '#id_from_name' do
+    before(:each) do
+      allow(described_class).to receive(:id_from_name).with('floppy drive', room_json).and_return(31)
+    end
+
+    context 'returns the room_id from the room_name' do
+      it 'does not error when getting the ID from name' do
+        expect do
+          described_class.id_from_name('floppy drive', room_json)
+        end.to_not raise_error
+      end
+      it 'returns the room_id when given a room name' do
+        expect(described_class.id_from_name('floppy drive', room_json)).to eq 31
+      end
+    end
+  end
+
+  describe '#identify_room_count' do
+    context 'room count is returned when called' do
+      it 'returns the number of rooms when requested' do
+        send_command('identify room count')
+        expect(replies.last).to include('Rooms in hipchat')
+      end
+    end
+  end
+  # end identify_room_count
+
+  describe '#identify_user_count' do
+    before(:each) do
+      stub_request(:get, 'https://api.hipchat.com/v2/group/171096/statistics?auth_token=abc&format=json')
+        .with(headers: { 'Accept' => 'application/json', 'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3', 'Content-Type' => 'application/json', 'User-Agent' => 'Faraday v0.9.2' })
+        .to_return(status: 200, body: group_stats, headers: {})
+    end
+    context 'grabs the statistics from HipChats API' do
+      it 'replies with the user count from the statistics URL' do
+        send_command('identify user count')
+        expect(replies.last).to include('Users in hipchat:')
+      end
+    end
+  end
+  # end identify_user_count
+
+  describe '#identify_room_change_admins' do
+    context 'returns the room change admins' do
+      it 'names are returned' do
+        send_command('identify room change admins')
+        expect(replies.last).to include('room change admins')
+      end
+    end
+
+    context 'shows TestAdmin name from hcadmin.config' do
+      it 'shows the TestAdmin was returned' do
+        send_command('identify room change admins')
+        expect(replies).to include('TestAdmin')
+      end
+    end
+  end # end room change admins
+
+  describe '#room_owner_change' do
+    it 'replies with some feedback to the member' do
+      send_command('room owner change')
+      expect(replies).to_not eq '' || nil
+    end
+    it 'validates a regular member is identified' do
+      send_command('room owner change testmember testroom', as: regular_member)
+      expect(replies.last).to eq 'You are not represented in the room owner change admin group'
+    end
+    it 'tells you bad arguments passed' do
+      send_command('room owner change testroom', as: room_change_admin_member)
+      expect(replies.last).to include('Wrong number of arguments; expected format of owner_name & room_name received arguments')
+    end
+    it 'tells you bad arguments passed' do
+      send_command('room owner change testroom', as: regular_member)
+      expect(replies.last).to eq 'You are not represented in the room owner change admin group'
+    end
+
+    it 'tells you when a user is not found' do
+      send_command('room owner change testmember realroom', as: room_change_admin_member)
+      expect(replies.last).to eq 'Uh-oh, 404 returned! The user testmember not found'
+    end
+
+    it 'tells you when a room is not found' do
+      send_command('room owner change realmember foobar', as: room_change_admin_member)
+      expect(replies.last).to eq 'Uh-oh, 404 returned! The room foobar not found'
+    end
+
+    it 'does not cry when a real user and a real room are passed' do
+      send_command('room owner change realmember realroom', as: room_change_admin_member)
+      expect(replies.last).to include('Room update request sent. HTTP response code:')
+    end
+  end # end room owner change
+
+  describe '#fetch_data' do
+    context 'accepts API v2 requests' do
+      it 'accepts multiple parameters' do
+        expect(subject).to respond_to(:fetch_data)
+      end
+
+      it 'returns feedback when v2 is not expressed' do
+        expect(subject.fetch_data('v1', 'foo', 'bar')).to eq 'Wrong API version provided'
+      end
+      it 'only accepts room and user object types' do
+        expect(subject.fetch_data('v2', 'foo', 'bar')).to eq "Wrong HipChat object type (foo). Only accepts 'room' or 'user'"
+      end
+      it 'requires an object id to not be nil' do
+        expect(subject.fetch_data('v2', 'user', nil)).to eq 'Please provide the object id of the room or user you want information for'
+      end
+      it 'gets parseable JSON data from the api' do
+        expect do
+          JSON.parse(subject.fetch_data('v2', 'user', '1234').to_json)
+        end.to_not raise_error
+      end
+    end
+  end # end fetch_data
+
+  describe '#unarchive_room' do
+    context 'accepts room name' do
+      it 'replies with some feedback to the member' do
+        send_command('room unarchive foobar')
+        expect(replies).to_not eq '' || nil
+      end
+      it 'validates a regular member is identified' do
+        send_command('room unarchive foobar', as: regular_member)
+        expect(replies.last).to eq 'You are not represented in the room owner change admin group'
+      end
+      it 'tells you bad arguments passed' do
+        send_command('room unarchive', as: room_change_admin_member)
+        expect(replies.last).to include('Wrong number of arguments; expected format of room_name received arguments')
+      end
+      it 'tells you when a room is not found' do
+        send_command('room unarchive foobar', as: room_change_admin_member)
+        expect(replies.last).to include('Uh-oh, 404 returned! The room foobar not found')
+      end
+      it 'does not cry when a real user and a real room are passed' do
+        send_command('room unarchive realroom', as: room_change_admin_member)
+        expect(replies.last).to include('Room update request sent. HTTP response code:')
+      end
+      it 'handles multi-word names' do
+        send_command('room unarchive real room', as: room_change_admin_member)
+        expect(replies.last).to include('Room update request sent. HTTP response code:')
+      end
+    end
+  end
+end