lita-greet 0.1.1 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7876a4856b3c1e691a3c18c18a94d7ee4f19ab1d
-  data.tar.gz: fbc1f49b5ace7ab4ab712f15d55c21d4eb1b4108
+  metadata.gz: 1a26fa6c0394e2726c3192e5440877e818276a51
+  data.tar.gz: 4c36d70f3288f8d0ac335cbf26251d6b702a1f3e
 SHA512:
-  metadata.gz: 4fa1e3ea940bd4c3aefaec242e2634113a694f75e3f050b7bf38dc3f5646847639c5ebf625676f03fd5340f92d412f09ba599eb5003c6a349793f1ab70598f13
-  data.tar.gz: 675d0448b28027d9113739faaa6ec2d1a671db32646ac86d41aea9e56bc91a482e5e20e672f10c27f4a21278807326e78c8ebc1e14f252760d24834efc97ea2d
+  metadata.gz: 90a5c352f96dffa847fa85df6d8bf013e5c78239754626c221fadf87aa7e6a8b21e33c1c05eac987e7503cc1c5e1b339f1a085edc3d2e548c6b8bb24d5922c8d
+  data.tar.gz: e1b6ac2d821e0d2044060e07e674975fb4e164170e2de7aa8f608db1565cc1bd7eca96608524b9ce7f1fbc8fd1385a9926cc806190dd1987aa150bfad16bd799

data/lib/lita/handlers/greet.rb

@@ -2,22 +2,19 @@ module Lita
   module Handlers
     class Greet < Handler
 
-      route(/^(hello|hi!?(| .*)$|good morning|howdy|yo!?$|hey).*/i, :say_hello)
+      route(/^(((ahoy|he+l{2,}+o+|he+y+|hi+)+( there)*)|go{2,}d (morning|afternoon|evening|night|nite)|greetings|howdy|sup|yo)+[!1?]*((\s)+Regexp.new(robot.config.robot.name))*[!1?]*$/i, :say_hello)
       route(/^welcome (.+)/i, :welcome)
 
       def say_hello(response)
         return if response.user.name.empty?
-        reply_to_name = response.user.metadata['mention_name'].nil? ?
-                         "#{response.user.name}" :
-                        "#{response.user.metadata['mention_name']}"
-        response.reply "Hello #{reply_to_name}!"
+        bot_response = response.message.body.gsub(/[1?!]+/, "").gsub(/(\s)*#{robot.config.robot.name}(\s)*/i, "")
+        response.reply "#{bot_response} #{(response.user.mention_name || response.user.name)}"
       end
 
       def welcome(response)
         response.reply "Hello and Welcome #{response.matches[0][0]}!"
       end
 
-
     end
 
     Lita.register_handler(Greet)

data/lita-greet.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = "lita-greet"
-  spec.version       = "0.1.1"
+  spec.version       = "0.2.0"
   spec.authors       = ["epinault"]
   spec.email         = ["emmanuel.pinault@zumobi.com"]
   spec.description   = "Make your bot more welcoming and greeting"

data/spec/lita/handlers/greet_spec.rb

@@ -1,19 +1,39 @@
 require "spec_helper"
 
 describe Lita::Handlers::Greet, lita_handler: true do
-  it { is_expected.to route("hello dog").to(:say_hello) }
-  it { is_expected.to route("hi dog").to(:say_hello) }
+  it { is_expected.to route("hello").to(:say_hello) }
+  it { is_expected.to route("hi there").to(:say_hello) }
   it { is_expected.to route("yo!").to(:say_hello) }
-  it { is_expected.to route("good morning").to(:say_hello) }
+  it { is_expected.to route("heeeyyyy").to(:say_hello) }
+  it { is_expected.to route("greetings").to(:say_hello) }
+  it { is_expected.to route("gooooooooood morning").to(:say_hello) }
+  it { is_expected.to route("good afternoon").to(:say_hello) }
+  it { is_expected.to route("Good evening").to(:say_hello) }
+  it { is_expected.to route("good night!").to(:say_hello) }
+  it { is_expected.to route("Good Nite").to(:say_hello) }
   it { is_expected.to route("howdy").to(:say_hello) }
+  it { is_expected.to route("sup!").to(:say_hello) }
+  it { is_expected.to route("ahoy there").to(:say_hello) }
 
   it { is_expected.to route("welcome John Doe").to(:welcome) }
 
-  it "sends hello back the user who said hello" do
-    send_message("Hi")
+  it "sends hello back to the user who said hello" do
+    send_message("Hello")
     expect(replies.last).to match(/Hello/)
   end
 
+  it "sends good morning back to the user name (since no mention_name is supplied) who greeted it" do
+    user = Lita::User.create("1", name: "Stephen")
+    send_message("Good morning!", as: user)
+    expect(replies.last).to match(/Good morning Stephen/)
+  end
+
+  it "sends howdy back to the mention_name of the user who greeted it" do
+    user = Lita::User.create("2", name: "Robert", mention_name: "Bob")
+    send_message("Howdy", as: user)
+    expect(replies.last).to match(/Howdy Bob/)
+  end
+
   it "does not send a message when the user object is empty" do
     user = Lita::User.create("1", name: "")
     send_message("Hi", as: user)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lita-greet
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.2.0
 platform: ruby
 authors:
 - epinault
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-10-14 00:00:00.000000000 Z
+date: 2016-03-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lita
@@ -164,7 +164,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.8
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Greeting lita plugin