lita-google-images 1.0.1 → 1.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 358bdfacf0cdd3050cfb12ca35d2fc1bada87c5c
-  data.tar.gz: 284fb1f71ef59e638c76239f98debd63b23f07ee
+  metadata.gz: 3fc398cce7e6d5f213c99fe009d05377e7f389ff
+  data.tar.gz: 9ea15647790c5116a88c855104d2ff0e4f84613a
 SHA512:
-  metadata.gz: 13a3bccbf71a25f693403a729cd9769c2aacf6c498ecd96e79f4adcc880a2fcfba88eca04bea94cf45901b2fb969b6f2a8a33376b910deb6f056fae11597e957
-  data.tar.gz: 66d340478f710f2235503039eff058d5c55bbed68ca07a249094a804dcbf50f5b3de677fdfc1402a702ccc6f1900dad25d835cff8431f772d3d7f0119342de30
+  metadata.gz: ac19222336770d92793889b4c225077e687ed7808983a26b27db71e6bec91cfe62fe5de18ed67e40a445dea202c9424a7e8982c9be349919c316d49515ea963d
+  data.tar.gz: 8d909da0917e18409ac360a47f14e5919ee7aeb176b655a13f8cad70b3f23b1408da8c817e88361757c2131848a5bfef23072fe1020ae99679c93e0704d24ca7

data/LICENSE

@@ -0,0 +1,19 @@
+Copyright (c) 2013 Jimmy Cuadra
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in
+all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+THE SOFTWARE.

data/lib/lita/handlers/google_images.rb

@@ -28,7 +28,11 @@ module Lita
 
         if data["responseStatus"] == 200
           choice = data["responseData"]["results"].sample
-          response.reply "#{choice["unescapedUrl"]}#.png"
+          if choice
+            response.reply "#{choice["unescapedUrl"]}#.png"
+          else
+            response.reply %{No images found for "#{query}".}
+          end
         else
           reason = data["responseDetails"] || "unknown error"
           Lita.logger.warn(

data/lita-google-images.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = "lita-google-images"
-  spec.version       = "1.0.1"
+  spec.version       = "1.0.2"
   spec.authors       = ["Jimmy Cuadra"]
   spec.email         = ["jimmy@jimmycuadra.com"]
   spec.description   = %q{A Lita handler for fetching images from Google.}
@@ -17,7 +17,7 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency "bundler", "~> 1.3"
   spec.add_development_dependency "rake"
-  spec.add_development_dependency "rspec", ">= 2.14.0.rc1"
+  spec.add_development_dependency "rspec", "~> 2.14"
   spec.add_development_dependency "simplecov"
   spec.add_development_dependency "coveralls"
 end

data/spec/lita/handlers/google_images_spec.rb

@@ -35,6 +35,15 @@ JSON
       )
     end
 
+    it "replies that no images were found if the results are empty" do
+      allow(response).to receive(:body).and_return(<<-JSON.chomp
+{"responseStatus": 200, "responseData": { "results": [] } }
+JSON
+      )
+      send_command("image carl")
+      expect(replies.last).to eq(%{No images found for "carl".})
+    end
+
     it "logs a warning on failure" do
       allow(response).to receive(:body).and_return(<<-JSON.chomp
 {

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lita-google-images
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors:
 - Jimmy Cuadra
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-07-08 00:00:00.000000000 Z
+date: 2013-08-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lita
@@ -56,16 +56,16 @@ dependencies:
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ~>
       - !ruby/object:Gem::Version
-        version: 2.14.0.rc1
+        version: '2.14'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ~>
       - !ruby/object:Gem::Version
-        version: 2.14.0.rc1
+        version: '2.14'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -104,6 +104,7 @@ files:
 - .gitignore
 - .travis.yml
 - Gemfile
+- LICENSE
 - README.md
 - Rakefile
 - lib/lita-google-images.rb