lita-github_pr_list 0.0.21 → 0.1.0

data/spec/lita/handlers/comment_hook_spec.rb

@@ -1,11 +1,34 @@
 describe Lita::Handlers::GithubPrList, lita_handler: true do
+  let(:issue_comments_passed) { sawyer_resource_array("spec/fixtures/issue_comments_passed.json") }
+  let(:issue_comments_passed_design) { sawyer_resource_array("spec/fixtures/issue_comments_passed_design.json") }
+  let(:issue_comments_failed) { sawyer_resource_array("spec/fixtures/issue_comments_failed.json") }
+  let(:issue_comments_in_review) { sawyer_resource_array("spec/fixtures/issue_comments_in_review.json") }
+  let(:issue_comments_fixed) { sawyer_resource_array("spec/fixtures/issue_comments_fixed.json") }
+  let(:issue_comments_passed_both) { sawyer_resource_array("spec/fixtures/issue_comments_passed_both.json") }
   before :each do
     Lita.config.handlers.github_pr_list.github_organization = 'aaaaaabbbbbbcccccc'
     Lita.config.handlers.github_pr_list.github_access_token = 'wafflesausages111111'
     allow_any_instance_of(Lita::Configuration).to receive(:hipchat).and_return(OpenStruct.new({ rooms: ["room"] }))
   end
 
+  let(:agent) do
+    Sawyer::Agent.new "http://example.com/a/" do |conn|
+      conn.builder.handlers.delete(Faraday::Adapter::NetHttp)
+      conn.adapter :test, Faraday::Adapter::Test::Stubs.new
+    end
+  end
+
+  def sawyer_resource_array(file_path)
+    resources = []
+    JSON.parse(File.read(file_path)).each do |i|
+      resources << Sawyer::Resource.new(agent, i)
+    end
+
+    resources
+  end
+
   let(:issue_comment_event_passed) { File.read("spec/fixtures/issue_comment_event_passed.json") }
+  let(:issue_comment_event_passed_design) { File.read("spec/fixtures/issue_comment_event_passed_design.json") }
   let(:issue_comment_event_failed) { File.read("spec/fixtures/issue_comment_event_failed.json") }
   let(:issue_comment_event_failed_hankey) { File.read("spec/fixtures/issue_comment_event_failed_hankey.json") }
   let(:issue_comment_event_in_review) { File.read("spec/fixtures/issue_comment_event_in_review.json") }
@@ -13,22 +36,52 @@ describe Lita::Handlers::GithubPrList, lita_handler: true do
 
   it { is_expected.to route_http(:post, "/comment_hook").to(:comment_hook) }
 
-  it "mentions the github user in the room and tell them they passed" do
+  it "mentions the github user in the room and tell them they passed , but they need design review" do
+    expect_any_instance_of(Octokit::Client).to receive(:issue_comments).and_return(issue_comments_passed)
+
     request = Rack::Request.new("rack.input" => StringIO.new(issue_comment_event_passed))
     response = Rack::Response.new(['Hello'], 200, { 'Content-Type' => 'text/plain' })
+    github_handler = Lita::Handlers::GithubPrList.new robot
+    github_handler.comment_hook(request, response)
+
+    expect(replies.last).to include("@mcwaffle1234 your pull request: Spelling error in the README file has passed DEV REVIEW."\
+                                    " https://github.com/baxterthehacker/public-repo/issues/47"\
+                                    " - You still require DESIGN REVIEW")
+  end
+
+  it "mentions the github user in the room and tell them they passed DESIGN" do
+    expect_any_instance_of(Octokit::Client).to receive(:issue_comments).and_return(issue_comments_passed_design)
 
-    github_handler = Lita::Handlers::GithubPrList.new
+    request = Rack::Request.new("rack.input" => StringIO.new(issue_comment_event_passed_design))
+    response = Rack::Response.new(['Hello'], 200, { 'Content-Type' => 'text/plain' })
+
+    github_handler = Lita::Handlers::GithubPrList.new robot
     github_handler.comment_hook(request, response)
+    expect(replies.last).to include("@mcwaffle1234 your pull request: Spelling error in the README file has passed DESIGN."\
+                                    " https://github.com/baxterthehacker/public-repo/issues/47"\
+                                    " - You still require DEV REVIEW")
+  end
 
+  it "mentions the github user in the room and tell them they passed DESIGN - DEV already passed" do
+    expect_any_instance_of(Octokit::Client).to receive(:issue_comments).and_return(issue_comments_passed_both)
+
+    request = Rack::Request.new("rack.input" => StringIO.new(issue_comment_event_passed_design))
+    response = Rack::Response.new(['Hello'], 200, { 'Content-Type' => 'text/plain' })
+
+    github_handler = Lita::Handlers::GithubPrList.new robot
+    github_handler.comment_hook(request, response)
     expect(replies.last).to include("@mcwaffle1234 your pull request: Spelling error in the README file has passed."\
                                     " https://github.com/baxterthehacker/public-repo/issues/47")
+    expect(replies.last).to_not include(" - You still require DEV REVIEW")
   end
 
+
   it "mentions the github user in the room and tell them they failed" do
+    expect_any_instance_of(Octokit::Client).to receive(:issue_comments).and_return(issue_comments_failed)
     request = Rack::Request.new("rack.input" => StringIO.new(issue_comment_event_failed))
     response = Rack::Response.new(['Hello'], 200, { 'Content-Type' => 'text/plain' })
 
-    github_handler = Lita::Handlers::GithubPrList.new
+    github_handler = Lita::Handlers::GithubPrList.new robot
     github_handler.comment_hook(request, response)
 
     expect(replies.last).to include("@mcwaffle1234 your pull request: Spelling error in the README file has failed."\
@@ -36,10 +89,11 @@ describe Lita::Handlers::GithubPrList, lita_handler: true do
   end
 
   it "mentions the github user in the room and tell them they failed for hankey too" do
+    expect_any_instance_of(Octokit::Client).to receive(:issue_comments).and_return(issue_comments_failed)
     request = Rack::Request.new("rack.input" => StringIO.new(issue_comment_event_failed_hankey))
     response = Rack::Response.new(['Hello'], 200, { 'Content-Type' => 'text/plain' })
 
-    github_handler = Lita::Handlers::GithubPrList.new
+    github_handler = Lita::Handlers::GithubPrList.new robot
     github_handler.comment_hook(request, response)
 
     expect(replies.last).to include("@mcwaffle1234 your pull request: Spelling error in the README file has failed."\
@@ -47,10 +101,12 @@ describe Lita::Handlers::GithubPrList, lita_handler: true do
   end
 
   it "mentions the github user in the room and tell them they are reviewing" do
+    expect_any_instance_of(Octokit::Client).to receive(:issue_comments).and_return(issue_comments_in_review)
+
     request = Rack::Request.new("rack.input" => StringIO.new(issue_comment_event_in_review))
     response = Rack::Response.new(['Hello'], 200, { 'Content-Type' => 'text/plain' })
 
-    github_handler = Lita::Handlers::GithubPrList.new
+    github_handler = Lita::Handlers::GithubPrList.new robot
     github_handler.comment_hook(request, response)
 
     expect(replies.last).to include("@baxterthehacker is currently reviewing: Spelling error in the README file."\
@@ -58,10 +114,11 @@ describe Lita::Handlers::GithubPrList, lita_handler: true do
   end
 
   it "mentions the github user in the room and tell them it has been fixed" do
+    expect_any_instance_of(Octokit::Client).to receive(:issue_comments).and_return(issue_comments_fixed)
     request = Rack::Request.new("rack.input" => StringIO.new(issue_comment_event_fixed))
     response = Rack::Response.new(['Hello'], 200, { 'Content-Type' => 'text/plain' })
 
-    github_handler = Lita::Handlers::GithubPrList.new
+    github_handler = Lita::Handlers::GithubPrList.new robot
     github_handler.comment_hook(request, response)
 
     expect(replies.last).to include("Spelling error in the README file has been fixed:"\

data/spec/lita/handlers/open_pull_request_message_hook_spec.rb

@@ -12,8 +12,7 @@ describe Lita::Handlers::GithubPrList, lita_handler: true do
   it "sends a message to hipchat - pull request opened" do
     request = Rack::Request.new("rack.input" => StringIO.new(open_pull_request_response.first))
     response = Rack::Response.new(['Hello'], 200, {'Content-Type' => 'text/plain'})
-
-    github_handler = Lita::Handlers::GithubPrList.new
+    github_handler = Lita::Handlers::GithubPrList.new robot
     github_handler.pull_request_open_message_hook(request, response)
 
     expect(replies.last).to include("@baxterthehacker opened pull request: 'Update the README with new information' in 'baxterthehacker/public-repo'. https://github.com/baxterthehacker/public-repo/pull/48")

data/spec/lita/handlers/pull_request_spec.rb

@@ -24,7 +24,9 @@ describe Lita::Handlers::GithubPrList, lita_handler: true do
 
   let(:one_issue) { sawyer_resource_array("spec/fixtures/one_org_issue_list.json") }
   let(:two_issues) { sawyer_resource_array("spec/fixtures/two_org_issue_list.json") }
+  let(:three_issues) { sawyer_resource_array("spec/fixtures/three_org_issue_list.json") }
   let(:issue_comments_passed) { sawyer_resource_array("spec/fixtures/issue_comments_passed.json") }
+  let(:issue_comments_passed_design) { sawyer_resource_array("spec/fixtures/issue_comments_passed_design.json") }
   let(:issue_comments_failed) { sawyer_resource_array("spec/fixtures/issue_comments_failed.json") }
   let(:issue_comments_in_review) { sawyer_resource_array("spec/fixtures/issue_comments_in_review.json") }
   let(:issue_comments_fixed) { sawyer_resource_array("spec/fixtures/issue_comments_fixed.json") }
@@ -36,8 +38,8 @@ describe Lita::Handlers::GithubPrList, lita_handler: true do
   it { is_expected.to route_http(:post, "/merge_request_action").to(:merge_request_action) }
 
   it "displays a list of pull requests" do
-    expect_any_instance_of(Octokit::Client).to receive(:org_issues).and_return(two_issues)
-    expect_any_instance_of(Octokit::Client).to receive(:issue_comments).and_return(issue_comments_passed, issue_comments_failed)
+    expect_any_instance_of(Octokit::Client).to receive(:org_issues).and_return(three_issues)
+    expect_any_instance_of(Octokit::Client).to receive(:issue_comments).and_return(issue_comments_passed, issue_comments_failed, issue_comments_passed_design)
 
     send_command("pr list")
 
@@ -45,13 +47,14 @@ describe Lita::Handlers::GithubPrList, lita_handler: true do
   end
 
   it "displays the status of the PR (pass/fail)" do
-    expect_any_instance_of(Octokit::Client).to receive(:org_issues).and_return(two_issues)
-    expect_any_instance_of(Octokit::Client).to receive(:issue_comments).and_return(issue_comments_passed, issue_comments_failed)
+    expect_any_instance_of(Octokit::Client).to receive(:org_issues).and_return(three_issues)
+    expect_any_instance_of(Octokit::Client).to receive(:issue_comments).and_return(issue_comments_passed, issue_comments_failed, issue_comments_passed_design)
 
     send_command("pr list")
 
-    expect(replies.last).to include("waffles (elephant)(elephant)(elephant) Found a bug https://github.com/octocat/Hello-World/pull/1347")
-    expect(replies.last).to include("waffles (poop) Found a waffle https://github.com/octocat/Hello-World/pull/1347")
+    expect(replies.last).to include("waffles (elephant)(art)(art)(art) Found a waffle https://github.com/octocat/Hello-World/pull/1347")
+    expect(replies.last).to include("waffles (elephant)(elephant)(elephant)(art) Found a bug https://github.com/octocat/Hello-World/pull/1347")
+    expect(replies.last).to include("waffles (poop)(elephant)(art) Found a waffle https://github.com/octocat/Hello-World/pull/1347")
   end
 
   it "displays the status of the PR (in review/fixed)" do
@@ -59,9 +62,8 @@ describe Lita::Handlers::GithubPrList, lita_handler: true do
     expect_any_instance_of(Octokit::Client).to receive(:issue_comments).and_return(issue_comments_in_review, issue_comments_fixed)
 
     send_command("pr list")
-
-    expect(replies.last).to include("waffles (book) Found a bug https://github.com/octocat/Hello-World/pull/1347")
-    expect(replies.last).to include("waffles (wave) Found a waffle https://github.com/octocat/Hello-World/pull/1347")
+    expect(replies.last).to include("waffles (book)(elephant)(art) Found a bug https://github.com/octocat/Hello-World/pull/1347")
+    expect(replies.last).to include("waffles (wave)(elephant)(art) Found a waffle https://github.com/octocat/Hello-World/pull/1347")
   end
 
   it "displays the status of the PR (new)" do
@@ -70,7 +72,7 @@ describe Lita::Handlers::GithubPrList, lita_handler: true do
 
     send_command("pr list")
 
-    expect(replies.last).to include("waffles (new) Found a bug https://github.com/octocat/Hello-World/pull/1347")
+    expect(replies.last).to include("waffles (new)(elephant)(art) Found a bug https://github.com/octocat/Hello-World/pull/1347")
   end
 
   it "lists gitlab merge requests" do
@@ -89,7 +91,6 @@ describe Lita::Handlers::GithubPrList, lita_handler: true do
     expect_any_instance_of(Octokit::Client).to receive(:issue_comments).and_return(issue_comments_new)
 
     subject.merge_request_action(gitlab_request_closed, nil)
-
     send_command("pr list")
 
     expect(replies.last).to_not include("rails_envs (new) Fixed the things https://gitlab.corp.ads/ama/rails_envs/merge_requests/99")

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lita-github_pr_list
 version: !ruby/object:Gem::Version
-  version: 0.0.21
+  version: 0.1.0
 platform: ruby
 authors:
 - Michael van den Beuken
@@ -10,121 +10,123 @@ authors:
 - Mathieu Gilbert
 - Ryan Jones
 - Darko Dosenovic
+- Jonathan Weyermann
+- Adam Melnyk
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-20 00:00:00.000000000 Z
+date: 2015-11-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lita
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: octokit
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '3.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '3.0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.6'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.6'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec-instafail
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 description: List open pull requests for an organization.
@@ -135,16 +137,18 @@ email:
 - mathieu.gilbert@ama.ab.ca
 - ryan.michael.jones@gmail.com
 - darko.dosenovic@ama.ab.ca
+- jonathan.weyermann@ama.ab.ca
+- adam.melnyk@ama.ab.ca
 executables:
 - rake
 - rspec
 extensions: []
 extra_rdoc_files: []
 files:
-- ".gitignore"
-- ".hound.yml"
-- ".rspec"
-- ".travis.yml"
+- .gitignore
+- .hound.yml
+- .rspec
+- .travis.yml
 - Gemfile
 - LICENSE
 - README.md
@@ -173,15 +177,19 @@ files:
 - spec/fixtures/issue_comment_event_fixed.json
 - spec/fixtures/issue_comment_event_in_review.json
 - spec/fixtures/issue_comment_event_passed.json
+- spec/fixtures/issue_comment_event_passed_design.json
 - spec/fixtures/issue_comments_failed.json
 - spec/fixtures/issue_comments_fixed.json
 - spec/fixtures/issue_comments_in_review.json
 - spec/fixtures/issue_comments_new.json
 - spec/fixtures/issue_comments_passed.json
+- spec/fixtures/issue_comments_passed_both.json
+- spec/fixtures/issue_comments_passed_design.json
 - spec/fixtures/one_org_issue_list.json
 - spec/fixtures/open_pull_request_response.json
 - spec/fixtures/repository_hooks.json
 - spec/fixtures/repository_list.json
+- spec/fixtures/three_org_issue_list.json
 - spec/fixtures/two_org_issue_list.json
 - spec/fixtures/update_pull_request_response.json
 - spec/lita/handlers/alias_spec.rb
@@ -201,17 +209,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.0
+rubygems_version: 2.0.3
 signing_key: 
 specification_version: 4
 summary: List open pull requests for an organization.
@@ -225,15 +233,19 @@ test_files:
 - spec/fixtures/issue_comment_event_fixed.json
 - spec/fixtures/issue_comment_event_in_review.json
 - spec/fixtures/issue_comment_event_passed.json
+- spec/fixtures/issue_comment_event_passed_design.json
 - spec/fixtures/issue_comments_failed.json
 - spec/fixtures/issue_comments_fixed.json
 - spec/fixtures/issue_comments_in_review.json
 - spec/fixtures/issue_comments_new.json
 - spec/fixtures/issue_comments_passed.json
+- spec/fixtures/issue_comments_passed_both.json
+- spec/fixtures/issue_comments_passed_design.json
 - spec/fixtures/one_org_issue_list.json
 - spec/fixtures/open_pull_request_response.json
 - spec/fixtures/repository_hooks.json
 - spec/fixtures/repository_list.json
+- spec/fixtures/three_org_issue_list.json
 - spec/fixtures/two_org_issue_list.json
 - spec/fixtures/update_pull_request_response.json
 - spec/lita/handlers/alias_spec.rb