lita-github 0.0.13 → 0.0.14

data/spec/unit/lita-github/general_spec.rb

@@ -21,25 +21,40 @@ describe LitaGithub::General do
 
   describe '.opts_parse' do
     it 'should find the valid options' do
-      o = ' private:true team:heckman bacon:always bacon:sometimes'
+      o = %q( private:true team:heckman Bacon:always bacon:sometimes string1:"something here" string2:'something else')
       co = opts_parse(o)
       expect(co).to be_an_instance_of Hash
-      expect(co[:private]).to eql 'true'
-      expect(co[:team]).to eql 'heckman'
+      expect(co.key?(:Bacon)).to be_falsey
+      expect(co.key?(:bacon)).to be_truthy
       expect(co[:bacon]).to eql 'always' # of course it's always
-    end
-  end
-
-  describe '.e_opts_parse' do
-    it 'should find the valid options' do
-      o = %q( private:true team:heckman bacon:always bacon:sometimes string1:"something here" string2:'something else')
-      co = e_opts_parse(o)
-      expect(co).to be_an_instance_of Hash
+      expect(co[:bacon]).to_not eql 'sometimes'
       expect(co[:private]).to eql 'true'
       expect(co[:team]).to eql 'heckman'
-      expect(co[:bacon]).to eql 'always' # of course it's always
       expect(co[:string1]).to eql 'something here'
       expect(co[:string2]).to eql 'something else'
     end
   end
+
+  describe '.to_i_if_numeric' do
+    context 'when value is a number' do
+      subject { to_i_if_numeric('42') }
+      it { should eql 42 }
+    end
+
+    context 'when value is not a number' do
+      let(:val) { 'hello' }
+      subject { to_i_if_numeric(val) }
+      it { should eql val }
+    end
+  end
+
+  describe '.symbolize_opt_key' do
+    it 'should return an Array with the downcased/symblized key' do
+      kv = %w(Hello! ohai)
+      a = symbolize_opt_key(*kv)
+      expect(a).to be_an_instance_of Array
+      expect(a[0]).to eql kv[0].downcase.to_sym
+      expect(a[1]).to eql kv[1]
+    end
+  end
 end

data/spec/unit/lita-github/r_spec.rb

@@ -44,50 +44,6 @@ describe LitaGithub::R do
   describe '::OPT_REGEX' do
     subject { LitaGithub::R::OPT_REGEX }
 
-    context 'it should match' do
-      it 'test:pass' do
-        s = ' test:pass'
-        m = s.scan(subject).flatten.map(&:strip)
-        expect(m).to eql ['test:pass']
-      end
-
-      it 'test7_pass:pAss_test' do
-        s = ' test7_pass:pAss_test'
-        m = s.scan(subject).flatten.map(&:strip)
-        expect(m).to eql ['test7_pass:pAss_test']
-      end
-
-      it 'test:pass bacon:always test:coverage' do
-        s = ' test:pass bacon:always test:coverage'
-        m = s.scan(subject).flatten.map(&:strip)
-        expect(m).to eql ['test:pass', 'bacon:always', 'test:coverage']
-      end
-    end
-
-    context 'it should not match' do
-      it 'test-stuff:fail' do
-        s = ' test-stuff:fail'
-        m = s.scan(subject).flatten
-        expect(m).to be_empty
-      end
-
-      it 'test: fail' do
-        s = ' test: fail'
-        m = s.scan(subject).flatten
-        expect(m).to be_empty
-      end
-
-      it 'test:fail (no leading space)' do
-        s = 'test:fail'
-        m = s.scan(subject).flatten
-        expect(m).to be_empty
-      end
-    end
-  end
-
-  describe '::E_OPT_REGEX' do
-    subject { LitaGithub::R::E_OPT_REGEX }
-
     context 'it should match' do
       it 'test:pass' do
         s = ' test:pass'

data/spec/unit/lita-github/version_spec.rb

@@ -18,23 +18,23 @@ describe LitaGithub do
   describe '::VERSION' do
     subject { LitaGithub::VERSION }
     it { should be_an_instance_of String }
-    it { should match(/\d+\.\d+\.\d+(?:\-[a-zA-Z0-9_\.\-])?/) }
+    it { should match(/\d+\.\d+\.\d+(?:\-[a-zA-Z0-9_\.\-]+)?/) }
   end
 
-  describe '::MAJ' do
-    subject { LitaGithub::MAJ }
+  describe '::MAJOR_VERSION' do
+    subject { LitaGithub::MAJOR_VERSION }
     it { should be_an_instance_of Fixnum }
     it { should be >= 0 }
   end
 
-  describe '::MIN' do
-    subject { LitaGithub::MIN }
+  describe '::MINOR_VERSION' do
+    subject { LitaGithub::MINOR_VERSION }
     it { should be_an_instance_of Fixnum }
     it { should be >= 0 }
   end
 
-  describe '::REV' do
-    subject { LitaGithub::REV }
+  describe '::REVISION' do
+    subject { LitaGithub::REVISION }
     it { should be_an_instance_of Fixnum }
     it { should be >= 0 }
   end

data/spec/unit/lita/handlers/github_issues_spec.rb

@@ -0,0 +1,162 @@
+# -*- coding: UTF-8 -*-
+#
+# Copyright 2014 PagerDuty, Inc.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+require 'spec_helper'
+
+describe Lita::Handlers::GithubIssues, lita_handler: true do
+  # issues_list command routing
+  it { routes_command('gh issues GrapeDuty/lita-test').to(:issues_list) }
+  it { routes_command('gh issues lita-test').to(:issues_list) }
+  it { routes_command('gh issues lita-test key:value keys:"values"').to(:issues_list) }
+  it { routes_command('gh repo issues GrapeDuty/lita-test').to(:issues_list) }
+  it { routes_command('gh repo issues lita-test').to(:issues_list) }
+  it { routes_command('gh repo issues lita-test key:value keys:"values"').to(:issues_list) }
+
+  let(:gh_org) { 'GapeDuty' }
+  let(:gh_repo) { 'lita-test' }
+  let(:github_issues) { Lita::Handlers::GithubIssues.new('robot') }
+
+  describe '.validate_list_opts' do
+    let(:good_opts) { { state: 'open', sort: 'updated', direction: 'asc' } }
+    let(:bad_opts) { Hash.new('sometestval').merge(state: 'shipped', sort: 'most code', direction: 'backwards, yo') }
+    let(:bad_state) { good_opts.merge(state: 'something') }
+    let(:bad_sort) { good_opts.merge(sort: 'something') }
+    let(:bad_direction) { good_opts.merge(direction: 'backwards, yo') }
+    let(:io_header) { "Invalid option(s):\n" }
+
+    context 'when all options are good' do
+      it 'should reply with a string' do
+        expect(github_issues.send(:validate_list_opts, good_opts)).to be_an_instance_of String
+      end
+
+      it 'should reply with empty string' do
+        expect(github_issues.send(:validate_list_opts, good_opts)).to be_empty
+      end
+    end
+
+    context 'when :state is invalid' do
+      it 'should return a string containing a valid error message' do
+        r =  github_issues.send(:validate_list_opts, bad_state)
+        expect(r).to eql "#{io_header}Issues can be one of the following states: 'open', 'closed', or 'all'\n"
+      end
+    end
+
+    context 'when :sort is invalid' do
+      it 'should return a string containing a valid error message' do
+        r =  github_issues.send(:validate_list_opts, bad_sort)
+        expect(r).to eql "#{io_header}Issues can be sorted by one of the following: 'created', 'updated', 'comments'\n"
+      end
+    end
+
+    context 'when :direction is invalid' do
+      it 'should return a string containing a valid error message' do
+        r =  github_issues.send(:validate_list_opts, bad_direction)
+        expect(r).to eql "#{io_header}Issues can be ordered either 'asc' (ascending) or 'desc' (descending)\n"
+      end
+    end
+
+    context 'when the user did EVERYTHING wrong' do
+      it 'should return a string containing all the error messages' do
+        r =  github_issues.send(:validate_list_opts, bad_opts)
+        expect(r).to eql(
+          "#{io_header}Issues can be one of the following states: 'open', 'closed', or 'all'\n" \
+          "Issues can be sorted by one of the following: 'created', 'updated', 'comments'\n" \
+          "Issues can be ordered either 'asc' (ascending) or 'desc' (descending)\n"
+        )
+      end
+    end
+  end
+
+  describe '.issues_list' do
+    before do
+      issues = [
+        {
+          number: 42, title: 'XYXYXYXY', html_url: 'https://github.com/GrapeDuty/lita-test/issues/42',
+          user: { login: 'theckman' }
+        },
+        {
+          number: 84, title: 'YZYZYZYZ', html_url: 'https://github.com/GrapeDuty/lita-test/issues/84',
+          user: { login: 'theckman' }
+        },
+        {
+          number: 99, title: 'NO', html_url: 'https://github.com/GrapeDuty/lita-test/issues/99',
+          user: { login: 'theckman' }, pull_request: {}
+        }
+      ]
+      @octo_obj = double('Octokit::Client', list_issues: issues)
+      allow(github_issues).to receive(:octo).and_return(@octo_obj)
+      allow(github_issues).to receive(:repo?).and_return(true)
+      allow(github_issues).to receive(:validate_list_opts).and_return('')
+    end
+
+    context 'when all goes well' do
+      it 'should reply with the list of issues' do
+        send_command('gh issues GrapeDuty/lita-test')
+        r = replies.last
+        expect(r).to eql "Showing 2 issue(s) for GrapeDuty/lita-test
+GrapeDuty/lita-test #42: 'XYXYXYXY' opened by theckman :: https://github.com/GrapeDuty/lita-test/issues/42
+GrapeDuty/lita-test #84: 'YZYZYZYZ' opened by theckman :: https://github.com/GrapeDuty/lita-test/issues/84
+"
+      end
+    end
+
+    context 'when there are no issues' do
+      before { allow(@octo_obj).to receive(:list_issues).and_return([]) }
+
+      it 'should return message indicating no issues' do
+        send_command('gh issues GrapeDuty/lita-test')
+        expect(replies.last).to eql 'There are no open issues for GrapeDuty/lita-test'
+      end
+    end
+
+    context 'when there is an option that fails validation' do
+      before { allow(github_issues).to receive(:validate_list_opts).and_return('sadpanda') }
+
+      it 'should reply with the response from .validate_list_opts' do
+        send_command('gh issues GrapeDuty/lita-test')
+        expect(replies.last).to eql 'sadpanda'
+      end
+    end
+
+    context 'when the repo is not found' do
+      before { allow(github_issues).to receive(:repo?).and_return(false) }
+
+      it 'should reply with response indicating repo not found' do
+        send_command('gh issues GrapeDuty/lita-test')
+        expect(replies.last).to eql 'That repo (GrapeDuty/lita-test) was not found'
+      end
+    end
+
+    context 'when an option passes validation, but fails from GitHub' do
+      before { allow(@octo_obj).to receive(:list_issues).and_raise(Octokit::UnprocessableEntity.new) }
+
+      it 'should reply indicating an issue was hit and include the exception message' do
+        send_command('gh issues GrapeDuty/lita-test')
+        expect(replies.last).to eql "An invalid option was provided, here's the error from Octokit:
+Octokit::UnprocessableEntity"
+      end
+    end
+
+    context 'when there is a general error when calling GitHub' do
+      before { allow(@octo_obj).to receive(:list_issues).and_raise(StandardError.new) }
+
+      it 'should reply indicating an issue was hit and include the exception message' do
+        send_command('gh issues GrapeDuty/lita-test')
+        expect(replies.last).to eql 'I had a problem :( ... StandardError'
+      end
+    end
+  end
+end

data/spec/unit/lita/handlers/github_org_spec.rb

@@ -29,7 +29,30 @@ describe Lita::Handlers::GithubOrg, lita_handler: true do
   it { routes_command('gh org team add GrapeDuty name:"All Staff" perms:pull').to(:org_team_add) }
   it { routes_command('gh org team add name:"All Staff" perms:pull').to(:org_team_add) }
 
+  # org_team_rm routing
+  it { routes_command('gh org team rm GrapeDuty ops').to(:org_team_rm) }
+  it { routes_command('gh org team rm GrapeDuty 42').to(:org_team_rm) }
+  it { routes_command('gh org team rm ops').to(:org_team_rm) }
+  it { routes_command('gh org team rm 42').to(:org_team_rm) }
+
+  # org_user_add routing
+  it { routes_command('gh org user add GrapeDuty heckmantest theckman').to(:org_user_add) }
+  it { routes_command('gh org user add heckmantest theckman').to(:org_user_add) }
+  it { routes_command('gh org user add GrapeDuty 42 theckman').to(:org_user_add) }
+  it { routes_command('gh org user add 42 theckman').to(:org_user_add) }
+
+  # org_user_rm routing
+  it { routes_command('gh org user rm GrapeDuty heckmantest theckman').to(:org_user_rm) }
+  it { routes_command('gh org user rm heckmantest theckman').to(:org_user_rm) }
+  it { routes_command('gh org user rm GrapeDuty 42 theckman').to(:org_user_rm) }
+  it { routes_command('gh org user rm 42 theckman').to(:org_user_rm) }
+
+  # org_eject_user routing
+  it { routes_command('gh org eject GrapeDuty theckman').to(:org_eject_user) }
+  it { routes_command('gh org eject theckman').to(:org_eject_user) }
+
   let(:github_org) { Lita::Handlers::GithubOrg.new('robot') }
+  let(:disabled_err) { 'Sorry, this function has either been disabled or not enabled in the config' }
 
   ####
   # Helper Methods
@@ -165,7 +188,7 @@ Name: HeckmanTest, Slug: heckmantest, ID: 42, Perms: push
 
       it 'should return the method disabled error' do
         send_command('gh org team add GrapeDuty name:"HeckmanTest" perms:pull')
-        expect(replies.last).to eql 'Sorry, this function has either been disabled or not enabled in the config'
+        expect(replies.last).to eql disabled_err
       end
     end
 
@@ -226,7 +249,7 @@ Missing the perms option
 
       it 'should return the method disabled error' do
         send_command('gh org team rm GrapeDuty 42')
-        expect(replies.last).to eql 'Sorry, this function has either been disabled or not enabled in the config'
+        expect(replies.last).to eql disabled_err
       end
     end
 
@@ -249,4 +272,238 @@ Missing the perms option
       end
     end
   end
+
+  describe '.org_eject_user' do
+    before do
+      @self_user = {
+        name: 'OfficerURL',
+        login: 'OfficerURL',
+        id: 8_525_060
+      }
+      @t_user = {
+        name: 'Tim Heckman',
+        login: 'theckman',
+        id: 787_332
+      }
+      @octo_obj = double('Octokit::Client', remove_organization_member: true)
+      @conf_obj = double('Lita::Config', default_org: 'GrapeDuty')
+      allow(@octo_obj).to receive(:user).with(no_args).and_return(@self_user)
+      allow(@octo_obj).to receive(:user).with('theckman').and_return(@t_user)
+      allow(github_org).to receive(:func_disabled?).and_return(false)
+      allow(github_org).to receive(:octo).and_return(@octo_obj)
+      allow(github_org).to receive(:cofig).and_return(@conf_obj)
+    end
+
+    context 'when all goes well' do
+      it 'should reply that the user was ejected' do
+        send_command('gh org eject GrapeDuty theckman')
+        expect(replies.last).to eql 'Ejected theckman out of GrapeDuty'
+      end
+    end
+
+    context 'when the method is disabled' do
+      before { allow(github_org).to receive(:func_disabled?).and_return(true) }
+
+      it 'should return the method disabled error' do
+        send_command('gh org eject GrapeDuty theckman')
+        expect(replies.last).to eql disabled_err
+      end
+    end
+
+    context 'when the user is the same user' do
+      before { allow(@octo_obj).to receive(:user).with('OfficerURL').and_return(@self_user) }
+
+      it 'should return the gtfo error message' do
+        send_command('gh org eject GrapeDuty OfficerURL')
+        expect(replies.last).to eql "No...\n\nಠ_ಠ"
+      end
+    end
+
+    context 'when the user is not found' do
+      before { allow(@octo_obj).to receive(:user).with('theckman').and_raise(Octokit::NotFound.new) }
+
+      it 'should reply with the user not found message' do
+        send_command('gh org eject GrapeDuty theckman')
+        expect(replies.last).to eql 'Unable to find the GitHub user theckman'
+      end
+    end
+
+    context 'when the Octokit client call bombs' do
+      before { allow(@octo_obj).to receive(:remove_organization_member).and_raise(Octokit::NotFound.new) }
+
+      it 'should return the *boom* error' do
+        send_command('gh org eject GrapeDuty theckman')
+        expect(replies.last).to eql 'I had a problem :( ... Octokit::NotFound'
+      end
+    end
+
+    context 'when the action fails' do
+      before { allow(@octo_obj).to receive(:remove_organization_member).and_return(false) }
+
+      it 'should respond with the failure message' do
+        send_command('gh org eject GrapeDuty theckman')
+        expect(replies.last).to eql 'Failed to eject the user from the organization for an unknown reason'
+      end
+    end
+  end
+
+  describe '.org_user_add' do
+    before do
+      @self_user = {
+        name: 'OfficerURL',
+        login: 'OfficerURL',
+        id: 8_525_060
+      }
+      @t_user = {
+        name: 'Tim Heckman',
+        login: 'theckman',
+        id: 787_332
+      }
+      @team = {
+        name: 'HeckmanTest',
+        id: 42,
+        slug: 'heckmantest'
+      }
+      @octo_obj = double('Octokit::Client', team: @team, add_team_membership: true)
+      @conf_obj = double('Lita::Config', default_org: 'GrapeDuty')
+      allow(@octo_obj).to receive(:user).with(no_args).and_return(@self_user)
+      allow(@octo_obj).to receive(:user).with('theckman').and_return(@t_user)
+      allow(github_org).to receive(:func_disabled?).and_return(false)
+      allow(github_org).to receive(:octo).and_return(@octo_obj)
+      allow(github_org).to receive(:cofig).and_return(@conf_obj)
+      allow(github_org).to receive(:team_id).and_return(42)
+    end
+
+    context 'when all goes well' do
+      it 'should respond with a successful add' do
+        send_command('gh org user add GrapeDuty heckmantest theckman')
+        expect(replies.last).to eql "theckman has been added to the 'GrapeDuty/HeckmanTest' (heckmantest) team"
+      end
+    end
+
+    context 'when the method is disabled' do
+      before { allow(github_org).to receive(:func_disabled?).and_return(true) }
+
+      it 'should return the method disabled error' do
+        send_command('gh org user add GrapeDuty heckmantest theckman')
+        expect(replies.last).to eql disabled_err
+      end
+    end
+
+    context 'when the user is the same user' do
+      before { allow(@octo_obj).to receive(:user).with('OfficerURL').and_return(@self_user) }
+
+      it 'should return the gtfo error message' do
+        send_command('gh org user add GrapeDuty heckmantest OfficerURL')
+        expect(replies.last).to eql "No...\n\nಠ_ಠ"
+      end
+    end
+
+    context 'when the user is not found' do
+      before { allow(@octo_obj).to receive(:user).with('theckman').and_raise(Octokit::NotFound.new) }
+
+      it 'should reply with the user not found message' do
+        send_command('gh org user add GrapeDuty heckmantest theckman')
+        expect(replies.last).to eql 'Unable to find the GitHub user theckman'
+      end
+    end
+
+    context 'when the team is not found' do
+      before { allow(@octo_obj).to receive(:team).with(42).and_raise(Octokit::NotFound.new) }
+
+      it 'should reply with the team not found message' do
+        send_command('gh org user add GrapeDuty heckmantest theckman')
+        expect(replies.last).to eql 'Unable to match any teams based on: heckmantest'
+      end
+    end
+
+    context 'when an error is hit adding the team membership' do
+      before { allow(@octo_obj).to receive(:add_team_membership).with(42, 'theckman').and_raise(StandardError.new) }
+
+      it 'should reply with the *boom* message' do
+        send_command('gh org user add GrapeDuty heckmantest theckman')
+        expect(replies.last).to eql 'I had a problem :( ... StandardError'
+      end
+    end
+  end
+
+  describe '.org_user_rm' do
+    before do
+      @self_user = {
+        name: 'OfficerURL',
+        login: 'OfficerURL',
+        id: 8_525_060
+      }
+      @t_user = {
+        name: 'Tim Heckman',
+        login: 'theckman',
+        id: 787_332
+      }
+      @team = {
+        name: 'HeckmanTest',
+        id: 42,
+        slug: 'heckmantest'
+      }
+      @octo_obj = double('Octokit::Client', team: @team, remove_team_member: true)
+      @conf_obj = double('Lita::Config', default_org: 'GrapeDuty')
+      allow(@octo_obj).to receive(:user).with(no_args).and_return(@self_user)
+      allow(@octo_obj).to receive(:user).with('theckman').and_return(@t_user)
+      allow(github_org).to receive(:func_disabled?).and_return(false)
+      allow(github_org).to receive(:octo).and_return(@octo_obj)
+      allow(github_org).to receive(:cofig).and_return(@conf_obj)
+      allow(github_org).to receive(:team_id).and_return(42)
+    end
+
+    context 'when all goes well' do
+      it 'should respond with a successful removal' do
+        send_command('gh org user rm GrapeDuty heckmantest theckman')
+        expect(replies.last).to eql "theckman has been removed from the 'GrapeDuty/HeckmanTest' (heckmantest) team"
+      end
+    end
+
+    context 'when the method is disabled' do
+      before { allow(github_org).to receive(:func_disabled?).and_return(true) }
+
+      it 'should return the method disabled error' do
+        send_command('gh org user rm GrapeDuty heckmantest theckman')
+        expect(replies.last).to eql disabled_err
+      end
+    end
+
+    context 'when the user is the same user' do
+      before { allow(@octo_obj).to receive(:user).with('OfficerURL').and_return(@self_user) }
+
+      it 'should return the gtfo error message' do
+        send_command('gh org user rm GrapeDuty heckmantest OfficerURL')
+        expect(replies.last).to eql "No...\n\nಠ_ಠ"
+      end
+    end
+
+    context 'when the user is not found' do
+      before { allow(@octo_obj).to receive(:user).with('theckman').and_raise(Octokit::NotFound.new) }
+
+      it 'should reply with the user not found message' do
+        send_command('gh org user rm GrapeDuty heckmantest theckman')
+        expect(replies.last).to eql 'Unable to find the GitHub user theckman'
+      end
+    end
+
+    context 'when the team is not found' do
+      before { allow(@octo_obj).to receive(:team).with(42).and_raise(Octokit::NotFound.new) }
+
+      it 'should reply with the team not found message' do
+        send_command('gh org user rm GrapeDuty heckmantest theckman')
+        expect(replies.last).to eql 'Unable to match any teams based on: heckmantest'
+      end
+    end
+
+    context 'when an error is hit adding the team membership' do
+      before { allow(@octo_obj).to receive(:remove_team_member).with(42, 'theckman').and_raise(StandardError.new) }
+
+      it 'should reply with the *boom* message' do
+        send_command('gh org user rm GrapeDuty heckmantest theckman')
+        expect(replies.last).to eql 'I had a problem :( ... StandardError'
+      end
+    end
+  end
 end