lita-github-pinger 0.6.6 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 662aea59222ac24d19a2b402c3e7710b02637c7e
-  data.tar.gz: 8afb238ddbd88bc03b0a1305f820967c78ed70e7
+SHA256:
+  metadata.gz: 4219c3fba527d10c59902d567b84ac3bf900cd90f34c5f41b85e3fc31263e5bb
+  data.tar.gz: 0bfe1ff5bb95fbb56a57fb0c6ea3135d2b2478b3d5b3ea5ef2c437374f38b053
 SHA512:
-  metadata.gz: 42300f8b34f2b20cca88fe68dcbdc0272b8d5b47bb44270b8325c71b37c8ee8152836bcbd20684c9a651c664f242d536d64d81fd58aca18dbd33665244c4a8a5
-  data.tar.gz: edfd401bf6276d7982bc3319b2130ccfaf65a72fe1bddb98b23a6f78d8daf168d128b97b42e5e4aae3a3490097774aec27e6bf60c79d76398122f7898f349759
+  metadata.gz: 92c0fb731b72c6463737c081e31398cf207677d85361ec8fb8367e9daa0c764e46faa9db48713e9734b5177dcaa3205a1af94cc1eb368a5947cb9666bf014ea6
+  data.tar.gz: 7a34c368801fd5cec786ba2c9e94190eb84930a5f399ac21078485adc9e39f9512074fa036833a91006dd02933444760a74e09cb053237fda3716e4fc69ae1a7

data/lib/lita/handlers/github_pinger.rb

@@ -1,5 +1,7 @@
 module Lita
   module Handlers
+    RR_REDIS_KEY = 'lita-github-pinger:roundrobin'.freeze
+
     class GithubPinger < Handler
 
       ####
@@ -54,6 +56,10 @@ module Lita
           act_on_assign(body, response)
         end
 
+        if body["state"] && body["state"] == "opened"
+          act_on_pr_opened(body, response)
+        end
+
         if body["state"] && body["state"] == "success"
           act_on_build_success(body, response)
         end
@@ -92,13 +98,23 @@ module Lita
       end
 
       def act_on_assign(body, response)
-        puts "Detected that someone got assigned to a pull request."
-        assignee = find_engineer(github: body["pull_request"]["assignee"]["login"])
+        type = detect_type(body)
+
+        if type.nil?
+          puts 'Neither pull request or issue detected, exiting...'
+          return
+        end
+
+        puts "Detected that someone got assigned to a #{type.tr('_', ' ')}."
+
+        assignee_login = body[type]['assignee']['login']
+        assignee = find_engineer(github: assignee_login)
 
         puts "#{assignee} determined as the assignee."
 
-        pr_url   = body["pull_request"]["html_url"]
-        message = "*Heads up!* You've been assigned to review a pull request:\n#{pr_url}"
+        url = body[type]['html_url']
+
+        message = "*Heads up!* You've been assigned to review a #{type.tr('_', ' ')}:\n#{url}"
 
         puts "Sending DM to #{assignee}..."
         send_dm(assignee[:usernames][:slack], message)
@@ -106,6 +122,47 @@ module Lita
         response
       end
 
+      def act_on_pr_opened(body, response)
+        puts "Detected that someone opened a #{type.tr('_', ' ')}."
+        if type.nil?
+          puts 'Neither pull request or issue detected, exiting...'
+          return
+        end
+
+        if config.enable_round_robin
+          puts "round robin is enabled, selecting the next engineer.."
+
+          chosen_reviewer = redis.get(RR_REDIS_KEY)
+          engineers_with_rr_enabled = config.engineers.values.select { |eng| eng[:enable_round_robin] }
+
+          if chosen_reviewer.nil?
+            chosen_reviewer = engineers_with_rr_enabled[0][:usernames][:slack]
+          end
+
+          current_reviewer_index = engineers_with_rr_enabled.find_index do |eng|
+            eng[:usernames][:slack] == chosen_reviewer
+          end
+
+          next_reviewer_index = (current_reviewer_index + 1) % engineers_with_rr_enabled.length
+          next_reviewer = engineers_with_rr_enabled[next_reviewer_index][:usernames][:slack]
+
+          puts "#{chosen_reviewer} determined as the reviewer."
+          puts "#{next_reviewer} determined as the next reviewer"
+
+          puts "storing #{next_reviewer} in redis..."
+          redis.set(RR_REDIS_KEY, next_reviewer)
+
+          url = body[type]['html_url']
+
+          message = "You're next in line to review a PR! Please review, or assign to an engineer with more context if you think you are unable to give a thorough review. \n#{url}"
+
+          puts "Sending DM to #{chosen_reviewer}..."
+          send_dm(chosen_reviewer, message)
+
+          response
+        end
+      end
+
       def act_on_comment(body, response)
         puts "Detected a comment. Extracting data... "
 
@@ -212,6 +269,14 @@ module Lita
           alert_eng_pr("Could not find user with name #{username}, please configure everbot.")
         end
       end
+
+      def detect_type(body)
+        if body['pull_request']
+          'pull_request'
+        elsif body['issue']
+          'issue'
+        end
+      end
     end
 
     Lita.register_handler(GithubPinger)

data/lita-github-pinger.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = "lita-github-pinger"
-  spec.version       = "0.6.6"
+  spec.version       = "0.7.0"
   spec.authors       = ["Taylor Lapeyre"]
   spec.email         = ["taylorlapeyre@gmail.com"]
   spec.description   = "A Lita handler that detects github comment notifications and regurgitates a ping to the correct slack username."

data/spec/lita/handlers/github_pinger_spec.rb

@@ -1,15 +1,16 @@
 require "spec_helper"
-
-# This file is out of date and will be fixed soon
+require "json"
 
 describe Lita::Handlers::GithubPinger, lita_handler: true do
   before do
-    registry.config.handlers.github_pinger.engineers = [
-      {
-        slack: "taylor",
-        github: "taylorlapeyre"
-      },
-    ]
+    registry.config.handlers.github_pinger.engineers = {
+      'Taylor' => {
+        usernames: {
+          slack: 'taylor',
+          github: 'taylorlapeyre'
+        }
+      }
+    }
   end
 
   it "will respond" do
@@ -21,4 +22,47 @@ describe Lita::Handlers::GithubPinger, lita_handler: true do
     response = http.post("/ghping", '{"hello": "world", "events": ["pull_request_review_comment"]}')
     expect(response.body).to_not be_nil
   end
+
+  describe 'act on assign' do
+    before do
+      Lita::Room.create_or_update(1, name: 'eng-pr')
+      Lita::User.create(1, name: 'taylorlapeyre')
+    end
+
+    context 'pull request' do
+      it 'sends direct message' do
+        fake_json_request = {
+          action: 'assigned',
+          pull_request: {
+            assignee: {
+              login: 'taylorlapeyre'
+            }
+          }
+        }.to_json
+
+        response = http.post('/ghping', fake_json_request)
+
+        expect(replies.first).to match("You've been assigned to review a pull request")
+        expect(response.status).to eq(200)
+      end
+    end
+
+    context 'issue' do
+      it 'sends direct message' do
+        fake_json_request = {
+          action: 'assigned',
+          issue: {
+            assignee: {
+                login: 'taylorlapeyre'
+            }
+          }
+        }.to_json
+
+        response = http.post('/ghping', fake_json_request)
+
+        expect(replies.first).to match("You've been assigned to review a issue")
+        expect(response.status).to eq(200)
+      end
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lita-github-pinger
 version: !ruby/object:Gem::Version
-  version: 0.6.6
+  version: 0.7.0
 platform: ruby
 authors:
 - Taylor Lapeyre
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-18 00:00:00.000000000 Z
+date: 2018-05-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lita
@@ -134,7 +134,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: A Lita handler that detects github comment notifications and regurgitates