lita-github-pinger 0.4.7 → 0.4.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3881550e0e010490d7e8bb65230f550bc496b0d9
-  data.tar.gz: e0918ccf2c3de04898640fc82efec446bd24e4d7
+  metadata.gz: c9a67b40aebdeb0cbae576e8296372045398781a
+  data.tar.gz: d3876e419ef7b89c484b816fdaa69947ab305798
 SHA512:
-  metadata.gz: 235893973dc19de4627bf66b17a875e7a6ce6d989233f73bd1cf1b79841a9d43b3d25943108b171306c0c5b30b1e27be79469346c57042941ad4ed1d8f544098
-  data.tar.gz: ddf57b7532389122ab973e1d6269545f20153141a48edf98a84b88981f2bf3750a1c862ec6bcc73fa0e4a386ca32076dca2dc9156ee89f8148f1908cdb369145
+  metadata.gz: c16766a54c0d03486eaba195ee8d8b8107c9a3b7a7498db7b5c936cafb449d8fcf50d4e3b4dc7feecd68a6b78afd49bec125ffe69bdf6dc4c61700add8c29d70
+  data.tar.gz: 353f04a1c4bed25bf0856ce3f487a657e3e4d2dbabcf15d3754d733b9571162beda7f90a5a1167cf983253d81e15eba3a289bc59cb12bf412b899bf8af3efb94

data/lib/lita/handlers/github_pinger.rb

@@ -2,79 +2,128 @@ module Lita
   module Handlers
     class GithubPinger < Handler
 
+      ####
+      # ENGINEER NOTIFICATION PREFERENCES
+      ####
+
+      # example entry: {
+      #   :slack         => "taylor"
+      #   :github        => "taylorlapeyre"
+      #   :frequency     => "only_mentions"
+      #   :ping_location => "dm"
+      #}
+      #
+      # :ping_location can be...
+      #  - "dm"
+      #  - "eng-pr" (pings you in #eng-pr)
+      #  default: "dm"
+      #
+      # :frequency can be
+      #  - "all_discussion" (pings you about any comments on your PRs and @mentions)
+      #  - "only_mentions" (will only ping you when you are explicitly @mentioned)
+      #  - "off"
+      #  default: "all_discussion"
       config :engineers, type: Array, required: true
 
       http.post("/ghping", :ghping)
 
       def ghping(request, response)
         puts "########## New GH PR Event! ##########"
-
         body = MultiJson.load(request.body)
+
         if body["comment"]
-          puts "Detected a comment. Extracting data... "
+          act_on_comment(body, response)
+        end
 
-          comment_url = body["comment"]["html_url"]
-          comment     = body["comment"]["body"]
-          context     = body["pull_request"] || body["issue"]
+        if body["action"] && body["action"] == "assigned"
+          act_on_assign(body, response)
+        end
+      end
 
-          commenter = find_engineer(github: body["comment"]["user"]["login"])
-          pr_owner  = find_engineer(github: context["user"]["login"])
+      def act_on_assign(body, response)
+        puts "Detected that someone got assigned to a pull request."
+        assignee = find_engineer(github: body["pull_request"]["assignee"])
+        assigner = find_engineer(github: body["pull_request"]["user"]["login"])
 
-          puts "Reacting to PR comment #{comment_url}"
-          puts "Found commenter #{commenter}"
-          puts "Found pr owner #{pr_owner}"
+        puts "#{assignee} determined as the assignee."
+        puts "#{assigner} determined as assigner."
 
-          engineers_to_ping = []
-          # automatically include the creator of the PR, unless he's
-          # commenting on his own PR
+        pr_url   = body["pull_request"]["html_url"]
+        message = "*Heads up!* #{pr_owner[:slack]} has assigned you to review their pull request:\n#{pr_url}"
 
-          if commenter != pr_owner && ["all_discussion", nil].include?(pr_owner[:frequency])
-            puts "PR owner was not the commenter, and has a :frequency of 'all_discussion' or nil"
-            puts "Therefore, adding the PR owner to list of engineers to ping."
-            engineers_to_ping << pr_owner
-          end
+        puts "Sending DM to #{assignee}..."
+        send_dm(assignee[:slack], message)
 
-          # Is anyone mentioned in this comment?
-          if comment.include?("@")
-            puts "Found @mentions in the body of the comment! Extracting usernames... "
+        response
+      end
 
-            # get each @mentioned engineer in the comment
-            mentions = comment.split("@")[1..-1].map { |snip| snip.split(" ").first }
+      def act_on_comment(request, response)
+        puts "Detected a comment. Extracting data... "
 
-            puts "Done. Got #{mentions}"
-            puts "Converting usernames to engineers..."
+        comment_url = body["comment"]["html_url"]
+        comment     = body["comment"]["body"]
+        context     = body["pull_request"] || body["issue"]
 
-            mentioned_engineers = mentions.map { |username| find_engineer(github: username) }
+        commenter = find_engineer(github: body["comment"]["user"]["login"])
+        pr_owner  = find_engineer(github: context["user"]["login"])
 
-            puts "Done. Got #{mentioned_engineers}"
+        puts "Reacting to PR comment #{comment_url}"
+        puts "Found commenter #{commenter}"
+        puts "Found pr owner #{pr_owner}"
 
-            # add them to the list of usernames to ping
-            engineers_to_ping = engineers_to_ping.concat(mentioned_engineers).uniq.compact
-          end
+        # Sanity Checks - might be a new engineer around that hasn't set up
+        # their config.
 
-          puts "New list of engineers to ping: #{engineers_to_ping}."
-          puts "Starting pinging process for each engineer..."
-          engineers_to_ping.each do |engineer|
-            puts "looking at #{engineer}'s preferences..'"
-            next if engineer[:frequency] == "off"
-
-            case engineer[:ping_location]
-            when "dm", nil
-              puts "Preference was either 'dm' or nil, so sending DM."
-              private_message  = "New PR comment from @#{commenter[:slack]}:\n"
-              private_message += "#{comment_url}\n#{comment}"
-              send_dm(engineer[:slack], private_message)
-            when "eng-pr", "eng_pr"
-              puts "Preference was either 'eng-pr' or 'eng_pr', so alerting #eng-pr."
-              public_message  = "@#{engineer[:slack]}, new PR mention: "
-              public_message += "#{comment_url}\n#{comment}"
-              alert_eng_pr(public_message)
-            end
-          end
+        engineers_to_ping = []
+        # automatically include the creator of the PR, unless he's
+        # commenting on his own PR
 
-          puts "GitHub Hook successfully processed."
+        if commenter != pr_owner && ["all_discussion", nil].include?(pr_owner[:frequency])
+          puts "PR owner was not the commenter, and has a :frequency of 'all_discussion' or nil"
+          puts "Therefore, adding the PR owner to list of engineers to ping."
+          engineers_to_ping << pr_owner
         end
 
+        # Is anyone mentioned in this comment?
+        if comment.include?("@")
+          puts "Found @mentions in the body of the comment! Extracting usernames... "
+
+          # get each @mentioned engineer in the comment
+          mentions = comment.split("@")[1..-1].map { |snip| snip.split(" ").first }
+
+          puts "Done. Got #{mentions}"
+          puts "Converting usernames to engineers..."
+
+          mentioned_engineers = mentions.map { |username| find_engineer(github: username) }
+
+          puts "Done. Got #{mentioned_engineers}"
+
+          # add them to the list of usernames to ping
+          engineers_to_ping = engineers_to_ping.concat(mentioned_engineers).uniq.compact
+        end
+
+        puts "New list of engineers to ping: #{engineers_to_ping}."
+        puts "Starting pinging process for each engineer..."
+        engineers_to_ping.each do |engineer|
+          puts "looking at #{engineer}'s preferences..'"
+          next if engineer[:frequency] == "off"
+
+          case engineer[:ping_location]
+          when "dm", nil
+            puts "Preference was either 'dm' or nil, so sending DM."
+            private_message  = "New PR comment from @#{commenter[:slack]}:\n"
+            private_message += "#{comment_url}\n#{comment}"
+            send_dm(engineer[:slack], private_message)
+          when "eng-pr", "eng_pr"
+            puts "Preference was either 'eng-pr' or 'eng_pr', so alerting #eng-pr."
+            public_message  = "@#{engineer[:slack]}, new PR mention: "
+            public_message += "#{comment_url}\n#{comment}"
+            alert_eng_pr(public_message)
+          end
+        end
+
+        puts "GitHub Hook successfully processed."
+
         response
       end
 

data/lita-github-pinger.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = "lita-github-pinger"
-  spec.version       = "0.4.7"
+  spec.version       = "0.4.8"
   spec.authors       = ["Taylor Lapeyre"]
   spec.email         = ["taylorlapeyre@gmail.com"]
   spec.description   = "A Lita handler that detects github comment notifications and regurgitates a ping to the correct slack username."

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lita-github-pinger
 version: !ruby/object:Gem::Version
-  version: 0.4.7
+  version: 0.4.8
 platform: ruby
 authors:
 - Taylor Lapeyre
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-08-11 00:00:00.000000000 Z
+date: 2015-08-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lita