lita-github-pinger 0.4.6 → 0.4.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ee333fa793da79fbf68506127e4453e9a4c25614
-  data.tar.gz: d7070b91880ed8225c9c21e4801f72da0e3075bb
+  metadata.gz: 3881550e0e010490d7e8bb65230f550bc496b0d9
+  data.tar.gz: e0918ccf2c3de04898640fc82efec446bd24e4d7
 SHA512:
-  metadata.gz: cbb4e43c5c0b9d26f9a6a456d8dfbac360970885fec086eec941d277eef14d283717f67d687ff70c3aa0ee0bed8c3e770643d2215ecedd6f3ba82b9bc9baac09
-  data.tar.gz: b2324a92932621300555c55d1d854468a7c8e34dffc5fde981ba181698b41b902c7b7ee5d9ae80f9d07091c01a971cf3735b88ddc6b89b1e3d7e58eddc48c871
+  metadata.gz: 235893973dc19de4627bf66b17a875e7a6ce6d989233f73bd1cf1b79841a9d43b3d25943108b171306c0c5b30b1e27be79469346c57042941ad4ed1d8f544098
+  data.tar.gz: ddf57b7532389122ab973e1d6269545f20153141a48edf98a84b88981f2bf3750a1c862ec6bcc73fa0e4a386ca32076dca2dc9156ee89f8148f1908cdb369145

data/lib/lita/handlers/github_pinger.rb

@@ -7,75 +7,69 @@ module Lita
       http.post("/ghping", :ghping)
 
       def ghping(request, response)
-
         puts "########## New GH PR Event! ##########"
-        body = MultiJson.load(request.body)
 
+        body = MultiJson.load(request.body)
         if body["comment"]
           puts "Detected a comment. Extracting data... "
 
-          thing     = body["pull_request"] || body["issue"]
-          pr_url    = thing["html_url"]
-          comment   = body["comment"]["body"]
-          commenter = body["comment"]["user"]["login"]
-          pr_owner  = thing["user"]["login"]
+          comment_url = body["comment"]["html_url"]
+          comment     = body["comment"]["body"]
+          context     = body["pull_request"] || body["issue"]
+
+          commenter = find_engineer(github: body["comment"]["user"]["login"])
+          pr_owner  = find_engineer(github: context["user"]["login"])
 
-          puts "Found PR #{pr_url}"
+          puts "Reacting to PR comment #{comment_url}"
           puts "Found commenter #{commenter}"
           puts "Found pr owner #{pr_owner}"
 
-          usernames_to_ping = []
+          engineers_to_ping = []
           # automatically include the creator of the PR, unless he's
           # commenting on his own PR
-          if commenter != pr_owner
-            puts "Commenter is not the pr owner. Adding to list of usernames to ping."
-            usernames_to_ping << pr_owner
-          end
 
-          puts "So far, github usernames to ping: #{usernames_to_ping}"
+          if commenter != pr_owner && ["all_discussion", nil].include?(pr_owner[:frequency])
+            puts "PR owner was not the commenter, and has a :frequency of 'all_discussion' or nil"
+            puts "Therefore, adding the PR owner to list of engineers to ping."
+            engineers_to_ping << pr_owner
+          end
 
           # Is anyone mentioned in this comment?
           if comment.include?("@")
             puts "Found @mentions in the body of the comment! Extracting usernames... "
 
-            # get each @mentioned username in the comment
+            # get each @mentioned engineer in the comment
             mentions = comment.split("@")[1..-1].map { |snip| snip.split(" ").first }
-            puts "Done. (Got #{mentions})"
 
-            # add them to the list of usernames to ping
-            usernames_to_ping = usernames_to_ping.concat(mentions).uniq
-          end
+            puts "Done. Got #{mentions}"
+            puts "Converting usernames to engineers..."
 
-          puts "New list of github usernames to ping: #{usernames_to_ping}."
-          puts "Converting github usernames to slack usernames... "
+            mentioned_engineers = mentions.map { |username| find_engineer(github: username) }
 
-          # slackify all of the users
-          usernames_to_ping.map! { |user| github_to_slack_username(user) }
+            puts "Done. Got #{mentioned_engineers}"
 
-          puts "Done. (Got #{usernames_to_ping})"
+            # add them to the list of usernames to ping
+            engineers_to_ping = engineers_to_ping.concat(mentioned_engineers).uniq.compact
+          end
 
+          puts "New list of engineers to ping: #{engineers_to_ping}."
           puts "Starting pinging process for each engineer..."
-          usernames_to_ping.compact.each do |user|
-
-            pref = find_engineer(slack: user)[:preference]
-
-            puts "Found preference #{pref.inspect} for user #{user}"
+          engineers_to_ping.each do |engineer|
+            puts "looking at #{engineer}'s preferences..'"
+            next if engineer[:frequency] == "off"
 
-            case pref
-            when "off"
-              puts "Preference was 'off', so doing nothing."
+            case engineer[:ping_location]
             when "dm", nil
               puts "Preference was either 'dm' or nil, so sending DM."
-              private_message  = "New PR comment from @#{commenter}:\n"
-              private_message += "#{pr_url}\n#{comment}"
-              send_dm(user, private_message)
+              private_message  = "New PR comment from @#{commenter[:slack]}:\n"
+              private_message += "#{comment_url}\n#{comment}"
+              send_dm(engineer[:slack], private_message)
             when "eng-pr", "eng_pr"
               puts "Preference was either 'eng-pr' or 'eng_pr', so alerting #eng-pr."
-              public_message  = "@#{user}, new PR mention: "
-              public_message += "#{pr_url}\n#{comment}" if user == usernames_to_ping.last
+              public_message  = "@#{engineer[:slack]}, new PR mention: "
+              public_message += "#{comment_url}\n#{comment}"
               alert_eng_pr(public_message)
             end
-
           end
 
           puts "GitHub Hook successfully processed."
@@ -102,11 +96,6 @@ module Lita
         end.first
       end
 
-      def github_to_slack_username(github_username)
-        engineer = find_engineer(github: github_username)
-        engineer[:slack] if engineer
-      end
-
       def send_dm(username, content)
         puts "Sending DM to #{username} with content #{content[0..5]}... "
         if user = Lita::User.fuzzy_find(username)

data/lita-github-pinger.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = "lita-github-pinger"
-  spec.version       = "0.4.6"
+  spec.version       = "0.4.7"
   spec.authors       = ["Taylor Lapeyre"]
   spec.email         = ["taylorlapeyre@gmail.com"]
   spec.description   = "A Lita handler that detects github comment notifications and regurgitates a ping to the correct slack username."

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lita-github-pinger
 version: !ruby/object:Gem::Version
-  version: 0.4.6
+  version: 0.4.7
 platform: ruby
 authors:
 - Taylor Lapeyre