lita-github-pinger 0.4.3 → 0.4.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c02180295dcf0e5bcabbcc58ba346d4ffd352e12
-  data.tar.gz: f436e69420273ecb918a20e15f16c5a86f0bc6e2
+  metadata.gz: 86fdffcf6c595d041202bf131f3131e36c45abc2
+  data.tar.gz: 60bf57e40b1c281c48cf5d89e76b4a3eae9456e8
 SHA512:
-  metadata.gz: 802a892a377b6e11434990d6735da9c462fdc4c7e04c616a0eb9f5db9e2fae3f7fc440ee9e6e322052de409c5eea17253a7a74506d5fba0c423031498df1f461
-  data.tar.gz: 7903b0a7d5c748291cb426637febfc76647f652e6be58bb30b4c75fb46b3f1d8ac759b923bad50153d0ef76b93f0cae3b549626ac5e38c09a9b2d517f9121c84
+  metadata.gz: 4cddff5c4b5995d2da602c27df3e25617065e39fd10d8ef273fe01862bcf532c63ec7f73a23251b87fdb6f00d733c7e6e3847f74af45589ad6e512fd7f969335
+  data.tar.gz: 9b7cc2cf54c7a6508cdaeb16fd88ca8ad3417ea9b8d8163365d023312ad3eb6a3a19bd6c029b55de68b4180a340234d9b1763d713d99cd1a3c8f7f2df8af69fc

data/lib/lita/handlers/github_pinger.rb

@@ -7,36 +7,60 @@ module Lita
       http.post("/ghping", :ghping)
 
       def ghping(request, response)
+
+        puts "######################################"
+        puts "GitHub hook received. Parsing body... "
+
         body = MultiJson.load(request.body)
 
+        print "Done."
+        puts "######################################"
+
         if body["comment"]
+          puts "Detected a comment. Extracting data... "
+
           thing     = body["pull_request"] || body["issue"]
           pr_url    = thing["html_url"]
           comment   = body["comment"]["body"]
-          commenter = github_to_slack_username(body["comment"]["user"]["login"])
+          commenter = body["comment"]["user"]["login"]
+          pr_owner  = thing["user"]["login"]
+
+          puts "Found PR #{pr_url}"
+          puts "Found commenter #{commenter}"
+          puts "Found pr owner #{pr_owner}"
 
           usernames_to_ping = []
           # automatically include the creator of the PR, unless he's
           # commenting on his own PR
-          if body["comment"]["user"]["login"] != thing["user"]["login"]
-            usernames_to_ping << [thing["user"]["login"]]
+          if commenter != pr_owner
+            puts "Commenter is not the pr owner. Adding to list of usernames to ping."
+            usernames_to_ping << pr_owner
           end
 
+          puts "So far, github usernames to ping: #{usernames_to_ping}"
 
           # Is anyone mentioned in this comment?
           if comment.include?("@")
+            puts "Found @mentions in the body of the comment! Extracting usernames... "
+
             # get each @mentioned username in the comment
             mentions = comment.split("@")[1..-1].map { |snip| snip.split(" ").first }
+            print "Done. (Got #{mentions})"
 
             # add them to the list of usernames to ping
             usernames_to_ping = usernames_to_ping.concat(mentions).uniq
           end
 
+          puts "New list of github usernames to ping: #{usernames_to_ping}."
+          puts "Converting github usernames to slack usernames... "
+
           # slackify all of the users
           usernames_to_ping.map! { |user| github_to_slack_username(user) }
 
-          puts "Got a comment on something, sending messages to #{usernames_to_ping}"
-          usernames_to_ping.each do |user|
+          print "Done. (Got #{usernames_to_ping})"
+
+          puts "Starting pinging process for each engineer..."
+          usernames_to_ping.compact.each do |user|
 
             pref = find_engineer(slack: user)[:preference]
             case pref
@@ -53,15 +77,19 @@ module Lita
             end
 
           end
+
+          puts "GitHub Hook successfully processed."
         end
 
         response
       end
 
       def alert_eng_pr(message)
+        puts "Alerting #eng-pr about content #{message[0..5]}... "
         room = Lita::Room.fuzzy_find("eng-pr")
         source = Lita::Source.new(room: room)
         robot.send_message(source, message)
+        puts "Done."
       end
 
       def find_engineer(slack: nil, github: nil)
@@ -75,13 +103,16 @@ module Lita
       end
 
       def github_to_slack_username(github_username)
-        find_engineer(github: github_username)[:slack]
+        engineer = find_engineer(github: github_username)
+        engineer[:slack] if engineer
       end
 
       def send_dm(username, content)
+        puts "Sending DM to #{username} with content #{content[0..5]}... "
         if user = Lita::User.fuzzy_find(username)
           source = Lita::Source.new(user: user)
           robot.send_message(source, content)
+          print "Done."
         else
           alert_eng_pr("Could not find user with name #{username}, please configure everbot.")
         end

data/lita-github-pinger.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = "lita-github-pinger"
-  spec.version       = "0.4.3"
+  spec.version       = "0.4.4"
   spec.authors       = ["Taylor Lapeyre"]
   spec.email         = ["taylorlapeyre@gmail.com"]
   spec.description   = "A Lita handler that detects github comment notifications and regurgitates a ping to the correct slack username."

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lita-github-pinger
 version: !ruby/object:Gem::Version
-  version: 0.4.3
+  version: 0.4.4
 platform: ruby
 authors:
 - Taylor Lapeyre