lita-github-pinger 0.3.8 → 0.3.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8bacfd86e21e49be2aeaf27442ec4ab2cb195b50
-  data.tar.gz: 6103685ca7f649f4a4af5dd92cf4a3a900c454da
+  metadata.gz: 33d12a4430193d253237eac9a65735cdb2f6cfa5
+  data.tar.gz: ce1ca14e173036d664e2596a5fe1b76009a6c45c
 SHA512:
-  metadata.gz: 12414a7712309ea09cbf18f3f656b3db812454f65e7f722510a56561a2ec9e69daccf5ab320c4726528e9cb3e15ddb24d933ba41330df17b79f52b2308594ae2
-  data.tar.gz: 96edd8cf33e0c24e30f23145b09820e7bee3badf8ed806f35bce255e0bcb2fcfe4fe2f3cf658b2b08ebb91dafc747e79f748e3b7052ca345a6773f588c8a83eb
+  metadata.gz: c46a08c0045397962ac8f40b101aa4df2c9a3cfd819d2a4c58ba6908744d6059148949edde87cbd5543c07400a421f34d21600bce0cf92c78b54b03a7d9463ab
+  data.tar.gz: 0240b620b9a96e61ef1434a4b158584238cc5b200a49dc36ef9408c1392351dc6f41cba19c4bc93227f1bbbff4ef6b09212a497f48ace40b6fd3adc3c971be85

data/lib/lita/handlers/github_pinger.rb

@@ -13,7 +13,7 @@ module Lita
           thing     = body["pull_request"] || body["issue"]
           pr_url    = thing["html_url"]
           comment   = body["comment"]["body"]
-          commenter = body["comment"]["user"]["login"]
+          commenter = github_to_slack_username(body["comment"]["user"]["login"])
 
           # automatically include the creator of the PR
           usernames_to_ping = [thing["user"]["login"]]
@@ -27,30 +27,49 @@ module Lita
             usernames_to_ping = usernames_to_ping.concat(mentions).uniq
 
             # slackify all of the users
-            usernames_to_ping.map! { |user| github_username_to_slack_username(user) }
+            usernames_to_ping.map! { |user| github_to_slack_username(user) }
           end
 
-          message  = "New PR comment from #{commenter}:\n"
-          message += "#{pr_url}\n#{comment}"
-
           puts "Got a comment on something, sending messages to #{usernames_to_ping}"
+          usernames_to_ping.each do |user|
+
+            pref = find_engineer(slack: user)[:preference]
+            case pref
+            when "off" return
+            when "dm", nil
+              private_message  = "New PR comment from @#{commenter}:\n"
+              private_message += "#{pr_url}\n#{comment}"
+              send_dm(user, private_message)
+            when "eng-pr", "eng_pr"
+              public_message  = "@#{user}, new PR mention: "
+              public_message += "#{pr_url}\n#{comment}" if user == usernames_to_ping.last
+              alert_eng_pr(public_message)
+            end
 
-          usernames_to_ping.each { |user| send_dm(user, message) }
+          end
         end
 
         response
       end
 
       def alert_eng_pr(message)
-        room = Lita::Room.fuzzy_find("eng")
+        room = Lita::Room.fuzzy_find("eng-pr")
         source = Lita::Source.new(room: room)
         robot.send_message(source, message)
       end
 
-      def github_username_to_slack_username(github_username)
+      def find_engineer(slack: nil, github: nil)
         config.engineers.select do |eng|
-          eng[:github] == github_username
-        end.first[:slack]
+          if slack
+            eng[:github] == slack
+          elsif github
+            eng[:github] == github
+          end
+        end.first
+      end
+
+      def github_to_slack_username(github_username)
+        find_engineer(github: github_username)[:slack]
       end
 
       def send_dm(username, content)
@@ -58,7 +77,7 @@ module Lita
           source = Lita::Source.new(user: user)
           robot.send_message(source, content)
         else
-          puts "Could not find user with name #{username}"
+          alert_eng_pr("Could not find user with name #{username}, please configure everbot.")
         end
       end
     end

data/lita-github-pinger.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = "lita-github-pinger"
-  spec.version       = "0.3.8"
+  spec.version       = "0.3.9"
   spec.authors       = ["Taylor Lapeyre"]
   spec.email         = ["taylorlapeyre@gmail.com"]
   spec.description   = "A Lita handler that detects github comment notifications and regurgitates a ping to the correct slack username."

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lita-github-pinger
 version: !ruby/object:Gem::Version
-  version: 0.3.8
+  version: 0.3.9
 platform: ruby
 authors:
 - Taylor Lapeyre