lita-github-pinger 0.1.8 → 0.1.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 80370f63b75bbc667a90e4e9b353a945da00858f
-  data.tar.gz: 6a73783bf7382617242f7cb13e79bd7822575d76
+  metadata.gz: 3a3d82bf0baafe7a5419a8f82de49e1cedc3e5ff
+  data.tar.gz: 0f0b885ce1c21b95462c6336d89c3b9dfb0dc1cf
 SHA512:
-  metadata.gz: 0815ed89a5a02f549e0432ee4e6c4d5002818fbf28caec746449787a21f404f24e09f237ff473e6e0f20951a1df2c7c421ecfc1f5fee83404f647dabf3b3018d
-  data.tar.gz: 497b7e93bd042edfefe945d314b3b9be456e9c0c0d985d3484662205386b85ffdea6b43c39f7277b82b306378b7941fffe6e8d0252c724caceb772930ed372ed
+  metadata.gz: 6638e2a20b0350ebe248f20162c423eda4733f1e8eb956429bf4c754633b458bfba191ef75dbf296315af42e8756461e38d1cdfcf252ff23861ccbcfb242c9a6
+  data.tar.gz: b5a60325b56f1bb91c76cc7e050a67a4c6c3e945a62583ddaa4caf911b0e21a08fa3e46b24d0c14fa83cecda8bd3814ca1c1c1bfcde2e0394fe8bd2a3e6809d3

data/lib/lita/handlers/github_pinger.rb

@@ -2,40 +2,25 @@ module Lita
   module Handlers
     class GithubPinger < Handler
 
-      GITHUB_PR_COMMENT_REGEX = /\[Everlane\/.*\] New comment on pull request #(\d+): (.+) \(assigned to (\w+)\)\nComment by (\w+)\n(.*)/
-
       config :engineers, type: Array, required: true
 
-      route(GITHUB_PR_COMMENT_REGEX, :detect_comment, command: false)
-      route(/testing/, :see_what_happens, command: false)
-
-      def see_what_happens(message)
-        message.reply message.message.body
-      end
+      route(/@(\w*)/, :detect_comment, command: false)
 
       def detect_comment(message)
-        pr_id,
-        pr_title,
-        assigned_person,
-        comment_author,
-        comment_text = message.matches[0]
-
-        # return unless message.user.metadata["name"] == "" # Integrations don't have names
-        return unless comment_text.include?("@")
+        return unless message.user.metadata["name"] == "" # Integrations don't have names
+        mentioned_username = message.matches[0][0]
 
-        mentioned_username = comment_text.split("@")[1].split(" ").first
-
-        config.engineers.each do |engineer|
-          if engineer[:github] == mentioned_username
-            content = %Q{#{engineer[:slack]}, you were mentioned by #{comment_author}:
-  http://github.com/everlane/everlane.com/pull/#{pr_id}
-  > #{comment_text}
-}
-            message.reply(content)
+        # side effects intentional
+        found = config.engineers.any? do |eng|
+          if eng[:github] == mentioned_username
             user = Lita::User.find_by_name(engineer[:slack])
-            robot.send_message(user, content)
+            robot.send_message(user, "New PR comment! #{message.message.body}")
           end
         end
+
+        unless found
+          message.reply("Could not find a slack username for #{pr_owner}. Please configure everbot to include this username.")
+        end
       end
     end
 

data/lita-github-pinger.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = "lita-github-pinger"
-  spec.version       = "0.1.8"
+  spec.version       = "0.1.9"
   spec.authors       = ["Taylor Lapeyre"]
   spec.email         = ["taylorlapeyre@gmail.com"]
   spec.description   = "A Lita handler that detects github comment notifications and regurgitates a ping to the correct slack username."

data/spec/lita/handlers/github_pinger_spec.rb

@@ -43,14 +43,7 @@ describe Lita::Handlers::GithubPinger, lita_handler: true do
   end
 
   it "will respond" do
-    send_message(%q{
-[Everlane/everlane.com] New comment on pull request #1137: More accurate location data and (by extension) working weather for factories (assigned to taylorlapeyre)
-Comment by thenanyu
-@taylorlapeyre hai
-})
-    expect(replies.last).to eq %q{taylor, you were mentioned by thenanyu:
-  http://github.com/everlane/everlane.com/pull/1137
-  > @taylorlapeyre hai
-}
+    send_message("comments up @taylorlapeyre)")
+    expect(replies.count).to eq 0
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lita-github-pinger
 version: !ruby/object:Gem::Version
-  version: 0.1.8
+  version: 0.1.9
 platform: ruby
 authors:
 - Taylor Lapeyre