lita-github-pinger 0.1.5 → 0.1.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3b5e3bf8f9557663e6b1fcc9cd891aca132f4dfe
-  data.tar.gz: aff9d9747cde46cab4e86b6fae38e0cdcada32cf
+  metadata.gz: 7ec059d6207155788e7c6b5e118aab41d182e17a
+  data.tar.gz: 5e30bc5beba43aa299bda1b4f63e88b0491bf73a
 SHA512:
-  metadata.gz: 464979d993761a7c2a91d9a3ab13cff69804ca6e810cf37df879f97cc6f81c68d2377afb4281b05092548193a4e7002a1521100fb2a965f48721d230ec588f85
-  data.tar.gz: 3b3b5fa464d9cebf2bcb52cf0c344499330d0c9989801411ec493302e209f4a1b0a29922bdaa5723c423229770ee21a4fb7b309ddfb8f2c01c91fc836c970f40
+  metadata.gz: e8649f1a775c5771c91b8282a18eb764a97617fbfc4eb9005325755316420d1b9778a70b8c96dbc5a4161fe4a0ebf732d994596366b5736be98af4205607ef95
+  data.tar.gz: e0ce2f411d54b209f06fff49e5acffb83a1908bd4d5ce09c699a62e4c17029dcd86bcbf9acf2f0a2ab0654e205b40919113fa9411a54bebd104bc9082c74f7a1

data/lib/lita/handlers/github_pinger.rb

@@ -2,21 +2,32 @@ module Lita
   module Handlers
     class GithubPinger < Handler
 
+      GITHUB_PR_COMMENT_REGEX = /\[Everlane\/.*\] New comment on pull request #(\d+): (.+) \(assigned to (\w+)\)\nComment by (\w+)\n(.*)/
+
       config :engineers, type: Array, required: true
 
-      route(/@(\w*)/, :detect_comment, command: false)
+      route(GITHUB_PR_COMMENT_REGEX, :detect_comment, command: false)
 
       def detect_comment(message)
-        return unless message.user.metadata["name"] == "" # Integrations don't have names
-        mentioned_username = message.matches[0][0]
+        pr_id,
+        pr_title,
+        assigned_person,
+        comment_author,
+        comment_text = message.matches[0]
 
-        # side effects intentional
-        found = config.engineers.any? do |eng|
-          message.reply("@" + eng[:slack]) if eng[:github] == mentioned_username
-        end
+        # return unless message.user.metadata["name"] == "" # Integrations don't have names
+        return unless comment_text.include?("@")
+
+        mentioned_username = comment_text.split("@")[1].split(" ").first
 
-        unless found
-          message.reply("Could not find a slack username for #{pr_owner}. Please configure everbot to include this username.")
+        config.engineers.each do |engineer|
+          if engineer[:github] == mentioned_username
+            content = %Q{#{engineer[:slack]}, you were mentioned by #{comment_author}:
+  http://github.com/everlane/everlane.com/pulls/#{pr_id}
+  > #{comment_text}
+}
+            message.reply(content)
+          end
         end
       end
     end

data/lita-github-pinger.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = "lita-github-pinger"
-  spec.version       = "0.1.5"
+  spec.version       = "0.1.6"
   spec.authors       = ["Taylor Lapeyre"]
   spec.email         = ["taylorlapeyre@gmail.com"]
   spec.description   = "A Lita handler that detects github comment notifications and regurgitates a ping to the correct slack username."

data/spec/lita/handlers/github_pinger_spec.rb

@@ -43,7 +43,14 @@ describe Lita::Handlers::GithubPinger, lita_handler: true do
   end
 
   it "will respond" do
-    send_message("comments up @taylorlapeyre)")
-    expect(replies.count).to eq 0
+    send_message(%q{
+[Everlane/everlane.com] New comment on pull request #1137: More accurate location data and (by extension) working weather for factories (assigned to taylorlapeyre)
+Comment by thenanyu
+@taylorlapeyre hai
+})
+    expect(replies.last).to eq %q{taylor, you were mentioned by thenanyu:
+  http://github.com/everlane/everlane.com/pulls/1137
+  > @taylorlapeyre hai
+}
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lita-github-pinger
 version: !ruby/object:Gem::Version
-  version: 0.1.5
+  version: 0.1.6
 platform: ruby
 authors:
 - Taylor Lapeyre
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-08-04 00:00:00.000000000 Z
+date: 2015-08-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lita