lita-github-commits 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: db21716b69044be4479bcd4828a7d8fad5171e52
-  data.tar.gz: bbcdc2cc6c93ade267e0ffa571af9163384b32dc
+  metadata.gz: 7aa1facf7a84b6537381b3ef78694d97c65508de
+  data.tar.gz: 3822f5ff206ca183233670c018b9bc20fd3fa20c
 SHA512:
-  metadata.gz: 1c8c4e7e5f795389b025c654248bd592eb3fcf40475657f46ada0d44e62aba1b4cbcfadedebb2dc6786ca08246e1d1e94dbedaa1f882872bf0bbb8c5b8a02771
-  data.tar.gz: cf296f96de3b45aa94b0a0704afa5738bb94213b7dbafdc8c133dca4165958b98198c608802d5fcc019327f778e3e39d969b13e6008aece89679cb10233379c0
+  metadata.gz: 3d3668c149f36b55f0bd9b5f108f96d832c53e402604eb5b4223110cb2f9e2dd4291c8ee0fde5eda9316392321f89bdb549478dc46b68939edd7a54a04c27ab4
+  data.tar.gz: d808c5f2ad8bf7d4dfd173b85f725c1bdd81301f59d0ae820b031bef5d14ca0f0f23ddb164f7b0048be1f28430013cef2eeaab33cf6b07166ba582c70947f6ca

data/lib/lita/handlers/github_commits.rb

@@ -11,9 +11,17 @@ module Lita
       http.post "/github-commits", :receive
 
       def receive(request, response)
-        payload = parse_payload(request.params['payload']) or return
-        repo = get_repo(payload)
-        notify_rooms(repo, payload)
+        event_type = request.env['HTTP_X_GITHUB_EVENT'] || 'unknown'
+        if event_type == "push"
+          payload = parse_payload(request.params['payload']) or return
+          repo = get_repo(payload)
+          notify_rooms(repo, payload)
+        elsif event_type == "ping"
+          response.status = 200
+          response.write "Working!"
+        else
+          response.status = 404
+        end
       end
 
       private

data/lita-github-commits.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = "lita-github-commits"
-  spec.version       = "0.0.2"
+  spec.version       = "0.0.3"
   spec.authors       = ["Mitch Dempsey"]
   spec.email         = ["mrdempsey@gmail.com"]
   spec.description   = %q{A Lita handler that will display GitHub commit messages in the channel}

data/spec/lita/handlers/github_commits_spec.rb

@@ -7,6 +7,7 @@ describe Lita::Handlers::GithubCommits, lita_handler: true do
 
     let(:request) do
       request = double("Rack::Request")
+      allow(request).to receive(:env).and_return({"HTTP_X_GITHUB_EVENT" => "push"})
       allow(request).to receive(:params).and_return(params)
       request
     end
@@ -307,6 +308,15 @@ describe Lita::Handlers::GithubCommits, lita_handler: true do
       JSON
       end
 
+      let(:ping_payload) do
+      <<-JSON.chomp
+{
+   "zen":"Non-blocking is better than blocking",
+   "hook_id":12345
+}
+      JSON
+      end
+
 
       context "request with commits" do
         before do
@@ -372,6 +382,35 @@ describe Lita::Handlers::GithubCommits, lita_handler: true do
       end
 
 
+      context "ping event" do
+        before do
+          Lita.config.handlers.github_commits.repos["octokitty/testing"] = "#baz"
+          allow(params).to receive(:[]).with("payload").and_return(ping_payload)
+          allow(request).to receive(:env).and_return({"HTTP_X_GITHUB_EVENT" => "ping"})
+        end
+
+        it "handles the ping event" do
+          expect(Lita.logger).to_not receive(:error)
+          expect(response).to receive(:write).with("Working!")
+          subject.receive(request, response)
+        end
+      end
+
+      context "unknown event" do
+        before do
+          Lita.config.handlers.github_commits.repos["octokitty/testing"] = "#baz"
+          allow(params).to receive(:[]).with("payload").and_return(ping_payload)
+          allow(request).to receive(:env).and_return({"HTTP_X_GITHUB_EVENT" => "fakefake"})
+        end
+
+        it "handles the ping event" do
+          expect(Lita.logger).to_not receive(:error)
+          expect(response).to_not receive(:write)
+          subject.receive(request, response)
+        end
+      end
+
+
       context "improper config" do
         before do
           allow(params).to receive(:[]).with("payload").and_return(deleted_payload)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lita-github-commits
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Mitch Dempsey