lita-gerrit 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 283eb823d370a3f6cc278a0ecd2144707198fc9a
-  data.tar.gz: 2f5bf8e823577fc9dcfcde0cae162b2201650b66
+  metadata.gz: b63fa796726ff840033b17ea3e49fb54490b9875
+  data.tar.gz: 2b2bf62d813d6e8796fa27b85b53979085e18947
 SHA512:
-  metadata.gz: c33fa282ea95be144f071b778d8aa192a8757290d8a826e20411574a3c870fec611abd5536883230d52ab301b63532d936e124ac4dd073d771acd59ae9357987
-  data.tar.gz: 9a54e29ecf0910354e76ca4fcbc49c27bdd2f881f0fe041be1530501f88f29948924acd7c45a66dfadd595bff778ed91c94ae1664a940403461f97b0d8bb188f
+  metadata.gz: f56f3209bfb27973e5587ba4078e0d697873eeff474010a436b921c0609fd52a48c09e4f484f317d8057084f3693db3bac0d3747cdbe8a6a62340c980b326646
+  data.tar.gz: f65661a6c7144645d172cda2a6534eef9238a54462a1db557670cec700825af1bf57fe9c8b11dc36a320ef5576c71efff3fa3d2c77f912885fa2dc70eb050356

data/lib/lita/handlers/gerrit.rb

@@ -2,12 +2,10 @@ module Lita
   module Handlers
     class Gerrit < Handler
 
-      def self.default_config(config)
-        config.url = "https://gerrit.example.com"
-        config.username = "foo"
-        config.password = "bar"
-        config.default_room = nil
-      end
+      config :url, default: "https://gerrit.example.com"
+      config :username, default: "foo"
+      config :password, default: "bar"
+      config :default_room
 
       #
       # Fetch details of a given patchset
@@ -17,12 +15,12 @@ module Lita
 
       def change_details(response)
         change_id = response.matches.flatten.first
-        change_uri = "#{Lita.config.handlers.gerrit.url.chomp("/")}/a/changes/#{change_id}"
-        change_link = "#{Lita.config.handlers.gerrit.url.chomp("/")}/#{change_id}"
+        change_uri = "#{config.url.chomp("/")}/a/changes/#{change_id}"
+        change_link = "#{config.url.chomp("/")}/#{change_id}"
 
         http_resp = HTTParty.get(change_uri, :digest_auth => {
-          username: Lita.config.handlers.gerrit.username,
-          password: Lita.config.handlers.gerrit.password
+          username: config.username,
+          password: config.password
         })
 
         case http_resp.code
@@ -59,8 +57,8 @@ module Lita
 
         if request.params.has_key?("room")
           room = request.params["room"]
-        elsif Lita.config.handlers.gerrit.default_room
-          room = Lita.config.handlers.gerrit.default_room
+        elsif config.default_room
+          room = config.default_room
         else
           raise "Room must be defined. Either fix your hook or specify a default room ('config.handlers.gerrit.default_room')"
         end

data/lita-gerrit.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = "lita-gerrit"
-  spec.version       = "0.1.1"
+  spec.version       = "0.1.2"
   spec.authors       = ["Jonathan Amiez"]
   spec.email         = ["jonathan.amiez@gmail.com"]
   spec.description   = "Gerrit API client and hook events handler"
@@ -14,7 +14,7 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_runtime_dependency "lita", "~> 3.0"
+  spec.add_runtime_dependency "lita", "~> 4.0"
   spec.add_runtime_dependency "httparty", "~> 0.13.0"
 
   spec.add_development_dependency "bundler", "~> 1.3"

data/spec/lita/handlers/gerrit_spec.rb

@@ -11,8 +11,8 @@ describe Lita::Handlers::Gerrit, lita_handler: true do
     end
   end
 
-  it { routes("get me gerrit 123, please").to(:change_details) }
-  it { doesnt_route("gerrit foo").to(:change_details) }
+  it { is_expected.to route("get me gerrit 123, please").to(:change_details) }
+  it { is_expected.not_to route("gerrit foo").to(:change_details) }
 
   describe "#change_details" do
     let(:response) { double("HTTParty::Response") }
@@ -47,7 +47,7 @@ describe Lita::Handlers::Gerrit, lita_handler: true do
     end
   end
 
-  it { routes_http(:post, "/gerrit/hooks").to(:hook) }
+  it { is_expected.to route_http(:post, "/gerrit/hooks").to(:hook) }
 
   describe "#hook" do
     let(:request) do
@@ -61,8 +61,8 @@ describe Lita::Handlers::Gerrit, lita_handler: true do
     let(:params) { double("Hash") }
   end
 
-  it { routes_http(:post, "/gerrit/build/myroom").to(:build_notification) }
-  it { doesnt_route_http(:post, "/gerrit/build/").to(:build_notification) }
+  it { is_expected.to route_http(:post, "/gerrit/build/myroom").to(:build_notification) }
+  it { is_expected.not_to route_http(:post, "/gerrit/build/").to(:build_notification) }
 
   describe "#build_notification" do
     let(:request) { double("Rack::Request") }

data/spec/spec_helper.rb

@@ -8,3 +8,4 @@ SimpleCov.start { add_filter "/spec/" }
 
 require "lita-gerrit"
 require "lita/rspec"
+Lita.version_3_compatibility_mode = false

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lita-gerrit
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Jonathan Amiez
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '4.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '4.0'
 - !ruby/object:Gem::Dependency
   name: httparty
   requirement: !ruby/object:Gem::Requirement