lita-gauth 0.1.0.3 → 0.1.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e7c5f8adac615e198fcfec3f1a28adfd29dcdaf2ccdfe74bb9a91e95eab6bd59
-  data.tar.gz: f0bdc68c06c242a7ab5b2e52e75d00b87e11b6aa55db0129f4a7fb18eff80927
+  metadata.gz: 41d158c285f8d693c0e0e5f32c5fdfd845380b5b669d869db9208b7c71ccf150
+  data.tar.gz: 601e25c6651dfe49377d26e21bd8bd8a311403eb326343e1e3be89ac640f4c8d
 SHA512:
-  metadata.gz: 0eaf21c4392ba194b2d6e85ff6d2fa8bf6ad717e4a6f15110027c3ad95978d932840bd9eac5845eb44f86c3229eb5832a747f4ed78fb2878661d6ad28aaf3145
-  data.tar.gz: 67416ffd8d73072ac5d80dea276d59ddfb754661d418b47f941587ff9da02192770d512f2a4e39ddd61c6856e8b875fa630c6af073e013615c26146528a647c2
+  metadata.gz: 4f86816edbaf22303c231eb806f837f0b37002051e1a6ac7956252d43e106780c6372ad777c8bd1ce260760b91cd87bf40eb20a5a063889756dcf30d5c1cf39b
+  data.tar.gz: 569c3e5861cab69b98bb81a2ac4bf85410bb1261a6a19818159e2ba5157597e4414f3992ac2bcc3f19d1bc323752b8a182ca0de3b061e7cbf8f8f9443bb35de8

data/.gitignore

@@ -15,3 +15,4 @@ spec/reports
 test/tmp
 test/version_tmp
 tmp
+.byebug_history

data/lib/lita/handlers/gauth.rb

@@ -2,15 +2,14 @@ require 'google_auth_box'
 module Lita
   module Handlers
     class Gauth < Handler
-      config :secret_key, required: true 
-
       config :client_id_hash, required: true
 
       config :scopes, required: true
 
       config :data_file_path, required: true
 
-      config :base_uri, required: true
+      config :base_domain, required: true
+      config :oauth_redir_path, required: true
 
       route(/^authed\?$/, :check_auth, command: true)
       route(/^auth me$/, :request_auth, command: true)
@@ -20,12 +19,6 @@ module Lita
       http.get 'auth-root/:id', :auth_root
       http.get 'auth-save/:user_id/', :auth_save
 
-      def bar(msg)
-        p 'called'
-        p config.secret_key
-        msg.reply "hey there"
-      end
-      
       def get_user_creds(user_id)
         auth_client.get_creds user_id
       end
@@ -48,7 +41,7 @@ module Lita
         attrs = {
           storage_key: 'lita_gauth_user_id',
           code: req.params["code"],
-          base_url: config.base_uri
+          base_url: build_redir_url
         }
         resp.body << render_template("auth_redir.html", attrs)
       end
@@ -70,16 +63,20 @@ module Lita
       end
 
       def request_auth(msg)
-        url = "#{config.base_uri}/auth-root"
+        url = "#{config.base_domain}/auth-root"
         msg.reply "Click the followin link to do the thing! #{url}"
       end
 
+      def build_redir_url
+        "#{config.base_domain}#{config.oauth_redir_path}"
+      end
+
       def auth_client
          @_auth_client ||=GoogleAuthBox::Client.new(
           client_id_hash: config.client_id_hash,
           scopes: config.scopes,
           data_file_path: config.data_file_path,
-          base_uri: config.base_uri
+          base_uri: build_redir_url
         )
       end
 

data/lita-gauth.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = "lita-gauth"
-  spec.version       = "0.1.0.3"
+  spec.version       = "0.1.0.4"
   spec.authors       = ["Axylos"]
   spec.email         = ["robertdraketalley@gmail.com"]
   spec.description   = "auth with google api"

data/spec/lita/handlers/gauth_spec.rb

@@ -1,11 +1,14 @@
 require "spec_helper"
+require 'byebug'
 
 describe Lita::Handlers::Gauth, lita_handler: true do
   let(:robot) { Lita::Robot.new(registry) }
   let(:file_path) { './test_file_path' }
-  let(:base_uri) { "http://uri.com/auth-redir" }
-  subject { Lita::Handlers::Gauth.new(robot) }
-  let(:handler) { subject }
+  let(:base_domain) { "http://uri.com/virgil" }
+  let(:oauth_redir_path) { "/auth-redir" }
+  let(:handler) { Lita::Handlers::Gauth.new robot }
+  # subject { Lita::Handlers::Gauth.new(robot) }
+  subject { handler }
 
   before do
     robot.config.handlers.gauth.client_id_hash = {
@@ -16,7 +19,8 @@ describe Lita::Handlers::Gauth, lita_handler: true do
     }
 
     robot.config.handlers.gauth.scopes = ["sheets"]
-    robot.config.handlers.gauth.base_uri =  base_uri
+    robot.config.handlers.gauth.base_domain =  base_domain
+    robot.config.handlers.gauth.oauth_redir_path = oauth_redir_path
     File.delete file_path if File.exist? file_path
     f = File.new file_path, 'w'
     f.close
@@ -40,9 +44,14 @@ describe Lita::Handlers::Gauth, lita_handler: true do
       subject.check_auth auth_spy
     end
 
+    it 'can get the right auth url' do
+      send_message "Lita authed?"
+      expect(replies.last).to match handler.build_redir_url
+    end
+
     it 'listens for authorization requests' do
       send_message "Lita auth me"
-      expect(replies.last).to match(base_uri)
+      expect(replies.last).to match(base_domain)
       expect(replies.last).to match("auth-root")
     end
   end
@@ -51,10 +60,10 @@ describe Lita::Handlers::Gauth, lita_handler: true do
     let(:user_id) { 5 }
     let(:auth_url) { "/auth-root/#{user_id}" }
     let(:storage_key) { "lita_gauth_user_id" }
+    let(:redir_url) { build_redir_url }
     it { is_expected.to route_http(:get, "/auth-root/#{user_id}").to :auth_root }
-    let(:resp) { resp = http.get auth_url }
 
-    subject { resp.body }
+    subject { http.get(auth_url).body }
 
     it { is_expected.not_to be_empty }
 
@@ -62,7 +71,9 @@ describe Lita::Handlers::Gauth, lita_handler: true do
 
     it { is_expected.to match storage_key }
 
-    it { is_expected.to match base_uri }
+    it { is_expected.to match base_domain }
+
+    it { is_expected.to match handler.build_redir_url }
   end
 
   describe "#oauth_callback" do
@@ -81,7 +92,7 @@ describe Lita::Handlers::Gauth, lita_handler: true do
 
     it { is_expected.to match code }
 
-    it { is_expected.to match base_uri }
+    it { is_expected.to match base_domain }
 
     xit 'saves the api code' do
       code = '4/er7394sadfasdf'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lita-gauth
 version: !ruby/object:Gem::Version
-  version: 0.1.0.3
+  version: 0.1.0.4
 platform: ruby
 authors:
 - Axylos
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-03-24 00:00:00.000000000 Z
+date: 2018-03-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lita