lita-flowdock 0.2.3 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4e7c5b59bef6c79b46baabff5bb13104fd702d9a
-  data.tar.gz: 09e2d9d829cdcfc726c759b499b88c850ffc4904
+  metadata.gz: bb7e7149a8b43f305857dc0d9eef5ead5be2bfba
+  data.tar.gz: cb5880f71af7eea569d73cbd013b1e784cdb1875
 SHA512:
-  metadata.gz: a5f12b386be541e133c554c5fb70cb894bebe50997b262d3622b5811ff35acd9b384f8f3389821198b806ca9cc91f2ff3c0a2c76fce2660053569d7eca34726e
-  data.tar.gz: bc3da50050ee8c6d0b4d168874ca0df07aa6c5f120a870cfe9366cc75450082fa3aee95f19d59f694de44b9ad59c40683f8ebcb80d53f6d77510508c08274a01
+  metadata.gz: a7bf46d9a687efb8f6f4ae127b529531e3434cbb4c6dfd3cf5e8a35e6be6aa0ceb46c73ddf87c8c9c99cb7fc5caa0c0784ad1a253271954152654e0ecbc467b2
+  data.tar.gz: 1fc10004c9db4671c04a73ebf7c6f95a93e9dd8013768e63590416344ce367325f96da554f5d9559c2659d131d3d1d62f8d708b161cd7e62836cdfefea03f5a2

data/lib/lita/adapters/flowdock/message_handler.rb

@@ -39,14 +39,6 @@ module Lita
             return content.is_a?(Hash) ? content['text'] : content
           end
 
-          def tags
-            data['tags']
-          end
-
-          def thread_id
-            data['thread_id']
-          end
-
           def dispatch_message(user)
             source = FlowdockSource.new(
               user: user,
@@ -54,7 +46,7 @@ module Lita
               private_message: private_message?,
               message_id: private_message? ? data['id'] : data['thread']['initial_message']
             )
-            message = FlowdockMessage.new(robot, body, source, tags, thread_id)
+            message = FlowdockMessage.new(robot, body, source, data)
             robot.receive(message)
           end
 

data/lib/lita/message/flowdock_message.rb

@@ -1,10 +1,23 @@
 module Lita
   class FlowdockMessage < Message
-    attr_reader :tags, :thread_id
-    def initialize(robot, body, source, tags, thread_id)
-      @tags = tags
-      @thread_id = thread_id
+
+    attr_reader :data
+
+    def initialize(robot, body, source, data)
+      @data = data
       super(robot, body, source)
     end
+
+    def tags
+      @data['tags']
+    end
+
+    def thread_id
+      @data['thread_id']
+    end
+
+    def new_thread?
+      @data['id'] == @data['thread']['initial_message']
+    end
   end
 end

data/lita-flowdock.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = "lita-flowdock"
-  spec.version       = "0.2.3"
+  spec.version       = "0.3.0"
   spec.authors       = ["Ben House"]
   spec.email         = ["ben@benhouse.io"]
   spec.description   = %q{flowdock adapter for lita.io}

data/spec/lita/adapters/flowdock/message_handler_spec.rb

@@ -52,7 +52,7 @@ describe Lita::Adapters::Flowdock::MessageHandler, lita: true do
           message_id: id
         ).and_return(source)
         allow(Lita::FlowdockMessage).to receive(:new).with(
-          robot, 'Hello World!', source, [], nil).and_return(message)
+          robot, 'Hello World!', source, data).and_return(message)
         allow(robot).to receive(:receive).with(message)
       end
 
@@ -81,8 +81,7 @@ describe Lita::Adapters::Flowdock::MessageHandler, lita: true do
             robot,
             "",
             source,
-            [],
-            nil
+            data
           ).and_return(message)
 
           subject.handle
@@ -244,7 +243,7 @@ describe Lita::Adapters::Flowdock::MessageHandler, lita: true do
           message_id: parent_id
         ).and_return(source)
         allow(Lita::FlowdockMessage).to receive(:new).with(
-          robot, 'Lita: help', source, tags, nil).and_return(message)
+          robot, 'Lita: help', source, data).and_return(message)
         allow(robot).to receive(:receive).with(message)
       end
 

data/spec/lita/message/flowdock_message_spec.rb

@@ -30,100 +30,62 @@ describe Lita::FlowdockMessage, lita: true do
     allow(Lita::User).to receive(:find_by_id).and_return(user)
   end
 
-  context "a message in a thread has a tag" do
-    let(:tags) { ['down'] }
+  context "a message" do
     let(:body) { 'the system is #down' }
+    let(:initial_message){ 1234 }
     let(:data) do
       {
         'content'         => {
           'title'         => 'Thread title',
           'text'          => body
         },
+        'thread_id'       => 'a385473',
         'event'           => 'comment',
         'flow'            => test_flow,
         'id'              => 2345,
         'thread'          => {
-          'initial_message' => 1234
+          'initial_message' => initial_message
         },
-        'tags'            => tags,
+        'tags'            => ['down'],
         'user'            => 3
       }
     end
 
-    it 'creates a message with tags' do
+    it 'creates a message with data' do
       expect(Lita::FlowdockMessage).to receive(:new).with(
         robot,
         body,
         source,
-        tags,
-        nil
+        data
       )
 
       message_handler.handle
     end
-  end
-
-  context "a message in a thread" do
-    let(:tags) { ['down'] }
-    let(:body) { 'the system is #down' }
-    let(:data) do
-      {
-        'content'         => {
-          'title'         => 'Thread title',
-          'text'          => body
-        },
-        'event'           => 'comment',
-        'flow'            => test_flow,
-        'id'              => 2345,
-        'thread_id'     => 'deadbeef',
-        'thread'          => {
-          'initial_message' => 1234
-        },
-        'tags'            => tags,
-        'user'            => 3
-      }
-    end
-
-    it 'stores the message_id on the flowdock_message' do
-      expect(Lita::FlowdockMessage).to receive(:new).with(
-        robot,
-        body,
-        source,
-        tags,
-        'deadbeef'
-      )
 
-      message_handler.handle
-    end
-  end
+    context 'instance methods' do
+      subject{ Lita::FlowdockMessage.new( robot, body, source, data) }
+      it 'has #tags' do
+        expect(subject.tags).to eq(['down'])
+      end
 
-  context 'a regular message with a tag' do
-    let(:tags) { ['world'] }
-    let(:body) { 'Hello #world' }
-    let(:data) do
-      {
-        'content'         => body,
-        'event'           => 'message',
-        'flow'            => test_flow,
-        'id'              => 1234,
-        'thread'          => {
-          'initial_message' => 1234
-        },
-        'tags'            => tags,
-        'user'            => 3
-      }
-    end
+      it 'has #thread_id' do
+        expect(subject.thread_id).to eq('a385473')
+      end
 
-    it 'creates a message with tags' do
-      expect(Lita::FlowdockMessage).to receive(:new).with(
-        robot,
-        body,
-        source,
-        tags,
-        nil
-      )
+      context 'new_thread?' do
+        context 'non new-thread' do
+          it 'is false' do
+            expect(subject.new_thread?).to be false
+          end
+        end
 
-      message_handler.handle
+        context 'a new thread' do
+          let(:initial_message){ 2345 }
+          it 'is true' do
+            expect(subject.new_thread?).to be true
+          end
+        end
+      end
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lita-flowdock
 version: !ruby/object:Gem::Version
-  version: 0.2.3
+  version: 0.3.0
 platform: ruby
 authors:
 - Ben House
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-12-03 00:00:00.000000000 Z
+date: 2015-12-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lita