lita-estimate 0.1.4 → 0.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6d04887b4c71293d42db3b4977754346b8a425ce
-  data.tar.gz: 8b667c0dccdf5bd40bd9dabb3fd432c95c82ed8e
+  metadata.gz: ad344b1cdb4aa633161c6a85c6a23f4bb43bb6db
+  data.tar.gz: f3d41d7944d1a0cc24fc588f8305d4b1b52cff89
 SHA512:
-  metadata.gz: a86fafa98a6cf0757adad7c27ea0dfc6eb033f9e27cad766ec83ef5894f2de78988de0e324d94df98e3290a2ade34677e0da102ab92d0e342b95c400ad983d6a
-  data.tar.gz: 150157f64e780ce2d507106828951095adba5170115142700b9305c415926eecb9b48b2e08fcd8881dc09e93dc4267035da112143c08dc86fb7772c0eca167cb
+  metadata.gz: 0faf63327375d93f7feb54af5f3960e7495c76f3d1d4418c1d6109cad5abd9dfab916579c4d110ce250062b26eb4d1e4fee76fbcc23769c6d3413dca87d11028
+  data.tar.gz: b99c5d4444ec437e42730c7bccea4ca009fa6e22cde754ce2074c403ba319aecf51a01685a0e4d81210ce7f85710ce1165b00001e9928e9037ef3626e90eacae

data/lib/lita/handlers/estimate.rb

@@ -19,19 +19,27 @@ module Lita
 
       def show_estimates(response)
         story = response.matches.flatten.first
-        estimates = []
-        redis.hgetall(key(story)).each do |estimator, estimate|
-          response.reply("#{estimator}: #{estimate}")
-          estimates << estimate.to_i
+        estimates = redis.hgetall(key(story))
+        if estimates.empty?
+          response.reply("No estimates yet for #{story}")
+        else
+          lines = []
+          estimates.keys.sort.each do |estimator|
+            lines << "#{estimator}: #{estimates[estimator]}"
+          end
+          average = estimates.values.inject(0){ |sum, e| sum + e.to_i }.to_f / estimates.size
+          lines << "Average: #{average}"
+          response.reply(lines.join("\n"))
         end
-        average = estimates.inject{ |sum, e| sum + e }.to_f / estimates.size
-        response.reply("Average: #{average}")
       end
 
       def show_estimators(response)
         story = response.matches.flatten.first
-        redis.hgetall(key(story)).each do |estimator, estimate|
-          response.reply(estimator)
+        estimates = redis.hgetall(key(story))
+        if estimates.empty?
+          response.reply("No estimators yet for #{story}")
+        else
+          response.reply(estimates.keys.sort.join("\n"))
         end
       end
 

data/lita-estimate.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = "lita-estimate"
-  spec.version       = "0.1.4"
+  spec.version       = "0.1.5"
   spec.authors       = ["Ingo Weiss"]
   spec.email         = ["ingo@ingoweiss.com"]
   spec.description   = "Just a silly little Lita plugin for estimation"

data/spec/lita/handlers/estimate_spec.rb

@@ -38,47 +38,48 @@ describe Lita::Handlers::Estimate, lita_handler: true do
 
   describe "show estimates" do
 
-    before(:each) do
+    it "should list estimates" do
       subject.redis.hset('estimate:US123', 'Peter', '5')
       subject.redis.hset('estimate:US123', 'Paula', '3')
-    end
-
-    it "should list estimates" do
       send_command('US123 estimates')
-      expect(replies.to_set).to eq(Set[
+      expect(lines(replies.last)).to eq([
         "Paula: 3",
         "Peter: 5",
         "Average: 4.0"
       ])
     end
 
+    it "should show a message if no estimates are found" do
+      send_command('US456 estimates')
+      expect(replies.last).to eq('No estimates yet for US456')
+    end
+
   end
 
   describe "show estimators" do
 
-    before(:each) do
-      subject.redis.hset('estimate:US123', 'Peter', '5')
-      subject.redis.hset('estimate:US123', 'Paula', '3')
-    end
-
     it "should list estimates" do
+      subject.redis.hset('estimate:US123', 'Paula', '3')
+      subject.redis.hset('estimate:US123', 'Peter', '5')
       send_command('US123 estimators')
-      expect(replies.to_set).to eq(Set[
+      expect(lines(replies.last)).to eq([
         "Paula",
         "Peter"
       ])
     end
 
+    it "should show a message if no estimates are found" do
+      send_command('US456 estimators')
+      expect(replies.last).to eq('No estimators yet for US456')
+    end
+
   end
 
   describe "reset estimates" do
 
-    before(:each) do
+    it "should reset estimates" do
       subject.redis.hset('estimate:US123', 'Peter', '5')
       subject.redis.hset('estimate:US123', 'Paula', '3')
-    end
-
-    it "should reset estimates" do
       send_command('US123 estimates reset')
       expect(subject.redis.hgetall('estimate:US123')).to eq({})
     end

data/spec/spec_helper.rb

@@ -13,3 +13,7 @@ require "lita/rspec"
 # A compatibility mode is provided for older plugins upgrading from Lita 3. Since this plugin
 # was generated with Lita 4, the compatibility mode should be left disabled.
 Lita.version_3_compatibility_mode = false
+
+def lines(multi_line_response)
+  multi_line_response.split("\n")
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lita-estimate
 version: !ruby/object:Gem::Version
-  version: 0.1.4
+  version: 0.1.5
 platform: ruby
 authors:
 - Ingo Weiss
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-09-28 00:00:00.000000000 Z
+date: 2015-09-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lita