lita-estimate 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 226efee41b4a539d397bef2fc660fd8f6d6cae32
-  data.tar.gz: 5ce0ac5fe4914186d6a3e2e3ea9a621996c98e0d
+  metadata.gz: 41de7683e7304d3516be6415d3016cea50c3c8b2
+  data.tar.gz: b5c595debb988f0dcda69a3f8efd45450fc29fe7
 SHA512:
-  metadata.gz: 743b0ab2b3d046c74a2c8b8acdd5a75b348af5ba47be2cf34ee7d2311d7162abf4d90783c0627c6d4d962fb40e884dee71bf349409b7d22501ffc7b55197793c
-  data.tar.gz: 5035e22c9d28f1083191ee89723d37628a46697c742f0a05af1c9f61bb5dbba6481668240ab745269765b6edc79a2010891cb8fd1846ab7e91fda42493a206ed
+  metadata.gz: c1a180364e5b0aae3367e61eab23c9bdf436672de70e4673fad1301798f700f1c3faf1b7b0bac765f43bb81c40e92d237957dd2397931cd8331d95e753410621
+  data.tar.gz: 66d15e1abe080b36d8c5d1beaf5daf5d0a2aa759363e2ddb00d84dda23f6a0ca100a9664826bb8ae8313a448e9e7549ece693f27d9ec597aab93125e78e4372f

data/README.md

@@ -13,13 +13,15 @@ Add lita-estimate to your Lita instance's Gemfile:
 gem "lita-estimate"
 ```
 
-## Configuration
-
-none
-
 ## Usage
 
 ```
-> @bot estimate US123 as 5
-> @bot estimates
+Peter> @bot estimate US123 as 5
+Bot> Thanks!
+Paula> @bot estimate US123 as 3
+Bot> Thanks!
+Carl> @bot estimates
+Bot> Peter: 5
+Bot> Paula: 3
+Bot> Average: 4
 ```

data/lib/lita/handlers/estimate.rb

@@ -7,21 +7,29 @@ module Lita
 
       def estimate(response)
         story, points = response.matches.first
-        redis.set([story,response.user.name].join(':'), points)
+        if ['1','2','3','5','8','13'].include?(points)
+          redis.hset(key(story), response.user.name, points)
+          response.reply('Thanks!')
+        else
+          response.reply('Please use a Fibonacci number not larger than 13')
+        end
       end
 
       def show_estimates(response)
         story = response.matches.flatten.first
         estimates = []
-        redis.keys("#{story}:*").each do |key|
-          estimator = key.split(':').last
-          estimates << (estimate = redis.get(key).to_i)
+        redis.hgetall(key(story)).each do |estimator, estimate|
           response.reply("#{estimator}: #{estimate}")
+          estimates << estimate.to_i
         end
         average = estimates.inject{ |sum, e| sum + e }.to_f / estimates.size
         response.reply("Average: #{average}")
       end
 
+      def key(story)
+        ['estimate', story].join(':')
+      end
+
       Lita.register_handler(self)
     end
   end

data/lita-estimate.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = "lita-estimate"
-  spec.version       = "0.1.0"
+  spec.version       = "0.1.1"
   spec.authors       = ["Ingo Weiss"]
   spec.email         = ["ingo@ingoweiss.com"]
   spec.description   = "Just a silly little Lita plugin for estimation"

data/spec/lita/handlers/estimate_spec.rb

@@ -14,7 +14,20 @@ describe Lita::Handlers::Estimate, lita_handler: true do
     it "should persist estimates" do
       carl = Lita::User.create(123, name: "Carl")
       send_command('estimate US123 as 5', :as => carl)
-      expect(subject.redis.get('US123:Carl')).to eq("5")
+      expect(subject.redis.hget('estimate:US123', 'Carl')).to eq("5")
+    end
+
+    it "should confirm the estimate" do
+      carl = Lita::User.create(123, name: "Carl")
+      send_command('estimate US123 as 5', :as => carl)
+      expect(replies.last).to eq('Thanks!')
+    end
+
+    it "should reject the estimate if it is not a fibonacci number" do
+      carl = Lita::User.create(123, name: "Carl")
+      send_command('estimate US123 as 4', :as => carl)
+      expect(subject.redis.hget('estimate:US123', 'Carl')).to be_nil
+      expect(replies.last).to eq('Please use a Fibonacci number not larger than 13')
     end
 
   end
@@ -22,15 +35,13 @@ describe Lita::Handlers::Estimate, lita_handler: true do
   describe "show estimates" do
 
     before(:each) do
-      peter = Lita::User.create(123, name: "Peter")
-      paula = Lita::User.create(234, name: "Paula")
-      send_command('estimate US123 as 5', :as => peter)
-      send_command('estimate US123 as 3', :as => paula)
+      subject.redis.hset('estimate:US123', 'Peter', '5')
+      subject.redis.hset('estimate:US123', 'Paula', '3')
     end
 
     it "should list estimates" do
       send_command('US123 estimates')
-      expect(replies).to eq([
+      expect(replies.to_set).to eq(Set[
         "Paula: 3",
         "Peter: 5",
         "Average: 4.0"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lita-estimate
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Ingo Weiss
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-09-26 00:00:00.000000000 Z
+date: 2015-09-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lita