lita-claims 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0b0044d0d1c66f9d0e5420a8d51cda79bbd03dc4
-  data.tar.gz: 9e4156919f937a95262e078c2e9f8b2bdf46ca2c
+  metadata.gz: 35767028326bf769d2068db64f74df55a8769a09
+  data.tar.gz: 96b80f9a5ff1045f76975b8bb781b99d70d193cd
 SHA512:
-  metadata.gz: e27603ccaba2610838a5c47088513152c6eddba1fe7db65cc100df2e8c35dbad902aa34ba0fe2a38169c706fd4af853037a64249cd5a2788afbeace3694edebb
-  data.tar.gz: 5472a5aaeb0f0fc72b744e8474316beac5bc20dd38df3c69812c6fc9bdd443d37fbd1cadc6b62cac0b40b6aa2f69bc9160ca765de8b29aee8adbd3a6c13e9bf9
+  metadata.gz: f4f64bfc9b06be68629ed6a4e498afb3172037341da3a3245291a036424b91bdd878808b9a65b4670b40e38a5f377d3e67a148ad59d6677006e792c29f1c761e
+  data.tar.gz: 9554a58ab329527c02dcb2ec891c532713451bcf495dbcf96add536252db42e11e283d128872332ac896fe7f25fb5e208286991a122241e4795ea4a91a71f305

data/lib/lita/handlers/claims.rb

@@ -18,6 +18,33 @@ module Lita
         "unclaim PROPERTY" => "To remove your claim from a property by the name PROPERTY"
       })
 
+      route(/^force\sunclaim\s(#{PROPERTY_OR_ENVIRONMENT.source})(?:\s(#{PROPERTY_OR_ENVIRONMENT.source}))?/i, :force_destroy, command: true, help: {
+        "force unclaim PROPERTY" => "To remove a claim by someone else from a property by the name PROPERTY"
+      })
+
+      http.get "/available/:property/:requester(/:environment)", :available
+
+      def available(request, response)
+        property = request.env['router.params'][:property]
+        environment = request.env['router.params'][:environment]
+        environment_string = " (#{environment})" if environment
+        requester = request.env['router.params'][:requester]
+        claimer = Claim.read(property, environment)
+        if Claim.exists?(property, environment) && claimer != requester
+          # forbidden
+          response.status = 403
+          response.headers["Content-Type"] = "application/json"
+          response.body = {claimer: claimer}
+          target = Source.new(room: '#devs')
+          robot.send_message(target, "#{requester} tried deploying #{property}#{environment_string} but it has been claimed by #{claimer}.")
+        else
+          # OK
+          response.status = 200
+          response.headers["Content-Type"] = "application/json"
+          response.body = {}
+        end
+      end
+
       def create(response)
         claimer = response.message.source.user.name
         property, environment = response.matches.first
@@ -56,13 +83,26 @@ module Lita
             Claim.destroy(property, environment)
             reply = "#{property}#{environment_string} is no longer claimed."
           else
-            reply = "#{property}#{environment_string} is currently claimed by #{claimer}. Use the --force flag when you are sure to unclaim the property."
+            reply = "#{property}#{environment_string} is currently claimed by #{claimer}. Use the `force unclaim` command when you are sure to unclaim the property."
           end
         else
           reply = "#{property}#{environment_string} has not yet been claimed."
         end
         response.reply(reply)
       end
+
+      def force_destroy(response)
+        property, environment = response.matches.first
+        environment ||= 'default'
+        environment_string = " (#{environment})" if environment != 'default'
+        if property && Claim.exists?(property, environment)
+          Claim.destroy(property, environment)
+          reply = "#{property}#{environment_string} is no longer claimed."
+        else
+          reply = "#{property}#{environment_string} has not yet been claimed."
+        end
+        response.reply(reply)
+      end
     end
 
     Lita.register_handler(Claims)

data/lita-claims.gemspec

@@ -1,21 +1,22 @@
 Gem::Specification.new do |spec|
   spec.name          = "lita-claims"
-  spec.version       = "0.0.2"
+  spec.version       = "0.0.3"
   spec.authors       = ["Hannes Fostie"]
   spec.email         = ["hannes@maloik.co"]
   spec.description   = %q{A Lita.io plugin to claim 'properties'. Usecases include disabling deployments for environments when they are in use'}
   spec.summary       = %q{A Lita.io plugin to claim 'properties'}
   spec.homepage      = "https://github.com/hannesfostie/lita-claims"
   spec.license       = "MIT"
+  spec.metadata      = { "lita_plugin_type" => "handler" }
 
   spec.files         = `git ls-files`.split($/)
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_runtime_dependency "lita", "~> 2.3"
+  spec.add_runtime_dependency "lita", ">= 3.1"
 
   spec.add_development_dependency "bundler", "~> 1.3"
   spec.add_development_dependency "rake"
-  spec.add_development_dependency "rspec", ">= 2.14"
+  spec.add_development_dependency "rspec", ">= 3.0.0.beta2"
 end

data/spec/claim_spec.rb

@@ -47,11 +47,11 @@ describe Claim, lita: true do
 
   describe '#exists?' do
     it 'returns true if the property exists' do
-      expect(subject.exists?('property', 'staging')).to be_true
+      expect(subject.exists?('property', 'staging')).to be true
     end
 
     it 'returns false if the property does not exist' do
-      expect(subject.exists?('property_does_not_exist')).to be_false
+      expect(subject.exists?('property_does_not_exist')).to be false
     end
   end
 end

data/spec/lita/handlers/claims_spec.rb

@@ -10,19 +10,23 @@ describe Lita::Handlers::Claims, lita_handler: true do
 
     it { routes_command('unclaim property').to :destroy }
     it { routes_command('unclaim property environment').to :destroy }
+    it { routes_command('force unclaim property environment').to :force_destroy }
+
+    it { routes_http(:get, '/available/property_x/someone/staging').to(:available) }
+    it { routes_http(:get, '/available/property_x/someone').to(:available) }
   end
 
   describe 'creating claims' do
     it 'replies that the claim was made' do
       send_command 'claim property_x'
       expect(replies.last).to eq('property_x was claimed by Test User.')
-      expect(Claim.exists?('property_x')).to be_true
+      expect(Claim.exists?('property_x')).to be true
     end
 
     it 'replies that the claim was made for a non-default environment' do
       send_command 'claim property_x environment_y'
       expect(replies.last).to eq('property_x (environment_y) was claimed by Test User.')
-      expect(Claim.exists?('property_x', 'environment_y')).to be_true
+      expect(Claim.exists?('property_x', 'environment_y')).to be true
     end
 
     it 'replies that a claim could not be made because it already exists' do
@@ -67,14 +71,14 @@ describe Lita::Handlers::Claims, lita_handler: true do
       Claim.create('property_x', 'Test User')
       send_command 'unclaim property_x'
       expect(replies.last).to eq('property_x is no longer claimed.')
-      expect(Claim.exists?('property_x')).to be_false
+      expect(Claim.exists?('property_x')).to be false
     end
 
     it 'removes a claim on a property for a certain environment' do
       Claim.create('property_x', 'Test User', 'env')
       send_command 'unclaim property_x env'
       expect(replies.last).to eq('property_x (env) is no longer claimed.')
-      expect(Claim.exists?('property_x', 'env')).to be_false
+      expect(Claim.exists?('property_x', 'env')).to be false
     end
 
     it 'returns an error when no such claim exists' do
@@ -85,8 +89,38 @@ describe Lita::Handlers::Claims, lita_handler: true do
     it 'returns an error when the claimer is not the person removing a claim' do
       Claim.create('property_x', 'Not the test user')
       send_command 'unclaim property_x'
-      expect(replies.last).to eq('property_x is currently claimed by Not the test user. Use the --force flag when you are sure to unclaim the property.')
-      expect(Claim.exists?('property_x')).to be_true
+      expect(replies.last).to eq('property_x is currently claimed by Not the test user. Use the `force unclaim` command when you are sure to unclaim the property.')
+      expect(Claim.exists?('property_x')).to be true
+    end
+  end
+
+  describe 'forcing claim removal' do
+    it 'removes your own claim on a property' do
+      Claim.create('property_x', 'Test User')
+      send_command 'force unclaim property_x'
+      expect(replies.last).to eq('property_x is no longer claimed.')
+      expect(Claim.exists?('property_x')).to be false
+    end
+
+    it 'removes your own claim on a property for a certain environment' do
+      Claim.create('property_x', 'Test User', 'env')
+      send_command 'force unclaim property_x env'
+      expect(replies.last).to eq('property_x (env) is no longer claimed.')
+      expect(Claim.exists?('property_x', 'env')).to be false
+    end
+
+    it "removes another person's claim on a property'"do
+      Claim.create('property_x', 'Another User')
+      send_command 'force unclaim property_x'
+      expect(replies.last).to eq('property_x is no longer claimed.')
+      expect(Claim.exists?('property_x')).to be false
+    end
+
+    it "removes another person's claim on a property for a certain environment" do
+      Claim.create('property_x', 'Another User', 'env')
+      send_command 'force unclaim property_x env'
+      expect(replies.last).to eq('property_x (env) is no longer claimed.')
+      expect(Claim.exists?('property_x', 'env')).to be false
     end
   end
 end

metadata

@@ -1,29 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: lita-claims
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Hannes Fostie
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-30 00:00:00.000000000 Z
+date: 2014-05-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lita
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - '>='
       - !ruby/object:Gem::Version
-        version: '2.3'
+        version: '3.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - '>='
       - !ruby/object:Gem::Version
-        version: '2.3'
+        version: '3.1'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -58,14 +58,14 @@ dependencies:
     requirements:
     - - '>='
       - !ruby/object:Gem::Version
-        version: '2.14'
+        version: 3.0.0.beta2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
       - !ruby/object:Gem::Version
-        version: '2.14'
+        version: 3.0.0.beta2
 description: A Lita.io plugin to claim 'properties'. Usecases include disabling deployments
   for environments when they are in use'
 email:
@@ -91,7 +91,8 @@ files:
 homepage: https://github.com/hannesfostie/lita-claims
 licenses:
 - MIT
-metadata: {}
+metadata:
+  lita_plugin_type: handler
 post_install_message: 
 rdoc_options: []
 require_paths: