lita-claims 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 732d239f96492956b6cb2bc64e1f70f466288e11
-  data.tar.gz: 545d89715a2786c0899c85567f409de45158fd3c
+  metadata.gz: 0b0044d0d1c66f9d0e5420a8d51cda79bbd03dc4
+  data.tar.gz: 9e4156919f937a95262e078c2e9f8b2bdf46ca2c
 SHA512:
-  metadata.gz: 181fc3798c01853634389ed24b678755ad07a274c19d6238a8ec9175794c3b2c7de2c16c297f48797da0530f8365331ef0a1becbb16f98c9a51f80c7d513ec53
-  data.tar.gz: 3e12eeb56bcfe1844cbde5f2225dc2290ab2e32c19478799c0652f849223a61c2c31308863e3860e8c7b48c5b3507d3524141e7234ec40a81b5f9a5ad470bd66
+  metadata.gz: e27603ccaba2610838a5c47088513152c6eddba1fe7db65cc100df2e8c35dbad902aa34ba0fe2a38169c706fd4af853037a64249cd5a2788afbeace3694edebb
+  data.tar.gz: 5472a5aaeb0f0fc72b744e8474316beac5bc20dd38df3c69812c6fc9bdd443d37fbd1cadc6b62cac0b40b6aa2f69bc9160ca765de8b29aee8adbd3a6c13e9bf9

data/lib/lita/handlers/claims.rb

@@ -10,16 +10,56 @@ module Lita
         "claim PROPERTY" => "To claim a property by the name PROPERTY"
       })
 
+      route(/^who claimed\s(#{PROPERTY_OR_ENVIRONMENT.source})(?:\s(#{PROPERTY_OR_ENVIRONMENT.source}))?/i, :exists?, command: true, help: {
+        "who claimed PROPERTY" => "To see who claimed a property by the name PROPERTY"
+      })
+
+      route(/^unclaim\s(#{PROPERTY_OR_ENVIRONMENT.source})(?:\s(#{PROPERTY_OR_ENVIRONMENT.source}))?/i, :destroy, command: true, help: {
+        "unclaim PROPERTY" => "To remove your claim from a property by the name PROPERTY"
+      })
+
       def create(response)
         claimer = response.message.source.user.name
         property, environment = response.matches.first
         environment ||= 'default'
         environment_string = " (#{environment})" if environment != 'default'
         if property && Claim.create(property, claimer, environment)
-          reply = "#{property}#{environment_string} was claimed by #{claimer}"
+          reply = "#{property}#{environment_string} was claimed by #{claimer}."
         else
           existing_claimer = Claim.read(property, environment)
-          reply = "Could not claim #{property}#{environment_string} - already claimed by #{existing_claimer}"
+          reply = "Could not claim #{property}#{environment_string} - already claimed by #{existing_claimer}."
+        end
+        response.reply(reply)
+      end
+
+      def exists?(response)
+        property, environment = response.matches.first
+        environment ||= 'default'
+        environment_string = " (#{environment})" if environment != 'default'
+        if property && Claim.exists?(property, environment)
+          claimer = Claim.read(property, environment)
+          reply = "#{property}#{environment_string} is currently claimed by #{claimer}."
+        else
+          reply = "#{property}#{environment_string} has not been claimed."
+        end
+        response.reply(reply)
+      end
+
+      def destroy(response)
+        unclaimer = response.message.source.user.name
+        property, environment = response.matches.first
+        environment ||= 'default'
+        environment_string = " (#{environment})" if environment != 'default'
+        if property && Claim.exists?(property, environment)
+          claimer = Claim.read(property, environment)
+          if claimer == unclaimer
+            Claim.destroy(property, environment)
+            reply = "#{property}#{environment_string} is no longer claimed."
+          else
+            reply = "#{property}#{environment_string} is currently claimed by #{claimer}. Use the --force flag when you are sure to unclaim the property."
+          end
+        else
+          reply = "#{property}#{environment_string} has not yet been claimed."
         end
         response.reply(reply)
       end

data/lita-claims.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = "lita-claims"
-  spec.version       = "0.0.1"
+  spec.version       = "0.0.2"
   spec.authors       = ["Hannes Fostie"]
   spec.email         = ["hannes@maloik.co"]
   spec.description   = %q{A Lita.io plugin to claim 'properties'. Usecases include disabling deployments for environments when they are in use'}

data/spec/lita/handlers/claims_spec.rb

@@ -4,29 +4,89 @@ describe Lita::Handlers::Claims, lita_handler: true do
   describe 'routes' do
     it { routes_command('claim property').to :create }
     it { routes_command('claim property environment').to :create }
+
+    it { routes_command('who claimed property').to :exists? }
+    it { routes_command('who claimed property environment').to :exists? }
+
+    it { routes_command('unclaim property').to :destroy }
+    it { routes_command('unclaim property environment').to :destroy }
   end
 
   describe 'creating claims' do
     it 'replies that the claim was made' do
       send_command 'claim property_x'
-      expect(replies.last).to eq('property_x was claimed by Test User')
+      expect(replies.last).to eq('property_x was claimed by Test User.')
+      expect(Claim.exists?('property_x')).to be_true
     end
 
     it 'replies that the claim was made for a non-default environment' do
       send_command 'claim property_x environment_y'
-      expect(replies.last).to eq('property_x (environment_y) was claimed by Test User')
+      expect(replies.last).to eq('property_x (environment_y) was claimed by Test User.')
+      expect(Claim.exists?('property_x', 'environment_y')).to be_true
     end
 
     it 'replies that a claim could not be made because it already exists' do
       Claim.create('property', 'Test User')
       send_command 'claim property'
-      expect(replies.last).to eq('Could not claim property - already claimed by Test User')
+      expect(replies.last).to eq('Could not claim property - already claimed by Test User.')
     end
 
     it 'replies that a claim could not be made for a non-default environment because it already exists' do
       Claim.create('property', 'Test User', 'env')
       send_command 'claim property env'
-      expect(replies.last).to eq('Could not claim property (env) - already claimed by Test User')
+      expect(replies.last).to eq('Could not claim property (env) - already claimed by Test User.')
+    end
+  end
+
+  describe 'check if property has been claimed' do
+    it 'replies who claimed a property' do
+      Claim.create('property_x', 'claimer')
+      send_command 'who claimed property_x'
+      expect(replies.last).to eq('property_x is currently claimed by claimer.')
+    end
+
+    it 'replies who claimed a property with environment' do
+      Claim.create('property_x', 'claimer', 'some_env')
+      send_command 'who claimed property_x some_env'
+      expect(replies.last).to eq('property_x (some_env) is currently claimed by claimer.')
+    end
+
+    it 'replies that a property has not been claimed' do
+      send_command 'who claimed property_x'
+      expect(replies.last).to eq('property_x has not been claimed.')
+    end
+
+    it 'replies that a property has not been claimed with environment' do
+      send_command 'who claimed property_x some_env'
+      expect(replies.last).to eq('property_x (some_env) has not been claimed.')
+    end
+  end
+
+  describe 'removing your claims' do
+    it 'removes a claim on a property' do
+      Claim.create('property_x', 'Test User')
+      send_command 'unclaim property_x'
+      expect(replies.last).to eq('property_x is no longer claimed.')
+      expect(Claim.exists?('property_x')).to be_false
+    end
+
+    it 'removes a claim on a property for a certain environment' do
+      Claim.create('property_x', 'Test User', 'env')
+      send_command 'unclaim property_x env'
+      expect(replies.last).to eq('property_x (env) is no longer claimed.')
+      expect(Claim.exists?('property_x', 'env')).to be_false
+    end
+
+    it 'returns an error when no such claim exists' do
+      send_command 'unclaim property_x'
+      expect(replies.last).to eq('property_x has not yet been claimed.')
+    end
+
+    it 'returns an error when the claimer is not the person removing a claim' do
+      Claim.create('property_x', 'Not the test user')
+      send_command 'unclaim property_x'
+      expect(replies.last).to eq('property_x is currently claimed by Not the test user. Use the --force flag when you are sure to unclaim the property.')
+      expect(Claim.exists?('property_x')).to be_true
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lita-claims
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Hannes Fostie
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-11 00:00:00.000000000 Z
+date: 2014-04-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lita