lita-activedirectory 0.2.6 → 0.2.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c2116b9afea5a43594d2a05dcb820478bf7dc77b
-  data.tar.gz: 3064e8736c414881a2f8315e03078156d907d377
+  metadata.gz: 412986b1be4db4a3d2784fa4801428741f52db16
+  data.tar.gz: ccd12b861e7828310332e03443e7c2de3593bf46
 SHA512:
-  metadata.gz: 5bd717b7b920ea433a22c91f66d96c7ebf01387d9b46410f87b4cbb1b8aba5dd82ac151c526ae457f4857ca88f413e6f2de6e1243dabd7f4e42dc761f85c7880
-  data.tar.gz: 5a328472b8201cbf8cf0edb32400e4bf2e2f7ec192fc449aa94219a473902483685cce4aa49ec1ad5c028af7db3a10f79f9c9b56f9a52558f7ae5c2a8380195d
+  metadata.gz: 83f7c00513b82d81387530b8e7a2405cf5c266d6b88cdda5f36676d46cc05a99a9cb64d9f00a94e22e1a78ba9fb1a9583fb71c89bbbafc0a25de00ae6b0290a7
+  data.tar.gz: d9dcca88b3e7cf255da6422e91582d402cf2829b24f9db0b0fc5c46dd417d3766b7fbe93ab46ee18d7a544f9fb5b736b16ae09fb0ce2f62d8df7aefc10a362cf

data/.gitignore

@@ -15,3 +15,4 @@ spec/reports
 test/tmp
 test/version_tmp
 tmp
+dump.rdb

data/.rubocop.yml

@@ -17,3 +17,11 @@ Metrics/MethodLength:
 
 Metrics/ClassLength:
   Max: 150
+
+Metrics/BlockLength:
+  Max: 30
+  Exclude:
+    - '*.gemspec'
+    - Rakefile
+    - 'spec/**/*_spec.rb'
+    - 'spec/spec_helper.rb'

data/README.md

@@ -1,5 +1,5 @@
 # lita-activedirectory
-[![Build Status](https://travis-ci.org/knuedge/lita-activedirectory.svg?branch=master)](https://travis-ci.org/knuedge/lita-activedirectory)
+[![Build Status](https://travis-ci.org/knuedge/lita-activedirectory.svg?branch=master)](https://travis-ci.org/knuedge/lita-activedirectory) [![MIT License](https://img.shields.io/badge/license-MIT-brightgreen.svg)](https://tldrlegal.com/license/mit-license) [![Gem](https://img.shields.io/gem/v/formatador.svg)](https://rubygems.org/gems/lita-activedirectory) [![Code Climate](https://codeclimate.com/github/knuedge/lita-activedirectory/badges/gpa.svg)](https://codeclimate.com/github/knuedge/lita-activedirectory)
 
 A [Lita](https://www.lita.io/) handler plugin for basic interactions with Active Directory.
 
@@ -33,4 +33,7 @@ The user account specified in `config.handlers.activedirectory.username` must ha
 ### List a User's Group Memberships
 `<username> groups>`
 
+### List a Group's Members
+`group <groupname> members`
+
 

data/lib/lita/handlers/activedirectory.rb

@@ -31,6 +31,13 @@ module Lita
         help: { t('help.user_groups.syntax') => t('help.user_groups.desc') }
       )
 
+      route(
+        /^(group)\s+(\S+)\s+(members)$/i,
+        :group_members,
+        command: true,
+        help: { t('help.group_members.syntax') => t('help.group_members.desc') }
+      )
+
       include ::Utils::Cratususer
 
       def user_locked?(response)
@@ -63,6 +70,19 @@ module Lita
         end
       end
 
+      def group_members(response)
+        group = response.matches[0][1]
+        response.reply_with_mention(t('replies.group_members.working'))
+        result = group_mem_query(group)
+        if result.nil?
+          response.reply_with_mention(
+            t('replies.group_members.error, group: group')
+          )
+        else
+          response.reply result
+        end
+      end
+
       private
 
       def handle_user_query(response, user, result)

data/lib/utils/cratususer.rb

@@ -36,6 +36,17 @@ module Utils
       groups.map(&:name).join("\n")
     end
 
+    def group_mem_query(groupname)
+      cratus_connect
+      group = begin
+        Cratus::Group.new(groupname.to_s)
+      rescue
+        nil
+      end
+      members = group.members
+      members.map(&:fullname).join("\n")
+    end
+
     def unlock_user(username)
       ldap = Cratus::LDAP.connection
       ldap.replace_attribute Cratus::User.new(username.to_s).dn, :lockouttime, '0'

data/lita-activedirectory.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = 'lita-activedirectory'
-  spec.version       = '0.2.6'
+  spec.version       = '0.2.7'
   spec.authors       = ['Daniel Schaaff']
   spec.email         = ['dschaaff@knuedge.com']
   spec.description   = 'ldap/active directory instructions for Lita'
@@ -25,6 +25,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rack-test'
   spec.add_development_dependency 'rspec', '>= 3.0.0'
   spec.add_development_dependency 'simplecov'
+  spec.add_development_dependency 'codeclimate-test-reporter', '~> 1.0.0'
   spec.add_development_dependency 'coveralls'
   spec.add_development_dependency 'rubocop'
   spec.add_development_dependency 'travis', '~> 1.8'

data/locales/en.yml

@@ -12,6 +12,9 @@ en:
           user_groups:
             syntax: <username> groups
             desc: lists all group memberships for the given username
+          group_members:
+            syntax: group <groupname> members
+            desc: lists all members of the given group
         replies:
           user_locked?:
             working: let me check on that
@@ -27,3 +30,6 @@ en:
             success: "'%{user}' is a member of"
             not_found: "could not find any groups that '%{user}' is a member of"
             error: "That did not work, double check the '%{user}' is a valid samAccountName"
+          group_members:
+            working: Give me a second to search
+            error: "That did not work, double check the '%{group}' is a valid group name"

data/spec/lita/handlers/activedirectory_spec.rb

@@ -1,4 +1,78 @@
 require 'spec_helper'
 
 describe Lita::Handlers::Activedirectory, lita_handler: true do
+  before do
+    registry.config.handlers.activedirectory.host = 'ldap.example.com'
+    registry.config.handlers.activedirectory.basedn = 'dc=example,dc=com'
+    registry.config.handlers.activedirectory.user_basedn = 'ou=users,dc=example,dc=com'
+    registry.config.handlers.activedirectory.group_basedn = 'ou=groups,dc=example,dc=com'
+    registry.config.handlers.activedirectory.username = 'user'
+    registry.config.handlers.activedirectory.password = 'pass'
+  end
+
+  it 'should have the necessary routes' do
+    is_expected.to route_command('is jdoe locked').to(:user_locked?)
+    is_expected.to route_command('is jdoe locked?').to(:user_locked?)
+    is_expected.to route_command('unlock jdoe').to(:unlock)
+    is_expected.to route_command('jdoe groups').to(:user_groups)
+    is_expected.to route_command('group foo members').to(:group_members)
+  end
+
+  let(:locked_user) do
+    testuser = instance_double(
+      'Cratus::User',
+      dn: 'cn=jdoe,dc=example,dc=com',
+      lockouttime: '124',
+      locked?: true
+    )
+    testuser
+  end
+
+  let(:unlocked_user) do
+    testuser = instance_double(
+      'Cratus::User',
+      dn: 'cn=jdoe,dc=example,dc=com',
+      lockouttime: '0',
+      locked?: false
+    )
+    testuser
+  end
+
+  describe '#user_locked?' do
+    it 'lets you know if the user is locked' do
+      allow(Cratus::LDAP).to receive(:connect).and_return(true)
+      allow(Cratus::User).to receive(:new).and_return(locked_user)
+      send_command('is jdoe locked?')
+      expect(replies.first).to eq('let me check on that')
+      expect(replies.last).to eq("looks like 'jdoe' is locked")
+    end
+    it 'lets you know if a user is not locked' do
+      allow(Cratus::LDAP).to receive(:connect).and_return(true)
+      allow(Cratus::User).to receive(:new).and_return(unlocked_user)
+      send_command('is jdoe locked?')
+      expect(replies.first).to eq('let me check on that')
+      expect(replies.last).to eq("'jdoe' is not locked")
+    end
+  end
+
+  describe '#unlock' do
+    it 'unlocks the user when locked' do
+      allow(Cratus::LDAP).to receive(:connect).and_return(true)
+      allow(Cratus::LDAP).to receive(:connection).and_return(true)
+      allow(Cratus::User).to receive(:new).and_return(locked_user)
+      allow(Cratus::LDAP.connection).to receive(:replace_attribute).and_return(true)
+      send_command('unlock jdoe')
+      expect(replies.first).to eq('lets see what we can do')
+      expect(replies.last).to eq("'jdoe' has been unlocked")
+    end
+    it 'lets you know if the user is not locked' do
+      allow(Cratus::LDAP).to receive(:connect).and_return(true)
+      allow(Cratus::LDAP).to receive(:connection).and_return(true)
+      allow(Cratus::User).to receive(:new).and_return(unlocked_user)
+      allow(Cratus::LDAP.connection).to receive(:replace_attribute).and_return(true)
+      send_command('unlock jdoe')
+      expect(replies.first).to eq('lets see what we can do')
+      expect(replies.last).to eq("'jdoe' is not locked")
+    end
+  end
 end

data/spec/spec_helper.rb

@@ -1,8 +1,8 @@
 require 'simplecov'
-require 'coveralls'
+# require 'coveralls'
 SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[
   SimpleCov::Formatter::HTMLFormatter,
-  Coveralls::SimpleCov::Formatter
+  # Coveralls::SimpleCov::Formatter
 ]
 SimpleCov.start { add_filter '/spec/' }
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lita-activedirectory
 version: !ruby/object:Gem::Version
-  version: 0.2.6
+  version: 0.2.7
 platform: ruby
 authors:
 - Daniel Schaaff
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-12-15 00:00:00.000000000 Z
+date: 2017-03-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lita
@@ -122,6 +122,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: codeclimate-test-reporter
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.0.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.0.0
 - !ruby/object:Gem::Dependency
   name: coveralls
   requirement: !ruby/object:Gem::Requirement