listable_collections 5.1.0 → 5.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: d47c9d32ec17aa0389a54c9e415ec1a380792809
-  data.tar.gz: 3966124268625ebfa2be2455f44415b6ba0070d6
+SHA256:
+  metadata.gz: a930da030243d9469bca798a65dd6ef3ddb4dbe4fd6e1ed685bfe1352d11cf9f
+  data.tar.gz: 30fd2504c7059326fb97bf262daf7909eefc815d74c12257828c0974d32e59b1
 SHA512:
-  metadata.gz: ba45f4d4bd8a4e131314e2204184e20c459b63ed2738df2e38008efc0d82bf889d292d7005290e6b9a220440f0caaffce4b3d5cc31a74661a4748683483c95bc
-  data.tar.gz: 55858a79e778ea6def559e5d720afec00b745559d31cd9fd266b96e0f4663fee09a34ca4c9c4887c655745e4866f581a3f21a4c697a124a32b28a4e23c82530c
+  metadata.gz: 95fbc6c124e898592d753e45c821897f089259edfba8b7a1f988559acf4fc3f79ede7fd757b846a4c868e2e44edb8b7fdfaf5e01d657b90e906f3e2698c30262
+  data.tar.gz: c5bd31e8ae2588e8ac763588de147685fa34da6c7eb5e869c1fd27ccc28886589d67b9296d266c2f88fe90bbcb7d4564b68b265f16690102800ed8054c0a6ee1

data/README.md

@@ -9,11 +9,12 @@ Makes collections accessible from a string list in rails.
 
 ## Why
 
-I did this gem to:
+We did this gem to:
 
 - Easily manage collections from input text field.
 - Track changes like dirty module in activerecord.
 - Have callbacks like has_many associations.
+- Automatically handle join models creation/deletion.
 
 ## Install
 
@@ -33,28 +34,30 @@ $ bundle
 
 If you want to list a has_many association:
 ```ruby
-class Shop < ActiveRecord::Base
+class Product < ApplicationRecord
 
-  has_many :products
+  has_many :tagizations
+  has_many :tags, through: :tagizations
 
-  list :products, attribute: :name
+  listify :tags, by: :name
 
 end
 ```
 
-Associated records won't be touched but changes will be tracked using the following helpers:
+Associated records will be synced and chances will be tracked using the following helpers:
 ```ruby
-shop.products.map(&:name) => ['iPhone']
-shop.product_list => 'iPhone'
+product.tags.map(&:name) => ['New']
+product.tag_list => 'New'
 
-shop.product_list = 'iPod,iMac'
-shop.products.map(&:name) => ['iPhone']
+product.tag_list = 'Natural'
+product.tagizations.reject(&:marked_for_destruction?).map(&:tag).map(&:name) => ['Natural']
+product.tagizations.select(&:marked_for_destruction?).map(&:tag).map(&:name) => ['New']
 
-shop.added_products_to_list => ['iMac']
-shop.removed_products_from_list => ['iPod']
+product.added_tags_to_list => ['Natural']
+product.removed_tags_from_list => ['New']
 ```
 
-NOTE: Is recommended to do this check before save all at once and not dynamically to avoid multiple queries.
+NOTE: The gem will handle automatically creation/deletion if you use a has many through association.
 
 ### Attributes
 
@@ -64,7 +67,7 @@ class Product < ActiveRecord::Base
 
   serialize :sizes, Array
 
-  list :sizes
+  listify :sizes
 
 end
 ```
@@ -83,17 +86,17 @@ product.removed_sizes_from_list => ['64GB']
 
 In some cases you may need to run some logic after changes, you can use callbacks for it:
 ```ruby
-class Shop < ActiveRecord::Base
+class Product < ActiveRecord::Base
 
-  has_many :product
+  serialize :sizes, Array
 
-  list :products, attribute: :name, after_add: :product_added, after_remove: :product_removed
+  listify :sizes, after_add: :size_added, after_remove: :size_removed
 
-  def product_added(name)
+  def size_added(name)
     # Some logic
   end
 
-  def product_removed(name)
+  def size_removed(name)
     # Some logic
   end
 
@@ -104,7 +107,7 @@ end
 
 Any issue, pull request, comment of any kind is more than welcome!
 
-I will mainly ensure compatibility to Rails, AWS, PostgreSQL, Redis, Elasticsearch and FreeBSD. 
+We will mainly ensure compatibility to Rails, AWS, PostgreSQL, Redis, Elasticsearch and FreeBSD. 
 
 ## Credits
 

data/Rakefile

@@ -12,6 +12,7 @@ Rake::TestTask.new(:test) do |t|
   t.libs << 'test'
   t.pattern = 'test/**/*_test.rb'
   t.verbose = false
+  t.warning = false
 end
 
 task default: :test

data/lib/listable_collections/builder.rb

@@ -29,23 +29,42 @@ module ListableCollections
         define_method "#{name}=" do |value|
           current_values = send(name).split(',')
           new_values = value.split(',').reject(&:blank?).map(&:strip)
-          value = ((current_values & new_values) + (new_values - current_values))
           if current_values.sort != new_values.sort
-            if options.has_key?(:attribute)
-              attribute_will_change! name
-              instance_variable_set variable, value.join(',')
+            attribute_will_change! name
+            instance_variable_set variable, new_values.join(',')
+            added_values = (new_values - current_values)
+            removed_values = (current_values - new_values)
+            if relation_attribute = options[:by]
+              reflection = self.class.reflections[attribute.to_s]
+              scope = options[:scope]
+              relation = (scope ? send(scope).send(attribute) : reflection.klass)
+              added_values.each do |added_value|
+                send(attribute) << relation.find_or_initialize_by(
+                  relation_attribute => added_value
+                )
+              end
+              through = reflection.options[:through]
+              source = reflection.source_reflection.name
+              removed_values.each do |removed_value|
+                send(through).each do |record|
+                  if record.send(source).send(relation_attribute) == removed_value
+                    record.mark_for_destruction
+                  end
+                end
+              end
             else
               attribute_will_change! name
-              send "#{attribute}=", value
+              new_value = ((current_values & new_values) + (new_values - current_values))
+              send "#{attribute}=", new_value
             end
-            if options.has_key?(:after_add)
-              (new_values - current_values).each do |added_value|
-                send options[:after_add], added_value
+            if add_callback = options[:after_add]
+              added_values.each do |added_value|
+                send add_callback, added_value
               end
             end
-            if options.has_key?(:after_remove)
-              (current_values - new_values).each do |removed_value|
-                send options[:after_remove], removed_value
+            if remove_callback = options[:after_remove]
+              removed_values.each do |removed_value|
+                send remove_callback, removed_value
               end
             end
           end
@@ -59,12 +78,12 @@ module ListableCollections
           if list = instance_variable_get(variable)
             list
           elsif values = send(attribute)
-            if options.has_key?(:attribute)
+            if relation_attribute = options[:by]
               values = values.map do |record|
-                record.send options[:attribute]
+                record.send relation_attribute
               end
             end
-            values.join(',')
+            values.join ','
           end
         end
       end

data/lib/listable_collections/extensions/active_record/base.rb

@@ -6,7 +6,7 @@ module ListableCollections
 
         module ClassMethods
 
-          def list(*args)
+          def listify(*args)
             options = args.extract_options!
             builder = Builder.new(self)
             args.each do |attribute|

data/lib/listable_collections/version.rb

@@ -1,5 +1,5 @@
 module ListableCollections
 
-  VERSION = '5.1.0'
+  VERSION = '5.1.1'
 
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: listable_collections
 version: !ruby/object:Gem::Version
-  version: 5.1.0
+  version: 5.1.1
 platform: ruby
 authors:
 - mmontossi
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-09-27 00:00:00.000000000 Z
+date: 2018-01-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -87,7 +87,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.13
+rubygems_version: 2.7.3
 signing_key: 
 specification_version: 4
 summary: Listable collections for rails.