linzer 0.7.5 → 0.7.7.beta1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0cb9025767ae44e70b7a9462fa9f587fb99c34080e6903efd5b1fdf505c8ae98
-  data.tar.gz: 2df4758cb77e19d255fcc1e135a1f67a4f5203cdc8cef2535ae148c7a3f0901a
+  metadata.gz: 4a0c6679a12f4d81ad0c404c0250e968540434ef2ea973c0d15efc946b337ec8
+  data.tar.gz: e6ab100316577c1f5b4c0b407ba6a23bb9815dc944f0cbd88d664f86a1601ae9
 SHA512:
-  metadata.gz: 7f5807077e46c27db08d764f0b696421bbf61cd04b0906ce6d14d547a22149cfbf8a7496559d363a73fa4ee1d7e0b8e5e9187ed84dd0d491a6fec59f8fd673fa
-  data.tar.gz: 491a60772d4eb2da91c0ac9b1bb3dce27d61538c43a1ac78b28a804e0344a8f265f5ccc5a444b9a34391300513a289f8e9d4f194550683f8295a9d8fe5e82569
+  metadata.gz: 4c90ad154c524fe517baf299cae1071b890071db735c2ea5f029f5c471f7cc652ce301675d7a20223dad3b18b923f60bdd9cfb1c5ed4e5896f06fa66e37ad3cf
+  data.tar.gz: 3503fb59e52628fcb2df866045b95731b823a0e31df79e07e419e088f19707a42b6f36d8cccb1e6c8e20cc5f071dc16e5de986b2a5927c208a26ffff82cb5538

data/CHANGELOG.md

@@ -1,5 +1,18 @@
 ## [Unreleased]
 
+## [0.7.7.beta1] - 2025-07-07
+
+- Introduce generic adapters for typical requests and responses.
+  This allows adapter classes to stop inheriting functionality from totally
+  unrelated implementations by relying on a saner hierarchy class. 
+
+## [0.7.6] - 2025-07-03
+
+- Fix a bug in the `Linzer::Message::Adapter::HTTPGem::Response` class where
+  the serialized id of fields like derived `@status` were not recognized.
+  This issue caused signature creation and verification to fail for `HTTP::Response`
+  instances. (Issue [#16](https://github.com/nomadium/linzer/issues/16))
+
 ## [0.7.5] - 2025-06-30
 
 - No changes since 0.7.4.

data/lib/linzer/message/adapter/abstract.rb

@@ -16,8 +16,6 @@ module Linzer
           self.class.to_s.include?("Response")
         end
 
-        # XXX: attached request as specified in RFC has to be tested for Net::HTTP classes
-        # and custom HTTP message classes
         def attached_request?
           response? && !!@attached_request
         end

data/lib/linzer/message/adapter/generic/request.rb

@@ -0,0 +1,58 @@
+# frozen_string_literal: true
+
+require "cgi"
+
+module Linzer
+  class Message
+    module Adapter
+      module Generic
+        class Request < Abstract
+          def initialize(operation, **options)
+            @operation = operation
+            freeze
+          end
+
+          def header(name)
+            @operation[name]
+          end
+
+          def attach!(signature)
+            signature.to_h.each { |h, v| @operation[h] = v }
+            @operation
+          end
+
+          private
+
+          def derived(name)
+            unimplemented_method = 'Derived field "@method" lookup is not implemented!'
+            case name.value
+            when "@method"         then raise Error, unimplemented_method
+            when "@target-uri"     then @operation.uri.to_s
+            when "@authority"      then @operation.uri.authority.downcase
+            when "@scheme"         then @operation.uri.scheme.downcase
+            when "@request-target" then @operation.uri.request_uri
+            when "@path"           then @operation.uri.path
+            when "@query"          then "?%s" % String(@operation.uri.query)
+            when "@query-param"    then query_param(name)
+            end
+          end
+
+          def query_param(name)
+            param_name = name.parameters["name"]
+            return nil if !param_name
+            decoded_param_name = URI.decode_uri_component(param_name)
+            params = CGI.parse(@operation.uri.query)
+            URI.encode_uri_component(params[decoded_param_name]&.first)
+          end
+
+          def field(name)
+            has_tr = name.parameters["tr"]
+            return nil if has_tr # HTTP requests don't have trailer fields
+            value = @operation[name.value.to_s]
+            value.dup&.strip
+          end
+        end
+      end
+    end
+  end
+end

data/lib/linzer/message/adapter/generic/response.rb

@@ -0,0 +1,41 @@
+# frozen_string_literal: true
+
+module Linzer
+  class Message
+    module Adapter
+      module Generic
+        class Response < Abstract
+          def initialize(operation, **options)
+            @operation = operation
+            attached_request = options[:attached_request]
+            @attached_request = attached_request ? Message.new(attached_request) : nil
+            validate_attached_request @attached_request if @attached_request
+            freeze
+          end
+
+          def header(name)
+            @operation[name]
+          end
+
+          def attach!(signature)
+            signature.to_h.each { |h, v| @operation[h] = v }
+            @operation
+          end
+
+          private
+
+          def derived(name)
+            raise Linzer::Error, "Sub-classes are required to implement this method!"
+          end
+
+          def field(name)
+            has_tr = name.parameters["tr"]
+            return nil if has_tr # is there a library actually supporting trailers?
+            value = @operation[name.value.to_s]
+            value.dup&.strip
+          end
+        end
+      end
+    end
+  end
+end

data/lib/linzer/message/adapter/http_gem/request.rb

@@ -4,11 +4,7 @@ module Linzer
   class Message
     module Adapter
       module HTTPGem
-        class Request < Linzer::Message::Adapter::NetHTTP::Request
-          def header(name)
-            @operation[name]
-          end
-
+        class Request < Generic::Request
           private
 
           def derived(name)

data/lib/linzer/message/adapter/http_gem/response.rb

@@ -1,32 +1,21 @@
 # frozen_string_literal: true
 
-# Example HTTP message adapter for HTTP::Response class from http ruby gem.
+# HTTP message adapter for HTTP::Response class from http ruby gem.
 # https://github.com/httprb/http
-# It's not required automatically to avoid making http gem a dependency.
+#
+# It's not loaded automatically to avoid making http gem a dependency.
 #
 module Linzer
   class Message
     module Adapter
       module HTTPGem
-        class Response < Abstract
-          def initialize(operation, **options)
-            @operation = operation
-            freeze
-          end
-
-          def header(name)
-            @operation[name]
-          end
-
-          # XXX: this implementation is incomplete, e.g.: ;tr parameter is not supported yet
-          def [](field_name)
-            return @operation.code if field_name == "@status"
-            @operation[field_name]
-          end
+        class Response < Generic::Response
+          private
 
-          def attach!(signature)
-            signature.to_h.each { |h, v| @operation[h] = v }
-            @operation
+          def derived(name)
+            case name.value
+            when "@status" then @operation.status.to_i
+            end
           end
         end
       end

data/lib/linzer/message/adapter/net_http/request.rb

@@ -1,54 +1,15 @@
 # frozen_string_literal: true
 
-require "cgi"
-
 module Linzer
   class Message
     module Adapter
       module NetHTTP
-        class Request < Abstract
-          def initialize(operation, **options)
-            @operation = operation
-            freeze
-          end
-
-          def header(name)
-            @operation[name]
-          end
-
-          def attach!(signature)
-            signature.to_h.each { |h, v| @operation[h] = v }
-            @operation
-          end
-
+        class Request < Generic::Request
           private
 
           def derived(name)
-            case name.value
-            when "@method"         then @operation.method
-            when "@target-uri"     then @operation.uri.to_s
-            when "@authority"      then @operation.uri.authority.downcase
-            when "@scheme"         then @operation.uri.scheme.downcase
-            when "@request-target" then @operation.uri.request_uri
-            when "@path"           then @operation.uri.path
-            when "@query"          then "?%s" % String(@operation.uri.query)
-            when "@query-param"    then query_param(name)
-            end
-          end
-
-          def query_param(name)
-            param_name = name.parameters["name"]
-            return nil if !param_name
-            decoded_param_name = URI.decode_uri_component(param_name)
-            params = CGI.parse(@operation.uri.query)
-            URI.encode_uri_component(params[decoded_param_name]&.first)
-          end
-
-          def field(name)
-            has_tr = name.parameters["tr"]
-            return nil if has_tr # HTTP requests don't have trailer fields
-            value = @operation[name.value.to_s]
-            value.dup&.strip
+            return @operation.method if name.value == "@method"
+            super
           end
         end
       end

data/lib/linzer/message/adapter/net_http/response.rb

@@ -4,24 +4,7 @@ module Linzer
   class Message
     module Adapter
       module NetHTTP
-        class Response < Abstract
-          def initialize(operation, **options)
-            @operation = operation
-            attached_request = options[:attached_request]
-            @attached_request = attached_request ? Message.new(attached_request) : nil
-            validate_attached_request @attached_request if @attached_request
-            freeze
-          end
-
-          def header(name)
-            @operation[name]
-          end
-
-          def attach!(signature)
-            signature.to_h.each { |h, v| @operation[h] = v }
-            @operation
-          end
-
+        class Response < Generic::Response
           private
 
           def derived(name)
@@ -29,14 +12,6 @@ module Linzer
             when "@status" then @operation.code.to_i
             end
           end
-
-          # XXX: this implementation is incomplete, e.g.: ;bs parameter is not supported yet
-          def field(name)
-            has_tr = name.parameters["tr"]
-            return nil if has_tr # Net::HTTP doesn't support trailers
-            value = @operation[name.value.to_s]
-            value.dup&.strip
-          end
         end
       end
     end

data/lib/linzer/message/adapter.rb

@@ -1,6 +1,8 @@
 # frozen_string_literal: true
 
 require_relative "adapter/abstract"
+require_relative "adapter/generic/request"
+require_relative "adapter/generic/response"
 require_relative "adapter/rack/common"
 require_relative "adapter/rack/request"
 require_relative "adapter/rack/response"

data/lib/linzer/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Linzer
-  VERSION = "0.7.5"
+  VERSION = "0.7.7.beta1"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: linzer
 version: !ruby/object:Gem::Version
-  version: 0.7.5
+  version: 0.7.7.beta1
 platform: ruby
 authors:
 - Miguel Landaeta
@@ -203,6 +203,8 @@ files:
 - lib/linzer/message.rb
 - lib/linzer/message/adapter.rb
 - lib/linzer/message/adapter/abstract.rb
+- lib/linzer/message/adapter/generic/request.rb
+- lib/linzer/message/adapter/generic/response.rb
 - lib/linzer/message/adapter/http_gem/request.rb
 - lib/linzer/message/adapter/http_gem/response.rb
 - lib/linzer/message/adapter/net_http/request.rb