linux_admin 0.9.1 → 0.9.2

data/spec/spec_helper.rb

@@ -1,31 +1,82 @@
 # This file was generated by the `rspec --init` command. Conventionally, all
 # specs live under a `spec` directory, which RSpec adds to the `$LOAD_PATH`.
-# Require this file using `require "spec_helper"` to ensure that it is only
-# loaded once.
+# The generated `.rspec` file contains `--require spec_helper` which will cause this
+# file to always be loaded, without a need to explicitly require it in any files.
+#
+# Given that it is always loaded, you are encouraged to keep this file as
+# light-weight as possible. Requiring heavyweight dependencies from this file
+# will add to the boot time of your test suite on EVERY test run, even for an
+# individual file that may not need all of that loaded. Instead, make a
+# separate helper file that requires this one and then use it only in the specs
+# that actually need it.
+#
+# The `.rspec` file also contains a few flags that are not defaults but that
+# users commonly want.
 #
 # See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
 RSpec.configure do |config|
-  config.treat_symbols_as_metadata_keys_with_true_values = true
+# The settings below are suggested to provide a good initial experience
+# with RSpec, but feel free to customize to your heart's content.
+
+  # These two settings work together to allow you to limit a spec run
+  # to individual examples or groups you care about by tagging them with
+  # `:focus` metadata. When nothing is tagged with `:focus`, all examples
+  # get run.
+  config.filter_run :focus
   config.run_all_when_everything_filtered = true
-  # config.filter_run :focus
+
+  # Many RSpec users commonly either run the entire suite or an individual
+  # file, and it's useful to allow more verbose output when running an
+  # individual spec file.
+  if config.files_to_run.one?
+    # Use the documentation formatter for detailed output,
+    # unless a formatter has already been configured
+    # (e.g. via a command-line flag).
+    config.default_formatter = 'doc'
+  end
+
+  # Print the 10 slowest examples and example groups at the
+  # end of the spec run, to help surface which specs are running
+  # particularly slow.
+  # config.profile_examples = 10
 
   # Run specs in random order to surface order dependencies. If you find an
   # order dependency and want to debug it, you can fix the order by providing
   # the seed, which is printed after each run.
   #     --seed 1234
-  config.order = 'random'
+  config.order = :random
 
-  config.before do
-    Kernel.stub(:spawn).and_raise("Spawning is not permitted in specs.  Please change your spec to use expectations/stubs.")
-    # by default, have it say it is running Red Hat linux
-    stub_distro
+  # Seed global randomization in this process using the `--seed` CLI option.
+  # Setting this allows you to use `--seed` to deterministically reproduce
+  # test failures related to randomization by passing the same `--seed` value
+  # as the one that triggered the failure.
+  Kernel.srand config.seed
+
+  # rspec-expectations config goes here. You can use an alternate
+  # assertion/expectation library such as wrong or the stdlib/minitest
+  # assertions if you prefer.
+  config.expect_with :rspec do |expectations|
+    # Enable only the newer, non-monkey-patching expect syntax.
+    # For more details, see:
+    #   - http://myronmars.to/n/dev-blog/2012/06/rspecs-new-expectation-syntax
+    expectations.syntax = :expect
+  end
+
+  # rspec-mocks config goes here. You can use an alternate test double
+  # library (such as bogus or mocha) by changing the `mock_with` option here.
+  config.mock_with :rspec do |mocks|
+    # Enable only the newer, non-monkey-patching expect syntax.
+    # For more details, see:
+    #   - http://teaisaweso.me/blog/2013/05/27/rspecs-new-message-expectation-syntax/
+    mocks.syntax = :expect
+
+    # Prevents you from mocking or stubbing a method that does not exist on
+    # a real object. This is generally recommended.
+    mocks.verify_partial_doubles = true
   end
 
   config.after do
     clear_caches
-
-    # reset the distro, tested in various placed & used extensively
-    LinuxAdmin::Distros.instance_variable_set(:@local, nil)
   end
 end
 
@@ -39,13 +90,13 @@ require 'linux_admin'
 
 def etc_issue_contains(contents)
   LinuxAdmin::EtcIssue.instance.send(:refresh)
-  allow(File).to receive(:exists?).with('/etc/issue').at_least(:once).and_return(true)
+  allow(File).to receive(:exist?).with('/etc/issue').at_least(:once).and_return(true)
   allow(File).to receive(:read).with('/etc/issue').at_least(:once).and_return(contents)
 end
 
 def stub_distro(distro = LinuxAdmin::Distros.rhel)
   # simply alias test distro to redhat distro for time being
-  LinuxAdmin::Distros.stub(:local => distro)
+  allow(LinuxAdmin::Distros).to receive_messages(:local => distro)
 end
 
 def data_file_path(to)
@@ -58,4 +109,7 @@ end
 
 def clear_caches
   LinuxAdmin::RegistrationSystem.instance_variable_set(:@registration_type, nil)
+
+  # reset the distro, tested in various placed & used extensively
+  LinuxAdmin::Distros.instance_variable_set(:@local, nil)
 end

data/spec/subscription_manager_spec.rb

@@ -1,20 +1,18 @@
-require 'spec_helper'
-
 describe LinuxAdmin::SubscriptionManager do
   context "#registered?" do
     it "system with subscription-manager commands" do
-      described_class.any_instance.should_receive(:run).once.with("subscription-manager identity").and_return(double(:exit_status => 0))
-      expect(described_class.new.registered?).to be_true
+      expect_any_instance_of(described_class).to receive(:run).once.with("subscription-manager identity").and_return(double(:exit_status => 0))
+      expect(described_class.new.registered?).to be_truthy
     end
 
     it "system without subscription-manager commands" do
-      described_class.any_instance.should_receive(:run).once.with("subscription-manager identity").and_return(double(:exit_status => 255))
-      expect(described_class.new.registered?).to be_false
+      expect_any_instance_of(described_class).to receive(:run).once.with("subscription-manager identity").and_return(double(:exit_status => 255))
+      expect(described_class.new.registered?).to be_falsey
     end
   end
 
   it "#refresh" do
-    described_class.any_instance.should_receive(:run!).once.with("subscription-manager refresh")
+    expect_any_instance_of(described_class).to receive(:run!).once.with("subscription-manager refresh")
     described_class.new.refresh
   end
 
@@ -39,15 +37,15 @@ describe LinuxAdmin::SubscriptionManager do
         run_params.store_path(:params, "--serverurl=", "https://server.url")
         base_options.store_path(:server_url, "https://server.url")
 
-        described_class.any_instance.should_receive(:run!).once.with("subscription-manager register", run_params)
-        LinuxAdmin::Rpm.should_receive(:upgrade).with("http://server.url/pub/candlepin-cert-consumer-latest.noarch.rpm")
+        expect_any_instance_of(described_class).to receive(:run!).once.with("subscription-manager register", run_params)
+        expect(LinuxAdmin::Rpm).to receive(:upgrade).with("http://server.url/pub/katello-ca-consumer-latest.noarch.rpm")
 
         described_class.new.register(base_options)
       end
 
       it "without server_url" do
-        described_class.any_instance.should_receive(:run!).once.with("subscription-manager register", run_params)
-        described_class.any_instance.should_not_receive(:install_server_certificate)
+        expect_any_instance_of(described_class).to receive(:run!).once.with("subscription-manager register", run_params)
+        expect_any_instance_of(described_class).not_to receive(:install_server_certificate)
 
         described_class.new.register(base_options)
       end
@@ -56,30 +54,30 @@ describe LinuxAdmin::SubscriptionManager do
 
   context "#subscribe" do
     it "with pools" do
-      described_class.any_instance.should_receive(:run!).once.with("subscription-manager attach", {:params=>[["--pool", 123], ["--pool", 456]]})
+      expect_any_instance_of(described_class).to receive(:run!).once.with("subscription-manager attach", {:params=>[["--pool", 123], ["--pool", 456]]})
       described_class.new.subscribe({:pools => [123, 456]})
     end
 
     it "without pools" do
-      described_class.any_instance.should_receive(:run!).once.with("subscription-manager attach", {:params=>{"--auto"=>nil}})
+      expect_any_instance_of(described_class).to receive(:run!).once.with("subscription-manager attach", {:params=>{"--auto"=>nil}})
       described_class.new.subscribe({})
     end
   end
 
   context "#subscribed_products" do
     it "subscribed" do
-      described_class.any_instance.should_receive(:run!).once.with("subscription-manager list --installed").and_return(double(:output => sample_output("subscription_manager/output_list_installed_subscribed")))
+      expect_any_instance_of(described_class).to receive(:run!).once.with("subscription-manager list --installed").and_return(double(:output => sample_output("subscription_manager/output_list_installed_subscribed")))
       expect(described_class.new.subscribed_products).to eq(["69", "167"])
     end
 
     it "not subscribed" do
-      described_class.any_instance.should_receive(:run!).once.with("subscription-manager list --installed").and_return(double(:output => sample_output("subscription_manager/output_list_installed_not_subscribed")))
+      expect_any_instance_of(described_class).to receive(:run!).once.with("subscription-manager list --installed").and_return(double(:output => sample_output("subscription_manager/output_list_installed_not_subscribed")))
       expect(described_class.new.subscribed_products).to eq(["167"])
     end
   end
 
   it "#available_subscriptions" do
-    described_class.any_instance.should_receive(:run!).once.with("subscription-manager list --all --available").and_return(double(:output => sample_output("subscription_manager/output_list_all_available")))
+    expect_any_instance_of(described_class).to receive(:run!).once.with("subscription-manager list --all --available").and_return(double(:output => sample_output("subscription_manager/output_list_all_available")))
     expect(described_class.new.available_subscriptions).to eq({
       "82c042fca983889b10178893f29b06e3" => {
         :subscription_name => "Example Subscription",
@@ -132,8 +130,8 @@ describe LinuxAdmin::SubscriptionManager do
     it "with valid credentials" do
       run_options = ["subscription-manager orgs", {:params=>{"--username="=>"SomeUser", "--password="=>"SomePass", "--proxy="=>"1.2.3.4", "--proxyuser="=>"ProxyUser", "--proxypassword="=>"ProxyPass", "--serverurl="=>"192.168.1.1"}}]
 
-      LinuxAdmin::Rpm.should_receive(:upgrade).with("http://192.168.1.1/pub/candlepin-cert-consumer-latest.noarch.rpm")
-      described_class.any_instance.should_receive(:run!).once.with(*run_options).and_return(double(:output => sample_output("subscription_manager/output_orgs")))
+      expect(LinuxAdmin::Rpm).to receive(:upgrade).with("http://192.168.1.1/pub/katello-ca-consumer-latest.noarch.rpm")
+      expect_any_instance_of(described_class).to receive(:run!).once.with(*run_options).and_return(double(:output => sample_output("subscription_manager/output_orgs")))
 
       expect(described_class.new.organizations({:username=>"SomeUser", :password=>"SomePass", :proxy_address=>"1.2.3.4", :proxy_username=>"ProxyUser", :proxy_password=>"ProxyPass", :server_url=>"192.168.1.1"})).to eq({"SomeOrg"=>{:name=>"SomeOrg", :key=>"1234567"}})
     end
@@ -146,19 +144,19 @@ describe LinuxAdmin::SubscriptionManager do
           :exit_status => 255
         )
       )
-      AwesomeSpawn.should_receive(:run!).once.with(*run_options).and_raise(error)
+      expect(AwesomeSpawn).to receive(:run!).once.with(*run_options).and_raise(error)
       expect { described_class.new.organizations({:username=>"BadUser", :password=>"BadPass"}) }.to raise_error(LinuxAdmin::CredentialError)
     end
   end
 
   it "#enable_repo" do
-    described_class.any_instance.should_receive(:run!).once.with("subscription-manager repos", {:params=>{"--enable="=>"abc"}})
+    expect_any_instance_of(described_class).to receive(:run!).once.with("subscription-manager repos", {:params=>{"--enable="=>"abc"}})
 
     described_class.new.enable_repo("abc")
   end
 
   it "#disable_repo" do
-    described_class.any_instance.should_receive(:run!).once.with("subscription-manager repos", {:params=>{"--disable="=>"abc"}})
+    expect_any_instance_of(described_class).to receive(:run!).once.with("subscription-manager repos", {:params=>{"--disable="=>"abc"}})
 
     described_class.new.disable_repo("abc")
   end
@@ -185,7 +183,7 @@ describe LinuxAdmin::SubscriptionManager do
       }
     ]
 
-    described_class.any_instance.should_receive(:run!).once.with("subscription-manager repos").and_return(double(:output => sample_output("subscription_manager/output_repos")))
+    expect_any_instance_of(described_class).to receive(:run!).once.with("subscription-manager repos").and_return(double(:output => sample_output("subscription_manager/output_repos")))
 
     expect(described_class.new.all_repos).to eq(expected)
   end
@@ -193,7 +191,7 @@ describe LinuxAdmin::SubscriptionManager do
   it "#enabled_repos" do
     expected = ["some-repo-source-rpms", "some-repo-rpms"]
 
-    described_class.any_instance.should_receive(:run!).once.with("subscription-manager repos").and_return(double(:output => sample_output("subscription_manager/output_repos")))
+    expect_any_instance_of(described_class).to receive(:run!).once.with("subscription-manager repos").and_return(double(:output => sample_output("subscription_manager/output_repos")))
 
     expect(described_class.new.enabled_repos).to eq(expected)
   end

data/spec/system_spec.rb

@@ -1,9 +1,7 @@
-require 'spec_helper'
-
 describe LinuxAdmin::System do
   describe "#reboot!" do
     it "reboots the system" do
-      LinuxAdmin::System.should_receive(:run!).
+      expect(LinuxAdmin::System).to receive(:run!).
          with(LinuxAdmin::System.cmd(:shutdown),
               :params => { '-r' => 'now'})
       LinuxAdmin::System.reboot!
@@ -12,7 +10,7 @@ describe LinuxAdmin::System do
 
   describe "#shutdown!" do
     it "shuts down the system" do
-      LinuxAdmin::System.should_receive(:run!).
+      expect(LinuxAdmin::System).to receive(:run!).
          with(LinuxAdmin::System.cmd(:shutdown),
               :params => { '-h' => '0'})
       LinuxAdmin::System.shutdown!

data/spec/volume_group_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe LinuxAdmin::VolumeGroup do
   before(:each) do
     @groups = <<eos
@@ -18,7 +16,7 @@ eos
     it "uses lvextend" do
       vg = described_class.new :name => 'vg'
       lv = LinuxAdmin::LogicalVolume.new :name => 'lv', :volume_group => vg
-      vg.should_receive(:run!).
+      expect(vg).to receive(:run!).
          with(vg.cmd(:lvextend),
               :params => ['lv', 'vg'])
       vg.attach_to(lv)
@@ -27,8 +25,8 @@ eos
     it "returns self" do
       vg = described_class.new :name => 'vg'
       lv = LinuxAdmin::LogicalVolume.new :name => 'lv', :volume_group => vg
-      vg.stub(:run!)
-      vg.attach_to(lv).should == vg
+      allow(vg).to receive(:run!)
+      expect(vg.attach_to(lv)).to eq(vg)
     end
   end
 
@@ -36,7 +34,7 @@ eos
     it "uses vgextend" do
       vg = described_class.new :name => 'vg'
       pv = LinuxAdmin::PhysicalVolume.new :device_name => '/dev/hda'
-      vg.should_receive(:run!).
+      expect(vg).to receive(:run!).
          with(vg.cmd(:vgextend),
               :params => ['vg', '/dev/hda'])
       vg.extend_with(pv)
@@ -45,16 +43,16 @@ eos
     it "assigns volume group to physical volume" do
       vg = described_class.new :name => 'vg'
       pv = LinuxAdmin::PhysicalVolume.new :device_name => '/dev/hda'
-      vg.stub(:run!)
+      allow(vg).to receive(:run!)
       vg.extend_with(pv)
-      pv.volume_group.should == vg
+      expect(pv.volume_group).to eq(vg)
     end
 
     it "returns self" do
       vg = described_class.new :name => 'vg'
       pv = LinuxAdmin::PhysicalVolume.new :device_name => '/dev/hda'
-      vg.stub(:run!)
-      vg.extend_with(pv).should == vg
+      allow(vg).to receive(:run!)
+      expect(vg.extend_with(pv)).to eq(vg)
     end
   end
 
@@ -65,29 +63,29 @@ eos
 
     it "uses vgcreate" do
       described_class.instance_variable_set(:@vgs, [])
-      described_class.should_receive(:run!).
+      expect(described_class).to receive(:run!).
                               with(LinuxAdmin.cmd(:vgcreate),
                                    :params => ['vg', '/dev/hda'])
       described_class.create 'vg', @pv
     end
 
     it "returns new volume group" do
-      described_class.stub(:run! => double(:output => ""))
+      allow(described_class).to receive_messages(:run! => double(:output => ""))
       vg = described_class.create 'vg', @pv
-      vg.should be_an_instance_of(described_class)
-      vg.name.should == 'vg'
+      expect(vg).to be_an_instance_of(described_class)
+      expect(vg.name).to eq('vg')
     end
 
     it "adds volume group to local registry" do
-      described_class.stub(:run! => double(:output => ""))
+      allow(described_class).to receive_messages(:run! => double(:output => ""))
       vg = described_class.create 'vg', @pv
-      described_class.scan.should include(vg)
+      expect(described_class.scan).to include(vg)
     end
   end
 
   describe "#scan" do
     it "uses vgdisplay" do
-      described_class.should_receive(:run!).
+      expect(described_class).to receive(:run!).
                               with(LinuxAdmin.cmd(:vgdisplay),
                                    :params => { '-c' => nil}).
                                  and_return(double(:output => @groups))
@@ -95,11 +93,11 @@ eos
     end
 
     it "returns local volume groups" do
-      described_class.should_receive(:run!).and_return(double(:output => @groups))
+      expect(described_class).to receive(:run!).and_return(double(:output => @groups))
       vgs = described_class.scan
 
-      vgs[0].should be_an_instance_of(described_class)
-      vgs[0].name.should == 'vg_foobar'
+      expect(vgs[0]).to be_an_instance_of(described_class)
+      expect(vgs[0].name).to eq('vg_foobar')
     end
   end
 end

data/spec/yum_spec.rb

@@ -1,25 +1,23 @@
-require 'spec_helper'
-
 describe LinuxAdmin::Yum do
   before(:each) do
-    FileUtils.stub(:mkdir_p => true)
+    allow(FileUtils).to receive_messages(:mkdir_p => true)
   end
 
   context ".create_repo" do
     it "default arguments" do
-      described_class.should_receive(:run!).once.with("createrepo", {:params=>{nil=>"some/path", "--database"=>nil, "--unique-md-filenames"=>nil}})
+      expect(described_class).to receive(:run!).once.with("createrepo", {:params=>{nil=>"some/path", "--database"=>nil, "--unique-md-filenames"=>nil}})
       described_class.create_repo("some/path")
     end
 
     it "bare create" do
-      described_class.should_receive(:run!).once.with("createrepo", {:params=>{nil=>"some/path"}})
+      expect(described_class).to receive(:run!).once.with("createrepo", {:params=>{nil=>"some/path"}})
       described_class.create_repo("some/path", :database => false, :unique_file_names => false)
     end
   end
 
   context ".download_packages" do
     it "with valid input" do
-      described_class.should_receive(:run!).once.with("repotrack", {:params=>{"-p"=>"some/path", nil=>"pkg_a pkg_b"}})
+      expect(described_class).to receive(:run!).once.with("repotrack", {:params=>{"-p"=>"some/path", nil=>"pkg_a pkg_b"}})
       described_class.download_packages("some/path", "pkg_a pkg_b")
     end
 
@@ -29,8 +27,8 @@ describe LinuxAdmin::Yum do
   end
 
   it ".repo_settings" do
-    described_class.should_receive(:parse_repo_dir).once.with("/etc/yum.repos.d").and_return(true)
-    expect(described_class.repo_settings).to be_true
+    expect(described_class).to receive(:parse_repo_dir).once.with("/etc/yum.repos.d").and_return(true)
+    expect(described_class.repo_settings).to be_truthy
   end
 
   it ".parse_repo_dir" do
@@ -68,41 +66,47 @@ describe LinuxAdmin::Yum do
 
   context ".updates_available?" do
     it "check updates for a specific package" do
-      described_class.should_receive(:run).once.with("yum check-update", {:params=>{nil=>["abc"]}}).and_return(double(:exit_status => 100))
-      expect(described_class.updates_available?("abc")).to be_true
+      expect(described_class).to receive(:run).once.with("yum check-update", {:params=>{nil=>["abc"]}}).and_return(double(:exit_status => 100))
+      expect(described_class.updates_available?("abc")).to be_truthy
     end
 
     it "updates are available" do
-      described_class.stub(:run => double(:exit_status => 100))
-      expect(described_class.updates_available?).to be_true
+      allow(described_class).to receive_messages(:run => double(:exit_status => 100))
+      expect(described_class.updates_available?).to be_truthy
     end
 
     it "updates not available" do
-      described_class.stub(:run => double(:exit_status => 0))
-      expect(described_class.updates_available?).to be_false
+      allow(described_class).to receive_messages(:run => double(:exit_status => 0))
+      expect(described_class.updates_available?).to be_falsey
     end
 
     it "other exit code" do
-      described_class.stub(:run => double(:exit_status => 255))
+      allow(described_class).to receive_messages(:run => double(:exit_status => 255))
       expect { described_class.updates_available? }.to raise_error
     end
 
     it "other error" do
-      described_class.stub(:run).and_raise(RuntimeError)
+      allow(described_class).to receive(:run).and_raise(RuntimeError)
       expect { described_class.updates_available? }.to raise_error(RuntimeError)
     end
   end
 
   context ".update" do
     it "no arguments" do
-      described_class.should_receive(:run!).once.with("yum -y update", {:params=>nil})
+      expect(described_class).to receive(:run!).once.with("yum -y update", :params => nil).and_return(AwesomeSpawn::CommandResult.new("", "", "", 0))
       described_class.update
     end
 
     it "with arguments" do
-      described_class.should_receive(:run!).once.with("yum -y update", {:params=>{nil=>["1 2", "3"]}})
+      expect(described_class).to receive(:run!).once.with("yum -y update", :params => {nil => ["1 2", "3"]}).and_return(AwesomeSpawn::CommandResult.new("", "", "", 0))
       described_class.update("1 2", "3")
     end
+
+    it "with bad arguments" do
+      error = AwesomeSpawn::CommandResult.new("", "Loaded plugins: product-id\nNo Packages marked for Update\n", "Blah blah ...\nNo Match for argument: \n", 0)
+      expect(described_class).to receive(:run!).once.with("yum -y update", :params => {nil => [""]}).and_return(error)
+      expect { described_class.update("") }.to raise_error(AwesomeSpawn::CommandResultError)
+    end
   end
 
   context ".version_available" do
@@ -111,12 +115,12 @@ describe LinuxAdmin::Yum do
     end
 
     it "with one package" do
-      described_class.should_receive(:run!).once.with("repoquery --qf=\"%{name} %{version}\"", {:params=>{nil=>["subscription-manager"]}}).and_return(double(:output => sample_output("yum/output_repoquery_single")))
+      expect(described_class).to receive(:run!).once.with("repoquery --qf=\"%{name} %{version}\"", {:params=>{nil=>["subscription-manager"]}}).and_return(double(:output => sample_output("yum/output_repoquery_single")))
       expect(described_class.version_available("subscription-manager")).to eq({"subscription-manager" => "1.1.23.1"})
     end
 
     it "with multiple packages" do
-      described_class.should_receive(:run!).once.with("repoquery --qf=\"%{name} %{version}\"", {:params=>{nil=>["curl", "subscription-manager", "wget"]}}).and_return(double(:output => sample_output("yum/output_repoquery_multiple")))
+      expect(described_class).to receive(:run!).once.with("repoquery --qf=\"%{name} %{version}\"", {:params=>{nil=>["curl", "subscription-manager", "wget"]}}).and_return(double(:output => sample_output("yum/output_repoquery_multiple")))
       expect(described_class.version_available("curl", "subscription-manager", "wget")).to eq({
         "curl"                  => "7.19.7",
         "subscription-manager"  => "1.1.23.1",
@@ -127,13 +131,13 @@ describe LinuxAdmin::Yum do
 
   context ".repo_list" do
     it "with no arguments" do
-      described_class.should_receive(:run!).with("yum repolist", {:params=>{nil=>"enabled"}}).and_return(double(:output => sample_output("yum/output_repo_list")))
+      expect(described_class).to receive(:run!).with("yum repolist", {:params=>{nil=>"enabled"}}).and_return(double(:output => sample_output("yum/output_repo_list")))
       expect(described_class.repo_list).to eq(["rhel-6-server-rpms", "rhel-ha-for-rhel-6-server-rpms", "rhel-lb-for-rhel-6-server-rpms"])
     end
 
     it "with argument" do
-      described_class.should_receive(:run!).with("yum repolist", {:params=>{nil=>"enabled"}}).and_return(double(:output => sample_output("yum/output_repo_list")))
+      expect(described_class).to receive(:run!).with("yum repolist", {:params=>{nil=>"enabled"}}).and_return(double(:output => sample_output("yum/output_repo_list")))
       expect(described_class.repo_list("enabled")).to eq(["rhel-6-server-rpms", "rhel-ha-for-rhel-6-server-rpms", "rhel-lb-for-rhel-6-server-rpms"])
     end
   end
-end
+end