lint_trap 0.0.2 → 0.0.3

data/spec/linter/csslint_spec.rb

@@ -0,0 +1,44 @@
+require 'spec_helper'
+
+describe LintTrap::Linter::CSSLint do
+  let(:container){LintTrap::Container::Fake.new}
+  let(:config){nil}
+  let(:files){%w(good.css bad.css)}
+  subject(:linter){described_class.new(container: container, config: config)}
+  let(:command){instance_double(LintTrap::Command)}
+
+  describe '#lint' do
+    context 'when config is provided' do
+      let(:config){'.csslintrc'}
+
+      it 'runs the lint command with the correct arguments' do
+        expect(LintTrap::Command).to receive(:new).with(
+          'csslint',
+          [
+            '--format=compact',
+            '--config=.csslintrc'
+          ],
+          files
+        ).and_return(command)
+        expect(command).to receive(:run).with(container)
+
+        linter.lint(files)
+      end
+    end
+
+    context 'when config is not provided' do
+      it 'runs the lint command with the correct arguments' do
+        expect(LintTrap::Command).to receive(:new).with(
+          'csslint',
+          [
+            '--format=compact'
+          ],
+          files
+        ).and_return(command)
+        expect(command).to receive(:run).with(container)
+
+        linter.lint(files)
+      end
+    end
+  end
+end

data/spec/linter/golint_spec.rb

@@ -0,0 +1,22 @@
+require 'spec_helper'
+
+describe LintTrap::Linter::GoLint do
+  let(:container){LintTrap::Container::Fake.new}
+  let(:config){nil}
+  let(:files){%w(good.go bad.go)}
+  subject(:linter){described_class.new(container: container, config: config)}
+  let(:command){instance_double(LintTrap::Command)}
+
+  describe '#lint' do
+    it 'runs the lint command with the correct arguments' do
+      expect(LintTrap::Command).to receive(:new).with(
+        'golint',
+        [],
+        files
+      ).and_return(command)
+      expect(command).to receive(:run).with(container)
+
+      linter.lint(files)
+    end
+  end
+end

data/spec/linter/jshint_spec.rb

@@ -0,0 +1,44 @@
+require 'spec_helper'
+
+describe LintTrap::Linter::JSHint do
+  let(:container){LintTrap::Container::Fake.new}
+  let(:config){nil}
+  let(:files){%w(good.js bad.js)}
+  subject(:linter){described_class.new(container: container, config: config)}
+  let(:command){instance_double(LintTrap::Command)}
+
+  describe '#lint' do
+    context 'when config is provided' do
+      let(:config){'.jshintrc'}
+
+      it 'runs the lint command with the correct arguments' do
+        expect(LintTrap::Command).to receive(:new).with(
+          'jshint',
+          [
+            '--reporter', container.config_path(described_class::FORMATTER),
+            '--config', config
+          ],
+          files
+        ).and_return(command)
+        expect(command).to receive(:run).with(container)
+
+        linter.lint(files)
+      end
+    end
+
+    context 'when config is not provided' do
+      it 'runs the lint command with the correct arguments' do
+        expect(LintTrap::Command).to receive(:new).with(
+          'jshint',
+          [
+            '--reporter', container.config_path(described_class::FORMATTER)
+          ],
+          files
+        ).and_return(command)
+        expect(command).to receive(:run).with(container)
+
+        linter.lint(files)
+      end
+    end
+  end
+end

data/spec/linter/jsonlint_spec.rb

@@ -0,0 +1,22 @@
+require 'spec_helper'
+
+describe LintTrap::Linter::JSONLint do
+  let(:container){LintTrap::Container::Fake.new}
+  let(:config){nil}
+  let(:files){%w(good.go bad.go)}
+  subject(:linter){described_class.new(container: container, config: config)}
+  let(:command){instance_double(LintTrap::Command)}
+
+  describe '#lint' do
+    it 'runs the lint command with the correct arguments' do
+      expect(LintTrap::Command).to receive(:new).with(
+        'durable-json-lint',
+        ['--format', '{{file}}:{{line}}:{{column}}:::error:{{{description}}}'],
+        files
+      ).and_return(command)
+      expect(command).to receive(:run).with(container)
+
+      linter.lint(files)
+    end
+  end
+end

data/spec/linter/pylint_spec.rb

@@ -0,0 +1,46 @@
+require 'spec_helper'
+
+describe LintTrap::Linter::PyLint do
+  let(:container){LintTrap::Container::Fake.new}
+  let(:config){nil}
+  let(:files){%w(good.py bad.py)}
+  subject(:linter){described_class.new(container: container, config: config)}
+  let(:command){instance_double(LintTrap::Command)}
+
+  describe '#lint' do
+    context 'when config is provided' do
+      let(:config){'.pylintrc'}
+
+      it 'runs the lint command with the correct arguments' do
+        expect(LintTrap::Command).to receive(:new).with(
+          'pylint',
+          [
+            '-r', 'no',
+            '--msg-template', '"{abspath}:{line}:{column}::{symbol}:{category}:{msg}"',
+            '--rcfile', config
+          ],
+          files
+        ).and_return(command)
+        expect(command).to receive(:run).with(container)
+
+        linter.lint(files)
+      end
+    end
+
+    context 'when config is not provided' do
+      it 'runs the lint command with the correct arguments' do
+        expect(LintTrap::Command).to receive(:new).with(
+          'pylint',
+          [
+            '-r', 'no',
+            '--msg-template', '"{abspath}:{line}:{column}::{symbol}:{category}:{msg}"'
+          ],
+          files
+        ).and_return(command)
+        expect(command).to receive(:run).with(container)
+
+        linter.lint(files)
+      end
+    end
+  end
+end

data/spec/linter/rubocop_spec.rb

@@ -0,0 +1,48 @@
+require 'spec_helper'
+
+describe LintTrap::Linter::RuboCop do
+  let(:container){LintTrap::Container::Fake.new}
+  let(:config){nil}
+  let(:files){%w(good.rb bad.rb)}
+  subject(:linter){described_class.new(container: container, config: config)}
+  let(:command){instance_double(LintTrap::Command)}
+
+  describe '#lint' do
+    context 'when config is provided' do
+      let(:config){'.rubocop.yml'}
+
+      it 'runs the lint command with the correct arguments' do
+        expect(LintTrap::Command).to receive(:new).with(
+          'rubocop',
+          [
+            '--require', container.config_path(described_class::FORMATTER),
+            '--format', 'LintTrap::Rubocop::Formatter',
+            '--no-color',
+            '--config', config
+          ],
+          files
+        ).and_return(command)
+        expect(command).to receive(:run).with(container)
+
+        linter.lint(files)
+      end
+    end
+
+    context 'when config is not provided' do
+      it 'runs the lint command with the correct arguments' do
+        expect(LintTrap::Command).to receive(:new).with(
+          'rubocop',
+          [
+            '--require', container.config_path(described_class::FORMATTER),
+            '--format', 'LintTrap::Rubocop::Formatter',
+            '--no-color'
+          ],
+          files
+        ).and_return(command)
+        expect(command).to receive(:run).with(container)
+
+        linter.lint(files)
+      end
+    end
+  end
+end

data/spec/linter/scsslint_spec.rb

@@ -0,0 +1,44 @@
+require 'spec_helper'
+
+describe LintTrap::Linter::SCSSLint do
+  let(:container){LintTrap::Container::Fake.new}
+  let(:config){nil}
+  let(:files){%w(good.scss bad.scss)}
+  subject(:linter){described_class.new(container: container, config: config)}
+  let(:command){instance_double(LintTrap::Command)}
+
+  describe '#lint' do
+    context 'when config is provided' do
+      let(:config){'.scss-lint.yml'}
+
+      it 'runs the lint command with the correct arguments' do
+        expect(LintTrap::Command).to receive(:new).with(
+          container.config_path(described_class::COMMAND),
+          [
+            '--format=LintTrap',
+            '--config', '.scss-lint.yml'
+          ],
+          files
+        ).and_return(command)
+        expect(command).to receive(:run).with(container)
+
+        linter.lint(files)
+      end
+    end
+
+    context 'when config is not provided' do
+      it 'runs the lint command with the correct arguments' do
+        expect(LintTrap::Command).to receive(:new).with(
+          container.config_path(described_class::COMMAND),
+          [
+            '--format=LintTrap'
+          ],
+          files
+        ).and_return(command)
+        expect(command).to receive(:run).with(container)
+
+        linter.lint(files)
+      end
+    end
+  end
+end

data/spec/linter_spec.rb

@@ -0,0 +1,67 @@
+require 'spec_helper'
+
+describe LintTrap::Linter do
+  describe '.find' do
+    subject(:language){described_class.find(linter_name)}
+
+    context 'when given CheckStyle' do
+      let(:linter_name){'CheckStyle'}
+
+      it{is_expected.to eq(described_class::CheckStyle)}
+    end
+
+    context 'when given CoffeeLint' do
+      let(:linter_name){'CoffeeLint'}
+
+      it{is_expected.to eq(described_class::CoffeeLint)}
+    end
+
+    context 'when given CPPCheck' do
+      let(:linter_name){'CPPCheck'}
+
+      it{is_expected.to eq(described_class::CPPCheck)}
+    end
+
+    context 'when given CSSLint' do
+      let(:linter_name){'CSSLint'}
+
+      it{is_expected.to eq(described_class::CSSLint)}
+    end
+
+    context 'when given GoLint' do
+      let(:linter_name){'GoLint'}
+
+      it{is_expected.to eq(described_class::GoLint)}
+    end
+
+    context 'when given JSHint' do
+      let(:linter_name){'JSHint'}
+
+      it{is_expected.to eq(described_class::JSHint)}
+    end
+
+    context 'when given JSONLint' do
+      let(:linter_name){'JSONLint'}
+
+      it{is_expected.to eq(described_class::JSONLint)}
+    end
+
+    context 'when given PyLint' do
+      let(:linter_name){'PyLint'}
+
+      it{is_expected.to eq(described_class::PyLint)}
+    end
+
+    context 'when given RuboCop' do
+      let(:linter_name){'RuboCop'}
+
+      it{is_expected.to eq(described_class::RuboCop)}
+    end
+
+    context 'when given SCSSLint' do
+      let(:linter_name){'SCSSLint'}
+
+      it{is_expected.to eq(described_class::SCSSLint)}
+    end
+  end
+end

data/spec/parser/csslint_spec.rb

@@ -0,0 +1,25 @@
+require 'spec_helper'
+
+describe LintTrap::Parser::CSSLint do
+  let(:parser_output) do
+    'bad.css: line 2, col 5, Error - Using width with border can sometimes'\
+    " make elements larger than you expect.\n\n"
+  end
+  let(:io){StringIO.new(parser_output)}
+  let(:container){LintTrap::Container::Fake.new}
+  subject(:parser){described_class.new(io, container)}
+
+  describe '.parse' do
+    it 'parses violations from io' do
+      expect{|b| parser.parse(&b)}.to yield_successive_args(
+        file: 'bad.css',
+        line: '2',
+        column: '5',
+        length: nil,
+        rule: nil,
+        severity: 'Error',
+        message: 'Using width with border can sometimes make elements larger than you expect.'
+      )
+    end
+  end
+end

data/spec/{parsers/standard_parser_spec.rb → parser/standard_spec.rb}

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe LintTrap::Parsers::StandardParser do
+describe LintTrap::Parser::Standard do
   let(:parser_output) do
     "bad.java:1:0::com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocTypeCheck:error:"\
     "Missing a Javadoc comment.\n"\
@@ -11,11 +11,12 @@ describe LintTrap::Parsers::StandardParser do
     "bad.scss:2:3:12:BorderZero:warning:`border: 0;` is preferred over `border: none;`\n"
   end
   let(:io){StringIO.new(parser_output)}
-  subject(:parser){described_class}
+  let(:container){LintTrap::Container::Fake.new}
+  subject(:parser){described_class.new(io, container)}
 
   describe '.parse' do
     it 'parses violations from io' do
-      expect{|b| parser.parse(io, &b)}.to yield_successive_args(
+      expect{|b| parser.parse(&b)}.to yield_successive_args(
         {
           file: 'bad.java',
           line: '1',

data/spec/{parsers/vim_quickfix_parser_spec.rb → parser/vim_quickfix_spec.rb}

@@ -1,15 +1,16 @@
 require 'spec_helper'
 
-describe LintTrap::Parsers::VimQuickfixParser do
+describe LintTrap::Parser::VimQuickfix do
   let(:parser_output) do
     "bad.go:5:1: exported function Main should have comment or be unexported\n"
   end
   let(:io){StringIO.new(parser_output)}
-  subject(:parser){described_class}
+  let(:container){LintTrap::Container::Fake.new}
+  subject(:parser){described_class.new(io, container)}
 
-  describe '.parse' do
+  describe '#parse' do
     it 'parses violations from io' do
-      expect{|b| parser.parse(io, &b)}.to yield_successive_args(
+      expect{|b| parser.parse(&b)}.to yield_successive_args(
         {
           file: 'bad.go',
           line: '5',

data/spec/spec_helper.rb

@@ -1,2 +1,10 @@
 $LOAD_PATH.unshift File.expand_path('../../lib', __FILE__)
+require 'rspec/its'
 require 'lint_trap'
+require_relative 'support/fixture_file_helper'
+
+ENV['DEBUG_LINTING'] = ENV['CI']
+
+RSpec.configure do |config|
+  config.include FixtureFileHelper
+end

data/spec/support/fixture_file_helper.rb

@@ -0,0 +1,8 @@
+# Simplifies referencing fixture files
+module FixtureFileHelper
+  FIXTURE_PATH = File.expand_path('../../fixtures', __FILE__)
+
+  def fixture_path(path = '')
+    File.join(FIXTURE_PATH, path)
+  end
+end