linkparser 1.1.3 → 2.2.0

data/lib/linkparser/mixins.rb

@@ -1,5 +1,5 @@
-#!/usr/bin/env ruby
-
+# -*- ruby -*-
+# frozen_string_literal: true
 
 module LinkParser
 
@@ -11,7 +11,6 @@ module LinkParser
 
 		### Make a wrapper for a deprecated method. The wrapper will print a deprecation warning
 		### to STDERR, and then call the method with the same name prefixed with an underscore.
-		### @param [Symbol, #to_sym] name  the name of the method to deprecate.
 		def deprecated_method( *names )
 			names.each do |name|
 				method_body = lambda do |*args|

data/lib/linkparser/parseoptions.rb

@@ -0,0 +1,58 @@
+# -*- ruby -*-
+# frozen_string_literal: true
+
+require 'linkparser' unless defined?( LinkParser )
+
+
+# LinkParser parse options class. Instances of this class are used to specify the different
+# parameters that are used to parse sentences. Examples of the kinds of things that are
+# controlled by ParseOptions include maximum parsing time and memory, whether to use
+# null-links, and whether or not to use "panic" mode. This data structure is passed in to
+# the various parsing and printing routines along with the sentence.
+class LinkParser::ParseOptions
+	extend Loggability,
+	       LinkParser::DeprecationUtilities
+
+	# Use LinkParser's logger
+	log_to :linkparser
+
+
+	### Return an Array of valid option names as Symbols.
+	def self::option_names
+		return @option_names ||= instance_methods( false ).
+			grep( /^[a-z].*=$/ ).map {|sym| sym.to_s.chomp('=').to_sym }
+	end
+
+
+	### Return a new LinkParser::ParseOptions with the values of the receiver merged with
+	### those from the +other+ object.
+	def merge( other )
+		new_options = self.dup
+		new_options.merge!( other )
+		return new_options
+	end
+
+
+	### Overwrite the option settings on the receiver with those from the +other+
+	### object.
+	def merge!( other )
+		other.to_hash.each do |key, val|
+			self.send( "#{key}=", val )
+		end
+	end
+
+
+	### Return the options as a Hash.
+	def to_hash
+		return self.class.option_names.each_with_object( {} ) do |optname, accum|
+			val = if self.respond_to?( "#{optname}?" )
+					self.send( "#{optname}?" )
+				else
+					self.send( optname )
+				end
+
+			accum[ optname ] = val
+		end
+	end
+
+end # class LinkParser::ParseOptions

data/lib/linkparser/sentence.rb

@@ -1,28 +1,16 @@
-#!/usr/bin/ruby
+# -*- ruby -*-
+# frozen_string_literal: true
 
 require 'linkparser' unless defined?( LinkParser )
 
-# 
-# A Sentence is the API's representation of an input string, tokenized
-# and interpreted according to a specific Dictionary. After a Sentence
-# is created and parsed, various attributes of the resulting set of
-# linkages can be obtained.
-# 
-# == Authors
-# 
-# * Michael Granger <ged@FaerieMUD.org>
-# 
-# == Version
-#
-#  $Id: sentence.rb,v 23a39531870a 2011/01/11 18:18:12 ged $
-# 
-# == License
-# 
-#  :include: LICENSE
-#--
-#  
-# See the LICENSE file for copyright/licensing information.
 class LinkParser::Sentence
+	extend Loggability,
+	       LinkParser::DeprecationUtilities
+
+
+	# Use LinkParser's logger
+	log_to :linkparser
+
 
 	######
 	public
@@ -41,7 +29,7 @@ class LinkParser::Sentence
 			contents = "(unparsed)"
 		end
 
-		return "#<%s:0x%x %s>" % [
+		return "#<%s:%#x %s>" % [
 			self.class.name,
 			self.object_id / 2,
 			contents,
@@ -59,26 +47,21 @@ class LinkParser::Sentence
 	protected
 	#########
 
-	### Return the singleton class for this object
-	def singleton_class
-		class << self; self; end
-	end
-
-
 	### Proxy method -- auto-delegate calls to the first linkage.
-	def method_missing( sym, *args )
-
-		# Check both symbol and string for forward-compatibility with 1.9.x
-		return super unless
-			LinkParser::Linkage.instance_methods.include?( sym.to_s ) ||
-			LinkParser::Linkage.instance_methods.include?( sym )
+	def method_missing( sym, *args, &block )
+		return super unless LinkParser::Linkage.instance_methods.include?( sym )
 
-		linkage = self.linkages.first or raise LinkParser::Error, "sentence has no linkages"
+		linkage_method = LinkParser::Linkage.instance_method( sym )
+		meth = lambda do |*args, &block|
+			linkage = self.linkages.first or raise LinkParser::Error, "sentence has no linkages"
+			linkage_method.bind( linkage ).call( *args, &block )
+		end
 
-		meth = linkage.method( sym )
-		self.singleton_class.send( :define_method, sym, &meth )
+		self.singleton_class.instance_exec( sym, meth ) do |name, new_method|
+			define_method( name, &new_method )
+		end
 
-		meth.call( *args )
+		meth.call( *args, &block )
 	rescue => err
 		raise err, err.message, err.backtrace[ 0..-2 ]
 	end

data/spec/bugfixes_spec.rb

@@ -1,48 +1,35 @@
-#!/usr/bin/ruby -w
-#
-# Specification for various bugfixes to the LinkParser binding
-# $Id: bugfixes_spec.rb,v 1eddd00723e6 2010/11/22 15:59:36 ged $
-#
-# See the LICENSE file in the distribution for information about copyright and licensing.
-#
-
-BEGIN {
-	require 'pathname'
-	basedir = Pathname.new( __FILE__ ).dirname.parent
-
-	libdir = basedir + 'lib'
-	extdir = basedir + 'ext'
-
-	$LOAD_PATH.unshift( basedir.to_s ) unless $LOAD_PATH.include?( basedir.to_s )
-	$LOAD_PATH.unshift( libdir.to_s ) unless $LOAD_PATH.include?( libdir.to_s )
-	$LOAD_PATH.unshift( extdir.to_s ) unless $LOAD_PATH.include?( extdir.to_s )
-}
+# -*- ruby -*-
+# frozen_string_literal: true
 
-require 'rspec'
+require_relative 'helpers'
 
+require 'rspec'
 require 'linkparser'
 
-# @dict = LinkParser::Dictionary.new( :verbosity => 0 )
-# s = LinkParser::Sentence.new('The cat runs.',@dict)
-# puts s.linkages.first.verb  #  "cat.n" !?!?!
-describe %{bugfix for #3: The first linkage for "The cat runs."} do
+
+describe LinkParser do
+
 	before( :all ) do
-		$DEBUG = true if ENV['DEBUG']
+		@dict = LinkParser::Dictionary.new('en', verbosity: 0)
 	end
 
-	before( :each ) do
-		@dict = LinkParser::Dictionary.new( 'en', :verbosity => 0 )
-		@sentence = @dict.parse( "The cat runs." )
-		@linkage = @sentence.linkages.first
-	end
+	let( :sentence ) { @dict.parse( text ) }
+	let( :linkage ) { sentence.linkages.first }
 
 
-	it "thinks cat is the subject" do
-		@linkage.subject.should == "cat"
-	end
+	describe 'bugfix for #3: The first linkage for "The cat runs."' do
+
+		let( :text ) { "The cat runs." }
+
+
+		it "selects cat as the subject" do
+			expect( linkage.subject ).to eq( "cat" )
+		end
+
+		it "selects runs as the verb" do
+			expect( linkage.verb ).to eq( "runs" )
+		end
 
-	it "thinks runs is the verb" do
-		@linkage.verb.should == "runs"
 	end
-end
 
+end

data/spec/helpers.rb

@@ -0,0 +1,39 @@
+# -*- ruby -*-
+# frozen_string_literal: true
+
+# SimpleCov test coverage reporting; enable this using the :coverage rake task
+require 'simplecov' if ENV['COVERAGE']
+require 'rspec'
+
+require 'loggability/spechelpers'
+
+require 'linkparser'
+
+
+$DEBUG = true if ENV['DEBUG']
+
+
+### RSpec helper functions.
+module LinkParser::SpecHelpers
+end
+
+
+### Mock with RSpec
+RSpec.configure do |config|
+	config.run_all_when_everything_filtered = true
+	config.filter_run :focus
+	config.order = 'random'
+	config.mock_with( :rspec ) do |mock|
+		mock.syntax = :expect
+	end
+
+	lg_version = LinkParser.link_grammar_version[ /(\d+(\.\d+)+)$/, 1 ]
+	config.filter_run_excluding( skip_version: lg_version )
+	config.filter_run_including( only_version: lg_version )
+
+	config.include( Loggability::SpecHelpers )
+	config.include( LinkParser::SpecHelpers )
+end
+
+# vim: set nosta noet ts=4 sw=4:
+

data/spec/linkparser/dictionary_spec.rb

@@ -1,31 +1,15 @@
-#!/usr/bin/ruby -w
-#
-# Specification for the LinkParser::Dictionary class
-# $Id: dictionary_spec.rb,v 54e4e2ff8899 2010/11/25 00:50:55 ged $
-#
-# See the LICENSE file in the distribution for information about copyright and licensing.
-#
-
-BEGIN {
-	require 'pathname'
-	basedir = Pathname.new( __FILE__ ).dirname.parent.parent
-
-	libdir = basedir + 'lib'
-	extdir = basedir + 'ext'
-
-	$LOAD_PATH.unshift( basedir.to_s ) unless $LOAD_PATH.include?( basedir.to_s )
-	$LOAD_PATH.unshift( libdir.to_s ) unless $LOAD_PATH.include?( libdir.to_s )
-	$LOAD_PATH.unshift( extdir.to_s ) unless $LOAD_PATH.include?( extdir.to_s )
-}
+# -*- ruby -*-
+# frozen_string_literal: true
 
-require 'rspec'
+require_relative '../helpers'
 
+require 'rspec'
 require 'linkparser'
 
 
 describe LinkParser::Dictionary do
 
-	### Work around current system's locale
+	### Tests expect English locale
 	before( :all ) do
 		$LANG = ENV['LANG']
 		ENV['LANG'] = 'en_US.UTF-8'
@@ -38,66 +22,63 @@ describe LinkParser::Dictionary do
 
 
 	it "can be instantiated using all default values" do
-		LinkParser::Dictionary.new.should be_an_instance_of( LinkParser::Dictionary )
+		expect( LinkParser::Dictionary.new ).to be_an_instance_of( LinkParser::Dictionary )
 	end
 
 	it "can be instantiated with an options hash" do
-		LinkParser::Dictionary.new( :verbosity => 2 ).options[:verbosity].should == 2
+		dict = LinkParser::Dictionary.new( :verbosity => 2 )
+		expect( dict ).to be_a( LinkParser::Dictionary )
+		expect( dict.options[:verbosity] ).to eq( 2 )
 	end
 
 	it "raises an error when created with an bad number of arguments" do
-		lambda {
+		expect {
 			LinkParser::Dictionary.new( "foo", "bar", "baz" )
-		}.should raise_error(ArgumentError)
+		}.to raise_error( ArgumentError )
 	end
 
 	it "can be instantiated with a language argument" do
-		lambda {LinkParser::Dictionary.new( 'en' )}.should_not raise_error()
+		dict = LinkParser::Dictionary.new( 'en' )
+		expect( dict ).to be_a( LinkParser::Dictionary )
 	end
 
 	it "can be instantiated with both a language and an options hash" do
-		LinkParser::Dictionary.new('en', :verbosity => 2).options[:verbosity].should == 2
+		dict = LinkParser::Dictionary.new( 'en', :verbosity => 2 )
+		expect( dict.options[:verbosity] ).to eq( 2 )
 	end
 
-	it "raises an exception if created with unknown dictionaries" do
-		lambda {
-			LinkParser::Dictionary.new('foo', 'bar', 'baz', 'bim')
-		}.should raise_error( LinkParser::Error )
+	it "raises an exception if created with an unknown language" do
+		expect {
+			LinkParser::Dictionary.new( 'ie' )
+		}.to raise_error( LinkParser::Error )
 	end
 
 	it "raises an exception if created with an unknown language" do
-		lambda {
+		expect {
 			LinkParser::Dictionary.new('zz')
-		}.should raise_error( LinkParser::Error )
+		}.to raise_error( LinkParser::Error )
 	end
 
+
 	context "instance" do
 
 		TEST_SENTENCE = "The dog plays with the ball."
 
-		before( :each ) do
-			@dict = LinkParser::Dictionary.new( 
-				:verbosity => 0,
-				:max_null_count => 18,
-				:echo_on => true
-			  )
+		before( :all ) do
+			@dict = LinkParser::Dictionary.new( verbosity: 0, max_null_count: 18, islands_ok: true )
 		end
 
 
-		it "knows what the total cost of its linkages are" do
-			@dict.max_cost.should be_an_instance_of(Fixnum)
-		end
-
 		it "can parse a sentence" do
-			@dict.parse( TEST_SENTENCE ).
-				should be_an_instance_of( LinkParser::Sentence )
+			sentence = @dict.parse( TEST_SENTENCE )
+			expect( sentence ).to be_an_instance_of( LinkParser::Sentence )
 		end
 
 		it "passes on its options to the sentences it parses" do
 			sentence = @dict.parse( TEST_SENTENCE )
-			sentence.options.max_null_count.should == 18
-			sentence.options.verbosity.should == 0
-			sentence.options.echo_on?.should == true
+			expect( sentence.options.max_null_count ).to eq( 18 )
+			expect( sentence.options.verbosity ).to eq( 0 )
+			expect( sentence.options.islands_ok? ).to eq( true )
 		end
 	end
 

data/spec/linkparser/linkage_spec.rb

@@ -1,420 +1,349 @@
-#!/usr/bin/ruby -w
-#
-# Specification for the LinkParser::Linkage class
-# $Id: linkage_spec.rb,v 7af8c401b107 2010/12/30 18:00:05 ged $
-#
-# See the LICENSE file in the distribution for information about copyright and licensing.
-#
-
-BEGIN {
-	require 'pathname'
-	basedir = Pathname.new( __FILE__ ).dirname.parent.parent
-
-	libdir = basedir + 'lib'
-	extdir = basedir + 'ext'
-
-	$LOAD_PATH.unshift( basedir.to_s ) unless $LOAD_PATH.include?( basedir.to_s )
-	$LOAD_PATH.unshift( libdir.to_s ) unless $LOAD_PATH.include?( libdir.to_s )
-	$LOAD_PATH.unshift( extdir.to_s ) unless $LOAD_PATH.include?( extdir.to_s )
-}
+# -*- ruby -*-
+# frozen_string_literal: true
 
-require 'rspec'
+require_relative '../helpers'
 
+require 'rspec'
 require 'linkparser'
 
 
 describe LinkParser::Linkage do
 
 	before( :all ) do
-		@dict = LinkParser::Dictionary.new( 'en', :verbosity => 0 )
-		$DEBUG = true if ENV['DEBUG']
+		@dict = LinkParser::Dictionary.new( 'en', verbosity: 0 )
 	end
 
-	before( :each ) do
-		@sentence = @dict.parse( "The flag was wet." )
-		@linkage = @sentence.linkages.first
-	end
 
+	let( :dict ) { @dict }
 
-	#     +-------------Xp-------------+
-	#     +-----Wd-----+               |
-	#     |      +--Ds-+--Ss-+--Pa-+   |
-	#     |      |     |     |     |   |
-	# LEFT-WALL the flag.n was.v wet.a .
-	it "can build a diagram string for a sentence" do
-		@linkage.diagram.should =~ /LEFT-WALL/
-		@linkage.diagram.should =~ /the/
-		@linkage.diagram.should =~ /flag\.n/
-		@linkage.diagram.should =~ /was\.v/
-		@linkage.diagram.should =~ /wet\.a/
-
-		@linkage.diagram.should =~ /-Xp-/
-		@linkage.diagram.should =~ /-Wd-/
-		@linkage.diagram.should =~ /-Ds-/
-		@linkage.diagram.should =~ /-Ss-/
-		@linkage.diagram.should =~ /-Pa-/
-	end
-
-
-	 #       LEFT-WALL      Xp      <---Xp---->  Xp        .
-	 # (m)   LEFT-WALL      Wd      <---Wd---->  Wd        flag.n
-	 # (m)   the            D       <---Ds---->  Ds        flag.n
-	 # (m)   flag.n         Ss      <---Ss---->  Ss        was.v
-	 # (m)   was.v          Pa      <---Pa---->  Pa        wet.a
-	 #       .              RW      <---RW---->  RW        RIGHT-WALL
-	it "can build a 'links and domains' diagram" do
-		@linkage.links_and_domains.should =~ /LEFT-WALL/
-		@linkage.links_and_domains.should =~ /the/
-		@linkage.links_and_domains.should =~ /flag\.n/
-		@linkage.links_and_domains.should =~ /was\.v/
-		@linkage.links_and_domains.should =~ /wet\.a/
+	let( :text ) { "The flag was wet." }
+	let( :sentence ) { @dict.parse(text) }
+	let( :linkage ) { sentence.linkages.first }
 
-		@linkage.links_and_domains.should =~ /-Xp-/
-		@linkage.links_and_domains.should =~ /-Wd-/
-		@linkage.links_and_domains.should =~ /-Ds-/
-		@linkage.links_and_domains.should =~ /-Ss-/
-		@linkage.links_and_domains.should =~ /-Pa-/
+
+	it "can build a diagram string for a sentence" do
+		expect( linkage.diagram.each_line.to_a ).to include(
+			"    +--------------Xp--------------+\n",
+			"    +-------->WV------->+          |\n",
+			"    +---->Wd-----+      |          |\n",
+			"    |      +Ds**c+-Ss*s-+--Pa--+   +--RW--+\n",
+			"    |      |     |      |      |   |      |\n",
+			"LEFT-WALL the flag.n was.v-d wet.a . RIGHT-WALL\n",
+		)
 	end
 
 
-	it "knows how many words are in the sentence" do
-		# LEFT-WALL + words + '.' + RIGHT-WALL = 7
-		@linkage.num_words.should == 7
+	it "can build a diagram string for a sentence wrapped to a screen width" do
+		diagram = linkage.diagram( max_width: 20 )
+		expect( diagram.each_line.map(&:strip).map(&:length) ).to all( be <= 20 )
 	end
 
 
-	it "can return a list of the tokenized words" do
-		@linkage.words.should include("LEFT-WALL")
-		@linkage.words.should include("the")
-		@linkage.words.should include("flag.n")
-		@linkage.words.should include("was.v-d")
-		@linkage.words.should include("wet.a")
-		@linkage.words.should include(".")
-		@linkage.words.should include("RIGHT-WALL")
+	it "can build a diagram string without wall-words" do
+		expect( linkage.diagram(display_walls: false) ).to_not include( 'RIGHT-WALL' )
 	end
 
 
-	it "knows how many links are in the sentence" do
-		@linkage.num_links.should == 6
+	it "can build a 'links and domains' diagram" do
+		expect( linkage.links_and_domains.each_line.to_a ).to include(
+			"       LEFT-WALL      Xp            ----Xp-----  Xp              .\n",
+			" (m)   LEFT-WALL      hWV           >---WV---->  dWV             was.v-d\n",
+			" (m)   LEFT-WALL      hWd           >---Wd-----  Wd              flag.n\n",
+			" (m)   flag.n         Ss*s          ----Ss*s---  Ss              was.v-d\n",
+			" (m)   the            D             ----Ds**c--  Ds**c           flag.n\n",
+			" (m)   was.v-d        Pa            ----Pa-----  Pa              wet.a\n",
+			"       .              RW            ----RW-----  RW              RIGHT-WALL\n",
+			"\n"
+		)
 	end
 
 
-	it "can return the left word for any of its links" do
-	 	#       LEFT-WALL      Xp      <---Xp---->  Xp        .
-		@linkage.link_lword( 0 ).should == @linkage.words.index('LEFT-WALL')
+	it "knows how many words are in the sentence" do
+		# LEFT-WALL + words + '.' + RIGHT-WALL = 7
+		expect( linkage.num_words ).to eq( 7 )
+	end
 
-		# (m)   LEFT-WALL      Wd      <---Wd---->  Wd        flag.n
-		@linkage.link_lword( 1 ).should == @linkage.words.index('LEFT-WALL')
 
-		# (m)   the            D       <---Ds---->  Ds        flag.n
-		@linkage.link_lword( 2 ).should == @linkage.words.index('the')
+	it "can return a list of the tokenized words" do
+		expect( linkage.words ).to include("LEFT-WALL")
+		expect( linkage.words ).to include("the")
+		expect( linkage.words ).to include("flag.n")
+		expect( linkage.words ).to include("was.v-d")
+		expect( linkage.words ).to include("wet.a")
+		expect( linkage.words ).to include(".")
+		expect( linkage.words ).to include("RIGHT-WALL")
+	end
 
-		# (m)   flag.n         Ss      <---Ss---->  Ss        was.v
-		@linkage.link_lword( 3 ).should == @linkage.words.index('flag.n')
 
-		# (m)   was.v          Pa      <---Pa---->  Pa        wet.a
-		@linkage.link_lword( 4 ).should == @linkage.words.index('was.v-d')
+	it "knows how many links are in the sentence" do
+		expect( linkage.num_links ).to eq( 7 )
+	end
 
-		#       .              RW      <---RW---->  RW        RIGHT-WALL
-		@linkage.link_lword( 5 ).should == @linkage.words.index('.')
 
+	it "can return the left word for any of its links" do
+		 #       LEFT-WALL      Xp      <---Xp---->  Xp        .
+		expect( linkage.link_lword(0) ).to eq( linkage.words.index('LEFT-WALL') )
+		 # (m)   LEFT-WALL      WV      <---WV---->  WV        was.v-d
+		expect( linkage.link_lword(1) ).to eq( linkage.words.index('LEFT-WALL') )
+		 # (m)   LEFT-WALL      Wd      <---Wd---->  Wd        flag.n
+		expect( linkage.link_lword(2) ).to eq( linkage.words.index('LEFT-WALL') )
+		 # (m)   flag.n         Ss      <---Ss---->  Ss        was.v-d
+		expect( linkage.link_lword(3) ).to eq( linkage.words.index('flag.n') )
+		 # (m)   the            D       <---Ds---->  Ds        flag.n
+		expect( linkage.link_lword(4) ).to eq( linkage.words.index('the') )
+		 # (m)   was.v-d        Pa      <---Pa---->  Pa        wet.a
+		expect( linkage.link_lword(5) ).to eq( linkage.words.index('was.v-d') )
+		 #       .              RW      <---RW---->  RW        RIGHT-WALL
+		expect( linkage.link_lword(6) ).to eq( linkage.words.index('.') )
 	end
 
 	it "can return the right word for any of its links" do
-	 	#       LEFT-WALL      Xp      <---Xp---->  Xp        .
-		@linkage.link_rword( 0 ).should == @linkage.words.index('.')
-
-		# (m)   LEFT-WALL      Wd      <---Wd---->  Wd        flag.n
-		@linkage.link_rword( 1 ).should == @linkage.words.index('flag.n')
-
-		# (m)   the            D       <---Ds---->  Ds        flag.n
-		@linkage.link_rword( 2 ).should == @linkage.words.index('flag.n')
-
-		# (m)   flag.n         Ss      <---Ss---->  Ss        was.v
-		@linkage.link_rword( 3 ).should == @linkage.words.index('was.v-d')
-
-		# (m)   was.v          Pa      <---Pa---->  Pa        wet.a
-		@linkage.link_rword( 4 ).should == @linkage.words.index('wet.a')
-
-		#       .              RW      <---RW---->  RW        RIGHT-WALL
-		@linkage.link_rword( 5 ).should == @linkage.words.index('RIGHT-WALL')
-
+		 #       LEFT-WALL      Xp      <---Xp---->  Xp        .
+		expect( linkage.link_rword(0) ).to eq( linkage.words.index('.') )
+		 # (m)   LEFT-WALL      WV      <---WV---->  WV        was.v-d
+		expect( linkage.link_rword(1) ).to eq( linkage.words.index('was.v-d') )
+		 # (m)   LEFT-WALL      Wd      <---Wd---->  Wd        flag.n
+		expect( linkage.link_rword(2) ).to eq( linkage.words.index('flag.n') )
+		 # (m)   flag.n         Ss      <---Ss---->  Ss        was.v-d
+		expect( linkage.link_rword(3) ).to eq( linkage.words.index('was.v-d') )
+		 # (m)   the            D       <---Ds---->  Ds        flag.n
+		expect( linkage.link_rword(4) ).to eq( linkage.words.index('flag.n') )
+		 # (m)   was.v-d        Pa      <---Pa---->  Pa        wet.a
+		expect( linkage.link_rword(5) ).to eq( linkage.words.index('wet.a') )
+		 #       .              RW      <---RW---->  RW        RIGHT-WALL
+		expect( linkage.link_rword(6) ).to eq( linkage.words.index('RIGHT-WALL') )
 	end
 
 
 	it "can return the length of any of its links" do
-		@linkage.link_length( 0 ).should == 5 
-		@linkage.link_length( 1 ).should == 2
-		@linkage.link_length( 2 ).should == 1
-		@linkage.link_length( 3 ).should == 1
-		@linkage.link_length( 4 ).should == 1
-		@linkage.link_length( 5 ).should == 1
+		expect( linkage.link_length(0) ).to eq( 5 )
+		expect( linkage.link_length(1) ).to eq( 3 )
+		expect( linkage.link_length(2) ).to eq( 2 )
+		expect( linkage.link_length(3) ).to eq( 1 )
+		expect( linkage.link_length(4) ).to eq( 1 )
+		expect( linkage.link_length(5) ).to eq( 1 )
+		expect( linkage.link_length(6) ).to eq( 1 )
 
 		# Out-of-bounds just returns -1
-		@linkage.link_length( 7 ).should == -1
+		expect( linkage.link_length(11) ).to eq( -1 )
 	end
 
 
 	it "can return labels for any of its links" do
-		@linkage.link_label( 0 ).should == "Xp"
-		@linkage.link_label( 1 ).should == "Wd"
-		@linkage.link_label( 2 ).should == "Ds"
-		@linkage.link_label( 3 ).should == "Ss"
-		@linkage.link_label( 4 ).should == "Pa"
-		@linkage.link_label( 5 ).should == "RW"
+		expect( linkage.link_label(0) ).to eq( "Xp" )
+		expect( linkage.link_label(1) ).to eq( "WV" )
+		expect( linkage.link_label(2) ).to eq( "Wd" )
+		expect( linkage.link_label(3) ).to eq( "Ss*s" )
+		expect( linkage.link_label(4) ).to eq( "Ds**c" )
+		expect( linkage.link_label(5) ).to eq( "Pa" )
+		expect( linkage.link_label(6) ).to eq( "RW" )
 
-		@linkage.link_label( 7 ).should be_nil
+		expect( linkage.link_label(7) ).to be_nil
 	end
 
 
 	it "can return left labels for any of its links" do
-		@linkage.link_llabel( 0 ).should == "Xp"
-		@linkage.link_llabel( 1 ).should == "Wd"
-		@linkage.link_llabel( 2 ).should == "D"
-		@linkage.link_llabel( 3 ).should == "Ss"
-		@linkage.link_llabel( 4 ).should == "Pa"
-		@linkage.link_llabel( 5 ).should == "RW"
+		expect( linkage.link_llabel(0) ).to eq( "Xp" )
+		expect( linkage.link_llabel(1) ).to eq( "hWV" )
+		expect( linkage.link_llabel(2) ).to eq( "hWd" )
+		expect( linkage.link_llabel(3) ).to eq( "Ss*s" )
+		expect( linkage.link_llabel(4) ).to eq( "D" )
+		expect( linkage.link_llabel(5) ).to eq( "Pa" )
+		expect( linkage.link_llabel(6) ).to eq( "RW" )
 
-		@linkage.link_llabel( 7 ).should be_nil
+		expect( linkage.link_llabel(7) ).to be_nil
 	end
 
 
 	it "can return labels for any of its links" do
-		@linkage.link_rlabel( 0 ).should == "Xp"
-		@linkage.link_rlabel( 1 ).should == "Wd"
-		@linkage.link_rlabel( 2 ).should == "Ds"
-		@linkage.link_rlabel( 3 ).should == "Ss"
-		@linkage.link_rlabel( 4 ).should == "Pa"
-		@linkage.link_rlabel( 5 ).should == "RW"
+		expect( linkage.link_rlabel(0) ).to eq( "Xp" )
+		expect( linkage.link_rlabel(1) ).to eq( "dWV" )
+		expect( linkage.link_rlabel(2) ).to eq( "Wd" )
+		expect( linkage.link_rlabel(3) ).to eq( "Ss" )
+		expect( linkage.link_rlabel(4) ).to eq( "Ds**c" )
+		expect( linkage.link_rlabel(5) ).to eq( "Pa" )
+		expect( linkage.link_rlabel(6) ).to eq( "RW" )
 
-		@linkage.link_rlabel( 7 ).should be_nil
+		expect( linkage.link_rlabel(7) ).to be_nil
 	end
 
 
 	it "can return the number of domains for any link" do
-		@linkage.link_num_domains( 0 ).should == 0
-		1.upto(4) do |i|
-			@linkage.link_num_domains( i ).should == 1
-		end
-		@linkage.link_num_domains( 5 ).should == 0
+		pending "are domains deprecated or something?"
+		expect( linkage.link_num_domains(0) ).to eq( -1 )
+		expect( linkage.link_num_domains(1) ).to eq( 1 )
+		expect( linkage.link_num_domains(2) ).to eq( 1 )
+		expect( linkage.link_num_domains(3) ).to eq( 1 )
+		expect( linkage.link_num_domains(4) ).to eq( 1 )
+		expect( linkage.link_num_domains(5) ).to eq( 1 )
+		expect( linkage.link_num_domains(6) ).to eq( 0 )
 
-		@linkage.link_num_domains( 112 ).should == -1
+		expect( linkage.link_num_domains(112) ).to eq( -1 )
 	end
 
 
 	it "can return the names of the domains of any of its links" do
-		@linkage.link_domain_names( 0 ).should be_an_instance_of( Array )
-		@linkage.link_domain_names( 0 ).should be_empty
+		pending "are domains deprecated or something?"
+		expect( linkage.link_domain_names(0) ).to be_an_instance_of( Array )
+		expect( linkage.link_domain_names(0) ).to be_empty
 
-		1.upto(4) do |i|
-			@linkage.link_domain_names( i ).should be_an_instance_of( Array )
-			@linkage.link_domain_names( i ).should == ["m"]
-		end
+		expect( linkage.link_domain_names(1) ).to be_an_instance_of( Array )
+		expect( linkage.link_domain_names(1) ).to eq( ['m'] )
+
+		expect( linkage.link_domain_names(2) ).to be_an_instance_of( Array )
+		expect( linkage.link_domain_names(2) ).to eq( ['m'] )
+
+		expect( linkage.link_domain_names(3) ).to be_an_instance_of( Array )
+		expect( linkage.link_domain_names(3) ).to eq( ["m"] )
 
-		@linkage.link_domain_names( 5 ).should be_an_instance_of( Array )
-		@linkage.link_domain_names( 5 ).should be_empty
+		expect( linkage.link_domain_names(4) ).to be_an_instance_of( Array )
+		expect( linkage.link_domain_names(4) ).to eq( ['m'] )
 
-		@linkage.link_domain_names( 12 ).should be_an_instance_of( Array )
-		@linkage.link_domain_names( 12 ).should be_empty
+		expect( linkage.link_domain_names(5) ).to be_an_instance_of( Array )
+		expect( linkage.link_domain_names(5) ).to eq( ['m'] )
+
+		expect( linkage.link_domain_names(6) ).to be_an_instance_of( Array )
+		expect( linkage.link_domain_names(6) ).to be_empty
+
+		expect( linkage.link_domain_names(12) ).to be_an_instance_of( Array )
+		expect( linkage.link_domain_names(12) ).to be_empty
 	end
 
 
 	it "can return the disjunct strings for any of its words" do
-		@linkage.disjunct_strings.should have( @linkage.num_words ).members
+		expect( linkage.disjunct_strings.length ).to eq( linkage.num_words )
 	end
 
 
 	it "can return parsed disjuncts for any of its words" do
-		@linkage.disjuncts.should have( @linkage.num_words ).members
+		expect( linkage.disjuncts.length ).to eq( linkage.num_words )
 	end
 
 
 	it "can report on the various cost metrics of the parse" do
-		@linkage.unused_word_cost.should be_an_instance_of( Fixnum )
-		@linkage.disjunct_cost.should be_an_instance_of( Fixnum )
-		@linkage.and_cost.should be_an_instance_of( Fixnum )
-		@linkage.link_cost.should be_an_instance_of( Fixnum )
+		expect( linkage.unused_word_cost ).to be_an_instance_of( Integer )
+		expect( linkage.disjunct_cost ).to be_an_instance_of( Integer )
+		expect( linkage.link_cost ).to be_an_instance_of( Integer )
 	end
 
 
-	### :FIXME: I don't know what these do/mean yet, so for now just test to 
+	### :FIXME: I don't know what these do/mean yet, so for now just test to
 	### make sure they're implemented. They should really be tested with
 	### sentences that have predictable results.
 	it "implements Link Grammar predicate methods" do
-		@linkage.should respond_to( :canonical? )
-		@linkage.should respond_to( :improper? )
-		@linkage.should respond_to( :has_inconsistent_domains? )
-		@linkage.should respond_to( :violation_name )
+		expect( linkage ).to respond_to( :violation_name )
 	end
 
 
-	 #       LEFT-WALL      Xp      <---Xp---->  Xp        .
-	 # (m)   LEFT-WALL      Wd      <---Wd---->  Wd        flag.n
-	 # (m)   the            D       <---Ds---->  Ds        flag.n
-	 # (m)   flag.n         Ss      <---Ss---->  Ss        was.v
-	 # (m)   was.v          Pa      <---Pa---->  Pa        wet.a
-	 #       .              RW      <---RW---->  RW        RIGHT-WALL
+	#       LEFT-WALL      Xp            ----Xp-----  Xp              .
+	# (m)   LEFT-WALL      hWV           >---WV---->  dWV             was.v-d
+	# (m)   LEFT-WALL      hWd           >---Wd-----  Wd              flag.n
+	# (m)   flag.n         Ss*s          ----Ss*s---  Ss              was.v-d
+	# (m)   the            D             ----Ds**c--  Ds**c           flag.n
+	# (m)   was.v-d        Pa            ----Pa-----  Pa              wet.a
+	#       .              RW            ----RW-----  RW              RIGHT-WALL
 	it "contains link structs describing the linkage" do
-		@linkage.should have(6).links
-		@linkage.links.should be_an_instance_of( Array )
+		expect( linkage.links ).to be_an_instance_of( Array )
+		expect( linkage.links.length ).to eq( 7 )
 
-		@linkage.links.each do |link|
-			link.should be_a_kind_of( Struct )
+		linkage.links.each do |link|
+			expect( link ).to be_a_kind_of( Struct )
 		end
 
-		@linkage.links.first.lword.should == 'LEFT-WALL'
-		@linkage.links.first.label.should == 'Xp'
-		@linkage.links.last.rword.should == 'RIGHT-WALL'
-		@linkage.links.last.label.should == 'RW'
-		@linkage.links[3].lword.should == 'flag.n'
-		@linkage.links[3].rword.should == 'was.v-d'
-		@linkage.links[3].label.should == 'Ss'
+		expect( linkage.links.first.lword ).to eq( 'LEFT-WALL' )
+		expect( linkage.links.first.label ).to eq( 'Xp' )
+		expect( linkage.links.last.rword ).to eq( 'RIGHT-WALL' )
+		expect( linkage.links.last.label ).to eq( 'RW' )
+		expect( linkage.links[3].lword ).to eq( 'flag.n' )
+		expect( linkage.links[3].rword ).to eq( 'was.v-d' )
+		expect( linkage.links[3].label ).to eq( 'Ss*s' )
 	end
 
 
 	it "knows what word is the verb in the sentence" do
-		@linkage.verb.should == "was"
+		expect( linkage.verb ).to eq( "was" )
 	end
 
 
-	it "knows what word is the subject of the sentence" do
-		@linkage.subject.should == "flag"
+	it "can return the verb without stripping the subscript" do
+		expect( linkage.verb(keep_subscript: true) ).to eq( "was.v-d" )
 	end
 
 
-	it "knows when the sentence doesn't have a direct object" do
-		@linkage.object.should be_nil()
+	it "knows what word is the subject of the sentence" do
+		expect( linkage.subject ).to eq( "flag" )
 	end
 
 
-	it "knows which of its words are nouns" do
-		@linkage.nouns.should have(1).member
-		@linkage.nouns.should include( "flag" )
+	it "can return the subject without stripping the subscript" do
+		expect( linkage.subject(keep_subscript: true) ).to eq( "flag.n" )
 	end
 
 
-	MODE1_C_TREE_STRING = "(S (NP The flag)\n   (VP was\n       (ADJP wet))\n   .)\n"
-	MODE2_C_TREE_STRING = "[S [NP The flag NP] [VP was [ADJP wet ADJP] VP] . S] \n"
-	MODE3_C_TREE_STRING = "(S (NP The flag) (VP was (ADJP wet)) .)\n"
+	context "for sentences with a direct object" do
 
-	it "returns an indented sexps for the constituent tree string by default (mode 1)" do
-		@linkage.constituent_tree_string.should == MODE1_C_TREE_STRING
-	end
+		let( :text ) { "The dog fetches the ball." }
 
 
-	it "returns indented sexps for the constituent tree string if fetched with explicit mode '1'" do
-		@linkage.constituent_tree_string( 1 ).should == MODE1_C_TREE_STRING
-	end
-
-	it "returns bracketed constituents if constituent tree string is fetched in mode 2" do
-		@linkage.constituent_tree_string( 2 ).should == MODE2_C_TREE_STRING
-	end
+		it "knows what word is the object of the sentence" do
+			expect( linkage.object ).to eq( "ball" )
+		end
 
-	it "returns unindented sexps for the constituent tree string if constituent tree string " +
-	   "is fetched in mode 3" do
-		@linkage.constituent_tree_string( 3 ).should == MODE3_C_TREE_STRING
-	end
 
-	it "raises an exception for any numeric constituent tree string mode greater than 3" do
-		expect {
-			@linkage.constituent_tree_string( 4 )
-		}.to raise_error( ArgumentError, /illegal mode 4/i )
-	end
+		it "can return the object without stripping the subscript" do
+			expect( linkage.object(keep_subscript: true) ).to eq( linkage.words[5] )
+		end
 
-	it "raises an exception for any numeric constituent tree string mode less than 1" do
-		expect {
-			@linkage.constituent_tree_string( 0 )
-		}.to raise_error( ArgumentError, /illegal mode 0/i )
 	end
 
 
-	it "raises an exception when a non-numeric constituent tree string mode is given" do
-		expect {
-			@linkage.constituent_tree_string( 'glarg' )
-		}.to raise_error( TypeError )
+	it "knows when the sentence doesn't have a direct object" do
+		expect( linkage.object ).to be_nil()
 	end
 
-	it "returns an Array of CTree structs for its constituent tree" do
-		rval = @linkage.constituent_tree
 
-		rval.should be_an_instance_of( Array )
-		rval.should have(1).members
-		rval.first.should be_a_kind_of( Struct )
-		rval.first.label.should == 'S'
-		rval.first.children.should have(3).members
-		rval.first.children.collect {|n| n.label }.should include( 'NP', 'VP', '.' )
+	it "knows which of its words are nouns" do
+		expect( linkage.nouns.size ).to eq( 1 )
+		expect( linkage.nouns ).to include( "flag" )
 	end
 
+
 	it "returns an informational string when inspected" do
-		@linkage.inspect.should =~ /Linkage:0x[[:xdigit:]]+: \[\d+ links\]/
+		expect( linkage.inspect ).to match( /Linkage:0x[[:xdigit:]]+: \[\d+ links\]/ )
 	end
 
 
 	context "from a simple sentence with a direct object" do
-		before( :each ) do
-			@sentence = @dict.parse( "The dog ran home." )
-			@linkage = @sentence.linkages.first
-		end
-
-
-		it "knows what word is the object in the sentence" do
-			# This depends on the linkage:
-			#       +---------------Xp---------------+
-			#       +-----Wd----+                    |
-			#       |      +-Ds-+--Ss--+---Ou---+    |
-			#       |      |    |      |        |    |
-			#   LEFT-WALL the dog.n ran.v-d home.n-u . 
-			@sentence.object.should == 'home'
 
-		end
-
-	end
+		let( :text ) { "The dog fetches the ball." }
 
 
-	context "deprecated sublinkage API" do
-
-		before( :each ) do
-			@sentence = @dict.parse( "The ball rolled down the hill and bumped the curb." )
-			@linkage = @sentence.linkages.first
-		end
-
-		it "warns about deprecation if #num_sublinkages is called" do
-			@linkage.should_receive( :warn ).with( /deprecated/i )
-			@linkage.num_sublinkages
-		end
-
-		it "warns about deprecation if #compute_union is called" do
-			@linkage.should_receive( :warn ).with( /deprecated/i )
-			@linkage.compute_union
-		end
-
-		it "warn about deprecation if #current_sublinkage= is called" do
-			@linkage.should_receive( :warn ).with( /deprecated/i )
-			@linkage.current_sublinkage = 1
-		end
+		it "knows what word is the object in the sentence" do
+			#     +------------------Xp------------------+
+			#     +-------->WV------->+                  |
+			#     +-----Wd----+       +------Ou-----+    |
+			#     |      +Ds**+---Ss--+      +--Dmu-+    +--RW--+
+			#     |      |    |       |      |      |    |      |
+			# LEFT-WALL the dog.n fetches.v the ball.n-u . RIGHT-WALL
+			expect( sentence.object ).to eq( 'ball' )
 
-		it "warn about deprecation if #current_sublinkage is called" do
-			@linkage.should_receive( :warn ).with( /deprecated/i )
-			@linkage.current_sublinkage
 		end
 
 	end
 
 
 	it "should know that it's not an imperative sentence" do
-		@linkage.imperative?.should be_false()
+		expect( linkage.imperative? ).to be_falsey()
 	end
 
 
 	context "from an imperative sentence" do
-		before( :each ) do
-			@sentence = @dict.parse( "Go to the store!" )
-			@linkage = @sentence.linkages.first
-		end
+
+		let( :text ) { "Go to the store!" }
 
 
 		it "knows that it's an imperative sentence" do
-			@linkage.imperative?.should be_true()
+			expect( linkage.imperative? ).to be_truthy()
 		end
 
 
@@ -424,9 +353,16 @@ describe LinkParser::Linkage do
 	context "bugfixes" do
 
 		it "also strips off the '.p' from the subject and object when they are plural" do
-			sent = @dict.parse( 'People like goats.' )
-			sent.subject.should_not =~ /people\.p/i
-			sent.object.should_not =~ /goats\.p/i
+			sent = dict.parse( 'People like goats.' )
+			expect( sent.subject ).to_not match( /people\.p/i )
+			expect( sent.object ).to_not match( /goats\.p/i )
+		end
+
+
+		it "raises an exception if the diagram screen_width is too small", skip_version: '5.4.2' do
+			expect {
+				linkage.diagram( max_width: 2 )
+			}.to raise_error( /can't create a diagram/i )
 		end
 
 	end