linkedin2 0.0.16 → 0.0.17

data/lib/linkedin/version.rb

@@ -1,3 +1,3 @@
 module LinkedIn
-  VERSION = '0.0.16'
+  VERSION = '0.0.17'
 end

data/lib/linkedin2.rb

@@ -1,42 +1,34 @@
-require 'forwardable'
-require 'oauth2'
 require 'active_support'
 require 'active_support/core_ext'
 require 'active_support/time'
-require 'faraday'
 require 'faraday_middleware'
-require 'yaml'
 require 'hashie'
+require 'oauth2'
 
 require 'linkedin/version'
-require 'linkedin/error'
+require 'linkedin/errors'
+require 'linkedin/fields'
+
 require 'linkedin/utils'
 require 'linkedin/configuration'
 require 'linkedin/base'
 require 'linkedin/profile'
 require 'linkedin/company'
-require 'linkedin/industry'
+require 'linkedin/industries'
+require 'linkedin/api'
+require 'linkedin/credentials'
+require 'linkedin/response'
 require 'linkedin/faraday_middleware'
-
-require 'linkedin/api/authentication'
-require 'linkedin/api/profiles'
-require 'linkedin/api/network_updates'
-require 'linkedin/api/companies'
-require 'linkedin/api/groups'
-require 'linkedin/api/industries'
-require 'linkedin/api/jobs'
-require 'linkedin/api/permissions'
-
 require 'linkedin/client'
 
 module LinkedIn
-  def self.new(options = {}, &block)
-    Client.new options, &block
+  def self.new(config = {}, &block)
+    Client.new config, &block
   end
 
   [:r_basicprofile, :r_emailaddress, :r_fullprofile, :r_contactinfo, :r_network, :rw_groups, :rw_nus, :w_messages].each do |field|
     define_singleton_method field do
-        API::Permissions.const_get field.to_s.upcase
+        Fields.const_get field.to_s.upcase
     end
   end
 end

data/linkedin.gemspec

@@ -18,16 +18,25 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ['lib']
 
-  spec.add_dependency 'oauth2', '~> 0.9'
-  spec.add_dependency 'hashie', '> 2.1.1'
+  spec.add_dependency 'oauth2', '~> 1.0'
+  spec.add_dependency 'hashie', '~> 3.3.1'
   spec.add_dependency 'activesupport', '>= 3.2'
   spec.add_dependency 'faraday_middleware', '~> 0.9.1'
 
-  spec.add_development_dependency 'bundler', '~> 1.3'
-  spec.add_development_dependency 'rake'
-  spec.add_development_dependency 'pry'
-  spec.add_development_dependency 'simplecov'
-  spec.add_development_dependency 'rspec', '~> 2.14'
+  spec.add_development_dependency 'dotenv', '~> 0.11.1'
+
+  spec.add_development_dependency 'bundler', '~> 1.6'
+  spec.add_development_dependency 'rake', '~> 10.0'
+
+  spec.add_development_dependency 'pry', '~> 0.10.0'
+  spec.add_development_dependency 'pry-byebug', '~> 1.3.3'
+
+  spec.add_development_dependency 'rspec', '~> 3.0.0'
+  spec.add_development_dependency 'rspec-collection_matchers', '1.0.0'
+  spec.add_development_dependency 'webmock', '~> 1.18.0'
+  spec.add_development_dependency 'simplecov', '~> 0.9.0'
+  spec.add_development_dependency 'coveralls', '~> 0.7.1'
   spec.add_development_dependency 'vcr', '~> 2.5'
+
   spec.add_development_dependency 'yard'
 end

data/spec/api/companies_spec.rb

@@ -1,29 +1,27 @@
-require 'spec_helper'
-
 describe LinkedIn::API::Companies, vcr: { cassette_name: 'companies' }  do
   subject { LinkedIn::Client.new }
 
   describe '#company' do
     it 'fetches a company profile by id' do
-      subject.company(selector: 162479)['name'].should eq 'Apple'
+      expect(subject.company(162479)['name']).to eq 'Apple'
     end
 
     it 'fetches a company profile by universal name' do
-      subject.company(selector: 'universal-name=linkedin')['name'].should eq 'LinkedIn'
+      expect(subject.company('universal-name=linkedin')['name']).to eq 'LinkedIn'
     end
 
     it 'fetches a company profile by e-mail domain' do
       companies = subject.company(filter: 'email-domain=apple.com')
-      companies['values'].first['name'].should eq 'Apple'
+      expect(companies['values'].first['name']).to eq 'Apple'
     end
 
     it 'fetches companies in bulk using their respective selectors' do
-      companies = subject.company(selector: [162479, 'universal-name=linkedin'])
-      companies['values'].collect { |c| c['name'] }.should eq ['Apple', 'LinkedIn']
+      companies = subject.company([162479, 'universal-name=linkedin'])
+      expect(companies['values'].collect { |c| c['name'] }).to eq ['Apple', 'LinkedIn']
     end
 
     it 'fetches companies that the current user is an adminstrator of' do
-      subject.company(filter: 'is-company-admin=true')['_total'].should eq 0
+      expect(subject.company(filter: 'is-company-admin=true')['_total']).to eq 0
     end
   end
 
@@ -41,6 +39,7 @@ describe LinkedIn::API::Companies, vcr: { cassette_name: 'companies' }  do
 
     it "should raise AccessDeniedError when LinkedIn returns 403 status code" do
       pending
+      pass
     end
   end
-end
+end

data/spec/api/groups_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe LinkedIn::API::Groups do
   describe '#jobs' do
   end
@@ -17,9 +15,10 @@ describe LinkedIn::API::Groups do
       response.body.should == nil
       response.code.should == "201"
     end
-    
+
     it "should raise AccessDeniedError when LinkedIn returns 403 status code" do
       pending
+      pass
     end
   end
-end
+end

data/spec/api/jobs_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe LinkedIn::API::Jobs do
   describe '#jobs' do
   end
@@ -29,6 +27,7 @@ describe LinkedIn::API::Jobs do
 
     it "should raise AccessDeniedError when LinkedIn returns 403 status code" do
       pending
+      pass
     end
   end
-end
+end

data/spec/api/network_updates_spec.rb

@@ -1,32 +1,26 @@
-require 'spec_helper'
-
-describe LinkedIn::API::Profiles, vcr: { cassette_name: 'network_updates' } do
+describe LinkedIn::API::NetworkUpdates, vcr: { cassette_name: 'network_updates' } do
   subject { LinkedIn::Client.new }
 
-  describe '#network_updates' do
+  context '#network_updates' do
     it 'fetches network updates for the current user' do
       network_updates = subject.network_updates
-      network_updates['_total'].should eq 13
-      network_updates['values'].should have(10).things
+      expect(network_updates['_total']).to eq 13
+      expect(network_updates['values']).to have(10).things
     end
 
     it 'fetches network updates by key' do
-      network_updates = subject.network_updates(selector: 'key=PROF-18939563-5794095336964247552-*1')
+      network_updates = subject.network_updates(key: 'PROF-18939563-5794095336964247552-*1')
       network_updates['updatedFields']['values'].should have(1).thing
     end
-  end
 
-  describe '#network_update_comments' do
     it 'fetches comments for network updates' do
-      comments = subject.network_update_comments(selector: 'key=PROF-18939563-5794095336964247552-*1')
+      comments = subject.network_updates(key: 'PROF-18939563-5794095336964247552-*1', type: 'update-comments')
       comments['values'].first['comment'].should eq 'Whaaaat'
     end
-  end
-
-  describe '#network_update_likes' do
+    
     it 'fetches "likes" for network updates' do
-      likes = subject.network_update_likes(selector: 'key=PROF-18939563-5794095336964247552-*1')
+      likes = subject.network_updates(key: 'PROF-18939563-5794095336964247552-*1', type: 'likes')
       likes['values'].first['person']['id'].should eq 'cDmdM9cb0H'
     end
   end
-end
+end

data/spec/api/{profiles_spec.rb → people_spec.rb}

@@ -1,27 +1,25 @@
-require 'spec_helper'
-
-describe LinkedIn::API::Profiles, vcr: { cassette_name: 'profiles' } do
+describe LinkedIn::API::People, vcr: { cassette_name: 'people' } do
   subject { LinkedIn::Client.new }
 
-  describe '#profile' do
+  context '#profile' do
     it 'fetches the profile of the current user' do
       profile = subject.profile
 
-      profile['firstName'].should eq 'Josh'
-      profile['lastName'].should eq 'Testjordan'
+      expect(profile['firstName']).to eq 'Josh'
+      expect(profile['lastName']).to eq 'Testjordan'
     end
 
     it 'fetches publicly available profiles' do
-      profile = subject.profile(selector: 'id=Fy5e5a4mqr')
-      
-      profile['firstName'].should eq 'Sir Richard'
-      profile['lastName'].should eq 'B.'
+      profile = subject.profile('id=Fy5e5a4mqr')
+
+      expect(profile['firstName']).to eq 'Sir Richard'
+      expect(profile['lastName']).to eq 'B.'
     end
   end
 
-  describe '#connections' do
+  context '#connections' do
     it 'fetches the connections of the current user' do
-      subject.connections['values'].should have(2).things
+      expect(subject.connections['values']).to have(2).things
     end
   end
 
@@ -99,7 +97,7 @@ describe LinkedIn::API::Profiles, vcr: { cassette_name: 'profiles' } do
     end
   end
 
-  describe '#connections' do
+  context '#connections' do
     it 'finds all connections for the current user' do
       linkedin_keys = %w(id headline firstName lastName industry location pictureUrl siteStandardProfileRequest)
       connections = subject.connections

data/spec/faraday_middleware/{linkedin_error_response_spec.rb → error_response_spec.rb}

@@ -1,14 +1,9 @@
-require 'spec_helper'
-
-describe LinkedIn::FaradayMiddleware::LinkedinErrorResponse, vcr: { cassette_name: 'invalid' } do
+describe LinkedIn::FaradayMiddleware::ErrorResponse, vcr: { cassette_name: 'invalid' } do
   subject { LinkedIn::Client.new(access_token: nil) }
 
   describe '#on_error' do
     it 'raises an error with the status and body reported by Rack included' do
-      begin
-        subject.profile
-        raise 'Should have encountered an exception'
-      rescue LinkedIn::Error => error
+      expect { subject.profile }.to raise_error do |error|
         error.status.should eq 401
         error.body.should eq({
           'errorCode' => 0,
@@ -21,21 +16,13 @@ describe LinkedIn::FaradayMiddleware::LinkedinErrorResponse, vcr: { cassette_nam
     end
 
     it 'uses the message returned by LinkedIn' do
-      begin
-        subject.profile
-        raise 'Should have encountered an exception'
-      rescue LinkedIn::Error => err
-        err.message.should eq 'Empty oauth2_access_token'
-      end
+      expect { subject.profile }.to raise_error { |error| expect(error.message).to eq 'Empty oauth2_access_token' }
     end
 
     it 'includes the Faraday request/response object for further introspection by the consumer' do
-      begin
-        subject.profile
-        raise 'Should have encountered an exception'
-      rescue LinkedIn::Error => err
-        err.request.headers['User-Agent'].should eq 'Faraday v0.8.8'
-        err.response.headers['Server'].should eq 'Apache-Coyote/1.1'
+      expect { subject.profile }.to raise_error do |error|
+        error.request.headers['User-Agent'].should eq 'LinkedIn2 Gem v0.0.16'
+        error.response.headers['server'].should eq 'Apache-Coyote/1.1'
       end
     end
 
@@ -46,8 +33,8 @@ describe LinkedIn::FaradayMiddleware::LinkedinErrorResponse, vcr: { cassette_nam
         raise 'Should have encountered an exception'
       rescue LinkedIn::Error => err
         pending 'we need to discuss camelCase vs snake_case. LinkedIn returns "errorCode"'
-        err.error_code.should eq 
+        err.error_code.should eq
       end
     end
   end
-end
+end

data/spec/fixtures/requests/companies.yml

@@ -2,17 +2,19 @@
 http_interactions:
 - request:
     method: get
-    uri: https://api.linkedin.com/v1/companies/162479?oauth2_access_token=AQUJwEF40pJUbVxsW_mujQ3QCiXvlTnMFk55SlfVPYRcAPdsn1oE1Hm8Ldlc61o57k96i04ufG81KFdPJIOSJswXsGyZ0tk9IMZea8sfNXMGMnZgikQJUQPkmRVYVw9BP1qH9tp7hJF32DQtzkBB_NE8xPASPVgXVWbbntChGyYqqDvF1p8&format=json
+    uri: https://api.linkedin.com/v1/companies/162479?oauth2_access_token=AQUJwEF40pJUbVxsW_mujQ3QCiXvlTnMFk55SlfVPYRcAPdsn1oE1Hm8Ldlc61o57k96i04ufG81KFdPJIOSJswXsGyZ0tk9IMZea8sfNXMGMnZgikQJUQPkmRVYVw9BP1qH9tp7hJF32DQtzkBB_NE8xPASPVgXVWbbntChGyYqqDvF1p8
     body:
       encoding: US-ASCII
       string: ''
     headers:
       User-Agent:
       - Faraday v0.8.8
+      X-Li-Format:
+      - json
   response:
     status:
       code: 200
-      message: 
+      message:
     headers:
       server:
       - Apache-Coyote/1.1
@@ -47,21 +49,23 @@ http_interactions:
           "id": 162479,
           "name": "Apple"
         }
-    http_version: 
+    http_version:
   recorded_at: Tue, 15 Oct 2013 03:40:32 GMT
 - request:
     method: get
-    uri: https://api.linkedin.com/v1/companies/universal-name=linkedin?oauth2_access_token=AQUJwEF40pJUbVxsW_mujQ3QCiXvlTnMFk55SlfVPYRcAPdsn1oE1Hm8Ldlc61o57k96i04ufG81KFdPJIOSJswXsGyZ0tk9IMZea8sfNXMGMnZgikQJUQPkmRVYVw9BP1qH9tp7hJF32DQtzkBB_NE8xPASPVgXVWbbntChGyYqqDvF1p8&format=json
+    uri: https://api.linkedin.com/v1/companies/universal-name=linkedin?oauth2_access_token=AQUJwEF40pJUbVxsW_mujQ3QCiXvlTnMFk55SlfVPYRcAPdsn1oE1Hm8Ldlc61o57k96i04ufG81KFdPJIOSJswXsGyZ0tk9IMZea8sfNXMGMnZgikQJUQPkmRVYVw9BP1qH9tp7hJF32DQtzkBB_NE8xPASPVgXVWbbntChGyYqqDvF1p8
     body:
       encoding: US-ASCII
       string: ''
     headers:
       User-Agent:
       - Faraday v0.8.8
+      X-Li-Format:
+      - json
   response:
     status:
       code: 200
-      message: 
+      message:
     headers:
       server:
       - Apache-Coyote/1.1
@@ -96,21 +100,23 @@ http_interactions:
           "id": 1337,
           "name": "LinkedIn"
         }
-    http_version: 
+    http_version:
   recorded_at: Tue, 15 Oct 2013 03:40:33 GMT
 - request:
     method: get
-    uri: https://api.linkedin.com/v1/companies/?email-domain=apple.com&oauth2_access_token=AQUJwEF40pJUbVxsW_mujQ3QCiXvlTnMFk55SlfVPYRcAPdsn1oE1Hm8Ldlc61o57k96i04ufG81KFdPJIOSJswXsGyZ0tk9IMZea8sfNXMGMnZgikQJUQPkmRVYVw9BP1qH9tp7hJF32DQtzkBB_NE8xPASPVgXVWbbntChGyYqqDvF1p8&format=json
+    uri: https://api.linkedin.com/v1/companies?email-domain=apple.com&oauth2_access_token=AQUJwEF40pJUbVxsW_mujQ3QCiXvlTnMFk55SlfVPYRcAPdsn1oE1Hm8Ldlc61o57k96i04ufG81KFdPJIOSJswXsGyZ0tk9IMZea8sfNXMGMnZgikQJUQPkmRVYVw9BP1qH9tp7hJF32DQtzkBB_NE8xPASPVgXVWbbntChGyYqqDvF1p8
     body:
       encoding: US-ASCII
       string: ''
     headers:
       User-Agent:
       - Faraday v0.8.8
+      X-Li-Format:
+      - json
   response:
     status:
       code: 200
-      message: 
+      message:
     headers:
       server:
       - Apache-Coyote/1.1
@@ -148,21 +154,23 @@ http_interactions:
             "name": "Apple"
           }]
         }
-    http_version: 
+    http_version:
   recorded_at: Tue, 15 Oct 2013 03:40:33 GMT
 - request:
     method: get
-    uri: https://api.linkedin.com/v1/companies::(162479,universal-name=linkedin)?oauth2_access_token=AQUJwEF40pJUbVxsW_mujQ3QCiXvlTnMFk55SlfVPYRcAPdsn1oE1Hm8Ldlc61o57k96i04ufG81KFdPJIOSJswXsGyZ0tk9IMZea8sfNXMGMnZgikQJUQPkmRVYVw9BP1qH9tp7hJF32DQtzkBB_NE8xPASPVgXVWbbntChGyYqqDvF1p8&format=json
+    uri: https://api.linkedin.com/v1/companies::(162479,universal-name=linkedin)?oauth2_access_token=AQUJwEF40pJUbVxsW_mujQ3QCiXvlTnMFk55SlfVPYRcAPdsn1oE1Hm8Ldlc61o57k96i04ufG81KFdPJIOSJswXsGyZ0tk9IMZea8sfNXMGMnZgikQJUQPkmRVYVw9BP1qH9tp7hJF32DQtzkBB_NE8xPASPVgXVWbbntChGyYqqDvF1p8
     body:
       encoding: US-ASCII
       string: ''
     headers:
       User-Agent:
       - Faraday v0.8.8
+      X-Li-Format:
+      - json
   response:
     status:
       code: 200
-      message: 
+      message:
     headers:
       server:
       - Apache-Coyote/1.1
@@ -208,21 +216,23 @@ http_interactions:
             }
           ]
         }
-    http_version: 
+    http_version:
   recorded_at: Tue, 15 Oct 2013 03:40:33 GMT
 - request:
     method: get
-    uri: https://api.linkedin.com/v1/companies/?is-company-admin=true&oauth2_access_token=AQUJwEF40pJUbVxsW_mujQ3QCiXvlTnMFk55SlfVPYRcAPdsn1oE1Hm8Ldlc61o57k96i04ufG81KFdPJIOSJswXsGyZ0tk9IMZea8sfNXMGMnZgikQJUQPkmRVYVw9BP1qH9tp7hJF32DQtzkBB_NE8xPASPVgXVWbbntChGyYqqDvF1p8&format=json
+    uri: https://api.linkedin.com/v1/companies?is-company-admin=true&oauth2_access_token=AQUJwEF40pJUbVxsW_mujQ3QCiXvlTnMFk55SlfVPYRcAPdsn1oE1Hm8Ldlc61o57k96i04ufG81KFdPJIOSJswXsGyZ0tk9IMZea8sfNXMGMnZgikQJUQPkmRVYVw9BP1qH9tp7hJF32DQtzkBB_NE8xPASPVgXVWbbntChGyYqqDvF1p8
     body:
       encoding: US-ASCII
       string: ''
     headers:
       User-Agent:
       - Faraday v0.8.8
+      X-Li-Format:
+      - json
   response:
     status:
       code: 200
-      message: 
+      message:
     headers:
       server:
       - Apache-Coyote/1.1
@@ -253,6 +263,6 @@ http_interactions:
     body:
       encoding: UTF-8
       string: '{"_total": 0}'
-    http_version: 
+    http_version:
   recorded_at: Tue, 15 Oct 2013 03:40:34 GMT
 recorded_with: VCR 2.5.0