linked-list 0.0.12 → 0.0.16

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1d11a48bdb387744768bf129513fce5e6f31001988e8cf45bf8b974009938e98
-  data.tar.gz: 9ba15ea4897065b9a111e6add68d6a60dac5ab61b9e3aba0ab83c7b42e91f8b5
+  metadata.gz: dff645cd01380ea68e75dd61a217a9c217a76eb229dc87817caab297444619d7
+  data.tar.gz: cbb85a2893c007c17729a3335b9ea9dd65ae9fd6b7f7a83ce4289fa024b21499
 SHA512:
-  metadata.gz: 13f2b676935b4b18a9302e9a484f888c9c4730e81cab6fb6a891e4da5cc721fd0adf07d3f62b7a490fe985d32ed6143fdd9e01f586904214824c29c1cc8ed6f6
-  data.tar.gz: 5f844ebe95b710614b30ebc6a0a732c361987882ea661cc30e3773432f1702c347a2cf8979f63c6b50e6011cdd348adff1f458d0a81d22cab67aaf3b15528c36
+  metadata.gz: 8085a108cc3ac4a8edeea3585a0fd0c8adf1639e450d9d6f33e42b8002c3c1d0bd6a4fd6f88ff8b957075b36ff97bf236ed705446f6536ce029ba59c4f16d867
+  data.tar.gz: 44feefe384c7420d01bba47b31c9ebc825097d672250b0c0a5a5f1615e2c031678b086631bfab05180da05a560757146657fcfeac30f360163f6b08cd4c43f49

data/.travis.yml

@@ -1,7 +1,6 @@
 language: ruby
 rvm:
-  - 2.3.0
-  - 2.5.0
+  - 2.7
 cache: bundler
 env:
   CI: true

data/CHANGELOG.md

@@ -1,3 +1,41 @@
+# 0.0.x / Unreleased
+
+# 0.0.16 / 2021-09-21
+
+## Fixed
+
+- Fixed bug when reference to prev node was not set correctly аfter using `shift`.
+
+[Compare v0.0.15...v0.0.16](https://github.com/spectator/linked-list/compare/v0.0.15...v0.0.16)
+
+# 0.0.15 / 2020-05-26
+
+## Fixed
+
+- Fixed bug when deleting the last node of the list. The @tail value was not updated if the @head value was updated.
+
+[Compare v0.0.14...v0.0.15](https://github.com/spectator/linked-list/compare/v0.0.14...v0.0.15)
+
+# 0.0.14 / 2020-04-17
+
+## Fixed
+
+Forced minimal rake version in gemspec to skip rake versions with security issues.
+
+[Compare v0.0.13...v0.0.14](https://github.com/spectator/linked-list/compare/v0.0.13...v0.0.14)
+
+# 0.0.13 / 2018-11-27
+
+## Fixed
+
+- Delete duplicate method definitions (nex3 in [#7](https://github.com/spectator/linked-list/pull/7))
+
+## Added
+
+- Allow `List#delete` to delete a `Node` in O(1) time (nex3 in [#6](https://github.com/spectator/linked-list/pull/6))
+
+[Compare v0.0.12...v0.0.13](https://github.com/spectator/linked-list/compare/v0.0.12...v0.0.13)
+
 # 0.0.12 / 2018-09-04
 
 ## Added

data/lib/linked-list/list.rb

@@ -130,10 +130,19 @@ module LinkedList
 
     # Removes first matched node.data from the the list by passed block or value.
     #
+    # If +val+ is a +Node+, removes that node from the list. Behavior is
+    # undefined if +val+ is a +Node+ that's not a member of this list.
+    #
     # == Returns:
-    # Deleted node
+    # Deleted node's data
     #
     def delete(val = nil, &block)
+      if val.respond_to?(:to_node)
+        node = val.to_node
+        __unlink_node(node)
+        return node.data
+      end
+
       each_node.find(&__to_matcher(val, &block)).tap do |node_to_delete|
         return unless node_to_delete
         __unlink_node(node_to_delete)
@@ -274,61 +283,22 @@ module LinkedList
       self
     end
 
-    # Inserts data after passed node.
-    #
-    # == Returns:
-    # Inserted node
-    #
-    def insert_after_node(data, node)
-      Node(data).tap do |new_node|
-        new_node.prev = node
-        new_node.next = node.next
-        if node.next
-          node.next.prev = new_node
-        else
-          @tail = new_node
-        end
-        node.next = new_node
-        @length += 1
-      end
-    end
-
-
-    # Inserts data before passed node.
-    #
-    # == Returns:
-    # Inserted node
-    #
-    def insert_before_node(data, node)
-      Node(data).tap do |new_node|
-        new_node.next = node
-        new_node.prev = node.prev
-        if node.prev
-          node.prev.next = new_node
-        else
-          @head = new_node
-        end
-        node.prev = new_node
-        @length += 1
-      end
-    end
-
     private
 
     def __unlink_node(node)
+      @head = node.next if node.prev.nil?
+      @tail = node.prev if node.next.nil?
+
       if node.prev.nil?
         node.next.prev = nil if node.next
-        @head = node.next
       elsif node.next.nil?
         node.prev.next = nil if node.prev
-        @tail = node.prev
       else
         node.prev.next, node.next.prev = node.next, node.prev
       end
       @length -= 1
     end
 
-
     def __to_matcher(val = nil, &block)
       raise ArgumentError, 'either value or block should be passed' if val && block_given?
       block = ->(e) { e == val } unless block_given?
@@ -338,7 +308,7 @@ module LinkedList
     def __shift
       head = @head
       @head = @head.next
-      head.next = nil
+      @head.prev = nil if @head
       head
     end
 

data/lib/linked-list/version.rb

@@ -2,6 +2,6 @@
 
 module Linked
   module List
-    VERSION = '0.0.12'
+    VERSION = '0.0.16'
   end
 end

data/linked-list.gemspec

@@ -18,9 +18,9 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ['lib']
 
-  spec.add_development_dependency 'bundler', '>= 1.3', '<= 2.0'
+  spec.add_development_dependency 'bundler', '>= 2.0', '< 3.0'
   spec.add_development_dependency 'coveralls', '~> 0'
   spec.add_development_dependency 'm', '~> 1.5', '>= 1.5.0'
   spec.add_development_dependency 'minitest', '>= 5.0', '<= 6.0'
-  spec.add_development_dependency 'rake', '~> 0'
+  spec.add_development_dependency 'rake', '>= 12.3.3'
 end

data/test/list_test.rb

@@ -4,6 +4,7 @@ describe LinkedList::List do
   let(:list)   { create_list }
   let(:node_1) { create_node('foo') }
   let(:node_2) { create_node('bar') }
+  let(:node_3) { create_node('baz') }
 
   describe 'instantiation' do
     it 'assigns first to nil' do
@@ -476,6 +477,75 @@ describe LinkedList::List do
         end
       end
     end
+
+    describe 'by node' do
+      it 'deletes first node' do
+        list.push(node_1)
+        list.push(node_2)
+        list.push(node_3)
+        list.delete(node_1)
+        assert_equal ['bar', 'baz'], list.to_a
+      end
+
+      it 'returns deleted value' do
+        list.push(node_1)
+        list.delete(node_1)
+        assert_equal node_1.data, list.delete(node_1)
+      end
+
+      it 'decreases length of list' do
+        list.push('foo')
+        list.push('bar')
+        list.push('baz')
+        list.delete('foo')
+        assert_equal 2, list.length
+      end
+
+      describe 'position edge cases' do
+        before do
+          list.push(node_1)
+          list.push(node_2)
+          list.push(node_3)
+        end
+
+        it 'deletes value from head' do
+          list.delete(node_1)
+          assert_equal [node_2.data, node_3.data], list.to_a
+          assert_equal node_2.data, list.first
+          assert_equal node_3.data, list.last
+        end
+
+        it 'deletes value from middle' do
+          list.delete(node_2)
+          assert_equal [node_1.data, node_3.data], list.to_a
+          assert_equal node_1.data, list.first
+          assert_equal node_3.data, list.last
+        end
+
+
+        it 'deletes value from tail' do
+          list.delete(node_3)
+          assert_equal [node_1.data, node_2.data], list.to_a
+          assert_equal node_1.data, list.first
+          assert_equal node_2.data, list.last
+        end
+      end
+
+      describe 'delete edge cases' do
+        it 'resets original list state when deleting the last node of the list' do
+          assert_nil list.first
+          assert_nil list.last
+
+          list.push(node_1)
+          assert_equal node_1.data, list.first
+          assert_equal node_1.data, list.last
+
+          list.delete(node_1)
+          assert_nil list.first
+          assert_nil list.last
+        end
+      end
+    end
   end
 
   describe '#delete_all' do
@@ -568,6 +638,16 @@ describe LinkedList::List do
       assert_nil list.first
     end
 
+    it 'sets reference to the prev node' do
+      list.push(node_1)
+      list.push(node_2)
+      assert_nil node_1.prev
+      assert_equal node_2.prev, node_1
+
+      list.shift
+      assert_nil node_2.prev
+    end
+
     it 'reduces list length by 1' do
       list.push(node_1)
       list.shift

metadata

@@ -1,35 +1,35 @@
 --- !ruby/object:Gem::Specification
 name: linked-list
 version: !ruby/object:Gem::Version
-  version: 0.0.12
+  version: 0.0.16
 platform: ruby
 authors:
 - Yury Velikanau
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2018-09-05 00:00:00.000000000 Z
+date: 2021-09-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
-      - !ruby/object:Gem::Version
-        version: '1.3'
-    - - "<="
       - !ruby/object:Gem::Version
         version: '2.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '3.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
-      - !ruby/object:Gem::Version
-        version: '1.3'
-    - - "<="
       - !ruby/object:Gem::Version
         version: '2.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: coveralls
   requirement: !ruby/object:Gem::Requirement
@@ -88,16 +88,16 @@ dependencies:
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 12.3.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 12.3.3
 description: Ruby implementation of Doubly Linked List, following some Ruby idioms.
 email:
 - yury.velikanau@gmail.com
@@ -130,7 +130,7 @@ homepage: https://github.com/spectator/linked-list
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -145,9 +145,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
-signing_key: 
+rubygems_version: 3.1.2
+signing_key:
 specification_version: 4
 summary: Ruby implementation of Doubly Linked List, following some Ruby idioms.
 test_files: